code.gitea.io/gitea@v1.21.7/services/pull/check.go (about) 1 // Copyright 2019 The Gitea Authors. 2 // All rights reserved. 3 // SPDX-License-Identifier: MIT 4 5 package pull 6 7 import ( 8 "context" 9 "errors" 10 "fmt" 11 "strconv" 12 "strings" 13 14 "code.gitea.io/gitea/models" 15 "code.gitea.io/gitea/models/db" 16 git_model "code.gitea.io/gitea/models/git" 17 issues_model "code.gitea.io/gitea/models/issues" 18 access_model "code.gitea.io/gitea/models/perm/access" 19 repo_model "code.gitea.io/gitea/models/repo" 20 "code.gitea.io/gitea/models/unit" 21 user_model "code.gitea.io/gitea/models/user" 22 "code.gitea.io/gitea/modules/git" 23 "code.gitea.io/gitea/modules/graceful" 24 "code.gitea.io/gitea/modules/log" 25 "code.gitea.io/gitea/modules/process" 26 "code.gitea.io/gitea/modules/queue" 27 "code.gitea.io/gitea/modules/timeutil" 28 asymkey_service "code.gitea.io/gitea/services/asymkey" 29 notify_service "code.gitea.io/gitea/services/notify" 30 ) 31 32 // prPatchCheckerQueue represents a queue to handle update pull request tests 33 var prPatchCheckerQueue *queue.WorkerPoolQueue[string] 34 35 var ( 36 ErrIsClosed = errors.New("pull is closed") 37 ErrUserNotAllowedToMerge = models.ErrDisallowedToMerge{} 38 ErrHasMerged = errors.New("has already been merged") 39 ErrIsWorkInProgress = errors.New("work in progress PRs cannot be merged") 40 ErrIsChecking = errors.New("cannot merge while conflict checking is in progress") 41 ErrNotMergableState = errors.New("not in mergeable state") 42 ErrDependenciesLeft = errors.New("is blocked by an open dependency") 43 ) 44 45 // AddToTaskQueue adds itself to pull request test task queue. 46 func AddToTaskQueue(ctx context.Context, pr *issues_model.PullRequest) { 47 pr.Status = issues_model.PullRequestStatusChecking 48 err := pr.UpdateColsIfNotMerged(ctx, "status") 49 if err != nil { 50 log.Error("AddToTaskQueue(%-v).UpdateCols.(add to queue): %v", pr, err) 51 return 52 } 53 log.Trace("Adding %-v to the test pull requests queue", pr) 54 err = prPatchCheckerQueue.Push(strconv.FormatInt(pr.ID, 10)) 55 if err != nil && err != queue.ErrAlreadyInQueue { 56 log.Error("Error adding %-v to the test pull requests queue: %v", pr, err) 57 } 58 } 59 60 type MergeCheckType int 61 62 const ( 63 MergeCheckTypeGeneral MergeCheckType = iota // general merge checks for "merge", "rebase", "squash", etc 64 MergeCheckTypeManually // Manually Merged button (mark a PR as merged manually) 65 MergeCheckTypeAuto // Auto Merge (Scheduled Merge) After Checks Succeed 66 ) 67 68 // CheckPullMergable check if the pull mergable based on all conditions (branch protection, merge options, ...) 69 func CheckPullMergable(stdCtx context.Context, doer *user_model.User, perm *access_model.Permission, pr *issues_model.PullRequest, mergeCheckType MergeCheckType, adminSkipProtectionCheck bool) error { 70 return db.WithTx(stdCtx, func(ctx context.Context) error { 71 if pr.HasMerged { 72 return ErrHasMerged 73 } 74 75 if err := pr.LoadIssue(ctx); err != nil { 76 log.Error("Unable to load issue[%d] for %-v: %v", pr.IssueID, pr, err) 77 return err 78 } else if pr.Issue.IsClosed { 79 return ErrIsClosed 80 } 81 82 if allowedMerge, err := IsUserAllowedToMerge(ctx, pr, *perm, doer); err != nil { 83 log.Error("Error whilst checking if %-v is allowed to merge %-v: %v", doer, pr, err) 84 return err 85 } else if !allowedMerge { 86 return ErrUserNotAllowedToMerge 87 } 88 89 if mergeCheckType == MergeCheckTypeManually { 90 // if doer is doing "manually merge" (mark as merged manually), do not check anything 91 return nil 92 } 93 94 if pr.IsWorkInProgress() { 95 return ErrIsWorkInProgress 96 } 97 98 if !pr.CanAutoMerge() && !pr.IsEmpty() { 99 return ErrNotMergableState 100 } 101 102 if pr.IsChecking() { 103 return ErrIsChecking 104 } 105 106 if err := CheckPullBranchProtections(ctx, pr, false); err != nil { 107 if !models.IsErrDisallowedToMerge(err) { 108 log.Error("Error whilst checking pull branch protection for %-v: %v", pr, err) 109 return err 110 } 111 112 // Now the branch protection check failed, check whether the failure could be skipped (skip by setting err = nil) 113 114 // * when doing Auto Merge (Scheduled Merge After Checks Succeed), skip the branch protection check 115 if mergeCheckType == MergeCheckTypeAuto { 116 err = nil 117 } 118 119 // * if the doer is admin, they could skip the branch protection check 120 if adminSkipProtectionCheck { 121 if isRepoAdmin, errCheckAdmin := access_model.IsUserRepoAdmin(ctx, pr.BaseRepo, doer); errCheckAdmin != nil { 122 log.Error("Unable to check if %-v is a repo admin in %-v: %v", doer, pr.BaseRepo, errCheckAdmin) 123 return errCheckAdmin 124 } else if isRepoAdmin { 125 err = nil // repo admin can skip the check, so clear the error 126 } 127 } 128 129 // If there is still a branch protection check error, return it 130 if err != nil { 131 return err 132 } 133 } 134 135 if _, err := isSignedIfRequired(ctx, pr, doer); err != nil { 136 return err 137 } 138 139 if noDeps, err := issues_model.IssueNoDependenciesLeft(ctx, pr.Issue); err != nil { 140 return err 141 } else if !noDeps { 142 return ErrDependenciesLeft 143 } 144 145 return nil 146 }) 147 } 148 149 // isSignedIfRequired check if merge will be signed if required 150 func isSignedIfRequired(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User) (bool, error) { 151 pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch) 152 if err != nil { 153 return false, err 154 } 155 156 if pb == nil || !pb.RequireSignedCommits { 157 return true, nil 158 } 159 160 sign, _, _, err := asymkey_service.SignMerge(ctx, pr, doer, pr.BaseRepo.RepoPath(), pr.BaseBranch, pr.GetGitRefName()) 161 162 return sign, err 163 } 164 165 // checkAndUpdateStatus checks if pull request is possible to leaving checking status, 166 // and set to be either conflict or mergeable. 167 func checkAndUpdateStatus(ctx context.Context, pr *issues_model.PullRequest) { 168 // If status has not been changed to conflict by testPatch then we are mergeable 169 if pr.Status == issues_model.PullRequestStatusChecking { 170 pr.Status = issues_model.PullRequestStatusMergeable 171 } 172 173 // Make sure there is no waiting test to process before leaving the checking status. 174 has, err := prPatchCheckerQueue.Has(strconv.FormatInt(pr.ID, 10)) 175 if err != nil { 176 log.Error("Unable to check if the queue is waiting to reprocess %-v. Error: %v", pr, err) 177 } 178 179 if has { 180 log.Trace("Not updating status for %-v as it is due to be rechecked", pr) 181 return 182 } 183 184 if err := pr.UpdateColsIfNotMerged(ctx, "merge_base", "status", "conflicted_files", "changed_protected_files"); err != nil { 185 log.Error("Update[%-v]: %v", pr, err) 186 } 187 } 188 189 // getMergeCommit checks if a pull request has been merged 190 // Returns the git.Commit of the pull request if merged 191 func getMergeCommit(ctx context.Context, pr *issues_model.PullRequest) (*git.Commit, error) { 192 if err := pr.LoadBaseRepo(ctx); err != nil { 193 return nil, fmt.Errorf("unable to load base repo for %s: %w", pr, err) 194 } 195 196 prHeadRef := pr.GetGitRefName() 197 198 // Check if the pull request is merged into BaseBranch 199 if _, _, err := git.NewCommand(ctx, "merge-base", "--is-ancestor"). 200 AddDynamicArguments(prHeadRef, pr.BaseBranch). 201 RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()}); err != nil { 202 if strings.Contains(err.Error(), "exit status 1") { 203 // prHeadRef is not an ancestor of the base branch 204 return nil, nil 205 } 206 // Errors are signaled by a non-zero status that is not 1 207 return nil, fmt.Errorf("%-v git merge-base --is-ancestor: %w", pr, err) 208 } 209 210 // If merge-base successfully exits then prHeadRef is an ancestor of pr.BaseBranch 211 212 // Find the head commit id 213 prHeadCommitID, err := git.GetFullCommitID(ctx, pr.BaseRepo.RepoPath(), prHeadRef) 214 if err != nil { 215 return nil, fmt.Errorf("GetFullCommitID(%s) in %s: %w", prHeadRef, pr.BaseRepo.FullName(), err) 216 } 217 218 // Get the commit from BaseBranch where the pull request got merged 219 mergeCommit, _, err := git.NewCommand(ctx, "rev-list", "--ancestry-path", "--merges", "--reverse"). 220 AddDynamicArguments(prHeadCommitID + ".." + pr.BaseBranch). 221 RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()}) 222 if err != nil { 223 return nil, fmt.Errorf("git rev-list --ancestry-path --merges --reverse: %w", err) 224 } else if len(mergeCommit) < git.SHAFullLength { 225 // PR was maybe fast-forwarded, so just use last commit of PR 226 mergeCommit = prHeadCommitID 227 } 228 mergeCommit = strings.TrimSpace(mergeCommit) 229 230 gitRepo, err := git.OpenRepository(ctx, pr.BaseRepo.RepoPath()) 231 if err != nil { 232 return nil, fmt.Errorf("%-v OpenRepository: %w", pr.BaseRepo, err) 233 } 234 defer gitRepo.Close() 235 236 commit, err := gitRepo.GetCommit(mergeCommit) 237 if err != nil { 238 return nil, fmt.Errorf("GetMergeCommit[%s]: %w", mergeCommit, err) 239 } 240 241 return commit, nil 242 } 243 244 // manuallyMerged checks if a pull request got manually merged 245 // When a pull request got manually merged mark the pull request as merged 246 func manuallyMerged(ctx context.Context, pr *issues_model.PullRequest) bool { 247 if err := pr.LoadBaseRepo(ctx); err != nil { 248 log.Error("%-v LoadBaseRepo: %v", pr, err) 249 return false 250 } 251 252 if unit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests); err == nil { 253 config := unit.PullRequestsConfig() 254 if !config.AutodetectManualMerge { 255 return false 256 } 257 } else { 258 log.Error("%-v BaseRepo.GetUnit(unit.TypePullRequests): %v", pr, err) 259 return false 260 } 261 262 commit, err := getMergeCommit(ctx, pr) 263 if err != nil { 264 log.Error("%-v getMergeCommit: %v", pr, err) 265 return false 266 } 267 268 if commit == nil { 269 // no merge commit found 270 return false 271 } 272 273 pr.MergedCommitID = commit.ID.String() 274 pr.MergedUnix = timeutil.TimeStamp(commit.Author.When.Unix()) 275 pr.Status = issues_model.PullRequestStatusManuallyMerged 276 merger, _ := user_model.GetUserByEmail(ctx, commit.Author.Email) 277 278 // When the commit author is unknown set the BaseRepo owner as merger 279 if merger == nil { 280 if pr.BaseRepo.Owner == nil { 281 if err = pr.BaseRepo.LoadOwner(ctx); err != nil { 282 log.Error("%-v BaseRepo.LoadOwner: %v", pr, err) 283 return false 284 } 285 } 286 merger = pr.BaseRepo.Owner 287 } 288 pr.Merger = merger 289 pr.MergerID = merger.ID 290 291 if merged, err := pr.SetMerged(ctx); err != nil { 292 log.Error("%-v setMerged : %v", pr, err) 293 return false 294 } else if !merged { 295 return false 296 } 297 298 notify_service.MergePullRequest(ctx, merger, pr) 299 300 log.Info("manuallyMerged[%-v]: Marked as manually merged into %s/%s by commit id: %s", pr, pr.BaseRepo.Name, pr.BaseBranch, commit.ID.String()) 301 return true 302 } 303 304 // InitializePullRequests checks and tests untested patches of pull requests. 305 func InitializePullRequests(ctx context.Context) { 306 prs, err := issues_model.GetPullRequestIDsByCheckStatus(ctx, issues_model.PullRequestStatusChecking) 307 if err != nil { 308 log.Error("Find Checking PRs: %v", err) 309 return 310 } 311 for _, prID := range prs { 312 select { 313 case <-ctx.Done(): 314 return 315 default: 316 log.Trace("Adding PR[%d] to the pull requests patch checking queue", prID) 317 if err := prPatchCheckerQueue.Push(strconv.FormatInt(prID, 10)); err != nil { 318 log.Error("Error adding PR[%d] to the pull requests patch checking queue %v", prID, err) 319 } 320 } 321 } 322 } 323 324 // handle passed PR IDs and test the PRs 325 func handler(items ...string) []string { 326 for _, s := range items { 327 id, _ := strconv.ParseInt(s, 10, 64) 328 testPR(id) 329 } 330 return nil 331 } 332 333 func testPR(id int64) { 334 pullWorkingPool.CheckIn(fmt.Sprint(id)) 335 defer pullWorkingPool.CheckOut(fmt.Sprint(id)) 336 ctx, _, finished := process.GetManager().AddContext(graceful.GetManager().HammerContext(), fmt.Sprintf("Test PR[%d] from patch checking queue", id)) 337 defer finished() 338 339 pr, err := issues_model.GetPullRequestByID(ctx, id) 340 if err != nil { 341 log.Error("Unable to GetPullRequestByID[%d] for testPR: %v", id, err) 342 return 343 } 344 345 log.Trace("Testing %-v", pr) 346 defer func() { 347 log.Trace("Done testing %-v (status: %s)", pr, pr.Status) 348 }() 349 350 if pr.HasMerged { 351 log.Trace("%-v is already merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID) 352 return 353 } 354 355 if manuallyMerged(ctx, pr) { 356 log.Trace("%-v is manually merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID) 357 return 358 } 359 360 if err := TestPatch(pr); err != nil { 361 log.Error("testPatch[%-v]: %v", pr, err) 362 pr.Status = issues_model.PullRequestStatusError 363 if err := pr.UpdateCols("status"); err != nil { 364 log.Error("update pr [%-v] status to PullRequestStatusError failed: %v", pr, err) 365 } 366 return 367 } 368 checkAndUpdateStatus(ctx, pr) 369 } 370 371 // CheckPRsForBaseBranch check all pulls with baseBrannch 372 func CheckPRsForBaseBranch(ctx context.Context, baseRepo *repo_model.Repository, baseBranchName string) error { 373 prs, err := issues_model.GetUnmergedPullRequestsByBaseInfo(ctx, baseRepo.ID, baseBranchName) 374 if err != nil { 375 return err 376 } 377 378 for _, pr := range prs { 379 AddToTaskQueue(ctx, pr) 380 } 381 382 return nil 383 } 384 385 // Init runs the task queue to test all the checking status pull requests 386 func Init() error { 387 prPatchCheckerQueue = queue.CreateUniqueQueue(graceful.GetManager().ShutdownContext(), "pr_patch_checker", handler) 388 389 if prPatchCheckerQueue == nil { 390 return fmt.Errorf("unable to create pr_patch_checker queue") 391 } 392 393 go graceful.GetManager().RunWithCancel(prPatchCheckerQueue) 394 go graceful.GetManager().RunWithShutdownContext(InitializePullRequests) 395 return nil 396 }