code.gitea.io/gitea@v1.22.3/services/pull/check.go (about)

     1  // Copyright 2019 The Gitea Authors.
     2  // All rights reserved.
     3  // SPDX-License-Identifier: MIT
     4  
     5  package pull
     6  
     7  import (
     8  	"context"
     9  	"errors"
    10  	"fmt"
    11  	"strconv"
    12  	"strings"
    13  
    14  	"code.gitea.io/gitea/models"
    15  	"code.gitea.io/gitea/models/db"
    16  	git_model "code.gitea.io/gitea/models/git"
    17  	issues_model "code.gitea.io/gitea/models/issues"
    18  	access_model "code.gitea.io/gitea/models/perm/access"
    19  	repo_model "code.gitea.io/gitea/models/repo"
    20  	"code.gitea.io/gitea/models/unit"
    21  	user_model "code.gitea.io/gitea/models/user"
    22  	"code.gitea.io/gitea/modules/git"
    23  	"code.gitea.io/gitea/modules/gitrepo"
    24  	"code.gitea.io/gitea/modules/graceful"
    25  	"code.gitea.io/gitea/modules/log"
    26  	"code.gitea.io/gitea/modules/process"
    27  	"code.gitea.io/gitea/modules/queue"
    28  	"code.gitea.io/gitea/modules/timeutil"
    29  	asymkey_service "code.gitea.io/gitea/services/asymkey"
    30  	notify_service "code.gitea.io/gitea/services/notify"
    31  )
    32  
    33  // prPatchCheckerQueue represents a queue to handle update pull request tests
    34  var prPatchCheckerQueue *queue.WorkerPoolQueue[string]
    35  
    36  var (
    37  	ErrIsClosed              = errors.New("pull is closed")
    38  	ErrUserNotAllowedToMerge = models.ErrDisallowedToMerge{}
    39  	ErrHasMerged             = errors.New("has already been merged")
    40  	ErrIsWorkInProgress      = errors.New("work in progress PRs cannot be merged")
    41  	ErrIsChecking            = errors.New("cannot merge while conflict checking is in progress")
    42  	ErrNotMergeableState     = errors.New("not in mergeable state")
    43  	ErrDependenciesLeft      = errors.New("is blocked by an open dependency")
    44  )
    45  
    46  // AddToTaskQueue adds itself to pull request test task queue.
    47  func AddToTaskQueue(ctx context.Context, pr *issues_model.PullRequest) {
    48  	pr.Status = issues_model.PullRequestStatusChecking
    49  	err := pr.UpdateColsIfNotMerged(ctx, "status")
    50  	if err != nil {
    51  		log.Error("AddToTaskQueue(%-v).UpdateCols.(add to queue): %v", pr, err)
    52  		return
    53  	}
    54  	log.Trace("Adding %-v to the test pull requests queue", pr)
    55  	err = prPatchCheckerQueue.Push(strconv.FormatInt(pr.ID, 10))
    56  	if err != nil && err != queue.ErrAlreadyInQueue {
    57  		log.Error("Error adding %-v to the test pull requests queue: %v", pr, err)
    58  	}
    59  }
    60  
    61  type MergeCheckType int
    62  
    63  const (
    64  	MergeCheckTypeGeneral  MergeCheckType = iota // general merge checks for "merge", "rebase", "squash", etc
    65  	MergeCheckTypeManually                       // Manually Merged button (mark a PR as merged manually)
    66  	MergeCheckTypeAuto                           // Auto Merge (Scheduled Merge) After Checks Succeed
    67  )
    68  
    69  // CheckPullMergeable check if the pull mergeable based on all conditions (branch protection, merge options, ...)
    70  func CheckPullMergeable(stdCtx context.Context, doer *user_model.User, perm *access_model.Permission, pr *issues_model.PullRequest, mergeCheckType MergeCheckType, adminSkipProtectionCheck bool) error {
    71  	return db.WithTx(stdCtx, func(ctx context.Context) error {
    72  		if pr.HasMerged {
    73  			return ErrHasMerged
    74  		}
    75  
    76  		if err := pr.LoadIssue(ctx); err != nil {
    77  			log.Error("Unable to load issue[%d] for %-v: %v", pr.IssueID, pr, err)
    78  			return err
    79  		} else if pr.Issue.IsClosed {
    80  			return ErrIsClosed
    81  		}
    82  
    83  		if allowedMerge, err := IsUserAllowedToMerge(ctx, pr, *perm, doer); err != nil {
    84  			log.Error("Error whilst checking if %-v is allowed to merge %-v: %v", doer, pr, err)
    85  			return err
    86  		} else if !allowedMerge {
    87  			return ErrUserNotAllowedToMerge
    88  		}
    89  
    90  		if mergeCheckType == MergeCheckTypeManually {
    91  			// if doer is doing "manually merge" (mark as merged manually), do not check anything
    92  			return nil
    93  		}
    94  
    95  		if pr.IsWorkInProgress(ctx) {
    96  			return ErrIsWorkInProgress
    97  		}
    98  
    99  		if !pr.CanAutoMerge() && !pr.IsEmpty() {
   100  			return ErrNotMergeableState
   101  		}
   102  
   103  		if pr.IsChecking() {
   104  			return ErrIsChecking
   105  		}
   106  
   107  		if err := CheckPullBranchProtections(ctx, pr, false); err != nil {
   108  			if !models.IsErrDisallowedToMerge(err) {
   109  				log.Error("Error whilst checking pull branch protection for %-v: %v", pr, err)
   110  				return err
   111  			}
   112  
   113  			// Now the branch protection check failed, check whether the failure could be skipped (skip by setting err = nil)
   114  
   115  			// * when doing Auto Merge (Scheduled Merge After Checks Succeed), skip the branch protection check
   116  			if mergeCheckType == MergeCheckTypeAuto {
   117  				err = nil
   118  			}
   119  
   120  			// * if the doer is admin, they could skip the branch protection check
   121  			if adminSkipProtectionCheck {
   122  				if isRepoAdmin, errCheckAdmin := access_model.IsUserRepoAdmin(ctx, pr.BaseRepo, doer); errCheckAdmin != nil {
   123  					log.Error("Unable to check if %-v is a repo admin in %-v: %v", doer, pr.BaseRepo, errCheckAdmin)
   124  					return errCheckAdmin
   125  				} else if isRepoAdmin {
   126  					err = nil // repo admin can skip the check, so clear the error
   127  				}
   128  			}
   129  
   130  			// If there is still a branch protection check error, return it
   131  			if err != nil {
   132  				return err
   133  			}
   134  		}
   135  
   136  		if _, err := isSignedIfRequired(ctx, pr, doer); err != nil {
   137  			return err
   138  		}
   139  
   140  		if noDeps, err := issues_model.IssueNoDependenciesLeft(ctx, pr.Issue); err != nil {
   141  			return err
   142  		} else if !noDeps {
   143  			return ErrDependenciesLeft
   144  		}
   145  
   146  		return nil
   147  	})
   148  }
   149  
   150  // isSignedIfRequired check if merge will be signed if required
   151  func isSignedIfRequired(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User) (bool, error) {
   152  	pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
   153  	if err != nil {
   154  		return false, err
   155  	}
   156  
   157  	if pb == nil || !pb.RequireSignedCommits {
   158  		return true, nil
   159  	}
   160  
   161  	sign, _, _, err := asymkey_service.SignMerge(ctx, pr, doer, pr.BaseRepo.RepoPath(), pr.BaseBranch, pr.GetGitRefName())
   162  
   163  	return sign, err
   164  }
   165  
   166  // checkAndUpdateStatus checks if pull request is possible to leaving checking status,
   167  // and set to be either conflict or mergeable.
   168  func checkAndUpdateStatus(ctx context.Context, pr *issues_model.PullRequest) {
   169  	// If status has not been changed to conflict by testPatch then we are mergeable
   170  	if pr.Status == issues_model.PullRequestStatusChecking {
   171  		pr.Status = issues_model.PullRequestStatusMergeable
   172  	}
   173  
   174  	// Make sure there is no waiting test to process before leaving the checking status.
   175  	has, err := prPatchCheckerQueue.Has(strconv.FormatInt(pr.ID, 10))
   176  	if err != nil {
   177  		log.Error("Unable to check if the queue is waiting to reprocess %-v. Error: %v", pr, err)
   178  	}
   179  
   180  	if has {
   181  		log.Trace("Not updating status for %-v as it is due to be rechecked", pr)
   182  		return
   183  	}
   184  
   185  	if err := pr.UpdateColsIfNotMerged(ctx, "merge_base", "status", "conflicted_files", "changed_protected_files"); err != nil {
   186  		log.Error("Update[%-v]: %v", pr, err)
   187  	}
   188  }
   189  
   190  // getMergeCommit checks if a pull request has been merged
   191  // Returns the git.Commit of the pull request if merged
   192  func getMergeCommit(ctx context.Context, pr *issues_model.PullRequest) (*git.Commit, error) {
   193  	if err := pr.LoadBaseRepo(ctx); err != nil {
   194  		return nil, fmt.Errorf("unable to load base repo for %s: %w", pr, err)
   195  	}
   196  
   197  	prHeadRef := pr.GetGitRefName()
   198  
   199  	// Check if the pull request is merged into BaseBranch
   200  	if _, _, err := git.NewCommand(ctx, "merge-base", "--is-ancestor").
   201  		AddDynamicArguments(prHeadRef, pr.BaseBranch).
   202  		RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()}); err != nil {
   203  		if strings.Contains(err.Error(), "exit status 1") {
   204  			// prHeadRef is not an ancestor of the base branch
   205  			return nil, nil
   206  		}
   207  		// Errors are signaled by a non-zero status that is not 1
   208  		return nil, fmt.Errorf("%-v git merge-base --is-ancestor: %w", pr, err)
   209  	}
   210  
   211  	// If merge-base successfully exits then prHeadRef is an ancestor of pr.BaseBranch
   212  
   213  	// Find the head commit id
   214  	prHeadCommitID, err := git.GetFullCommitID(ctx, pr.BaseRepo.RepoPath(), prHeadRef)
   215  	if err != nil {
   216  		return nil, fmt.Errorf("GetFullCommitID(%s) in %s: %w", prHeadRef, pr.BaseRepo.FullName(), err)
   217  	}
   218  
   219  	gitRepo, err := gitrepo.OpenRepository(ctx, pr.BaseRepo)
   220  	if err != nil {
   221  		return nil, fmt.Errorf("%-v OpenRepository: %w", pr.BaseRepo, err)
   222  	}
   223  	defer gitRepo.Close()
   224  
   225  	objectFormat := git.ObjectFormatFromName(pr.BaseRepo.ObjectFormatName)
   226  
   227  	// Get the commit from BaseBranch where the pull request got merged
   228  	mergeCommit, _, err := git.NewCommand(ctx, "rev-list", "--ancestry-path", "--merges", "--reverse").
   229  		AddDynamicArguments(prHeadCommitID + ".." + pr.BaseBranch).
   230  		RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()})
   231  	if err != nil {
   232  		return nil, fmt.Errorf("git rev-list --ancestry-path --merges --reverse: %w", err)
   233  	} else if len(mergeCommit) < objectFormat.FullLength() {
   234  		// PR was maybe fast-forwarded, so just use last commit of PR
   235  		mergeCommit = prHeadCommitID
   236  	}
   237  	mergeCommit = strings.TrimSpace(mergeCommit)
   238  
   239  	commit, err := gitRepo.GetCommit(mergeCommit)
   240  	if err != nil {
   241  		return nil, fmt.Errorf("GetMergeCommit[%s]: %w", mergeCommit, err)
   242  	}
   243  
   244  	return commit, nil
   245  }
   246  
   247  // manuallyMerged checks if a pull request got manually merged
   248  // When a pull request got manually merged mark the pull request as merged
   249  func manuallyMerged(ctx context.Context, pr *issues_model.PullRequest) bool {
   250  	if err := pr.LoadBaseRepo(ctx); err != nil {
   251  		log.Error("%-v LoadBaseRepo: %v", pr, err)
   252  		return false
   253  	}
   254  
   255  	if unit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests); err == nil {
   256  		config := unit.PullRequestsConfig()
   257  		if !config.AutodetectManualMerge {
   258  			return false
   259  		}
   260  	} else {
   261  		log.Error("%-v BaseRepo.GetUnit(unit.TypePullRequests): %v", pr, err)
   262  		return false
   263  	}
   264  
   265  	commit, err := getMergeCommit(ctx, pr)
   266  	if err != nil {
   267  		log.Error("%-v getMergeCommit: %v", pr, err)
   268  		return false
   269  	}
   270  
   271  	if commit == nil {
   272  		// no merge commit found
   273  		return false
   274  	}
   275  
   276  	pr.MergedCommitID = commit.ID.String()
   277  	pr.MergedUnix = timeutil.TimeStamp(commit.Author.When.Unix())
   278  	pr.Status = issues_model.PullRequestStatusManuallyMerged
   279  	merger, _ := user_model.GetUserByEmail(ctx, commit.Author.Email)
   280  
   281  	// When the commit author is unknown set the BaseRepo owner as merger
   282  	if merger == nil {
   283  		if pr.BaseRepo.Owner == nil {
   284  			if err = pr.BaseRepo.LoadOwner(ctx); err != nil {
   285  				log.Error("%-v BaseRepo.LoadOwner: %v", pr, err)
   286  				return false
   287  			}
   288  		}
   289  		merger = pr.BaseRepo.Owner
   290  	}
   291  	pr.Merger = merger
   292  	pr.MergerID = merger.ID
   293  
   294  	if merged, err := pr.SetMerged(ctx); err != nil {
   295  		log.Error("%-v setMerged : %v", pr, err)
   296  		return false
   297  	} else if !merged {
   298  		return false
   299  	}
   300  
   301  	notify_service.MergePullRequest(ctx, merger, pr)
   302  
   303  	log.Info("manuallyMerged[%-v]: Marked as manually merged into %s/%s by commit id: %s", pr, pr.BaseRepo.Name, pr.BaseBranch, commit.ID.String())
   304  	return true
   305  }
   306  
   307  // InitializePullRequests checks and tests untested patches of pull requests.
   308  func InitializePullRequests(ctx context.Context) {
   309  	prs, err := issues_model.GetPullRequestIDsByCheckStatus(ctx, issues_model.PullRequestStatusChecking)
   310  	if err != nil {
   311  		log.Error("Find Checking PRs: %v", err)
   312  		return
   313  	}
   314  	for _, prID := range prs {
   315  		select {
   316  		case <-ctx.Done():
   317  			return
   318  		default:
   319  			log.Trace("Adding PR[%d] to the pull requests patch checking queue", prID)
   320  			if err := prPatchCheckerQueue.Push(strconv.FormatInt(prID, 10)); err != nil {
   321  				log.Error("Error adding PR[%d] to the pull requests patch checking queue %v", prID, err)
   322  			}
   323  		}
   324  	}
   325  }
   326  
   327  // handle passed PR IDs and test the PRs
   328  func handler(items ...string) []string {
   329  	for _, s := range items {
   330  		id, _ := strconv.ParseInt(s, 10, 64)
   331  		testPR(id)
   332  	}
   333  	return nil
   334  }
   335  
   336  func testPR(id int64) {
   337  	pullWorkingPool.CheckIn(fmt.Sprint(id))
   338  	defer pullWorkingPool.CheckOut(fmt.Sprint(id))
   339  	ctx, _, finished := process.GetManager().AddContext(graceful.GetManager().HammerContext(), fmt.Sprintf("Test PR[%d] from patch checking queue", id))
   340  	defer finished()
   341  
   342  	pr, err := issues_model.GetPullRequestByID(ctx, id)
   343  	if err != nil {
   344  		log.Error("Unable to GetPullRequestByID[%d] for testPR: %v", id, err)
   345  		return
   346  	}
   347  
   348  	log.Trace("Testing %-v", pr)
   349  	defer func() {
   350  		log.Trace("Done testing %-v (status: %s)", pr, pr.Status)
   351  	}()
   352  
   353  	if pr.HasMerged {
   354  		log.Trace("%-v is already merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID)
   355  		return
   356  	}
   357  
   358  	if manuallyMerged(ctx, pr) {
   359  		log.Trace("%-v is manually merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID)
   360  		return
   361  	}
   362  
   363  	if err := TestPatch(pr); err != nil {
   364  		log.Error("testPatch[%-v]: %v", pr, err)
   365  		pr.Status = issues_model.PullRequestStatusError
   366  		if err := pr.UpdateCols(ctx, "status"); err != nil {
   367  			log.Error("update pr [%-v] status to PullRequestStatusError failed: %v", pr, err)
   368  		}
   369  		return
   370  	}
   371  	checkAndUpdateStatus(ctx, pr)
   372  }
   373  
   374  // CheckPRsForBaseBranch check all pulls with baseBrannch
   375  func CheckPRsForBaseBranch(ctx context.Context, baseRepo *repo_model.Repository, baseBranchName string) error {
   376  	prs, err := issues_model.GetUnmergedPullRequestsByBaseInfo(ctx, baseRepo.ID, baseBranchName)
   377  	if err != nil {
   378  		return err
   379  	}
   380  
   381  	for _, pr := range prs {
   382  		AddToTaskQueue(ctx, pr)
   383  	}
   384  
   385  	return nil
   386  }
   387  
   388  // Init runs the task queue to test all the checking status pull requests
   389  func Init() error {
   390  	prPatchCheckerQueue = queue.CreateUniqueQueue(graceful.GetManager().ShutdownContext(), "pr_patch_checker", handler)
   391  
   392  	if prPatchCheckerQueue == nil {
   393  		return fmt.Errorf("unable to create pr_patch_checker queue")
   394  	}
   395  
   396  	go graceful.GetManager().RunWithCancel(prPatchCheckerQueue)
   397  	go graceful.GetManager().RunWithShutdownContext(InitializePullRequests)
   398  	return nil
   399  }