github.com/DaAlbrecht/cf-cli@v0.0.0-20231128151943-1fe19bb400b9/doc/adr/0012-de-version-v8-code-base.md (about)

     1  # 1. De-version the V8 Code Base
     2  
     3  
     4  ## Status
     5  
     6  Accepted
     7  
     8  ## Context
     9  
    10  ### What do you mean by de-version?
    11  
    12  De-version in this context means to remove the concept of a version from most of the CLI's codepaths and directory structure outside of the actual version command.
    13  
    14  In the v7 code base, and in the current (as of 8/19/2021) version of v8, there are many places in the code which reference either the CLI version, or the CAPI version (command/v6, command/v7, v3action, v7action, v2v3action, etc). This makes it harder to develop in especially for folks without the historical context on the versioning schemes of both the CLI.
    15  
    16  After [PR #2180](https://github.com/cloudfoundry/cli/pull/2180) we should be in a state where most of the v6 cruft should be gone, but we will still be left with several places in the code base where there is still mention of v7 in the v8 code base, below you can find a list of all of the places I can find along with suggestions for changing them.
    17  
    18  * command/common/command_list_v7* => refactor to command list
    19  * command/v7 => command/ (just maybe putting all the commands in the root command folder)
    20  * actor/v7action => actor/ (putting all the actor files in the root actor path)
    21  * actor/v7pushaction => actor/pushaction
    22  * integration/v7 => integration/tests
    23  * Makefile ivi (integration versioned isolated) command => change to ii (integration isolated)
    24  * Makefile integration versioned global (ivg) => see above
    25  * cf/ legacy directory => maybe rename it to something like legacy-cf, and put a README describing 
    26  
    27  ## Decision
    28  
    29  PR Accepted, pending implementation
    30  
    31  ## Consequences
    32  
    33  If I am a relatively new contributor to the CLI and I want to make a change to a command I can much easier figure out the code relevant code path. I don't need to know what v6 or v7 are to make changes to v8.
    34  
    35  V7 and V8 diverge, meaning that future bugfixes that occur on both the v7 and v8 branch could be more challenging to cherry-pick between branches, as the file paths will be different.