github.com/fastly/cli@v1.7.2-0.20240304164155-9d0f1d77c3bf/pkg/commands/vcl/condition/condition_test.go

package condition_test

import (
	"bytes"
	"errors"
	"io"
	"strings"
	"testing"

	"github.com/fastly/go-fastly/v9/fastly"

	"github.com/fastly/cli/pkg/app"
	"github.com/fastly/cli/pkg/global"
	"github.com/fastly/cli/pkg/mock"
	"github.com/fastly/cli/pkg/testutil"
)

func TestConditionCreate(t *testing.T) {
	args := testutil.Args
	scenarios := []testutil.TestScenario{
		{
			Args:      args("vcl condition create --version 1"),
			WantError: "error reading service: no service ID found",
		},
		{
			Args: args("vcl condition create --service-id 123 --version 1 --name always_false --statement false --type REQUEST --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				CreateConditionFn: createConditionOK,
			},
			WantOutput: "Created condition always_false (service 123 version 4)",
		},
		{
			Args: args("vcl condition create --service-id 123 --version 1 --name always_false --statement false --type REQUEST --priority 10 --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				CreateConditionFn: createConditionError,
			},
			WantError: errTest.Error(),
		},
	}

	for _, testcase := range scenarios {
		t.Run(testcase.Name, func(t *testing.T) {
			var stdout bytes.Buffer
			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
				opts := testutil.MockGlobalData(testcase.Args, &stdout)
				opts.APIClientFactory = mock.APIClient(testcase.API)
				return opts, nil
			}
			err := app.Run(testcase.Args, nil)
			testutil.AssertErrorContains(t, err, testcase.WantError)
			testutil.AssertStringContains(t, stdout.String(), testcase.WantOutput)
		})
	}
}

func TestConditionDelete(t *testing.T) {
	args := testutil.Args
	scenarios := []testutil.TestScenario{
		{
			Args:      args("vcl condition delete --service-id 123 --version 1"),
			WantError: "error parsing arguments: required flag --name not provided",
		},
		{
			Args: args("vcl condition delete --service-id 123 --version 1 --name always_false --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				DeleteConditionFn: deleteConditionError,
			},
			WantError: errTest.Error(),
		},
		{
			Args: args("vcl condition delete --service-id 123 --version 1 --name always_false --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				DeleteConditionFn: deleteConditionOK,
			},
			WantOutput: "Deleted condition always_false (service 123 version 4)",
		},
	}
	for testcaseIdx := range scenarios {
		testcase := &scenarios[testcaseIdx]
		t.Run(testcase.Name, func(t *testing.T) {
			var stdout bytes.Buffer
			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
				opts := testutil.MockGlobalData(testcase.Args, &stdout)
				opts.APIClientFactory = mock.APIClient(testcase.API)
				return opts, nil
			}
			err := app.Run(testcase.Args, nil)
			testutil.AssertErrorContains(t, err, testcase.WantError)
			testutil.AssertStringContains(t, stdout.String(), testcase.WantOutput)
		})
	}
}

func TestConditionUpdate(t *testing.T) {
	args := testutil.Args
	scenarios := []testutil.TestScenario{
		{
			Args:      args("vcl condition update --service-id 123 --version 1 --new-name false_always --comment "),
			WantError: "error parsing arguments: required flag --name not provided",
		},
		{
			Args: args("vcl condition update --service-id 123 --version 1 --name always_false --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				UpdateConditionFn: updateConditionOK,
			},
			WantError: "error parsing arguments: must provide either --new-name, --statement, --type or --priority to update condition",
		},
		{
			Args: args("vcl condition update --service-id 123 --version 1 --name always_false --new-name false_always --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				UpdateConditionFn: updateConditionError,
			},
			WantError: errTest.Error(),
		},
		{
			Args: args("vcl condition update --service-id 123 --version 1 --name always_false --new-name false_always --autoclone"),
			API: mock.API{
				ListVersionsFn:    testutil.ListVersions,
				CloneVersionFn:    testutil.CloneVersionResult(4),
				UpdateConditionFn: updateConditionOK,
			},
			WantOutput: "Updated condition false_always (service 123 version 4)",
		},
	}
	for testcaseIdx := range scenarios {
		testcase := &scenarios[testcaseIdx]
		t.Run(testcase.Name, func(t *testing.T) {
			var stdout bytes.Buffer
			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
				opts := testutil.MockGlobalData(testcase.Args, &stdout)
				opts.APIClientFactory = mock.APIClient(testcase.API)
				return opts, nil
			}
			err := app.Run(testcase.Args, nil)
			testutil.AssertErrorContains(t, err, testcase.WantError)
			testutil.AssertStringContains(t, stdout.String(), testcase.WantOutput)
		})
	}
}

func TestConditionDescribe(t *testing.T) {
	args := testutil.Args
	scenarios := []testutil.TestScenario{
		{
			Args:      args("vcl condition describe --service-id 123 --version 1"),
			WantError: "error parsing arguments: required flag --name not provided",
		},
		{
			Args: args("vcl condition describe --service-id 123 --version 1 --name always_false"),
			API: mock.API{
				ListVersionsFn: testutil.ListVersions,
				GetConditionFn: getConditionError,
			},
			WantError: errTest.Error(),
		},
		{
			Args: args("vcl condition describe --service-id 123 --version 1 --name always_false"),
			API: mock.API{
				ListVersionsFn: testutil.ListVersions,
				GetConditionFn: getConditionOK,
			},
			WantOutput: describeConditionOutput,
		},
	}
	for testcaseIdx := range scenarios {
		testcase := &scenarios[testcaseIdx]
		t.Run(testcase.Name, func(t *testing.T) {
			var stdout bytes.Buffer
			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
				opts := testutil.MockGlobalData(testcase.Args, &stdout)
				opts.APIClientFactory = mock.APIClient(testcase.API)
				return opts, nil
			}
			err := app.Run(testcase.Args, nil)
			testutil.AssertErrorContains(t, err, testcase.WantError)
			testutil.AssertString(t, testcase.WantOutput, stdout.String())
		})
	}
}

func TestConditionList(t *testing.T) {
	args := testutil.Args
	scenarios := []testutil.TestScenario{
		{
			Args: args("vcl condition list --service-id 123 --version 1"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsOK,
			},
			WantOutput: listConditionsShortOutput,
		},
		{
			Args: args("vcl condition list --service-id 123 --version 1 --verbose"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsOK,
			},
			WantOutput: listConditionsVerboseOutput,
		},
		{
			Args: args("vcl condition list --service-id 123 --version 1 -v"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsOK,
			},
			WantOutput: listConditionsVerboseOutput,
		},
		{
			Args: args("vcl condition --verbose list --service-id 123 --version 1"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsOK,
			},
			WantOutput: listConditionsVerboseOutput,
		},
		{
			Args: args("-v vcl condition list --service-id 123 --version 1"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsOK,
			},
			WantOutput: listConditionsVerboseOutput,
		},
		{
			Args: args("vcl condition list --service-id 123 --version 1"),
			API: mock.API{
				ListVersionsFn:   testutil.ListVersions,
				ListConditionsFn: listConditionsError,
			},
			WantError: errTest.Error(),
		},
	}
	for testcaseIdx := range scenarios {
		testcase := &scenarios[testcaseIdx]
		t.Run(testcase.Name, func(t *testing.T) {
			var stdout bytes.Buffer
			app.Init = func(_ []string, _ io.Reader) (*global.Data, error) {
				opts := testutil.MockGlobalData(testcase.Args, &stdout)
				opts.APIClientFactory = mock.APIClient(testcase.API)
				return opts, nil
			}
			err := app.Run(testcase.Args, nil)
			testutil.AssertErrorContains(t, err, testcase.WantError)
			testutil.AssertString(t, testcase.WantOutput, stdout.String())
		})
	}
}

var describeConditionOutput = "\n" + strings.TrimSpace(`
Service ID: 123
Version: 1
Name: always_false
Statement: false
Type: CACHE
Priority: 10
`) + "\n"

var listConditionsShortOutput = strings.TrimSpace(`
SERVICE  VERSION  NAME                  STATEMENT  TYPE     PRIORITY
123      1        always_false_request  false      REQUEST  10
123      1        always_false_cache    false      CACHE    10
`) + "\n"

var listConditionsVerboseOutput = strings.TrimSpace(`
Fastly API endpoint: https://api.fastly.com
Fastly API token provided via config file (profile: user)

Service ID (via --service-id): 123

Version: 1
	Condition 1/2
		Name: always_false_request
		Statement: false
		Type: REQUEST
		Priority: 10
	Condition 2/2
		Name: always_false_cache
		Statement: false
		Type: CACHE
		Priority: 10
`) + "\n\n"

var errTest = errors.New("fixture error")

func createConditionOK(i *fastly.CreateConditionInput) (*fastly.Condition, error) {
	priority := 10
	if i.Priority != nil {
		priority = *i.Priority
	}

	conditionType := "REQUEST"
	if i.Type != nil {
		conditionType = *i.Type
	}

	return &fastly.Condition{
		ServiceID:      fastly.ToPointer(i.ServiceID),
		ServiceVersion: fastly.ToPointer(i.ServiceVersion),
		Name:           i.Name,
		Statement:      i.Statement,
		Type:           fastly.ToPointer(conditionType),
		Priority:       fastly.ToPointer(priority),
	}, nil
}

func createConditionError(_ *fastly.CreateConditionInput) (*fastly.Condition, error) {
	return nil, errTest
}

func deleteConditionOK(_ *fastly.DeleteConditionInput) error {
	return nil
}

func deleteConditionError(_ *fastly.DeleteConditionInput) error {
	return errTest
}

func updateConditionOK(i *fastly.UpdateConditionInput) (*fastly.Condition, error) {
	priority := 10
	if i.Priority != nil {
		priority = *i.Priority
	}

	conditionType := "REQUEST"
	if i.Type != nil {
		conditionType = *i.Type
	}

	statement := "false"
	if i.Statement != nil {
		statement = *i.Type
	}

	return &fastly.Condition{
		ServiceID:      fastly.ToPointer(i.ServiceID),
		ServiceVersion: fastly.ToPointer(i.ServiceVersion),
		Name:           fastly.ToPointer(i.Name),
		Statement:      fastly.ToPointer(statement),
		Type:           fastly.ToPointer(conditionType),
		Priority:       fastly.ToPointer(priority),
	}, nil
}

func updateConditionError(_ *fastly.UpdateConditionInput) (*fastly.Condition, error) {
	return nil, errTest
}

func getConditionOK(i *fastly.GetConditionInput) (*fastly.Condition, error) {
	priority := 10
	conditionType := "CACHE"
	statement := "false"

	return &fastly.Condition{
		ServiceID:      fastly.ToPointer(i.ServiceID),
		ServiceVersion: fastly.ToPointer(i.ServiceVersion),
		Name:           fastly.ToPointer(i.Name),
		Statement:      fastly.ToPointer(statement),
		Type:           fastly.ToPointer(conditionType),
		Priority:       fastly.ToPointer(priority),
	}, nil
}

func getConditionError(_ *fastly.GetConditionInput) (*fastly.Condition, error) {
	return nil, errTest
}

func listConditionsOK(i *fastly.ListConditionsInput) ([]*fastly.Condition, error) {
	return []*fastly.Condition{
		{
			ServiceID:      fastly.ToPointer(i.ServiceID),
			ServiceVersion: fastly.ToPointer(i.ServiceVersion),
			Name:           fastly.ToPointer("always_false_request"),
			Statement:      fastly.ToPointer("false"),
			Type:           fastly.ToPointer("REQUEST"),
			Priority:       fastly.ToPointer(10),
		},
		{
			ServiceID:      fastly.ToPointer(i.ServiceID),
			ServiceVersion: fastly.ToPointer(i.ServiceVersion),
			Name:           fastly.ToPointer("always_false_cache"),
			Statement:      fastly.ToPointer("false"),
			Type:           fastly.ToPointer("CACHE"),
			Priority:       fastly.ToPointer(10),
		},
	}, nil
}

func listConditionsError(_ *fastly.ListConditionsInput) ([]*fastly.Condition, error) {
	return nil, errTest
}