github.com/geraldss/go/src@v0.0.0-20210511222824-ac7d0ebfc235/net/http/fs_test.go (about) 1 // Copyright 2010 The Go Authors. All rights reserved. 2 // Use of this source code is governed by a BSD-style 3 // license that can be found in the LICENSE file. 4 5 package http_test 6 7 import ( 8 "bufio" 9 "bytes" 10 "errors" 11 "fmt" 12 "io" 13 "io/fs" 14 "io/ioutil" 15 "mime" 16 "mime/multipart" 17 "net" 18 . "net/http" 19 "net/http/httptest" 20 "net/url" 21 "os" 22 "os/exec" 23 "path" 24 "path/filepath" 25 "reflect" 26 "regexp" 27 "runtime" 28 "strings" 29 "testing" 30 "time" 31 ) 32 33 const ( 34 testFile = "testdata/file" 35 testFileLen = 11 36 ) 37 38 type wantRange struct { 39 start, end int64 // range [start,end) 40 } 41 42 var ServeFileRangeTests = []struct { 43 r string 44 code int 45 ranges []wantRange 46 }{ 47 {r: "", code: StatusOK}, 48 {r: "bytes=0-4", code: StatusPartialContent, ranges: []wantRange{{0, 5}}}, 49 {r: "bytes=2-", code: StatusPartialContent, ranges: []wantRange{{2, testFileLen}}}, 50 {r: "bytes=-5", code: StatusPartialContent, ranges: []wantRange{{testFileLen - 5, testFileLen}}}, 51 {r: "bytes=3-7", code: StatusPartialContent, ranges: []wantRange{{3, 8}}}, 52 {r: "bytes=0-0,-2", code: StatusPartialContent, ranges: []wantRange{{0, 1}, {testFileLen - 2, testFileLen}}}, 53 {r: "bytes=0-1,5-8", code: StatusPartialContent, ranges: []wantRange{{0, 2}, {5, 9}}}, 54 {r: "bytes=0-1,5-", code: StatusPartialContent, ranges: []wantRange{{0, 2}, {5, testFileLen}}}, 55 {r: "bytes=5-1000", code: StatusPartialContent, ranges: []wantRange{{5, testFileLen}}}, 56 {r: "bytes=0-,1-,2-,3-,4-", code: StatusOK}, // ignore wasteful range request 57 {r: "bytes=0-9", code: StatusPartialContent, ranges: []wantRange{{0, testFileLen - 1}}}, 58 {r: "bytes=0-10", code: StatusPartialContent, ranges: []wantRange{{0, testFileLen}}}, 59 {r: "bytes=0-11", code: StatusPartialContent, ranges: []wantRange{{0, testFileLen}}}, 60 {r: "bytes=10-11", code: StatusPartialContent, ranges: []wantRange{{testFileLen - 1, testFileLen}}}, 61 {r: "bytes=10-", code: StatusPartialContent, ranges: []wantRange{{testFileLen - 1, testFileLen}}}, 62 {r: "bytes=11-", code: StatusRequestedRangeNotSatisfiable}, 63 {r: "bytes=11-12", code: StatusRequestedRangeNotSatisfiable}, 64 {r: "bytes=12-12", code: StatusRequestedRangeNotSatisfiable}, 65 {r: "bytes=11-100", code: StatusRequestedRangeNotSatisfiable}, 66 {r: "bytes=12-100", code: StatusRequestedRangeNotSatisfiable}, 67 {r: "bytes=100-", code: StatusRequestedRangeNotSatisfiable}, 68 {r: "bytes=100-1000", code: StatusRequestedRangeNotSatisfiable}, 69 } 70 71 func TestServeFile(t *testing.T) { 72 setParallel(t) 73 defer afterTest(t) 74 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 75 ServeFile(w, r, "testdata/file") 76 })) 77 defer ts.Close() 78 c := ts.Client() 79 80 var err error 81 82 file, err := os.ReadFile(testFile) 83 if err != nil { 84 t.Fatal("reading file:", err) 85 } 86 87 // set up the Request (re-used for all tests) 88 var req Request 89 req.Header = make(Header) 90 if req.URL, err = url.Parse(ts.URL); err != nil { 91 t.Fatal("ParseURL:", err) 92 } 93 req.Method = "GET" 94 95 // straight GET 96 _, body := getBody(t, "straight get", req, c) 97 if !bytes.Equal(body, file) { 98 t.Fatalf("body mismatch: got %q, want %q", body, file) 99 } 100 101 // Range tests 102 Cases: 103 for _, rt := range ServeFileRangeTests { 104 if rt.r != "" { 105 req.Header.Set("Range", rt.r) 106 } 107 resp, body := getBody(t, fmt.Sprintf("range test %q", rt.r), req, c) 108 if resp.StatusCode != rt.code { 109 t.Errorf("range=%q: StatusCode=%d, want %d", rt.r, resp.StatusCode, rt.code) 110 } 111 if rt.code == StatusRequestedRangeNotSatisfiable { 112 continue 113 } 114 wantContentRange := "" 115 if len(rt.ranges) == 1 { 116 rng := rt.ranges[0] 117 wantContentRange = fmt.Sprintf("bytes %d-%d/%d", rng.start, rng.end-1, testFileLen) 118 } 119 cr := resp.Header.Get("Content-Range") 120 if cr != wantContentRange { 121 t.Errorf("range=%q: Content-Range = %q, want %q", rt.r, cr, wantContentRange) 122 } 123 ct := resp.Header.Get("Content-Type") 124 if len(rt.ranges) == 1 { 125 rng := rt.ranges[0] 126 wantBody := file[rng.start:rng.end] 127 if !bytes.Equal(body, wantBody) { 128 t.Errorf("range=%q: body = %q, want %q", rt.r, body, wantBody) 129 } 130 if strings.HasPrefix(ct, "multipart/byteranges") { 131 t.Errorf("range=%q content-type = %q; unexpected multipart/byteranges", rt.r, ct) 132 } 133 } 134 if len(rt.ranges) > 1 { 135 typ, params, err := mime.ParseMediaType(ct) 136 if err != nil { 137 t.Errorf("range=%q content-type = %q; %v", rt.r, ct, err) 138 continue 139 } 140 if typ != "multipart/byteranges" { 141 t.Errorf("range=%q content-type = %q; want multipart/byteranges", rt.r, typ) 142 continue 143 } 144 if params["boundary"] == "" { 145 t.Errorf("range=%q content-type = %q; lacks boundary", rt.r, ct) 146 continue 147 } 148 if g, w := resp.ContentLength, int64(len(body)); g != w { 149 t.Errorf("range=%q Content-Length = %d; want %d", rt.r, g, w) 150 continue 151 } 152 mr := multipart.NewReader(bytes.NewReader(body), params["boundary"]) 153 for ri, rng := range rt.ranges { 154 part, err := mr.NextPart() 155 if err != nil { 156 t.Errorf("range=%q, reading part index %d: %v", rt.r, ri, err) 157 continue Cases 158 } 159 wantContentRange = fmt.Sprintf("bytes %d-%d/%d", rng.start, rng.end-1, testFileLen) 160 if g, w := part.Header.Get("Content-Range"), wantContentRange; g != w { 161 t.Errorf("range=%q: part Content-Range = %q; want %q", rt.r, g, w) 162 } 163 body, err := io.ReadAll(part) 164 if err != nil { 165 t.Errorf("range=%q, reading part index %d body: %v", rt.r, ri, err) 166 continue Cases 167 } 168 wantBody := file[rng.start:rng.end] 169 if !bytes.Equal(body, wantBody) { 170 t.Errorf("range=%q: body = %q, want %q", rt.r, body, wantBody) 171 } 172 } 173 _, err = mr.NextPart() 174 if err != io.EOF { 175 t.Errorf("range=%q; expected final error io.EOF; got %v", rt.r, err) 176 } 177 } 178 } 179 } 180 181 func TestServeFile_DotDot(t *testing.T) { 182 tests := []struct { 183 req string 184 wantStatus int 185 }{ 186 {"/testdata/file", 200}, 187 {"/../file", 400}, 188 {"/..", 400}, 189 {"/../", 400}, 190 {"/../foo", 400}, 191 {"/..\\foo", 400}, 192 {"/file/a", 200}, 193 {"/file/a..", 200}, 194 {"/file/a/..", 400}, 195 {"/file/a\\..", 400}, 196 } 197 for _, tt := range tests { 198 req, err := ReadRequest(bufio.NewReader(strings.NewReader("GET " + tt.req + " HTTP/1.1\r\nHost: foo\r\n\r\n"))) 199 if err != nil { 200 t.Errorf("bad request %q: %v", tt.req, err) 201 continue 202 } 203 rec := httptest.NewRecorder() 204 ServeFile(rec, req, "testdata/file") 205 if rec.Code != tt.wantStatus { 206 t.Errorf("for request %q, status = %d; want %d", tt.req, rec.Code, tt.wantStatus) 207 } 208 } 209 } 210 211 // Tests that this doesn't panic. (Issue 30165) 212 func TestServeFileDirPanicEmptyPath(t *testing.T) { 213 rec := httptest.NewRecorder() 214 req := httptest.NewRequest("GET", "/", nil) 215 req.URL.Path = "" 216 ServeFile(rec, req, "testdata") 217 res := rec.Result() 218 if res.StatusCode != 301 { 219 t.Errorf("code = %v; want 301", res.Status) 220 } 221 } 222 223 var fsRedirectTestData = []struct { 224 original, redirect string 225 }{ 226 {"/test/index.html", "/test/"}, 227 {"/test/testdata", "/test/testdata/"}, 228 {"/test/testdata/file/", "/test/testdata/file"}, 229 } 230 231 func TestFSRedirect(t *testing.T) { 232 defer afterTest(t) 233 ts := httptest.NewServer(StripPrefix("/test", FileServer(Dir(".")))) 234 defer ts.Close() 235 236 for _, data := range fsRedirectTestData { 237 res, err := Get(ts.URL + data.original) 238 if err != nil { 239 t.Fatal(err) 240 } 241 res.Body.Close() 242 if g, e := res.Request.URL.Path, data.redirect; g != e { 243 t.Errorf("redirect from %s: got %s, want %s", data.original, g, e) 244 } 245 } 246 } 247 248 type testFileSystem struct { 249 open func(name string) (File, error) 250 } 251 252 func (fs *testFileSystem) Open(name string) (File, error) { 253 return fs.open(name) 254 } 255 256 func TestFileServerCleans(t *testing.T) { 257 defer afterTest(t) 258 ch := make(chan string, 1) 259 fs := FileServer(&testFileSystem{func(name string) (File, error) { 260 ch <- name 261 return nil, errors.New("file does not exist") 262 }}) 263 tests := []struct { 264 reqPath, openArg string 265 }{ 266 {"/foo.txt", "/foo.txt"}, 267 {"//foo.txt", "/foo.txt"}, 268 {"/../foo.txt", "/foo.txt"}, 269 } 270 req, _ := NewRequest("GET", "http://example.com", nil) 271 for n, test := range tests { 272 rec := httptest.NewRecorder() 273 req.URL.Path = test.reqPath 274 fs.ServeHTTP(rec, req) 275 if got := <-ch; got != test.openArg { 276 t.Errorf("test %d: got %q, want %q", n, got, test.openArg) 277 } 278 } 279 } 280 281 func TestFileServerEscapesNames(t *testing.T) { 282 defer afterTest(t) 283 const dirListPrefix = "<pre>\n" 284 const dirListSuffix = "\n</pre>\n" 285 tests := []struct { 286 name, escaped string 287 }{ 288 {`simple_name`, `<a href="simple_name">simple_name</a>`}, 289 {`"'<>&`, `<a href="%22%27%3C%3E&">"'<>&</a>`}, 290 {`?foo=bar#baz`, `<a href="%3Ffoo=bar%23baz">?foo=bar#baz</a>`}, 291 {`<combo>?foo`, `<a href="%3Ccombo%3E%3Ffoo"><combo>?foo</a>`}, 292 {`foo:bar`, `<a href="./foo:bar">foo:bar</a>`}, 293 } 294 295 // We put each test file in its own directory in the fakeFS so we can look at it in isolation. 296 fs := make(fakeFS) 297 for i, test := range tests { 298 testFile := &fakeFileInfo{basename: test.name} 299 fs[fmt.Sprintf("/%d", i)] = &fakeFileInfo{ 300 dir: true, 301 modtime: time.Unix(1000000000, 0).UTC(), 302 ents: []*fakeFileInfo{testFile}, 303 } 304 fs[fmt.Sprintf("/%d/%s", i, test.name)] = testFile 305 } 306 307 ts := httptest.NewServer(FileServer(&fs)) 308 defer ts.Close() 309 for i, test := range tests { 310 url := fmt.Sprintf("%s/%d", ts.URL, i) 311 res, err := Get(url) 312 if err != nil { 313 t.Fatalf("test %q: Get: %v", test.name, err) 314 } 315 b, err := io.ReadAll(res.Body) 316 if err != nil { 317 t.Fatalf("test %q: read Body: %v", test.name, err) 318 } 319 s := string(b) 320 if !strings.HasPrefix(s, dirListPrefix) || !strings.HasSuffix(s, dirListSuffix) { 321 t.Errorf("test %q: listing dir, full output is %q, want prefix %q and suffix %q", test.name, s, dirListPrefix, dirListSuffix) 322 } 323 if trimmed := strings.TrimSuffix(strings.TrimPrefix(s, dirListPrefix), dirListSuffix); trimmed != test.escaped { 324 t.Errorf("test %q: listing dir, filename escaped to %q, want %q", test.name, trimmed, test.escaped) 325 } 326 res.Body.Close() 327 } 328 } 329 330 func TestFileServerSortsNames(t *testing.T) { 331 defer afterTest(t) 332 const contents = "I am a fake file" 333 dirMod := time.Unix(123, 0).UTC() 334 fileMod := time.Unix(1000000000, 0).UTC() 335 fs := fakeFS{ 336 "/": &fakeFileInfo{ 337 dir: true, 338 modtime: dirMod, 339 ents: []*fakeFileInfo{ 340 { 341 basename: "b", 342 modtime: fileMod, 343 contents: contents, 344 }, 345 { 346 basename: "a", 347 modtime: fileMod, 348 contents: contents, 349 }, 350 }, 351 }, 352 } 353 354 ts := httptest.NewServer(FileServer(&fs)) 355 defer ts.Close() 356 357 res, err := Get(ts.URL) 358 if err != nil { 359 t.Fatalf("Get: %v", err) 360 } 361 defer res.Body.Close() 362 363 b, err := io.ReadAll(res.Body) 364 if err != nil { 365 t.Fatalf("read Body: %v", err) 366 } 367 s := string(b) 368 if !strings.Contains(s, "<a href=\"a\">a</a>\n<a href=\"b\">b</a>") { 369 t.Errorf("output appears to be unsorted:\n%s", s) 370 } 371 } 372 373 func mustRemoveAll(dir string) { 374 err := os.RemoveAll(dir) 375 if err != nil { 376 panic(err) 377 } 378 } 379 380 func TestFileServerImplicitLeadingSlash(t *testing.T) { 381 defer afterTest(t) 382 tempDir, err := os.MkdirTemp("", "") 383 if err != nil { 384 t.Fatalf("TempDir: %v", err) 385 } 386 defer mustRemoveAll(tempDir) 387 if err := os.WriteFile(filepath.Join(tempDir, "foo.txt"), []byte("Hello world"), 0644); err != nil { 388 t.Fatalf("WriteFile: %v", err) 389 } 390 ts := httptest.NewServer(StripPrefix("/bar/", FileServer(Dir(tempDir)))) 391 defer ts.Close() 392 get := func(suffix string) string { 393 res, err := Get(ts.URL + suffix) 394 if err != nil { 395 t.Fatalf("Get %s: %v", suffix, err) 396 } 397 b, err := io.ReadAll(res.Body) 398 if err != nil { 399 t.Fatalf("ReadAll %s: %v", suffix, err) 400 } 401 res.Body.Close() 402 return string(b) 403 } 404 if s := get("/bar/"); !strings.Contains(s, ">foo.txt<") { 405 t.Logf("expected a directory listing with foo.txt, got %q", s) 406 } 407 if s := get("/bar/foo.txt"); s != "Hello world" { 408 t.Logf("expected %q, got %q", "Hello world", s) 409 } 410 } 411 412 func TestDirJoin(t *testing.T) { 413 if runtime.GOOS == "windows" { 414 t.Skip("skipping test on windows") 415 } 416 wfi, err := os.Stat("/etc/hosts") 417 if err != nil { 418 t.Skip("skipping test; no /etc/hosts file") 419 } 420 test := func(d Dir, name string) { 421 f, err := d.Open(name) 422 if err != nil { 423 t.Fatalf("open of %s: %v", name, err) 424 } 425 defer f.Close() 426 gfi, err := f.Stat() 427 if err != nil { 428 t.Fatalf("stat of %s: %v", name, err) 429 } 430 if !os.SameFile(gfi, wfi) { 431 t.Errorf("%s got different file", name) 432 } 433 } 434 test(Dir("/etc/"), "/hosts") 435 test(Dir("/etc/"), "hosts") 436 test(Dir("/etc/"), "../../../../hosts") 437 test(Dir("/etc"), "/hosts") 438 test(Dir("/etc"), "hosts") 439 test(Dir("/etc"), "../../../../hosts") 440 441 // Not really directories, but since we use this trick in 442 // ServeFile, test it: 443 test(Dir("/etc/hosts"), "") 444 test(Dir("/etc/hosts"), "/") 445 test(Dir("/etc/hosts"), "../") 446 } 447 448 func TestEmptyDirOpenCWD(t *testing.T) { 449 test := func(d Dir) { 450 name := "fs_test.go" 451 f, err := d.Open(name) 452 if err != nil { 453 t.Fatalf("open of %s: %v", name, err) 454 } 455 defer f.Close() 456 } 457 test(Dir("")) 458 test(Dir(".")) 459 test(Dir("./")) 460 } 461 462 func TestServeFileContentType(t *testing.T) { 463 defer afterTest(t) 464 const ctype = "icecream/chocolate" 465 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 466 switch r.FormValue("override") { 467 case "1": 468 w.Header().Set("Content-Type", ctype) 469 case "2": 470 // Explicitly inhibit sniffing. 471 w.Header()["Content-Type"] = []string{} 472 } 473 ServeFile(w, r, "testdata/file") 474 })) 475 defer ts.Close() 476 get := func(override string, want []string) { 477 resp, err := Get(ts.URL + "?override=" + override) 478 if err != nil { 479 t.Fatal(err) 480 } 481 if h := resp.Header["Content-Type"]; !reflect.DeepEqual(h, want) { 482 t.Errorf("Content-Type mismatch: got %v, want %v", h, want) 483 } 484 resp.Body.Close() 485 } 486 get("0", []string{"text/plain; charset=utf-8"}) 487 get("1", []string{ctype}) 488 get("2", nil) 489 } 490 491 func TestServeFileMimeType(t *testing.T) { 492 defer afterTest(t) 493 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 494 ServeFile(w, r, "testdata/style.css") 495 })) 496 defer ts.Close() 497 resp, err := Get(ts.URL) 498 if err != nil { 499 t.Fatal(err) 500 } 501 resp.Body.Close() 502 want := "text/css; charset=utf-8" 503 if h := resp.Header.Get("Content-Type"); h != want { 504 t.Errorf("Content-Type mismatch: got %q, want %q", h, want) 505 } 506 } 507 508 func TestServeFileFromCWD(t *testing.T) { 509 defer afterTest(t) 510 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 511 ServeFile(w, r, "fs_test.go") 512 })) 513 defer ts.Close() 514 r, err := Get(ts.URL) 515 if err != nil { 516 t.Fatal(err) 517 } 518 r.Body.Close() 519 if r.StatusCode != 200 { 520 t.Fatalf("expected 200 OK, got %s", r.Status) 521 } 522 } 523 524 // Issue 13996 525 func TestServeDirWithoutTrailingSlash(t *testing.T) { 526 e := "/testdata/" 527 defer afterTest(t) 528 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 529 ServeFile(w, r, ".") 530 })) 531 defer ts.Close() 532 r, err := Get(ts.URL + "/testdata") 533 if err != nil { 534 t.Fatal(err) 535 } 536 r.Body.Close() 537 if g := r.Request.URL.Path; g != e { 538 t.Errorf("got %s, want %s", g, e) 539 } 540 } 541 542 // Tests that ServeFile doesn't add a Content-Length if a Content-Encoding is 543 // specified. 544 func TestServeFileWithContentEncoding_h1(t *testing.T) { testServeFileWithContentEncoding(t, h1Mode) } 545 func TestServeFileWithContentEncoding_h2(t *testing.T) { testServeFileWithContentEncoding(t, h2Mode) } 546 func testServeFileWithContentEncoding(t *testing.T, h2 bool) { 547 defer afterTest(t) 548 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 549 w.Header().Set("Content-Encoding", "foo") 550 ServeFile(w, r, "testdata/file") 551 552 // Because the testdata is so small, it would fit in 553 // both the h1 and h2 Server's write buffers. For h1, 554 // sendfile is used, though, forcing a header flush at 555 // the io.Copy. http2 doesn't do a header flush so 556 // buffers all 11 bytes and then adds its own 557 // Content-Length. To prevent the Server's 558 // Content-Length and test ServeFile only, flush here. 559 w.(Flusher).Flush() 560 })) 561 defer cst.close() 562 resp, err := cst.c.Get(cst.ts.URL) 563 if err != nil { 564 t.Fatal(err) 565 } 566 resp.Body.Close() 567 if g, e := resp.ContentLength, int64(-1); g != e { 568 t.Errorf("Content-Length mismatch: got %d, want %d", g, e) 569 } 570 } 571 572 func TestServeIndexHtml(t *testing.T) { 573 defer afterTest(t) 574 575 for i := 0; i < 2; i++ { 576 var h Handler 577 var name string 578 switch i { 579 case 0: 580 h = FileServer(Dir(".")) 581 name = "Dir" 582 case 1: 583 h = FileServer(FS(os.DirFS("."))) 584 name = "DirFS" 585 } 586 t.Run(name, func(t *testing.T) { 587 const want = "index.html says hello\n" 588 ts := httptest.NewServer(h) 589 defer ts.Close() 590 591 for _, path := range []string{"/testdata/", "/testdata/index.html"} { 592 res, err := Get(ts.URL + path) 593 if err != nil { 594 t.Fatal(err) 595 } 596 b, err := ioutil.ReadAll(res.Body) 597 if err != nil { 598 t.Fatal("reading Body:", err) 599 } 600 if s := string(b); s != want { 601 t.Errorf("for path %q got %q, want %q", path, s, want) 602 } 603 res.Body.Close() 604 } 605 }) 606 } 607 } 608 609 func TestServeIndexHtmlFS(t *testing.T) { 610 defer afterTest(t) 611 const want = "index.html says hello\n" 612 ts := httptest.NewServer(FileServer(Dir("."))) 613 defer ts.Close() 614 615 for _, path := range []string{"/testdata/", "/testdata/index.html"} { 616 res, err := Get(ts.URL + path) 617 if err != nil { 618 t.Fatal(err) 619 } 620 b, err := io.ReadAll(res.Body) 621 if err != nil { 622 t.Fatal("reading Body:", err) 623 } 624 if s := string(b); s != want { 625 t.Errorf("for path %q got %q, want %q", path, s, want) 626 } 627 res.Body.Close() 628 } 629 } 630 631 func TestFileServerZeroByte(t *testing.T) { 632 defer afterTest(t) 633 ts := httptest.NewServer(FileServer(Dir("."))) 634 defer ts.Close() 635 636 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 637 if err != nil { 638 t.Fatal(err) 639 } 640 defer c.Close() 641 _, err = fmt.Fprintf(c, "GET /..\x00 HTTP/1.0\r\n\r\n") 642 if err != nil { 643 t.Fatal(err) 644 } 645 var got bytes.Buffer 646 bufr := bufio.NewReader(io.TeeReader(c, &got)) 647 res, err := ReadResponse(bufr, nil) 648 if err != nil { 649 t.Fatal("ReadResponse: ", err) 650 } 651 if res.StatusCode == 200 { 652 t.Errorf("got status 200; want an error. Body is:\n%s", got.Bytes()) 653 } 654 } 655 656 type fakeFileInfo struct { 657 dir bool 658 basename string 659 modtime time.Time 660 ents []*fakeFileInfo 661 contents string 662 err error 663 } 664 665 func (f *fakeFileInfo) Name() string { return f.basename } 666 func (f *fakeFileInfo) Sys() interface{} { return nil } 667 func (f *fakeFileInfo) ModTime() time.Time { return f.modtime } 668 func (f *fakeFileInfo) IsDir() bool { return f.dir } 669 func (f *fakeFileInfo) Size() int64 { return int64(len(f.contents)) } 670 func (f *fakeFileInfo) Mode() fs.FileMode { 671 if f.dir { 672 return 0755 | fs.ModeDir 673 } 674 return 0644 675 } 676 677 type fakeFile struct { 678 io.ReadSeeker 679 fi *fakeFileInfo 680 path string // as opened 681 entpos int 682 } 683 684 func (f *fakeFile) Close() error { return nil } 685 func (f *fakeFile) Stat() (fs.FileInfo, error) { return f.fi, nil } 686 func (f *fakeFile) Readdir(count int) ([]fs.FileInfo, error) { 687 if !f.fi.dir { 688 return nil, fs.ErrInvalid 689 } 690 var fis []fs.FileInfo 691 692 limit := f.entpos + count 693 if count <= 0 || limit > len(f.fi.ents) { 694 limit = len(f.fi.ents) 695 } 696 for ; f.entpos < limit; f.entpos++ { 697 fis = append(fis, f.fi.ents[f.entpos]) 698 } 699 700 if len(fis) == 0 && count > 0 { 701 return fis, io.EOF 702 } else { 703 return fis, nil 704 } 705 } 706 707 type fakeFS map[string]*fakeFileInfo 708 709 func (fsys fakeFS) Open(name string) (File, error) { 710 name = path.Clean(name) 711 f, ok := fsys[name] 712 if !ok { 713 return nil, fs.ErrNotExist 714 } 715 if f.err != nil { 716 return nil, f.err 717 } 718 return &fakeFile{ReadSeeker: strings.NewReader(f.contents), fi: f, path: name}, nil 719 } 720 721 func TestDirectoryIfNotModified(t *testing.T) { 722 defer afterTest(t) 723 const indexContents = "I am a fake index.html file" 724 fileMod := time.Unix(1000000000, 0).UTC() 725 fileModStr := fileMod.Format(TimeFormat) 726 dirMod := time.Unix(123, 0).UTC() 727 indexFile := &fakeFileInfo{ 728 basename: "index.html", 729 modtime: fileMod, 730 contents: indexContents, 731 } 732 fs := fakeFS{ 733 "/": &fakeFileInfo{ 734 dir: true, 735 modtime: dirMod, 736 ents: []*fakeFileInfo{indexFile}, 737 }, 738 "/index.html": indexFile, 739 } 740 741 ts := httptest.NewServer(FileServer(fs)) 742 defer ts.Close() 743 744 res, err := Get(ts.URL) 745 if err != nil { 746 t.Fatal(err) 747 } 748 b, err := io.ReadAll(res.Body) 749 if err != nil { 750 t.Fatal(err) 751 } 752 if string(b) != indexContents { 753 t.Fatalf("Got body %q; want %q", b, indexContents) 754 } 755 res.Body.Close() 756 757 lastMod := res.Header.Get("Last-Modified") 758 if lastMod != fileModStr { 759 t.Fatalf("initial Last-Modified = %q; want %q", lastMod, fileModStr) 760 } 761 762 req, _ := NewRequest("GET", ts.URL, nil) 763 req.Header.Set("If-Modified-Since", lastMod) 764 765 c := ts.Client() 766 res, err = c.Do(req) 767 if err != nil { 768 t.Fatal(err) 769 } 770 if res.StatusCode != 304 { 771 t.Fatalf("Code after If-Modified-Since request = %v; want 304", res.StatusCode) 772 } 773 res.Body.Close() 774 775 // Advance the index.html file's modtime, but not the directory's. 776 indexFile.modtime = indexFile.modtime.Add(1 * time.Hour) 777 778 res, err = c.Do(req) 779 if err != nil { 780 t.Fatal(err) 781 } 782 if res.StatusCode != 200 { 783 t.Fatalf("Code after second If-Modified-Since request = %v; want 200; res is %#v", res.StatusCode, res) 784 } 785 res.Body.Close() 786 } 787 788 func mustStat(t *testing.T, fileName string) fs.FileInfo { 789 fi, err := os.Stat(fileName) 790 if err != nil { 791 t.Fatal(err) 792 } 793 return fi 794 } 795 796 func TestServeContent(t *testing.T) { 797 defer afterTest(t) 798 type serveParam struct { 799 name string 800 modtime time.Time 801 content io.ReadSeeker 802 contentType string 803 etag string 804 } 805 servec := make(chan serveParam, 1) 806 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 807 p := <-servec 808 if p.etag != "" { 809 w.Header().Set("ETag", p.etag) 810 } 811 if p.contentType != "" { 812 w.Header().Set("Content-Type", p.contentType) 813 } 814 ServeContent(w, r, p.name, p.modtime, p.content) 815 })) 816 defer ts.Close() 817 818 type testCase struct { 819 // One of file or content must be set: 820 file string 821 content io.ReadSeeker 822 823 modtime time.Time 824 serveETag string // optional 825 serveContentType string // optional 826 reqHeader map[string]string 827 wantLastMod string 828 wantContentType string 829 wantContentRange string 830 wantStatus int 831 } 832 htmlModTime := mustStat(t, "testdata/index.html").ModTime() 833 tests := map[string]testCase{ 834 "no_last_modified": { 835 file: "testdata/style.css", 836 wantContentType: "text/css; charset=utf-8", 837 wantStatus: 200, 838 }, 839 "with_last_modified": { 840 file: "testdata/index.html", 841 wantContentType: "text/html; charset=utf-8", 842 modtime: htmlModTime, 843 wantLastMod: htmlModTime.UTC().Format(TimeFormat), 844 wantStatus: 200, 845 }, 846 "not_modified_modtime": { 847 file: "testdata/style.css", 848 serveETag: `"foo"`, // Last-Modified sent only when no ETag 849 modtime: htmlModTime, 850 reqHeader: map[string]string{ 851 "If-Modified-Since": htmlModTime.UTC().Format(TimeFormat), 852 }, 853 wantStatus: 304, 854 }, 855 "not_modified_modtime_with_contenttype": { 856 file: "testdata/style.css", 857 serveContentType: "text/css", // explicit content type 858 serveETag: `"foo"`, // Last-Modified sent only when no ETag 859 modtime: htmlModTime, 860 reqHeader: map[string]string{ 861 "If-Modified-Since": htmlModTime.UTC().Format(TimeFormat), 862 }, 863 wantStatus: 304, 864 }, 865 "not_modified_etag": { 866 file: "testdata/style.css", 867 serveETag: `"foo"`, 868 reqHeader: map[string]string{ 869 "If-None-Match": `"foo"`, 870 }, 871 wantStatus: 304, 872 }, 873 "not_modified_etag_no_seek": { 874 content: panicOnSeek{nil}, // should never be called 875 serveETag: `W/"foo"`, // If-None-Match uses weak ETag comparison 876 reqHeader: map[string]string{ 877 "If-None-Match": `"baz", W/"foo"`, 878 }, 879 wantStatus: 304, 880 }, 881 "if_none_match_mismatch": { 882 file: "testdata/style.css", 883 serveETag: `"foo"`, 884 reqHeader: map[string]string{ 885 "If-None-Match": `"Foo"`, 886 }, 887 wantStatus: 200, 888 wantContentType: "text/css; charset=utf-8", 889 }, 890 "if_none_match_malformed": { 891 file: "testdata/style.css", 892 serveETag: `"foo"`, 893 reqHeader: map[string]string{ 894 "If-None-Match": `,`, 895 }, 896 wantStatus: 200, 897 wantContentType: "text/css; charset=utf-8", 898 }, 899 "range_good": { 900 file: "testdata/style.css", 901 serveETag: `"A"`, 902 reqHeader: map[string]string{ 903 "Range": "bytes=0-4", 904 }, 905 wantStatus: StatusPartialContent, 906 wantContentType: "text/css; charset=utf-8", 907 wantContentRange: "bytes 0-4/8", 908 }, 909 "range_match": { 910 file: "testdata/style.css", 911 serveETag: `"A"`, 912 reqHeader: map[string]string{ 913 "Range": "bytes=0-4", 914 "If-Range": `"A"`, 915 }, 916 wantStatus: StatusPartialContent, 917 wantContentType: "text/css; charset=utf-8", 918 wantContentRange: "bytes 0-4/8", 919 }, 920 "range_match_weak_etag": { 921 file: "testdata/style.css", 922 serveETag: `W/"A"`, 923 reqHeader: map[string]string{ 924 "Range": "bytes=0-4", 925 "If-Range": `W/"A"`, 926 }, 927 wantStatus: 200, 928 wantContentType: "text/css; charset=utf-8", 929 }, 930 "range_no_overlap": { 931 file: "testdata/style.css", 932 serveETag: `"A"`, 933 reqHeader: map[string]string{ 934 "Range": "bytes=10-20", 935 }, 936 wantStatus: StatusRequestedRangeNotSatisfiable, 937 wantContentType: "text/plain; charset=utf-8", 938 wantContentRange: "bytes */8", 939 }, 940 // An If-Range resource for entity "A", but entity "B" is now current. 941 // The Range request should be ignored. 942 "range_no_match": { 943 file: "testdata/style.css", 944 serveETag: `"A"`, 945 reqHeader: map[string]string{ 946 "Range": "bytes=0-4", 947 "If-Range": `"B"`, 948 }, 949 wantStatus: 200, 950 wantContentType: "text/css; charset=utf-8", 951 }, 952 "range_with_modtime": { 953 file: "testdata/style.css", 954 modtime: time.Date(2014, 6, 25, 17, 12, 18, 0 /* nanos */, time.UTC), 955 reqHeader: map[string]string{ 956 "Range": "bytes=0-4", 957 "If-Range": "Wed, 25 Jun 2014 17:12:18 GMT", 958 }, 959 wantStatus: StatusPartialContent, 960 wantContentType: "text/css; charset=utf-8", 961 wantContentRange: "bytes 0-4/8", 962 wantLastMod: "Wed, 25 Jun 2014 17:12:18 GMT", 963 }, 964 "range_with_modtime_mismatch": { 965 file: "testdata/style.css", 966 modtime: time.Date(2014, 6, 25, 17, 12, 18, 0 /* nanos */, time.UTC), 967 reqHeader: map[string]string{ 968 "Range": "bytes=0-4", 969 "If-Range": "Wed, 25 Jun 2014 17:12:19 GMT", 970 }, 971 wantStatus: StatusOK, 972 wantContentType: "text/css; charset=utf-8", 973 wantLastMod: "Wed, 25 Jun 2014 17:12:18 GMT", 974 }, 975 "range_with_modtime_nanos": { 976 file: "testdata/style.css", 977 modtime: time.Date(2014, 6, 25, 17, 12, 18, 123 /* nanos */, time.UTC), 978 reqHeader: map[string]string{ 979 "Range": "bytes=0-4", 980 "If-Range": "Wed, 25 Jun 2014 17:12:18 GMT", 981 }, 982 wantStatus: StatusPartialContent, 983 wantContentType: "text/css; charset=utf-8", 984 wantContentRange: "bytes 0-4/8", 985 wantLastMod: "Wed, 25 Jun 2014 17:12:18 GMT", 986 }, 987 "unix_zero_modtime": { 988 content: strings.NewReader("<html>foo"), 989 modtime: time.Unix(0, 0), 990 wantStatus: StatusOK, 991 wantContentType: "text/html; charset=utf-8", 992 }, 993 "ifmatch_matches": { 994 file: "testdata/style.css", 995 serveETag: `"A"`, 996 reqHeader: map[string]string{ 997 "If-Match": `"Z", "A"`, 998 }, 999 wantStatus: 200, 1000 wantContentType: "text/css; charset=utf-8", 1001 }, 1002 "ifmatch_star": { 1003 file: "testdata/style.css", 1004 serveETag: `"A"`, 1005 reqHeader: map[string]string{ 1006 "If-Match": `*`, 1007 }, 1008 wantStatus: 200, 1009 wantContentType: "text/css; charset=utf-8", 1010 }, 1011 "ifmatch_failed": { 1012 file: "testdata/style.css", 1013 serveETag: `"A"`, 1014 reqHeader: map[string]string{ 1015 "If-Match": `"B"`, 1016 }, 1017 wantStatus: 412, 1018 }, 1019 "ifmatch_fails_on_weak_etag": { 1020 file: "testdata/style.css", 1021 serveETag: `W/"A"`, 1022 reqHeader: map[string]string{ 1023 "If-Match": `W/"A"`, 1024 }, 1025 wantStatus: 412, 1026 }, 1027 "if_unmodified_since_true": { 1028 file: "testdata/style.css", 1029 modtime: htmlModTime, 1030 reqHeader: map[string]string{ 1031 "If-Unmodified-Since": htmlModTime.UTC().Format(TimeFormat), 1032 }, 1033 wantStatus: 200, 1034 wantContentType: "text/css; charset=utf-8", 1035 wantLastMod: htmlModTime.UTC().Format(TimeFormat), 1036 }, 1037 "if_unmodified_since_false": { 1038 file: "testdata/style.css", 1039 modtime: htmlModTime, 1040 reqHeader: map[string]string{ 1041 "If-Unmodified-Since": htmlModTime.Add(-2 * time.Second).UTC().Format(TimeFormat), 1042 }, 1043 wantStatus: 412, 1044 wantLastMod: htmlModTime.UTC().Format(TimeFormat), 1045 }, 1046 } 1047 for testName, tt := range tests { 1048 var content io.ReadSeeker 1049 if tt.file != "" { 1050 f, err := os.Open(tt.file) 1051 if err != nil { 1052 t.Fatalf("test %q: %v", testName, err) 1053 } 1054 defer f.Close() 1055 content = f 1056 } else { 1057 content = tt.content 1058 } 1059 for _, method := range []string{"GET", "HEAD"} { 1060 //restore content in case it is consumed by previous method 1061 if content, ok := content.(*strings.Reader); ok { 1062 content.Seek(0, io.SeekStart) 1063 } 1064 1065 servec <- serveParam{ 1066 name: filepath.Base(tt.file), 1067 content: content, 1068 modtime: tt.modtime, 1069 etag: tt.serveETag, 1070 contentType: tt.serveContentType, 1071 } 1072 req, err := NewRequest(method, ts.URL, nil) 1073 if err != nil { 1074 t.Fatal(err) 1075 } 1076 for k, v := range tt.reqHeader { 1077 req.Header.Set(k, v) 1078 } 1079 1080 c := ts.Client() 1081 res, err := c.Do(req) 1082 if err != nil { 1083 t.Fatal(err) 1084 } 1085 io.Copy(io.Discard, res.Body) 1086 res.Body.Close() 1087 if res.StatusCode != tt.wantStatus { 1088 t.Errorf("test %q using %q: got status = %d; want %d", testName, method, res.StatusCode, tt.wantStatus) 1089 } 1090 if g, e := res.Header.Get("Content-Type"), tt.wantContentType; g != e { 1091 t.Errorf("test %q using %q: got content-type = %q, want %q", testName, method, g, e) 1092 } 1093 if g, e := res.Header.Get("Content-Range"), tt.wantContentRange; g != e { 1094 t.Errorf("test %q using %q: got content-range = %q, want %q", testName, method, g, e) 1095 } 1096 if g, e := res.Header.Get("Last-Modified"), tt.wantLastMod; g != e { 1097 t.Errorf("test %q using %q: got last-modified = %q, want %q", testName, method, g, e) 1098 } 1099 } 1100 } 1101 } 1102 1103 // Issue 12991 1104 func TestServerFileStatError(t *testing.T) { 1105 rec := httptest.NewRecorder() 1106 r, _ := NewRequest("GET", "http://foo/", nil) 1107 redirect := false 1108 name := "file.txt" 1109 fs := issue12991FS{} 1110 ExportServeFile(rec, r, fs, name, redirect) 1111 if body := rec.Body.String(); !strings.Contains(body, "403") || !strings.Contains(body, "Forbidden") { 1112 t.Errorf("wanted 403 forbidden message; got: %s", body) 1113 } 1114 } 1115 1116 type issue12991FS struct{} 1117 1118 func (issue12991FS) Open(string) (File, error) { return issue12991File{}, nil } 1119 1120 type issue12991File struct{ File } 1121 1122 func (issue12991File) Stat() (fs.FileInfo, error) { return nil, fs.ErrPermission } 1123 func (issue12991File) Close() error { return nil } 1124 1125 func TestServeContentErrorMessages(t *testing.T) { 1126 defer afterTest(t) 1127 fs := fakeFS{ 1128 "/500": &fakeFileInfo{ 1129 err: errors.New("random error"), 1130 }, 1131 "/403": &fakeFileInfo{ 1132 err: &fs.PathError{Err: fs.ErrPermission}, 1133 }, 1134 } 1135 ts := httptest.NewServer(FileServer(fs)) 1136 defer ts.Close() 1137 c := ts.Client() 1138 for _, code := range []int{403, 404, 500} { 1139 res, err := c.Get(fmt.Sprintf("%s/%d", ts.URL, code)) 1140 if err != nil { 1141 t.Errorf("Error fetching /%d: %v", code, err) 1142 continue 1143 } 1144 if res.StatusCode != code { 1145 t.Errorf("For /%d, status code = %d; want %d", code, res.StatusCode, code) 1146 } 1147 res.Body.Close() 1148 } 1149 } 1150 1151 // verifies that sendfile is being used on Linux 1152 func TestLinuxSendfile(t *testing.T) { 1153 setParallel(t) 1154 defer afterTest(t) 1155 if runtime.GOOS != "linux" { 1156 t.Skip("skipping; linux-only test") 1157 } 1158 if _, err := exec.LookPath("strace"); err != nil { 1159 t.Skip("skipping; strace not found in path") 1160 } 1161 1162 ln, err := net.Listen("tcp", "127.0.0.1:0") 1163 if err != nil { 1164 t.Fatal(err) 1165 } 1166 lnf, err := ln.(*net.TCPListener).File() 1167 if err != nil { 1168 t.Fatal(err) 1169 } 1170 defer ln.Close() 1171 1172 // Attempt to run strace, and skip on failure - this test requires SYS_PTRACE. 1173 if err := exec.Command("strace", "-f", "-q", os.Args[0], "-test.run=^$").Run(); err != nil { 1174 t.Skipf("skipping; failed to run strace: %v", err) 1175 } 1176 1177 filename := fmt.Sprintf("1kb-%d", os.Getpid()) 1178 filepath := path.Join(os.TempDir(), filename) 1179 1180 if err := os.WriteFile(filepath, bytes.Repeat([]byte{'a'}, 1<<10), 0755); err != nil { 1181 t.Fatal(err) 1182 } 1183 defer os.Remove(filepath) 1184 1185 var buf bytes.Buffer 1186 child := exec.Command("strace", "-f", "-q", os.Args[0], "-test.run=TestLinuxSendfileChild") 1187 child.ExtraFiles = append(child.ExtraFiles, lnf) 1188 child.Env = append([]string{"GO_WANT_HELPER_PROCESS=1"}, os.Environ()...) 1189 child.Stdout = &buf 1190 child.Stderr = &buf 1191 if err := child.Start(); err != nil { 1192 t.Skipf("skipping; failed to start straced child: %v", err) 1193 } 1194 1195 res, err := Get(fmt.Sprintf("http://%s/%s", ln.Addr(), filename)) 1196 if err != nil { 1197 t.Fatalf("http client error: %v", err) 1198 } 1199 _, err = io.Copy(io.Discard, res.Body) 1200 if err != nil { 1201 t.Fatalf("client body read error: %v", err) 1202 } 1203 res.Body.Close() 1204 1205 // Force child to exit cleanly. 1206 Post(fmt.Sprintf("http://%s/quit", ln.Addr()), "", nil) 1207 child.Wait() 1208 1209 rx := regexp.MustCompile(`\b(n64:)?sendfile(64)?\(`) 1210 out := buf.String() 1211 if !rx.MatchString(out) { 1212 t.Errorf("no sendfile system call found in:\n%s", out) 1213 } 1214 } 1215 1216 func getBody(t *testing.T, testName string, req Request, client *Client) (*Response, []byte) { 1217 r, err := client.Do(&req) 1218 if err != nil { 1219 t.Fatalf("%s: for URL %q, send error: %v", testName, req.URL.String(), err) 1220 } 1221 b, err := io.ReadAll(r.Body) 1222 if err != nil { 1223 t.Fatalf("%s: for URL %q, reading body: %v", testName, req.URL.String(), err) 1224 } 1225 return r, b 1226 } 1227 1228 // TestLinuxSendfileChild isn't a real test. It's used as a helper process 1229 // for TestLinuxSendfile. 1230 func TestLinuxSendfileChild(*testing.T) { 1231 if os.Getenv("GO_WANT_HELPER_PROCESS") != "1" { 1232 return 1233 } 1234 defer os.Exit(0) 1235 fd3 := os.NewFile(3, "ephemeral-port-listener") 1236 ln, err := net.FileListener(fd3) 1237 if err != nil { 1238 panic(err) 1239 } 1240 mux := NewServeMux() 1241 mux.Handle("/", FileServer(Dir(os.TempDir()))) 1242 mux.HandleFunc("/quit", func(ResponseWriter, *Request) { 1243 os.Exit(0) 1244 }) 1245 s := &Server{Handler: mux} 1246 err = s.Serve(ln) 1247 if err != nil { 1248 panic(err) 1249 } 1250 } 1251 1252 // Issue 18984: tests that requests for paths beyond files return not-found errors 1253 func TestFileServerNotDirError(t *testing.T) { 1254 defer afterTest(t) 1255 ts := httptest.NewServer(FileServer(Dir("testdata"))) 1256 defer ts.Close() 1257 1258 res, err := Get(ts.URL + "/index.html/not-a-file") 1259 if err != nil { 1260 t.Fatal(err) 1261 } 1262 res.Body.Close() 1263 if res.StatusCode != 404 { 1264 t.Errorf("StatusCode = %v; want 404", res.StatusCode) 1265 } 1266 1267 test := func(name string, dir Dir) { 1268 t.Run(name, func(t *testing.T) { 1269 _, err = dir.Open("/index.html/not-a-file") 1270 if err == nil { 1271 t.Fatal("err == nil; want != nil") 1272 } 1273 if !os.IsNotExist(err) { 1274 t.Errorf("err = %v; os.IsNotExist(err) = %v; want true", err, os.IsNotExist(err)) 1275 } 1276 1277 _, err = dir.Open("/index.html/not-a-dir/not-a-file") 1278 if err == nil { 1279 t.Fatal("err == nil; want != nil") 1280 } 1281 if !os.IsNotExist(err) { 1282 t.Errorf("err = %v; os.IsNotExist(err) = %v; want true", err, os.IsNotExist(err)) 1283 } 1284 }) 1285 } 1286 1287 absPath, err := filepath.Abs("testdata") 1288 if err != nil { 1289 t.Fatal("get abs path:", err) 1290 } 1291 1292 test("RelativePath", Dir("testdata")) 1293 test("AbsolutePath", Dir(absPath)) 1294 } 1295 1296 func TestFileServerCleanPath(t *testing.T) { 1297 tests := []struct { 1298 path string 1299 wantCode int 1300 wantOpen []string 1301 }{ 1302 {"/", 200, []string{"/", "/index.html"}}, 1303 {"/dir", 301, []string{"/dir"}}, 1304 {"/dir/", 200, []string{"/dir", "/dir/index.html"}}, 1305 } 1306 for _, tt := range tests { 1307 var log []string 1308 rr := httptest.NewRecorder() 1309 req, _ := NewRequest("GET", "http://foo.localhost"+tt.path, nil) 1310 FileServer(fileServerCleanPathDir{&log}).ServeHTTP(rr, req) 1311 if !reflect.DeepEqual(log, tt.wantOpen) { 1312 t.Logf("For %s: Opens = %q; want %q", tt.path, log, tt.wantOpen) 1313 } 1314 if rr.Code != tt.wantCode { 1315 t.Logf("For %s: Response code = %d; want %d", tt.path, rr.Code, tt.wantCode) 1316 } 1317 } 1318 } 1319 1320 type fileServerCleanPathDir struct { 1321 log *[]string 1322 } 1323 1324 func (d fileServerCleanPathDir) Open(path string) (File, error) { 1325 *(d.log) = append(*(d.log), path) 1326 if path == "/" || path == "/dir" || path == "/dir/" { 1327 // Just return back something that's a directory. 1328 return Dir(".").Open(".") 1329 } 1330 return nil, fs.ErrNotExist 1331 } 1332 1333 type panicOnSeek struct{ io.ReadSeeker } 1334 1335 func Test_scanETag(t *testing.T) { 1336 tests := []struct { 1337 in string 1338 wantETag string 1339 wantRemain string 1340 }{ 1341 {`W/"etag-1"`, `W/"etag-1"`, ""}, 1342 {`"etag-2"`, `"etag-2"`, ""}, 1343 {`"etag-1", "etag-2"`, `"etag-1"`, `, "etag-2"`}, 1344 {"", "", ""}, 1345 {"W/", "", ""}, 1346 {`W/"truc`, "", ""}, 1347 {`w/"case-sensitive"`, "", ""}, 1348 {`"spaced etag"`, "", ""}, 1349 } 1350 for _, test := range tests { 1351 etag, remain := ExportScanETag(test.in) 1352 if etag != test.wantETag || remain != test.wantRemain { 1353 t.Errorf("scanETag(%q)=%q %q, want %q %q", test.in, etag, remain, test.wantETag, test.wantRemain) 1354 } 1355 } 1356 } 1357 1358 // Issue 40940: Ensure that we only accept non-negative suffix-lengths 1359 // in "Range": "bytes=-N", and should reject "bytes=--2". 1360 func TestServeFileRejectsInvalidSuffixLengths_h1(t *testing.T) { 1361 testServeFileRejectsInvalidSuffixLengths(t, h1Mode) 1362 } 1363 func TestServeFileRejectsInvalidSuffixLengths_h2(t *testing.T) { 1364 testServeFileRejectsInvalidSuffixLengths(t, h2Mode) 1365 } 1366 1367 func testServeFileRejectsInvalidSuffixLengths(t *testing.T, h2 bool) { 1368 defer afterTest(t) 1369 cst := httptest.NewUnstartedServer(FileServer(Dir("testdata"))) 1370 cst.EnableHTTP2 = h2 1371 cst.StartTLS() 1372 defer cst.Close() 1373 1374 tests := []struct { 1375 r string 1376 wantCode int 1377 wantBody string 1378 }{ 1379 {"bytes=--6", 416, "invalid range\n"}, 1380 {"bytes=--0", 416, "invalid range\n"}, 1381 {"bytes=---0", 416, "invalid range\n"}, 1382 {"bytes=-6", 206, "hello\n"}, 1383 {"bytes=6-", 206, "html says hello\n"}, 1384 {"bytes=-6-", 416, "invalid range\n"}, 1385 {"bytes=-0", 206, ""}, 1386 {"bytes=", 200, "index.html says hello\n"}, 1387 } 1388 1389 for _, tt := range tests { 1390 tt := tt 1391 t.Run(tt.r, func(t *testing.T) { 1392 req, err := NewRequest("GET", cst.URL+"/index.html", nil) 1393 if err != nil { 1394 t.Fatal(err) 1395 } 1396 req.Header.Set("Range", tt.r) 1397 res, err := cst.Client().Do(req) 1398 if err != nil { 1399 t.Fatal(err) 1400 } 1401 if g, w := res.StatusCode, tt.wantCode; g != w { 1402 t.Errorf("StatusCode mismatch: got %d want %d", g, w) 1403 } 1404 slurp, err := io.ReadAll(res.Body) 1405 res.Body.Close() 1406 if err != nil { 1407 t.Fatal(err) 1408 } 1409 if g, w := string(slurp), tt.wantBody; g != w { 1410 t.Fatalf("Content mismatch:\nGot: %q\nWant: %q", g, w) 1411 } 1412 }) 1413 } 1414 }