github.com/google/go-github/v49@v49.1.0/github/github_test.go (about) 1 // Copyright 2013 The go-github AUTHORS. All rights reserved. 2 // 3 // Use of this source code is governed by a BSD-style 4 // license that can be found in the LICENSE file. 5 6 package github 7 8 import ( 9 "context" 10 "encoding/json" 11 "errors" 12 "fmt" 13 "io" 14 "net/http" 15 "net/http/httptest" 16 "net/url" 17 "os" 18 "path" 19 "reflect" 20 "strings" 21 "testing" 22 "time" 23 24 "github.com/google/go-cmp/cmp" 25 ) 26 27 const ( 28 // baseURLPath is a non-empty Client.BaseURL path to use during tests, 29 // to ensure relative URLs are used for all endpoints. See issue #752. 30 baseURLPath = "/api-v3" 31 ) 32 33 // setup sets up a test HTTP server along with a github.Client that is 34 // configured to talk to that test server. Tests should register handlers on 35 // mux which provide mock responses for the API method being tested. 36 func setup() (client *Client, mux *http.ServeMux, serverURL string, teardown func()) { 37 // mux is the HTTP request multiplexer used with the test server. 38 mux = http.NewServeMux() 39 40 // We want to ensure that tests catch mistakes where the endpoint URL is 41 // specified as absolute rather than relative. It only makes a difference 42 // when there's a non-empty base URL path. So, use that. See issue #752. 43 apiHandler := http.NewServeMux() 44 apiHandler.Handle(baseURLPath+"/", http.StripPrefix(baseURLPath, mux)) 45 apiHandler.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) { 46 fmt.Fprintln(os.Stderr, "FAIL: Client.BaseURL path prefix is not preserved in the request URL:") 47 fmt.Fprintln(os.Stderr) 48 fmt.Fprintln(os.Stderr, "\t"+req.URL.String()) 49 fmt.Fprintln(os.Stderr) 50 fmt.Fprintln(os.Stderr, "\tDid you accidentally use an absolute endpoint URL rather than relative?") 51 fmt.Fprintln(os.Stderr, "\tSee https://github.com/google/go-github/issues/752 for information.") 52 http.Error(w, "Client.BaseURL path prefix is not preserved in the request URL.", http.StatusInternalServerError) 53 }) 54 55 // server is a test HTTP server used to provide mock API responses. 56 server := httptest.NewServer(apiHandler) 57 58 // client is the GitHub client being tested and is 59 // configured to use test server. 60 client = NewClient(nil) 61 url, _ := url.Parse(server.URL + baseURLPath + "/") 62 client.BaseURL = url 63 client.UploadURL = url 64 65 return client, mux, server.URL, server.Close 66 } 67 68 // openTestFile creates a new file with the given name and content for testing. 69 // In order to ensure the exact file name, this function will create a new temp 70 // directory, and create the file in that directory. It is the caller's 71 // responsibility to remove the directory and its contents when no longer needed. 72 func openTestFile(name, content string) (file *os.File, dir string, err error) { 73 dir, err = os.MkdirTemp("", "go-github") 74 if err != nil { 75 return nil, dir, err 76 } 77 78 file, err = os.OpenFile(path.Join(dir, name), os.O_RDWR|os.O_CREATE|os.O_EXCL, 0600) 79 if err != nil { 80 return nil, dir, err 81 } 82 83 fmt.Fprint(file, content) 84 85 // close and re-open the file to keep file.Stat() happy 86 file.Close() 87 file, err = os.Open(file.Name()) 88 if err != nil { 89 return nil, dir, err 90 } 91 92 return file, dir, err 93 } 94 95 func testMethod(t *testing.T, r *http.Request, want string) { 96 t.Helper() 97 if got := r.Method; got != want { 98 t.Errorf("Request method: %v, want %v", got, want) 99 } 100 } 101 102 type values map[string]string 103 104 func testFormValues(t *testing.T, r *http.Request, values values) { 105 t.Helper() 106 want := url.Values{} 107 for k, v := range values { 108 want.Set(k, v) 109 } 110 111 r.ParseForm() 112 if got := r.Form; !cmp.Equal(got, want) { 113 t.Errorf("Request parameters: %v, want %v", got, want) 114 } 115 } 116 117 func testHeader(t *testing.T, r *http.Request, header string, want string) { 118 t.Helper() 119 if got := r.Header.Get(header); got != want { 120 t.Errorf("Header.Get(%q) returned %q, want %q", header, got, want) 121 } 122 } 123 124 func testURLParseError(t *testing.T, err error) { 125 t.Helper() 126 if err == nil { 127 t.Errorf("Expected error to be returned") 128 } 129 if err, ok := err.(*url.Error); !ok || err.Op != "parse" { 130 t.Errorf("Expected URL parse error, got %+v", err) 131 } 132 } 133 134 func testBody(t *testing.T, r *http.Request, want string) { 135 t.Helper() 136 b, err := io.ReadAll(r.Body) 137 if err != nil { 138 t.Errorf("Error reading request body: %v", err) 139 } 140 if got := string(b); got != want { 141 t.Errorf("request Body is %s, want %s", got, want) 142 } 143 } 144 145 // Test whether the marshaling of v produces JSON that corresponds 146 // to the want string. 147 func testJSONMarshal(t *testing.T, v interface{}, want string) { 148 t.Helper() 149 // Unmarshal the wanted JSON, to verify its correctness, and marshal it back 150 // to sort the keys. 151 u := reflect.New(reflect.TypeOf(v)).Interface() 152 if err := json.Unmarshal([]byte(want), &u); err != nil { 153 t.Errorf("Unable to unmarshal JSON for %v: %v", want, err) 154 } 155 w, err := json.Marshal(u) 156 if err != nil { 157 t.Errorf("Unable to marshal JSON for %#v", u) 158 } 159 160 // Marshal the target value. 161 j, err := json.Marshal(v) 162 if err != nil { 163 t.Errorf("Unable to marshal JSON for %#v", v) 164 } 165 166 if string(w) != string(j) { 167 t.Errorf("json.Marshal(%q) returned %s, want %s", v, j, w) 168 } 169 } 170 171 // Test how bad options are handled. Method f under test should 172 // return an error. 173 func testBadOptions(t *testing.T, methodName string, f func() error) { 174 t.Helper() 175 if methodName == "" { 176 t.Error("testBadOptions: must supply method methodName") 177 } 178 if err := f(); err == nil { 179 t.Errorf("bad options %v err = nil, want error", methodName) 180 } 181 } 182 183 // Test function under NewRequest failure and then s.client.Do failure. 184 // Method f should be a regular call that would normally succeed, but 185 // should return an error when NewRequest or s.client.Do fails. 186 func testNewRequestAndDoFailure(t *testing.T, methodName string, client *Client, f func() (*Response, error)) { 187 t.Helper() 188 if methodName == "" { 189 t.Error("testNewRequestAndDoFailure: must supply method methodName") 190 } 191 192 client.BaseURL.Path = "" 193 resp, err := f() 194 if resp != nil { 195 t.Errorf("client.BaseURL.Path='' %v resp = %#v, want nil", methodName, resp) 196 } 197 if err == nil { 198 t.Errorf("client.BaseURL.Path='' %v err = nil, want error", methodName) 199 } 200 201 client.BaseURL.Path = "/api-v3/" 202 client.rateLimits[0].Reset.Time = time.Now().Add(10 * time.Minute) 203 resp, err = f() 204 if bypass := resp.Request.Context().Value(bypassRateLimitCheck); bypass != nil { 205 return 206 } 207 if want := http.StatusForbidden; resp == nil || resp.Response.StatusCode != want { 208 if resp != nil { 209 t.Errorf("rate.Reset.Time > now %v resp = %#v, want StatusCode=%v", methodName, resp.Response, want) 210 } else { 211 t.Errorf("rate.Reset.Time > now %v resp = nil, want StatusCode=%v", methodName, want) 212 } 213 } 214 if err == nil { 215 t.Errorf("rate.Reset.Time > now %v err = nil, want error", methodName) 216 } 217 } 218 219 // Test that all error response types contain the status code. 220 func testErrorResponseForStatusCode(t *testing.T, code int) { 221 t.Helper() 222 client, mux, _, teardown := setup() 223 defer teardown() 224 225 mux.HandleFunc("/repos/o/r/hooks", func(w http.ResponseWriter, r *http.Request) { 226 testMethod(t, r, "GET") 227 w.WriteHeader(code) 228 }) 229 230 ctx := context.Background() 231 _, _, err := client.Repositories.ListHooks(ctx, "o", "r", nil) 232 233 switch e := err.(type) { 234 case *ErrorResponse: 235 case *RateLimitError: 236 case *AbuseRateLimitError: 237 if code != e.Response.StatusCode { 238 t.Error("Error response does not contain status code") 239 } 240 default: 241 t.Error("Unknown error response type") 242 } 243 } 244 245 func TestNewClient(t *testing.T) { 246 c := NewClient(nil) 247 248 if got, want := c.BaseURL.String(), defaultBaseURL; got != want { 249 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 250 } 251 if got, want := c.UserAgent, defaultUserAgent; got != want { 252 t.Errorf("NewClient UserAgent is %v, want %v", got, want) 253 } 254 255 c2 := NewClient(nil) 256 if c.client == c2.client { 257 t.Error("NewClient returned same http.Clients, but they should differ") 258 } 259 } 260 261 func TestClient(t *testing.T) { 262 c := NewClient(nil) 263 c2 := c.Client() 264 if c.client == c2 { 265 t.Error("Client returned same http.Client, but should be different") 266 } 267 } 268 269 func TestNewEnterpriseClient(t *testing.T) { 270 baseURL := "https://custom-url/api/v3/" 271 uploadURL := "https://custom-upload-url/api/uploads/" 272 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 273 if err != nil { 274 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 275 } 276 277 if got, want := c.BaseURL.String(), baseURL; got != want { 278 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 279 } 280 if got, want := c.UploadURL.String(), uploadURL; got != want { 281 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 282 } 283 } 284 285 func TestNewEnterpriseClient_addsTrailingSlashToURLs(t *testing.T) { 286 baseURL := "https://custom-url/api/v3" 287 uploadURL := "https://custom-upload-url/api/uploads" 288 formattedBaseURL := baseURL + "/" 289 formattedUploadURL := uploadURL + "/" 290 291 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 292 if err != nil { 293 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 294 } 295 296 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 297 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 298 } 299 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 300 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 301 } 302 } 303 304 func TestNewEnterpriseClient_addsEnterpriseSuffixToURLs(t *testing.T) { 305 baseURL := "https://custom-url/" 306 uploadURL := "https://custom-upload-url/" 307 formattedBaseURL := baseURL + "api/v3/" 308 formattedUploadURL := uploadURL + "api/uploads/" 309 310 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 311 if err != nil { 312 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 313 } 314 315 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 316 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 317 } 318 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 319 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 320 } 321 } 322 323 func TestNewEnterpriseClient_addsEnterpriseSuffixAndTrailingSlashToURLs(t *testing.T) { 324 baseURL := "https://custom-url" 325 uploadURL := "https://custom-upload-url" 326 formattedBaseURL := baseURL + "/api/v3/" 327 formattedUploadURL := uploadURL + "/api/uploads/" 328 329 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 330 if err != nil { 331 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 332 } 333 334 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 335 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 336 } 337 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 338 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 339 } 340 } 341 342 func TestNewEnterpriseClient_badBaseURL(t *testing.T) { 343 baseURL := "bogus\nbase\nURL" 344 uploadURL := "https://custom-upload-url/api/uploads/" 345 if _, err := NewEnterpriseClient(baseURL, uploadURL, nil); err == nil { 346 t.Fatal("NewEnterpriseClient returned nil, expected error") 347 } 348 } 349 350 func TestNewEnterpriseClient_badUploadURL(t *testing.T) { 351 baseURL := "https://custom-url/api/v3/" 352 uploadURL := "bogus\nupload\nURL" 353 if _, err := NewEnterpriseClient(baseURL, uploadURL, nil); err == nil { 354 t.Fatal("NewEnterpriseClient returned nil, expected error") 355 } 356 } 357 358 func TestNewEnterpriseClient_URLHasExistingAPIPrefix_AddTrailingSlash(t *testing.T) { 359 baseURL := "https://api.custom-url" 360 uploadURL := "https://api.custom-upload-url" 361 formattedBaseURL := baseURL + "/" 362 formattedUploadURL := uploadURL + "/" 363 364 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 365 if err != nil { 366 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 367 } 368 369 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 370 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 371 } 372 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 373 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 374 } 375 } 376 377 func TestNewEnterpriseClient_URLHasExistingAPIPrefixAndTrailingSlash(t *testing.T) { 378 baseURL := "https://api.custom-url/" 379 uploadURL := "https://api.custom-upload-url/" 380 381 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 382 if err != nil { 383 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 384 } 385 386 if got, want := c.BaseURL.String(), baseURL; got != want { 387 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 388 } 389 if got, want := c.UploadURL.String(), uploadURL; got != want { 390 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 391 } 392 } 393 394 func TestNewEnterpriseClient_URLHasAPISubdomain_AddTrailingSlash(t *testing.T) { 395 baseURL := "https://catalog.api.custom-url" 396 uploadURL := "https://catalog.api.custom-upload-url" 397 formattedBaseURL := baseURL + "/" 398 formattedUploadURL := uploadURL + "/" 399 400 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 401 if err != nil { 402 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 403 } 404 405 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 406 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 407 } 408 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 409 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 410 } 411 } 412 413 func TestNewEnterpriseClient_URLHasAPISubdomainAndTrailingSlash(t *testing.T) { 414 baseURL := "https://catalog.api.custom-url/" 415 uploadURL := "https://catalog.api.custom-upload-url/" 416 417 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 418 if err != nil { 419 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 420 } 421 422 if got, want := c.BaseURL.String(), baseURL; got != want { 423 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 424 } 425 if got, want := c.UploadURL.String(), uploadURL; got != want { 426 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 427 } 428 } 429 430 func TestNewEnterpriseClient_URLIsNotAProperAPISubdomain_addsEnterpriseSuffixAndSlash(t *testing.T) { 431 baseURL := "https://cloud-api.custom-url" 432 uploadURL := "https://cloud-api.custom-upload-url" 433 formattedBaseURL := baseURL + "/api/v3/" 434 formattedUploadURL := uploadURL + "/api/uploads/" 435 436 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 437 if err != nil { 438 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 439 } 440 441 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 442 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 443 } 444 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 445 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 446 } 447 } 448 449 func TestNewEnterpriseClient_URLIsNotAProperAPISubdomain_addsEnterpriseSuffix(t *testing.T) { 450 baseURL := "https://cloud-api.custom-url/" 451 uploadURL := "https://cloud-api.custom-upload-url/" 452 formattedBaseURL := baseURL + "api/v3/" 453 formattedUploadURL := uploadURL + "api/uploads/" 454 455 c, err := NewEnterpriseClient(baseURL, uploadURL, nil) 456 if err != nil { 457 t.Fatalf("NewEnterpriseClient returned unexpected error: %v", err) 458 } 459 460 if got, want := c.BaseURL.String(), formattedBaseURL; got != want { 461 t.Errorf("NewClient BaseURL is %v, want %v", got, want) 462 } 463 if got, want := c.UploadURL.String(), formattedUploadURL; got != want { 464 t.Errorf("NewClient UploadURL is %v, want %v", got, want) 465 } 466 } 467 468 // Ensure that length of Client.rateLimits is the same as number of fields in RateLimits struct. 469 func TestClient_rateLimits(t *testing.T) { 470 if got, want := len(Client{}.rateLimits), reflect.TypeOf(RateLimits{}).NumField(); got != want { 471 t.Errorf("len(Client{}.rateLimits) is %v, want %v", got, want) 472 } 473 } 474 475 func TestRateLimits_String(t *testing.T) { 476 v := RateLimits{ 477 Core: &Rate{}, 478 Search: &Rate{}, 479 GraphQL: &Rate{}, 480 IntegrationManifest: &Rate{}, 481 SourceImport: &Rate{}, 482 CodeScanningUpload: &Rate{}, 483 ActionsRunnerRegistration: &Rate{}, 484 SCIM: &Rate{}, 485 } 486 want := `github.RateLimits{Core:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, Search:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, GraphQL:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, IntegrationManifest:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, SourceImport:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, CodeScanningUpload:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, ActionsRunnerRegistration:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}, SCIM:github.Rate{Limit:0, Remaining:0, Reset:github.Timestamp{0001-01-01 00:00:00 +0000 UTC}}}` 487 if got := v.String(); got != want { 488 t.Errorf("RateLimits.String = %v, want %v", got, want) 489 } 490 } 491 492 func TestNewRequest(t *testing.T) { 493 c := NewClient(nil) 494 495 inURL, outURL := "/foo", defaultBaseURL+"foo" 496 inBody, outBody := &User{Login: String("l")}, `{"login":"l"}`+"\n" 497 req, _ := c.NewRequest("GET", inURL, inBody) 498 499 // test that relative URL was expanded 500 if got, want := req.URL.String(), outURL; got != want { 501 t.Errorf("NewRequest(%q) URL is %v, want %v", inURL, got, want) 502 } 503 504 // test that body was JSON encoded 505 body, _ := io.ReadAll(req.Body) 506 if got, want := string(body), outBody; got != want { 507 t.Errorf("NewRequest(%q) Body is %v, want %v", inBody, got, want) 508 } 509 510 userAgent := req.Header.Get("User-Agent") 511 512 // test that default user-agent is attached to the request 513 if got, want := userAgent, c.UserAgent; got != want { 514 t.Errorf("NewRequest() User-Agent is %v, want %v", got, want) 515 } 516 517 if !strings.Contains(userAgent, Version) { 518 t.Errorf("NewRequest() User-Agent should contain %v, found %v", Version, userAgent) 519 } 520 521 apiVersion := req.Header.Get(headerAPIVersion) 522 if got, want := apiVersion, defaultAPIVersion; got != want { 523 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 524 } 525 526 req, _ = c.NewRequest("GET", inURL, inBody, WithVersion("2022-11-29")) 527 apiVersion = req.Header.Get(headerAPIVersion) 528 if got, want := apiVersion, "2022-11-29"; got != want { 529 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 530 } 531 } 532 533 func TestNewRequest_invalidJSON(t *testing.T) { 534 c := NewClient(nil) 535 536 type T struct { 537 A map[interface{}]interface{} 538 } 539 _, err := c.NewRequest("GET", ".", &T{}) 540 541 if err == nil { 542 t.Error("Expected error to be returned.") 543 } 544 if err, ok := err.(*json.UnsupportedTypeError); !ok { 545 t.Errorf("Expected a JSON error; got %#v.", err) 546 } 547 } 548 549 func TestNewRequest_badURL(t *testing.T) { 550 c := NewClient(nil) 551 _, err := c.NewRequest("GET", ":", nil) 552 testURLParseError(t, err) 553 } 554 555 func TestNewRequest_badMethod(t *testing.T) { 556 c := NewClient(nil) 557 if _, err := c.NewRequest("BOGUS\nMETHOD", ".", nil); err == nil { 558 t.Fatal("NewRequest returned nil; expected error") 559 } 560 } 561 562 // ensure that no User-Agent header is set if the client's UserAgent is empty. 563 // This caused a problem with Google's internal http client. 564 func TestNewRequest_emptyUserAgent(t *testing.T) { 565 c := NewClient(nil) 566 c.UserAgent = "" 567 req, err := c.NewRequest("GET", ".", nil) 568 if err != nil { 569 t.Fatalf("NewRequest returned unexpected error: %v", err) 570 } 571 if _, ok := req.Header["User-Agent"]; ok { 572 t.Fatal("constructed request contains unexpected User-Agent header") 573 } 574 } 575 576 // If a nil body is passed to github.NewRequest, make sure that nil is also 577 // passed to http.NewRequest. In most cases, passing an io.Reader that returns 578 // no content is fine, since there is no difference between an HTTP request 579 // body that is an empty string versus one that is not set at all. However in 580 // certain cases, intermediate systems may treat these differently resulting in 581 // subtle errors. 582 func TestNewRequest_emptyBody(t *testing.T) { 583 c := NewClient(nil) 584 req, err := c.NewRequest("GET", ".", nil) 585 if err != nil { 586 t.Fatalf("NewRequest returned unexpected error: %v", err) 587 } 588 if req.Body != nil { 589 t.Fatalf("constructed request contains a non-nil Body") 590 } 591 } 592 593 func TestNewRequest_errorForNoTrailingSlash(t *testing.T) { 594 tests := []struct { 595 rawurl string 596 wantError bool 597 }{ 598 {rawurl: "https://example.com/api/v3", wantError: true}, 599 {rawurl: "https://example.com/api/v3/", wantError: false}, 600 } 601 c := NewClient(nil) 602 for _, test := range tests { 603 u, err := url.Parse(test.rawurl) 604 if err != nil { 605 t.Fatalf("url.Parse returned unexpected error: %v.", err) 606 } 607 c.BaseURL = u 608 if _, err := c.NewRequest(http.MethodGet, "test", nil); test.wantError && err == nil { 609 t.Fatalf("Expected error to be returned.") 610 } else if !test.wantError && err != nil { 611 t.Fatalf("NewRequest returned unexpected error: %v.", err) 612 } 613 } 614 } 615 616 func TestNewFormRequest(t *testing.T) { 617 c := NewClient(nil) 618 619 inURL, outURL := "/foo", defaultBaseURL+"foo" 620 form := url.Values{} 621 form.Add("login", "l") 622 inBody, outBody := strings.NewReader(form.Encode()), "login=l" 623 req, _ := c.NewFormRequest(inURL, inBody) 624 625 // test that relative URL was expanded 626 if got, want := req.URL.String(), outURL; got != want { 627 t.Errorf("NewFormRequest(%q) URL is %v, want %v", inURL, got, want) 628 } 629 630 // test that body was form encoded 631 body, _ := io.ReadAll(req.Body) 632 if got, want := string(body), outBody; got != want { 633 t.Errorf("NewFormRequest(%q) Body is %v, want %v", inBody, got, want) 634 } 635 636 // test that default user-agent is attached to the request 637 if got, want := req.Header.Get("User-Agent"), c.UserAgent; got != want { 638 t.Errorf("NewFormRequest() User-Agent is %v, want %v", got, want) 639 } 640 641 apiVersion := req.Header.Get(headerAPIVersion) 642 if got, want := apiVersion, defaultAPIVersion; got != want { 643 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 644 } 645 646 req, _ = c.NewFormRequest(inURL, inBody, WithVersion("2022-11-29")) 647 apiVersion = req.Header.Get(headerAPIVersion) 648 if got, want := apiVersion, "2022-11-29"; got != want { 649 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 650 } 651 } 652 653 func TestNewFormRequest_badURL(t *testing.T) { 654 c := NewClient(nil) 655 _, err := c.NewFormRequest(":", nil) 656 testURLParseError(t, err) 657 } 658 659 func TestNewFormRequest_emptyUserAgent(t *testing.T) { 660 c := NewClient(nil) 661 c.UserAgent = "" 662 req, err := c.NewFormRequest(".", nil) 663 if err != nil { 664 t.Fatalf("NewFormRequest returned unexpected error: %v", err) 665 } 666 if _, ok := req.Header["User-Agent"]; ok { 667 t.Fatal("constructed request contains unexpected User-Agent header") 668 } 669 } 670 671 func TestNewFormRequest_emptyBody(t *testing.T) { 672 c := NewClient(nil) 673 req, err := c.NewFormRequest(".", nil) 674 if err != nil { 675 t.Fatalf("NewFormRequest returned unexpected error: %v", err) 676 } 677 if req.Body != nil { 678 t.Fatalf("constructed request contains a non-nil Body") 679 } 680 } 681 682 func TestNewFormRequest_errorForNoTrailingSlash(t *testing.T) { 683 tests := []struct { 684 rawURL string 685 wantError bool 686 }{ 687 {rawURL: "https://example.com/api/v3", wantError: true}, 688 {rawURL: "https://example.com/api/v3/", wantError: false}, 689 } 690 c := NewClient(nil) 691 for _, test := range tests { 692 u, err := url.Parse(test.rawURL) 693 if err != nil { 694 t.Fatalf("url.Parse returned unexpected error: %v.", err) 695 } 696 c.BaseURL = u 697 if _, err := c.NewFormRequest("test", nil); test.wantError && err == nil { 698 t.Fatalf("Expected error to be returned.") 699 } else if !test.wantError && err != nil { 700 t.Fatalf("NewFormRequest returned unexpected error: %v.", err) 701 } 702 } 703 } 704 705 func TestNewUploadRequest_WithVersion(t *testing.T) { 706 c := NewClient(nil) 707 req, _ := c.NewUploadRequest("https://example.com/", nil, 0, "") 708 709 apiVersion := req.Header.Get(headerAPIVersion) 710 if got, want := apiVersion, defaultAPIVersion; got != want { 711 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 712 } 713 714 req, _ = c.NewUploadRequest("https://example.com/", nil, 0, "", WithVersion("2022-11-29")) 715 apiVersion = req.Header.Get(headerAPIVersion) 716 if got, want := apiVersion, "2022-11-29"; got != want { 717 t.Errorf("NewRequest() %v header is %v, want %v", headerAPIVersion, got, want) 718 } 719 } 720 721 func TestNewUploadRequest_badURL(t *testing.T) { 722 c := NewClient(nil) 723 _, err := c.NewUploadRequest(":", nil, 0, "") 724 testURLParseError(t, err) 725 726 const methodName = "NewUploadRequest" 727 testBadOptions(t, methodName, func() (err error) { 728 _, err = c.NewUploadRequest("\n", nil, -1, "\n") 729 return err 730 }) 731 } 732 733 func TestNewUploadRequest_errorForNoTrailingSlash(t *testing.T) { 734 tests := []struct { 735 rawurl string 736 wantError bool 737 }{ 738 {rawurl: "https://example.com/api/uploads", wantError: true}, 739 {rawurl: "https://example.com/api/uploads/", wantError: false}, 740 } 741 c := NewClient(nil) 742 for _, test := range tests { 743 u, err := url.Parse(test.rawurl) 744 if err != nil { 745 t.Fatalf("url.Parse returned unexpected error: %v.", err) 746 } 747 c.UploadURL = u 748 if _, err = c.NewUploadRequest("test", nil, 0, ""); test.wantError && err == nil { 749 t.Fatalf("Expected error to be returned.") 750 } else if !test.wantError && err != nil { 751 t.Fatalf("NewUploadRequest returned unexpected error: %v.", err) 752 } 753 } 754 } 755 756 func TestResponse_populatePageValues(t *testing.T) { 757 r := http.Response{ 758 Header: http.Header{ 759 "Link": {`<https://api.github.com/?page=1>; rel="first",` + 760 ` <https://api.github.com/?page=2>; rel="prev",` + 761 ` <https://api.github.com/?page=4>; rel="next",` + 762 ` <https://api.github.com/?page=5>; rel="last"`, 763 }, 764 }, 765 } 766 767 response := newResponse(&r) 768 if got, want := response.FirstPage, 1; got != want { 769 t.Errorf("response.FirstPage: %v, want %v", got, want) 770 } 771 if got, want := response.PrevPage, 2; want != got { 772 t.Errorf("response.PrevPage: %v, want %v", got, want) 773 } 774 if got, want := response.NextPage, 4; want != got { 775 t.Errorf("response.NextPage: %v, want %v", got, want) 776 } 777 if got, want := response.LastPage, 5; want != got { 778 t.Errorf("response.LastPage: %v, want %v", got, want) 779 } 780 if got, want := response.NextPageToken, ""; want != got { 781 t.Errorf("response.NextPageToken: %v, want %v", got, want) 782 } 783 } 784 785 func TestResponse_populateSinceValues(t *testing.T) { 786 r := http.Response{ 787 Header: http.Header{ 788 "Link": {`<https://api.github.com/?since=1>; rel="first",` + 789 ` <https://api.github.com/?since=2>; rel="prev",` + 790 ` <https://api.github.com/?since=4>; rel="next",` + 791 ` <https://api.github.com/?since=5>; rel="last"`, 792 }, 793 }, 794 } 795 796 response := newResponse(&r) 797 if got, want := response.FirstPage, 1; got != want { 798 t.Errorf("response.FirstPage: %v, want %v", got, want) 799 } 800 if got, want := response.PrevPage, 2; want != got { 801 t.Errorf("response.PrevPage: %v, want %v", got, want) 802 } 803 if got, want := response.NextPage, 4; want != got { 804 t.Errorf("response.NextPage: %v, want %v", got, want) 805 } 806 if got, want := response.LastPage, 5; want != got { 807 t.Errorf("response.LastPage: %v, want %v", got, want) 808 } 809 if got, want := response.NextPageToken, ""; want != got { 810 t.Errorf("response.NextPageToken: %v, want %v", got, want) 811 } 812 } 813 814 func TestResponse_SinceWithPage(t *testing.T) { 815 r := http.Response{ 816 Header: http.Header{ 817 "Link": {`<https://api.github.com/?since=2021-12-04T10%3A43%3A42Z&page=1>; rel="first",` + 818 ` <https://api.github.com/?since=2021-12-04T10%3A43%3A42Z&page=2>; rel="prev",` + 819 ` <https://api.github.com/?since=2021-12-04T10%3A43%3A42Z&page=4>; rel="next",` + 820 ` <https://api.github.com/?since=2021-12-04T10%3A43%3A42Z&page=5>; rel="last"`, 821 }, 822 }, 823 } 824 825 response := newResponse(&r) 826 if got, want := response.FirstPage, 1; got != want { 827 t.Errorf("response.FirstPage: %v, want %v", got, want) 828 } 829 if got, want := response.PrevPage, 2; want != got { 830 t.Errorf("response.PrevPage: %v, want %v", got, want) 831 } 832 if got, want := response.NextPage, 4; want != got { 833 t.Errorf("response.NextPage: %v, want %v", got, want) 834 } 835 if got, want := response.LastPage, 5; want != got { 836 t.Errorf("response.LastPage: %v, want %v", got, want) 837 } 838 if got, want := response.NextPageToken, ""; want != got { 839 t.Errorf("response.NextPageToken: %v, want %v", got, want) 840 } 841 } 842 843 func TestResponse_cursorPagination(t *testing.T) { 844 r := http.Response{ 845 Header: http.Header{ 846 "Status": {"200 OK"}, 847 "Link": {`<https://api.github.com/resource?per_page=2&page=url-encoded-next-page-token>; rel="next"`}, 848 }, 849 } 850 851 response := newResponse(&r) 852 if got, want := response.FirstPage, 0; got != want { 853 t.Errorf("response.FirstPage: %v, want %v", got, want) 854 } 855 if got, want := response.PrevPage, 0; want != got { 856 t.Errorf("response.PrevPage: %v, want %v", got, want) 857 } 858 if got, want := response.NextPage, 0; want != got { 859 t.Errorf("response.NextPage: %v, want %v", got, want) 860 } 861 if got, want := response.LastPage, 0; want != got { 862 t.Errorf("response.LastPage: %v, want %v", got, want) 863 } 864 if got, want := response.NextPageToken, "url-encoded-next-page-token"; want != got { 865 t.Errorf("response.NextPageToken: %v, want %v", got, want) 866 } 867 868 // cursor-based pagination with "cursor" param 869 r = http.Response{ 870 Header: http.Header{ 871 "Link": { 872 `<https://api.github.com/?cursor=v1_12345678>; rel="next"`, 873 }, 874 }, 875 } 876 877 response = newResponse(&r) 878 if got, want := response.Cursor, "v1_12345678"; got != want { 879 t.Errorf("response.Cursor: %v, want %v", got, want) 880 } 881 } 882 883 func TestResponse_beforeAfterPagination(t *testing.T) { 884 r := http.Response{ 885 Header: http.Header{ 886 "Link": {`<https://api.github.com/?after=a1b2c3&before=>; rel="next",` + 887 ` <https://api.github.com/?after=&before=>; rel="first",` + 888 ` <https://api.github.com/?after=&before=d4e5f6>; rel="prev",`, 889 }, 890 }, 891 } 892 893 response := newResponse(&r) 894 if got, want := response.Before, "d4e5f6"; got != want { 895 t.Errorf("response.Before: %v, want %v", got, want) 896 } 897 if got, want := response.After, "a1b2c3"; got != want { 898 t.Errorf("response.After: %v, want %v", got, want) 899 } 900 if got, want := response.FirstPage, 0; got != want { 901 t.Errorf("response.FirstPage: %v, want %v", got, want) 902 } 903 if got, want := response.PrevPage, 0; want != got { 904 t.Errorf("response.PrevPage: %v, want %v", got, want) 905 } 906 if got, want := response.NextPage, 0; want != got { 907 t.Errorf("response.NextPage: %v, want %v", got, want) 908 } 909 if got, want := response.LastPage, 0; want != got { 910 t.Errorf("response.LastPage: %v, want %v", got, want) 911 } 912 if got, want := response.NextPageToken, ""; want != got { 913 t.Errorf("response.NextPageToken: %v, want %v", got, want) 914 } 915 } 916 917 func TestResponse_populatePageValues_invalid(t *testing.T) { 918 r := http.Response{ 919 Header: http.Header{ 920 "Link": {`<https://api.github.com/?page=1>,` + 921 `<https://api.github.com/?page=abc>; rel="first",` + 922 `https://api.github.com/?page=2; rel="prev",` + 923 `<https://api.github.com/>; rel="next",` + 924 `<https://api.github.com/?page=>; rel="last"`, 925 }, 926 }, 927 } 928 929 response := newResponse(&r) 930 if got, want := response.FirstPage, 0; got != want { 931 t.Errorf("response.FirstPage: %v, want %v", got, want) 932 } 933 if got, want := response.PrevPage, 0; got != want { 934 t.Errorf("response.PrevPage: %v, want %v", got, want) 935 } 936 if got, want := response.NextPage, 0; got != want { 937 t.Errorf("response.NextPage: %v, want %v", got, want) 938 } 939 if got, want := response.LastPage, 0; got != want { 940 t.Errorf("response.LastPage: %v, want %v", got, want) 941 } 942 943 // more invalid URLs 944 r = http.Response{ 945 Header: http.Header{ 946 "Link": {`<https://api.github.com/%?page=2>; rel="first"`}, 947 }, 948 } 949 950 response = newResponse(&r) 951 if got, want := response.FirstPage, 0; got != want { 952 t.Errorf("response.FirstPage: %v, want %v", got, want) 953 } 954 } 955 956 func TestResponse_populateSinceValues_invalid(t *testing.T) { 957 r := http.Response{ 958 Header: http.Header{ 959 "Link": {`<https://api.github.com/?since=1>,` + 960 `<https://api.github.com/?since=abc>; rel="first",` + 961 `https://api.github.com/?since=2; rel="prev",` + 962 `<https://api.github.com/>; rel="next",` + 963 `<https://api.github.com/?since=>; rel="last"`, 964 }, 965 }, 966 } 967 968 response := newResponse(&r) 969 if got, want := response.FirstPage, 0; got != want { 970 t.Errorf("response.FirstPage: %v, want %v", got, want) 971 } 972 if got, want := response.PrevPage, 0; got != want { 973 t.Errorf("response.PrevPage: %v, want %v", got, want) 974 } 975 if got, want := response.NextPage, 0; got != want { 976 t.Errorf("response.NextPage: %v, want %v", got, want) 977 } 978 if got, want := response.LastPage, 0; got != want { 979 t.Errorf("response.LastPage: %v, want %v", got, want) 980 } 981 982 // more invalid URLs 983 r = http.Response{ 984 Header: http.Header{ 985 "Link": {`<https://api.github.com/%?since=2>; rel="first"`}, 986 }, 987 } 988 989 response = newResponse(&r) 990 if got, want := response.FirstPage, 0; got != want { 991 t.Errorf("response.FirstPage: %v, want %v", got, want) 992 } 993 } 994 995 func TestDo(t *testing.T) { 996 client, mux, _, teardown := setup() 997 defer teardown() 998 999 type foo struct { 1000 A string 1001 } 1002 1003 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1004 testMethod(t, r, "GET") 1005 fmt.Fprint(w, `{"A":"a"}`) 1006 }) 1007 1008 req, _ := client.NewRequest("GET", ".", nil) 1009 body := new(foo) 1010 ctx := context.Background() 1011 client.Do(ctx, req, body) 1012 1013 want := &foo{"a"} 1014 if !cmp.Equal(body, want) { 1015 t.Errorf("Response body = %v, want %v", body, want) 1016 } 1017 } 1018 1019 func TestDo_nilContext(t *testing.T) { 1020 client, _, _, teardown := setup() 1021 defer teardown() 1022 1023 req, _ := client.NewRequest("GET", ".", nil) 1024 _, err := client.Do(nil, req, nil) 1025 1026 if !errors.Is(err, errNonNilContext) { 1027 t.Errorf("Expected context must be non-nil error") 1028 } 1029 } 1030 1031 func TestDo_httpError(t *testing.T) { 1032 client, mux, _, teardown := setup() 1033 defer teardown() 1034 1035 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1036 http.Error(w, "Bad Request", 400) 1037 }) 1038 1039 req, _ := client.NewRequest("GET", ".", nil) 1040 ctx := context.Background() 1041 resp, err := client.Do(ctx, req, nil) 1042 1043 if err == nil { 1044 t.Fatal("Expected HTTP 400 error, got no error.") 1045 } 1046 if resp.StatusCode != 400 { 1047 t.Errorf("Expected HTTP 400 error, got %d status code.", resp.StatusCode) 1048 } 1049 } 1050 1051 // Test handling of an error caused by the internal http client's Do() 1052 // function. A redirect loop is pretty unlikely to occur within the GitHub 1053 // API, but does allow us to exercise the right code path. 1054 func TestDo_redirectLoop(t *testing.T) { 1055 client, mux, _, teardown := setup() 1056 defer teardown() 1057 1058 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1059 http.Redirect(w, r, baseURLPath, http.StatusFound) 1060 }) 1061 1062 req, _ := client.NewRequest("GET", ".", nil) 1063 ctx := context.Background() 1064 _, err := client.Do(ctx, req, nil) 1065 1066 if err == nil { 1067 t.Error("Expected error to be returned.") 1068 } 1069 if err, ok := err.(*url.Error); !ok { 1070 t.Errorf("Expected a URL error; got %#v.", err) 1071 } 1072 } 1073 1074 // Test that an error caused by the internal http client's Do() function 1075 // does not leak the client secret. 1076 func TestDo_sanitizeURL(t *testing.T) { 1077 tp := &UnauthenticatedRateLimitedTransport{ 1078 ClientID: "id", 1079 ClientSecret: "secret", 1080 } 1081 unauthedClient := NewClient(tp.Client()) 1082 unauthedClient.BaseURL = &url.URL{Scheme: "http", Host: "127.0.0.1:0", Path: "/"} // Use port 0 on purpose to trigger a dial TCP error, expect to get "dial tcp 127.0.0.1:0: connect: can't assign requested address". 1083 req, err := unauthedClient.NewRequest("GET", ".", nil) 1084 if err != nil { 1085 t.Fatalf("NewRequest returned unexpected error: %v", err) 1086 } 1087 ctx := context.Background() 1088 _, err = unauthedClient.Do(ctx, req, nil) 1089 if err == nil { 1090 t.Fatal("Expected error to be returned.") 1091 } 1092 if strings.Contains(err.Error(), "client_secret=secret") { 1093 t.Errorf("Do error contains secret, should be redacted:\n%q", err) 1094 } 1095 } 1096 1097 func TestDo_rateLimit(t *testing.T) { 1098 client, mux, _, teardown := setup() 1099 defer teardown() 1100 1101 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1102 w.Header().Set(headerRateLimit, "60") 1103 w.Header().Set(headerRateRemaining, "59") 1104 w.Header().Set(headerRateReset, "1372700873") 1105 }) 1106 1107 req, _ := client.NewRequest("GET", ".", nil) 1108 ctx := context.Background() 1109 resp, err := client.Do(ctx, req, nil) 1110 if err != nil { 1111 t.Errorf("Do returned unexpected error: %v", err) 1112 } 1113 if got, want := resp.Rate.Limit, 60; got != want { 1114 t.Errorf("Client rate limit = %v, want %v", got, want) 1115 } 1116 if got, want := resp.Rate.Remaining, 59; got != want { 1117 t.Errorf("Client rate remaining = %v, want %v", got, want) 1118 } 1119 reset := time.Date(2013, time.July, 1, 17, 47, 53, 0, time.UTC) 1120 if resp.Rate.Reset.UTC() != reset { 1121 t.Errorf("Client rate reset = %v, want %v", resp.Rate.Reset, reset) 1122 } 1123 } 1124 1125 // ensure rate limit is still parsed, even for error responses 1126 func TestDo_rateLimit_errorResponse(t *testing.T) { 1127 client, mux, _, teardown := setup() 1128 defer teardown() 1129 1130 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1131 w.Header().Set(headerRateLimit, "60") 1132 w.Header().Set(headerRateRemaining, "59") 1133 w.Header().Set(headerRateReset, "1372700873") 1134 http.Error(w, "Bad Request", 400) 1135 }) 1136 1137 req, _ := client.NewRequest("GET", ".", nil) 1138 ctx := context.Background() 1139 resp, err := client.Do(ctx, req, nil) 1140 if err == nil { 1141 t.Error("Expected error to be returned.") 1142 } 1143 if _, ok := err.(*RateLimitError); ok { 1144 t.Errorf("Did not expect a *RateLimitError error; got %#v.", err) 1145 } 1146 if got, want := resp.Rate.Limit, 60; got != want { 1147 t.Errorf("Client rate limit = %v, want %v", got, want) 1148 } 1149 if got, want := resp.Rate.Remaining, 59; got != want { 1150 t.Errorf("Client rate remaining = %v, want %v", got, want) 1151 } 1152 reset := time.Date(2013, time.July, 1, 17, 47, 53, 0, time.UTC) 1153 if resp.Rate.Reset.UTC() != reset { 1154 t.Errorf("Client rate reset = %v, want %v", resp.Rate.Reset, reset) 1155 } 1156 } 1157 1158 // Ensure *RateLimitError is returned when API rate limit is exceeded. 1159 func TestDo_rateLimit_rateLimitError(t *testing.T) { 1160 client, mux, _, teardown := setup() 1161 defer teardown() 1162 1163 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1164 w.Header().Set(headerRateLimit, "60") 1165 w.Header().Set(headerRateRemaining, "0") 1166 w.Header().Set(headerRateReset, "1372700873") 1167 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1168 w.WriteHeader(http.StatusForbidden) 1169 fmt.Fprintln(w, `{ 1170 "message": "API rate limit exceeded for xxx.xxx.xxx.xxx. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", 1171 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1172 }`) 1173 }) 1174 1175 req, _ := client.NewRequest("GET", ".", nil) 1176 ctx := context.Background() 1177 _, err := client.Do(ctx, req, nil) 1178 1179 if err == nil { 1180 t.Error("Expected error to be returned.") 1181 } 1182 rateLimitErr, ok := err.(*RateLimitError) 1183 if !ok { 1184 t.Fatalf("Expected a *RateLimitError error; got %#v.", err) 1185 } 1186 if got, want := rateLimitErr.Rate.Limit, 60; got != want { 1187 t.Errorf("rateLimitErr rate limit = %v, want %v", got, want) 1188 } 1189 if got, want := rateLimitErr.Rate.Remaining, 0; got != want { 1190 t.Errorf("rateLimitErr rate remaining = %v, want %v", got, want) 1191 } 1192 reset := time.Date(2013, time.July, 1, 17, 47, 53, 0, time.UTC) 1193 if rateLimitErr.Rate.Reset.UTC() != reset { 1194 t.Errorf("rateLimitErr rate reset = %v, want %v", rateLimitErr.Rate.Reset.UTC(), reset) 1195 } 1196 } 1197 1198 // Ensure a network call is not made when it's known that API rate limit is still exceeded. 1199 func TestDo_rateLimit_noNetworkCall(t *testing.T) { 1200 client, mux, _, teardown := setup() 1201 defer teardown() 1202 1203 reset := time.Now().UTC().Add(time.Minute).Round(time.Second) // Rate reset is a minute from now, with 1 second precision. 1204 1205 mux.HandleFunc("/first", func(w http.ResponseWriter, r *http.Request) { 1206 w.Header().Set(headerRateLimit, "60") 1207 w.Header().Set(headerRateRemaining, "0") 1208 w.Header().Set(headerRateReset, fmt.Sprint(reset.Unix())) 1209 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1210 w.WriteHeader(http.StatusForbidden) 1211 fmt.Fprintln(w, `{ 1212 "message": "API rate limit exceeded for xxx.xxx.xxx.xxx. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", 1213 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1214 }`) 1215 }) 1216 1217 madeNetworkCall := false 1218 mux.HandleFunc("/second", func(w http.ResponseWriter, r *http.Request) { 1219 madeNetworkCall = true 1220 }) 1221 1222 // First request is made, and it makes the client aware of rate reset time being in the future. 1223 req, _ := client.NewRequest("GET", "first", nil) 1224 ctx := context.Background() 1225 client.Do(ctx, req, nil) 1226 1227 // Second request should not cause a network call to be made, since client can predict a rate limit error. 1228 req, _ = client.NewRequest("GET", "second", nil) 1229 _, err := client.Do(ctx, req, nil) 1230 1231 if madeNetworkCall { 1232 t.Fatal("Network call was made, even though rate limit is known to still be exceeded.") 1233 } 1234 1235 if err == nil { 1236 t.Error("Expected error to be returned.") 1237 } 1238 rateLimitErr, ok := err.(*RateLimitError) 1239 if !ok { 1240 t.Fatalf("Expected a *RateLimitError error; got %#v.", err) 1241 } 1242 if got, want := rateLimitErr.Rate.Limit, 60; got != want { 1243 t.Errorf("rateLimitErr rate limit = %v, want %v", got, want) 1244 } 1245 if got, want := rateLimitErr.Rate.Remaining, 0; got != want { 1246 t.Errorf("rateLimitErr rate remaining = %v, want %v", got, want) 1247 } 1248 if rateLimitErr.Rate.Reset.UTC() != reset { 1249 t.Errorf("rateLimitErr rate reset = %v, want %v", rateLimitErr.Rate.Reset.UTC(), reset) 1250 } 1251 } 1252 1253 // Ignore rate limit headers if the response was served from cache. 1254 func TestDo_rateLimit_ignoredFromCache(t *testing.T) { 1255 client, mux, _, teardown := setup() 1256 defer teardown() 1257 1258 reset := time.Now().UTC().Add(time.Minute).Round(time.Second) // Rate reset is a minute from now, with 1 second precision. 1259 1260 // By adding the X-From-Cache header we pretend this is served from a cache. 1261 mux.HandleFunc("/first", func(w http.ResponseWriter, r *http.Request) { 1262 w.Header().Set("X-From-Cache", "1") 1263 w.Header().Set(headerRateLimit, "60") 1264 w.Header().Set(headerRateRemaining, "0") 1265 w.Header().Set(headerRateReset, fmt.Sprint(reset.Unix())) 1266 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1267 w.WriteHeader(http.StatusForbidden) 1268 fmt.Fprintln(w, `{ 1269 "message": "API rate limit exceeded for xxx.xxx.xxx.xxx. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", 1270 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1271 }`) 1272 }) 1273 1274 madeNetworkCall := false 1275 mux.HandleFunc("/second", func(w http.ResponseWriter, r *http.Request) { 1276 madeNetworkCall = true 1277 }) 1278 1279 // First request is made so afterwards we can check the returned rate limit headers were ignored. 1280 req, _ := client.NewRequest("GET", "first", nil) 1281 ctx := context.Background() 1282 client.Do(ctx, req, nil) 1283 1284 // Second request should not by hindered by rate limits. 1285 req, _ = client.NewRequest("GET", "second", nil) 1286 _, err := client.Do(ctx, req, nil) 1287 1288 if err != nil { 1289 t.Fatalf("Second request failed, even though the rate limits from the cache should've been ignored: %v", err) 1290 } 1291 if !madeNetworkCall { 1292 t.Fatal("Network call was not made, even though the rate limits from the cache should've been ignored") 1293 } 1294 } 1295 1296 // Ensure *AbuseRateLimitError is returned when the response indicates that 1297 // the client has triggered an abuse detection mechanism. 1298 func TestDo_rateLimit_abuseRateLimitError(t *testing.T) { 1299 client, mux, _, teardown := setup() 1300 defer teardown() 1301 1302 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1303 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1304 w.WriteHeader(http.StatusForbidden) 1305 // When the abuse rate limit error is of the "temporarily blocked from content creation" type, 1306 // there is no "Retry-After" header. 1307 fmt.Fprintln(w, `{ 1308 "message": "You have triggered an abuse detection mechanism and have been temporarily blocked from content creation. Please retry your request again later.", 1309 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1310 }`) 1311 }) 1312 1313 req, _ := client.NewRequest("GET", ".", nil) 1314 ctx := context.Background() 1315 _, err := client.Do(ctx, req, nil) 1316 1317 if err == nil { 1318 t.Error("Expected error to be returned.") 1319 } 1320 abuseRateLimitErr, ok := err.(*AbuseRateLimitError) 1321 if !ok { 1322 t.Fatalf("Expected a *AbuseRateLimitError error; got %#v.", err) 1323 } 1324 if got, want := abuseRateLimitErr.RetryAfter, (*time.Duration)(nil); got != want { 1325 t.Errorf("abuseRateLimitErr RetryAfter = %v, want %v", got, want) 1326 } 1327 } 1328 1329 // Ensure *AbuseRateLimitError is returned when the response indicates that 1330 // the client has triggered an abuse detection mechanism on GitHub Enterprise. 1331 func TestDo_rateLimit_abuseRateLimitErrorEnterprise(t *testing.T) { 1332 client, mux, _, teardown := setup() 1333 defer teardown() 1334 1335 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1336 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1337 w.WriteHeader(http.StatusForbidden) 1338 // When the abuse rate limit error is of the "temporarily blocked from content creation" type, 1339 // there is no "Retry-After" header. 1340 // This response returns a documentation url like the one returned for GitHub Enterprise, this 1341 // url changes between versions but follows roughly the same format. 1342 fmt.Fprintln(w, `{ 1343 "message": "You have triggered an abuse detection mechanism and have been temporarily blocked from content creation. Please retry your request again later.", 1344 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1345 }`) 1346 }) 1347 1348 req, _ := client.NewRequest("GET", ".", nil) 1349 ctx := context.Background() 1350 _, err := client.Do(ctx, req, nil) 1351 1352 if err == nil { 1353 t.Error("Expected error to be returned.") 1354 } 1355 abuseRateLimitErr, ok := err.(*AbuseRateLimitError) 1356 if !ok { 1357 t.Fatalf("Expected a *AbuseRateLimitError error; got %#v.", err) 1358 } 1359 if got, want := abuseRateLimitErr.RetryAfter, (*time.Duration)(nil); got != want { 1360 t.Errorf("abuseRateLimitErr RetryAfter = %v, want %v", got, want) 1361 } 1362 } 1363 1364 // Ensure *AbuseRateLimitError.RetryAfter is parsed correctly. 1365 func TestDo_rateLimit_abuseRateLimitError_retryAfter(t *testing.T) { 1366 client, mux, _, teardown := setup() 1367 defer teardown() 1368 1369 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1370 w.Header().Set("Content-Type", "application/json; charset=utf-8") 1371 w.Header().Set("Retry-After", "123") // Retry after value of 123 seconds. 1372 w.WriteHeader(http.StatusForbidden) 1373 fmt.Fprintln(w, `{ 1374 "message": "You have triggered an abuse detection mechanism ...", 1375 "documentation_url": "https://docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits" 1376 }`) 1377 }) 1378 1379 req, _ := client.NewRequest("GET", ".", nil) 1380 ctx := context.Background() 1381 _, err := client.Do(ctx, req, nil) 1382 1383 if err == nil { 1384 t.Error("Expected error to be returned.") 1385 } 1386 abuseRateLimitErr, ok := err.(*AbuseRateLimitError) 1387 if !ok { 1388 t.Fatalf("Expected a *AbuseRateLimitError error; got %#v.", err) 1389 } 1390 if abuseRateLimitErr.RetryAfter == nil { 1391 t.Fatalf("abuseRateLimitErr RetryAfter is nil, expected not-nil") 1392 } 1393 if got, want := *abuseRateLimitErr.RetryAfter, 123*time.Second; got != want { 1394 t.Errorf("abuseRateLimitErr RetryAfter = %v, want %v", got, want) 1395 } 1396 } 1397 1398 func TestDo_noContent(t *testing.T) { 1399 client, mux, _, teardown := setup() 1400 defer teardown() 1401 1402 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 1403 w.WriteHeader(http.StatusNoContent) 1404 }) 1405 1406 var body json.RawMessage 1407 1408 req, _ := client.NewRequest("GET", ".", nil) 1409 ctx := context.Background() 1410 _, err := client.Do(ctx, req, &body) 1411 if err != nil { 1412 t.Fatalf("Do returned unexpected error: %v", err) 1413 } 1414 } 1415 1416 func TestSanitizeURL(t *testing.T) { 1417 tests := []struct { 1418 in, want string 1419 }{ 1420 {"/?a=b", "/?a=b"}, 1421 {"/?a=b&client_secret=secret", "/?a=b&client_secret=REDACTED"}, 1422 {"/?a=b&client_id=id&client_secret=secret", "/?a=b&client_id=id&client_secret=REDACTED"}, 1423 } 1424 1425 for _, tt := range tests { 1426 inURL, _ := url.Parse(tt.in) 1427 want, _ := url.Parse(tt.want) 1428 1429 if got := sanitizeURL(inURL); !cmp.Equal(got, want) { 1430 t.Errorf("sanitizeURL(%v) returned %v, want %v", tt.in, got, want) 1431 } 1432 } 1433 } 1434 1435 func TestCheckResponse(t *testing.T) { 1436 res := &http.Response{ 1437 Request: &http.Request{}, 1438 StatusCode: http.StatusBadRequest, 1439 Body: io.NopCloser(strings.NewReader(`{"message":"m", 1440 "errors": [{"resource": "r", "field": "f", "code": "c"}], 1441 "block": {"reason": "dmca", "created_at": "2016-03-17T15:39:46Z"}}`)), 1442 } 1443 err := CheckResponse(res).(*ErrorResponse) 1444 1445 if err == nil { 1446 t.Errorf("Expected error response.") 1447 } 1448 1449 want := &ErrorResponse{ 1450 Response: res, 1451 Message: "m", 1452 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1453 Block: &ErrorBlock{ 1454 Reason: "dmca", 1455 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1456 }, 1457 } 1458 if !errors.Is(err, want) { 1459 t.Errorf("Error = %#v, want %#v", err, want) 1460 } 1461 } 1462 1463 func TestCheckResponse_RateLimit(t *testing.T) { 1464 res := &http.Response{ 1465 Request: &http.Request{}, 1466 StatusCode: http.StatusForbidden, 1467 Header: http.Header{}, 1468 Body: io.NopCloser(strings.NewReader(`{"message":"m", 1469 "documentation_url": "url"}`)), 1470 } 1471 res.Header.Set(headerRateLimit, "60") 1472 res.Header.Set(headerRateRemaining, "0") 1473 res.Header.Set(headerRateReset, "243424") 1474 1475 err := CheckResponse(res).(*RateLimitError) 1476 1477 if err == nil { 1478 t.Errorf("Expected error response.") 1479 } 1480 1481 want := &RateLimitError{ 1482 Rate: parseRate(res), 1483 Response: res, 1484 Message: "m", 1485 } 1486 if !errors.Is(err, want) { 1487 t.Errorf("Error = %#v, want %#v", err, want) 1488 } 1489 } 1490 1491 func TestCheckResponse_AbuseRateLimit(t *testing.T) { 1492 res := &http.Response{ 1493 Request: &http.Request{}, 1494 StatusCode: http.StatusForbidden, 1495 Body: io.NopCloser(strings.NewReader(`{"message":"m", 1496 "documentation_url": "docs.github.com/en/rest/overview/resources-in-the-rest-api#abuse-rate-limits"}`)), 1497 } 1498 err := CheckResponse(res).(*AbuseRateLimitError) 1499 1500 if err == nil { 1501 t.Errorf("Expected error response.") 1502 } 1503 1504 want := &AbuseRateLimitError{ 1505 Response: res, 1506 Message: "m", 1507 } 1508 if !errors.Is(err, want) { 1509 t.Errorf("Error = %#v, want %#v", err, want) 1510 } 1511 } 1512 1513 func TestCompareHttpResponse(t *testing.T) { 1514 testcases := map[string]struct { 1515 h1 *http.Response 1516 h2 *http.Response 1517 expected bool 1518 }{ 1519 "both are nil": { 1520 expected: true, 1521 }, 1522 "both are non nil - same StatusCode": { 1523 expected: true, 1524 h1: &http.Response{StatusCode: 200}, 1525 h2: &http.Response{StatusCode: 200}, 1526 }, 1527 "both are non nil - different StatusCode": { 1528 expected: false, 1529 h1: &http.Response{StatusCode: 200}, 1530 h2: &http.Response{StatusCode: 404}, 1531 }, 1532 "one is nil, other is not": { 1533 expected: false, 1534 h2: &http.Response{}, 1535 }, 1536 } 1537 1538 for name, tc := range testcases { 1539 t.Run(name, func(t *testing.T) { 1540 v := compareHTTPResponse(tc.h1, tc.h2) 1541 if tc.expected != v { 1542 t.Errorf("Expected %t, got %t for (%#v, %#v)", tc.expected, v, tc.h1, tc.h2) 1543 } 1544 }) 1545 } 1546 } 1547 1548 func TestErrorResponse_Is(t *testing.T) { 1549 err := &ErrorResponse{ 1550 Response: &http.Response{}, 1551 Message: "m", 1552 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1553 Block: &ErrorBlock{ 1554 Reason: "r", 1555 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1556 }, 1557 DocumentationURL: "https://github.com", 1558 } 1559 testcases := map[string]struct { 1560 wantSame bool 1561 otherError error 1562 }{ 1563 "errors are same": { 1564 wantSame: true, 1565 otherError: &ErrorResponse{ 1566 Response: &http.Response{}, 1567 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1568 Message: "m", 1569 Block: &ErrorBlock{ 1570 Reason: "r", 1571 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1572 }, 1573 DocumentationURL: "https://github.com", 1574 }, 1575 }, 1576 "errors have different values - Message": { 1577 wantSame: false, 1578 otherError: &ErrorResponse{ 1579 Response: &http.Response{}, 1580 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1581 Message: "m1", 1582 Block: &ErrorBlock{ 1583 Reason: "r", 1584 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1585 }, 1586 DocumentationURL: "https://github.com", 1587 }, 1588 }, 1589 "errors have different values - DocumentationURL": { 1590 wantSame: false, 1591 otherError: &ErrorResponse{ 1592 Response: &http.Response{}, 1593 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1594 Message: "m", 1595 Block: &ErrorBlock{ 1596 Reason: "r", 1597 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1598 }, 1599 DocumentationURL: "https://google.com", 1600 }, 1601 }, 1602 "errors have different values - Response is nil": { 1603 wantSame: false, 1604 otherError: &ErrorResponse{ 1605 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1606 Message: "m", 1607 Block: &ErrorBlock{ 1608 Reason: "r", 1609 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1610 }, 1611 DocumentationURL: "https://github.com", 1612 }, 1613 }, 1614 "errors have different values - Errors": { 1615 wantSame: false, 1616 otherError: &ErrorResponse{ 1617 Response: &http.Response{}, 1618 Errors: []Error{{Resource: "r1", Field: "f1", Code: "c1"}}, 1619 Message: "m", 1620 Block: &ErrorBlock{ 1621 Reason: "r", 1622 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1623 }, 1624 DocumentationURL: "https://github.com", 1625 }, 1626 }, 1627 "errors have different values - Errors have different length": { 1628 wantSame: false, 1629 otherError: &ErrorResponse{ 1630 Response: &http.Response{}, 1631 Errors: []Error{}, 1632 Message: "m", 1633 Block: &ErrorBlock{ 1634 Reason: "r", 1635 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1636 }, 1637 DocumentationURL: "https://github.com", 1638 }, 1639 }, 1640 "errors have different values - Block - one is nil, other is not": { 1641 wantSame: false, 1642 otherError: &ErrorResponse{ 1643 Response: &http.Response{}, 1644 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1645 Message: "m", 1646 DocumentationURL: "https://github.com", 1647 }, 1648 }, 1649 "errors have different values - Block - different Reason": { 1650 wantSame: false, 1651 otherError: &ErrorResponse{ 1652 Response: &http.Response{}, 1653 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1654 Message: "m", 1655 Block: &ErrorBlock{ 1656 Reason: "r1", 1657 CreatedAt: &Timestamp{time.Date(2016, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1658 }, 1659 DocumentationURL: "https://github.com", 1660 }, 1661 }, 1662 "errors have different values - Block - different CreatedAt #1": { 1663 wantSame: false, 1664 otherError: &ErrorResponse{ 1665 Response: &http.Response{}, 1666 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1667 Message: "m", 1668 Block: &ErrorBlock{ 1669 Reason: "r", 1670 CreatedAt: nil, 1671 }, 1672 DocumentationURL: "https://github.com", 1673 }, 1674 }, 1675 "errors have different values - Block - different CreatedAt #2": { 1676 wantSame: false, 1677 otherError: &ErrorResponse{ 1678 Response: &http.Response{}, 1679 Errors: []Error{{Resource: "r", Field: "f", Code: "c"}}, 1680 Message: "m", 1681 Block: &ErrorBlock{ 1682 Reason: "r", 1683 CreatedAt: &Timestamp{time.Date(2017, time.March, 17, 15, 39, 46, 0, time.UTC)}, 1684 }, 1685 DocumentationURL: "https://github.com", 1686 }, 1687 }, 1688 "errors have different types": { 1689 wantSame: false, 1690 otherError: errors.New("Github"), 1691 }, 1692 } 1693 1694 for name, tc := range testcases { 1695 t.Run(name, func(t *testing.T) { 1696 if tc.wantSame != err.Is(tc.otherError) { 1697 t.Errorf("Error = %#v, want %#v", err, tc.otherError) 1698 } 1699 }) 1700 } 1701 } 1702 1703 func TestRateLimitError_Is(t *testing.T) { 1704 err := &RateLimitError{ 1705 Response: &http.Response{}, 1706 Message: "Github", 1707 } 1708 testcases := map[string]struct { 1709 wantSame bool 1710 err *RateLimitError 1711 otherError error 1712 }{ 1713 "errors are same": { 1714 wantSame: true, 1715 err: err, 1716 otherError: &RateLimitError{ 1717 Response: &http.Response{}, 1718 Message: "Github", 1719 }, 1720 }, 1721 "errors are same - Response is nil": { 1722 wantSame: true, 1723 err: &RateLimitError{ 1724 Message: "Github", 1725 }, 1726 otherError: &RateLimitError{ 1727 Message: "Github", 1728 }, 1729 }, 1730 "errors have different values - Rate": { 1731 wantSame: false, 1732 err: err, 1733 otherError: &RateLimitError{ 1734 Rate: Rate{Limit: 10}, 1735 Response: &http.Response{}, 1736 Message: "Gitlab", 1737 }, 1738 }, 1739 "errors have different values - Response is nil": { 1740 wantSame: false, 1741 err: err, 1742 otherError: &RateLimitError{ 1743 Message: "Github", 1744 }, 1745 }, 1746 "errors have different values - StatusCode": { 1747 wantSame: false, 1748 err: err, 1749 otherError: &RateLimitError{ 1750 Response: &http.Response{StatusCode: 200}, 1751 Message: "Github", 1752 }, 1753 }, 1754 "errors have different types": { 1755 wantSame: false, 1756 err: err, 1757 otherError: errors.New("Github"), 1758 }, 1759 } 1760 1761 for name, tc := range testcases { 1762 t.Run(name, func(t *testing.T) { 1763 if tc.wantSame != tc.err.Is(tc.otherError) { 1764 t.Errorf("Error = %#v, want %#v", tc.err, tc.otherError) 1765 } 1766 }) 1767 } 1768 } 1769 1770 func TestAbuseRateLimitError_Is(t *testing.T) { 1771 t1 := 1 * time.Second 1772 t2 := 2 * time.Second 1773 err := &AbuseRateLimitError{ 1774 Response: &http.Response{}, 1775 Message: "Github", 1776 RetryAfter: &t1, 1777 } 1778 testcases := map[string]struct { 1779 wantSame bool 1780 err *AbuseRateLimitError 1781 otherError error 1782 }{ 1783 "errors are same": { 1784 wantSame: true, 1785 err: err, 1786 otherError: &AbuseRateLimitError{ 1787 Response: &http.Response{}, 1788 Message: "Github", 1789 RetryAfter: &t1, 1790 }, 1791 }, 1792 "errors are same - Response is nil": { 1793 wantSame: true, 1794 err: &AbuseRateLimitError{ 1795 Message: "Github", 1796 RetryAfter: &t1, 1797 }, 1798 otherError: &AbuseRateLimitError{ 1799 Message: "Github", 1800 RetryAfter: &t1, 1801 }, 1802 }, 1803 "errors have different values - Message": { 1804 wantSame: false, 1805 err: err, 1806 otherError: &AbuseRateLimitError{ 1807 Response: &http.Response{}, 1808 Message: "Gitlab", 1809 RetryAfter: nil, 1810 }, 1811 }, 1812 "errors have different values - RetryAfter": { 1813 wantSame: false, 1814 err: err, 1815 otherError: &AbuseRateLimitError{ 1816 Response: &http.Response{}, 1817 Message: "Github", 1818 RetryAfter: &t2, 1819 }, 1820 }, 1821 "errors have different values - Response is nil": { 1822 wantSame: false, 1823 err: err, 1824 otherError: &AbuseRateLimitError{ 1825 Message: "Github", 1826 RetryAfter: &t1, 1827 }, 1828 }, 1829 "errors have different values - StatusCode": { 1830 wantSame: false, 1831 err: err, 1832 otherError: &AbuseRateLimitError{ 1833 Response: &http.Response{StatusCode: 200}, 1834 Message: "Github", 1835 RetryAfter: &t1, 1836 }, 1837 }, 1838 "errors have different types": { 1839 wantSame: false, 1840 err: err, 1841 otherError: errors.New("Github"), 1842 }, 1843 } 1844 1845 for name, tc := range testcases { 1846 t.Run(name, func(t *testing.T) { 1847 if tc.wantSame != tc.err.Is(tc.otherError) { 1848 t.Errorf("Error = %#v, want %#v", tc.err, tc.otherError) 1849 } 1850 }) 1851 } 1852 } 1853 1854 func TestAcceptedError_Is(t *testing.T) { 1855 err := &AcceptedError{Raw: []byte("Github")} 1856 testcases := map[string]struct { 1857 wantSame bool 1858 otherError error 1859 }{ 1860 "errors are same": { 1861 wantSame: true, 1862 otherError: &AcceptedError{Raw: []byte("Github")}, 1863 }, 1864 "errors have different values": { 1865 wantSame: false, 1866 otherError: &AcceptedError{Raw: []byte("Gitlab")}, 1867 }, 1868 "errors have different types": { 1869 wantSame: false, 1870 otherError: errors.New("Github"), 1871 }, 1872 } 1873 1874 for name, tc := range testcases { 1875 t.Run(name, func(t *testing.T) { 1876 if tc.wantSame != err.Is(tc.otherError) { 1877 t.Errorf("Error = %#v, want %#v", err, tc.otherError) 1878 } 1879 }) 1880 } 1881 } 1882 1883 // ensure that we properly handle API errors that do not contain a response body 1884 func TestCheckResponse_noBody(t *testing.T) { 1885 res := &http.Response{ 1886 Request: &http.Request{}, 1887 StatusCode: http.StatusBadRequest, 1888 Body: io.NopCloser(strings.NewReader("")), 1889 } 1890 err := CheckResponse(res).(*ErrorResponse) 1891 1892 if err == nil { 1893 t.Errorf("Expected error response.") 1894 } 1895 1896 want := &ErrorResponse{ 1897 Response: res, 1898 } 1899 if !errors.Is(err, want) { 1900 t.Errorf("Error = %#v, want %#v", err, want) 1901 } 1902 } 1903 1904 func TestCheckResponse_unexpectedErrorStructure(t *testing.T) { 1905 httpBody := `{"message":"m", "errors": ["error 1"]}` 1906 res := &http.Response{ 1907 Request: &http.Request{}, 1908 StatusCode: http.StatusBadRequest, 1909 Body: io.NopCloser(strings.NewReader(httpBody)), 1910 } 1911 err := CheckResponse(res).(*ErrorResponse) 1912 1913 if err == nil { 1914 t.Errorf("Expected error response.") 1915 } 1916 1917 want := &ErrorResponse{ 1918 Response: res, 1919 Message: "m", 1920 Errors: []Error{{Message: "error 1"}}, 1921 } 1922 if !errors.Is(err, want) { 1923 t.Errorf("Error = %#v, want %#v", err, want) 1924 } 1925 data, err2 := io.ReadAll(err.Response.Body) 1926 if err2 != nil { 1927 t.Fatalf("failed to read response body: %v", err) 1928 } 1929 if got := string(data); got != httpBody { 1930 t.Errorf("ErrorResponse.Response.Body = %q, want %q", got, httpBody) 1931 } 1932 } 1933 1934 func TestParseBooleanResponse_true(t *testing.T) { 1935 result, err := parseBoolResponse(nil) 1936 if err != nil { 1937 t.Errorf("parseBoolResponse returned error: %+v", err) 1938 } 1939 1940 if want := true; result != want { 1941 t.Errorf("parseBoolResponse returned %+v, want: %+v", result, want) 1942 } 1943 } 1944 1945 func TestParseBooleanResponse_false(t *testing.T) { 1946 v := &ErrorResponse{Response: &http.Response{StatusCode: http.StatusNotFound}} 1947 result, err := parseBoolResponse(v) 1948 if err != nil { 1949 t.Errorf("parseBoolResponse returned error: %+v", err) 1950 } 1951 1952 if want := false; result != want { 1953 t.Errorf("parseBoolResponse returned %+v, want: %+v", result, want) 1954 } 1955 } 1956 1957 func TestParseBooleanResponse_error(t *testing.T) { 1958 v := &ErrorResponse{Response: &http.Response{StatusCode: http.StatusBadRequest}} 1959 result, err := parseBoolResponse(v) 1960 1961 if err == nil { 1962 t.Errorf("Expected error to be returned.") 1963 } 1964 1965 if want := false; result != want { 1966 t.Errorf("parseBoolResponse returned %+v, want: %+v", result, want) 1967 } 1968 } 1969 1970 func TestErrorResponse_Error(t *testing.T) { 1971 res := &http.Response{Request: &http.Request{}} 1972 err := ErrorResponse{Message: "m", Response: res} 1973 if err.Error() == "" { 1974 t.Errorf("Expected non-empty ErrorResponse.Error()") 1975 } 1976 } 1977 1978 func TestError_Error(t *testing.T) { 1979 err := Error{} 1980 if err.Error() == "" { 1981 t.Errorf("Expected non-empty Error.Error()") 1982 } 1983 } 1984 1985 func TestRateLimits(t *testing.T) { 1986 client, mux, _, teardown := setup() 1987 defer teardown() 1988 1989 mux.HandleFunc("/rate_limit", func(w http.ResponseWriter, r *http.Request) { 1990 testMethod(t, r, "GET") 1991 fmt.Fprint(w, `{"resources":{ 1992 "core": {"limit":2,"remaining":1,"reset":1372700873}, 1993 "search": {"limit":3,"remaining":2,"reset":1372700874}, 1994 "graphql": {"limit":4,"remaining":3,"reset":1372700875}, 1995 "integration_manifest": {"limit":5,"remaining":4,"reset":1372700876}, 1996 "source_import": {"limit":6,"remaining":5,"reset":1372700877}, 1997 "code_scanning_upload": {"limit":7,"remaining":6,"reset":1372700878}, 1998 "actions_runner_registration": {"limit":8,"remaining":7,"reset":1372700879}, 1999 "scim": {"limit":9,"remaining":8,"reset":1372700880} 2000 }}`) 2001 }) 2002 2003 ctx := context.Background() 2004 rate, _, err := client.RateLimits(ctx) 2005 if err != nil { 2006 t.Errorf("RateLimits returned error: %v", err) 2007 } 2008 2009 want := &RateLimits{ 2010 Core: &Rate{ 2011 Limit: 2, 2012 Remaining: 1, 2013 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 53, 0, time.UTC).Local()}, 2014 }, 2015 Search: &Rate{ 2016 Limit: 3, 2017 Remaining: 2, 2018 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 54, 0, time.UTC).Local()}, 2019 }, 2020 GraphQL: &Rate{ 2021 Limit: 4, 2022 Remaining: 3, 2023 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 55, 0, time.UTC).Local()}, 2024 }, 2025 IntegrationManifest: &Rate{ 2026 Limit: 5, 2027 Remaining: 4, 2028 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 56, 0, time.UTC).Local()}, 2029 }, 2030 SourceImport: &Rate{ 2031 Limit: 6, 2032 Remaining: 5, 2033 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 57, 0, time.UTC).Local()}, 2034 }, 2035 CodeScanningUpload: &Rate{ 2036 Limit: 7, 2037 Remaining: 6, 2038 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 58, 0, time.UTC).Local()}, 2039 }, 2040 ActionsRunnerRegistration: &Rate{ 2041 Limit: 8, 2042 Remaining: 7, 2043 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 59, 0, time.UTC).Local()}, 2044 }, 2045 SCIM: &Rate{ 2046 Limit: 9, 2047 Remaining: 8, 2048 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 48, 00, 0, time.UTC).Local()}, 2049 }, 2050 } 2051 if !cmp.Equal(rate, want) { 2052 t.Errorf("RateLimits returned %+v, want %+v", rate, want) 2053 } 2054 2055 if got, want := client.rateLimits[coreCategory], *want.Core; got != want { 2056 t.Errorf("client.rateLimits[coreCategory] is %+v, want %+v", got, want) 2057 } 2058 if got, want := client.rateLimits[searchCategory], *want.Search; got != want { 2059 t.Errorf("client.rateLimits[searchCategory] is %+v, want %+v", got, want) 2060 } 2061 if got, want := client.rateLimits[graphqlCategory], *want.GraphQL; got != want { 2062 t.Errorf("client.rateLimits[graphqlCategory] is %+v, want %+v", got, want) 2063 } 2064 if got, want := client.rateLimits[integrationManifestCategory], *want.IntegrationManifest; got != want { 2065 t.Errorf("client.rateLimits[integrationManifestCategory] is %+v, want %+v", got, want) 2066 } 2067 if got, want := client.rateLimits[sourceImportCategory], *want.SourceImport; got != want { 2068 t.Errorf("client.rateLimits[sourceImportCategory] is %+v, want %+v", got, want) 2069 } 2070 if got, want := client.rateLimits[codeScanningUploadCategory], *want.CodeScanningUpload; got != want { 2071 t.Errorf("client.rateLimits[codeScanningUploadCategory] is %+v, want %+v", got, want) 2072 } 2073 if got, want := client.rateLimits[actionsRunnerRegistrationCategory], *want.ActionsRunnerRegistration; got != want { 2074 t.Errorf("client.rateLimits[actionsRunnerRegistrationCategory] is %+v, want %+v", got, want) 2075 } 2076 if got, want := client.rateLimits[scimCategory], *want.SCIM; got != want { 2077 t.Errorf("client.rateLimits[scimCategory] is %+v, want %+v", got, want) 2078 } 2079 } 2080 2081 func TestRateLimits_coverage(t *testing.T) { 2082 client, _, _, teardown := setup() 2083 defer teardown() 2084 2085 ctx := context.Background() 2086 2087 const methodName = "RateLimits" 2088 testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { 2089 _, resp, err := client.RateLimits(ctx) 2090 return resp, err 2091 }) 2092 } 2093 2094 func TestRateLimits_overQuota(t *testing.T) { 2095 client, mux, _, teardown := setup() 2096 defer teardown() 2097 2098 client.rateLimits[coreCategory] = Rate{ 2099 Limit: 1, 2100 Remaining: 0, 2101 Reset: Timestamp{time.Now().Add(time.Hour).Local()}, 2102 } 2103 mux.HandleFunc("/rate_limit", func(w http.ResponseWriter, r *http.Request) { 2104 fmt.Fprint(w, `{"resources":{ 2105 "core": {"limit":2,"remaining":1,"reset":1372700873}, 2106 "search": {"limit":3,"remaining":2,"reset":1372700874} 2107 }}`) 2108 }) 2109 2110 ctx := context.Background() 2111 rate, _, err := client.RateLimits(ctx) 2112 if err != nil { 2113 t.Errorf("RateLimits returned error: %v", err) 2114 } 2115 2116 want := &RateLimits{ 2117 Core: &Rate{ 2118 Limit: 2, 2119 Remaining: 1, 2120 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 53, 0, time.UTC).Local()}, 2121 }, 2122 Search: &Rate{ 2123 Limit: 3, 2124 Remaining: 2, 2125 Reset: Timestamp{time.Date(2013, time.July, 1, 17, 47, 54, 0, time.UTC).Local()}, 2126 }, 2127 } 2128 if !cmp.Equal(rate, want) { 2129 t.Errorf("RateLimits returned %+v, want %+v", rate, want) 2130 } 2131 2132 if got, want := client.rateLimits[coreCategory], *want.Core; got != want { 2133 t.Errorf("client.rateLimits[coreCategory] is %+v, want %+v", got, want) 2134 } 2135 if got, want := client.rateLimits[searchCategory], *want.Search; got != want { 2136 t.Errorf("client.rateLimits[searchCategory] is %+v, want %+v", got, want) 2137 } 2138 } 2139 2140 func TestSetCredentialsAsHeaders(t *testing.T) { 2141 req := new(http.Request) 2142 id, secret := "id", "secret" 2143 modifiedRequest := setCredentialsAsHeaders(req, id, secret) 2144 2145 actualID, actualSecret, ok := modifiedRequest.BasicAuth() 2146 if !ok { 2147 t.Errorf("request does not contain basic credentials") 2148 } 2149 2150 if actualID != id { 2151 t.Errorf("id is %s, want %s", actualID, id) 2152 } 2153 2154 if actualSecret != secret { 2155 t.Errorf("secret is %s, want %s", actualSecret, secret) 2156 } 2157 } 2158 2159 func TestUnauthenticatedRateLimitedTransport(t *testing.T) { 2160 client, mux, _, teardown := setup() 2161 defer teardown() 2162 2163 clientID, clientSecret := "id", "secret" 2164 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 2165 id, secret, ok := r.BasicAuth() 2166 if !ok { 2167 t.Errorf("request does not contain basic auth credentials") 2168 } 2169 if id != clientID { 2170 t.Errorf("request contained basic auth username %q, want %q", id, clientID) 2171 } 2172 if secret != clientSecret { 2173 t.Errorf("request contained basic auth password %q, want %q", secret, clientSecret) 2174 } 2175 }) 2176 2177 tp := &UnauthenticatedRateLimitedTransport{ 2178 ClientID: clientID, 2179 ClientSecret: clientSecret, 2180 } 2181 unauthedClient := NewClient(tp.Client()) 2182 unauthedClient.BaseURL = client.BaseURL 2183 req, _ := unauthedClient.NewRequest("GET", ".", nil) 2184 ctx := context.Background() 2185 unauthedClient.Do(ctx, req, nil) 2186 } 2187 2188 func TestUnauthenticatedRateLimitedTransport_missingFields(t *testing.T) { 2189 // missing ClientID 2190 tp := &UnauthenticatedRateLimitedTransport{ 2191 ClientSecret: "secret", 2192 } 2193 _, err := tp.RoundTrip(nil) 2194 if err == nil { 2195 t.Errorf("Expected error to be returned") 2196 } 2197 2198 // missing ClientSecret 2199 tp = &UnauthenticatedRateLimitedTransport{ 2200 ClientID: "id", 2201 } 2202 _, err = tp.RoundTrip(nil) 2203 if err == nil { 2204 t.Errorf("Expected error to be returned") 2205 } 2206 } 2207 2208 func TestUnauthenticatedRateLimitedTransport_transport(t *testing.T) { 2209 // default transport 2210 tp := &UnauthenticatedRateLimitedTransport{ 2211 ClientID: "id", 2212 ClientSecret: "secret", 2213 } 2214 if tp.transport() != http.DefaultTransport { 2215 t.Errorf("Expected http.DefaultTransport to be used.") 2216 } 2217 2218 // custom transport 2219 tp = &UnauthenticatedRateLimitedTransport{ 2220 ClientID: "id", 2221 ClientSecret: "secret", 2222 Transport: &http.Transport{}, 2223 } 2224 if tp.transport() == http.DefaultTransport { 2225 t.Errorf("Expected custom transport to be used.") 2226 } 2227 } 2228 2229 func TestBasicAuthTransport(t *testing.T) { 2230 client, mux, _, teardown := setup() 2231 defer teardown() 2232 2233 username, password, otp := "u", "p", "123456" 2234 2235 mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { 2236 u, p, ok := r.BasicAuth() 2237 if !ok { 2238 t.Errorf("request does not contain basic auth credentials") 2239 } 2240 if u != username { 2241 t.Errorf("request contained basic auth username %q, want %q", u, username) 2242 } 2243 if p != password { 2244 t.Errorf("request contained basic auth password %q, want %q", p, password) 2245 } 2246 if got, want := r.Header.Get(headerOTP), otp; got != want { 2247 t.Errorf("request contained OTP %q, want %q", got, want) 2248 } 2249 }) 2250 2251 tp := &BasicAuthTransport{ 2252 Username: username, 2253 Password: password, 2254 OTP: otp, 2255 } 2256 basicAuthClient := NewClient(tp.Client()) 2257 basicAuthClient.BaseURL = client.BaseURL 2258 req, _ := basicAuthClient.NewRequest("GET", ".", nil) 2259 ctx := context.Background() 2260 basicAuthClient.Do(ctx, req, nil) 2261 } 2262 2263 func TestBasicAuthTransport_transport(t *testing.T) { 2264 // default transport 2265 tp := &BasicAuthTransport{} 2266 if tp.transport() != http.DefaultTransport { 2267 t.Errorf("Expected http.DefaultTransport to be used.") 2268 } 2269 2270 // custom transport 2271 tp = &BasicAuthTransport{ 2272 Transport: &http.Transport{}, 2273 } 2274 if tp.transport() == http.DefaultTransport { 2275 t.Errorf("Expected custom transport to be used.") 2276 } 2277 } 2278 2279 func TestFormatRateReset(t *testing.T) { 2280 d := 120*time.Minute + 12*time.Second 2281 got := formatRateReset(d) 2282 want := "[rate reset in 120m12s]" 2283 if got != want { 2284 t.Errorf("Format is wrong. got: %v, want: %v", got, want) 2285 } 2286 2287 d = 14*time.Minute + 2*time.Second 2288 got = formatRateReset(d) 2289 want = "[rate reset in 14m02s]" 2290 if got != want { 2291 t.Errorf("Format is wrong. got: %v, want: %v", got, want) 2292 } 2293 2294 d = 2*time.Minute + 2*time.Second 2295 got = formatRateReset(d) 2296 want = "[rate reset in 2m02s]" 2297 if got != want { 2298 t.Errorf("Format is wrong. got: %v, want: %v", got, want) 2299 } 2300 2301 d = 12 * time.Second 2302 got = formatRateReset(d) 2303 want = "[rate reset in 12s]" 2304 if got != want { 2305 t.Errorf("Format is wrong. got: %v, want: %v", got, want) 2306 } 2307 2308 d = -1 * (2*time.Hour + 2*time.Second) 2309 got = formatRateReset(d) 2310 want = "[rate limit was reset 120m02s ago]" 2311 if got != want { 2312 t.Errorf("Format is wrong. got: %v, want: %v", got, want) 2313 } 2314 } 2315 2316 func TestNestedStructAccessorNoPanic(t *testing.T) { 2317 issue := &Issue{User: nil} 2318 got := issue.GetUser().GetPlan().GetName() 2319 want := "" 2320 if got != want { 2321 t.Errorf("Issues.Get.GetUser().GetPlan().GetName() returned %+v, want %+v", got, want) 2322 } 2323 } 2324 2325 func TestTwoFactorAuthError(t *testing.T) { 2326 u, err := url.Parse("https://example.com") 2327 if err != nil { 2328 t.Fatal(err) 2329 } 2330 2331 e := &TwoFactorAuthError{ 2332 Response: &http.Response{ 2333 Request: &http.Request{Method: "PUT", URL: u}, 2334 StatusCode: http.StatusTooManyRequests, 2335 }, 2336 Message: "<msg>", 2337 } 2338 if got, want := e.Error(), "PUT https://example.com: 429 <msg> []"; got != want { 2339 t.Errorf("TwoFactorAuthError = %q, want %q", got, want) 2340 } 2341 } 2342 2343 func TestRateLimitError(t *testing.T) { 2344 u, err := url.Parse("https://example.com") 2345 if err != nil { 2346 t.Fatal(err) 2347 } 2348 2349 r := &RateLimitError{ 2350 Response: &http.Response{ 2351 Request: &http.Request{Method: "PUT", URL: u}, 2352 StatusCode: http.StatusTooManyRequests, 2353 }, 2354 Message: "<msg>", 2355 } 2356 if got, want := r.Error(), "PUT https://example.com: 429 <msg> [rate limit was reset"; !strings.Contains(got, want) { 2357 t.Errorf("RateLimitError = %q, want %q", got, want) 2358 } 2359 } 2360 2361 func TestAcceptedError(t *testing.T) { 2362 a := &AcceptedError{} 2363 if got, want := a.Error(), "try again later"; !strings.Contains(got, want) { 2364 t.Errorf("AcceptedError = %q, want %q", got, want) 2365 } 2366 } 2367 2368 func TestAbuseRateLimitError(t *testing.T) { 2369 u, err := url.Parse("https://example.com") 2370 if err != nil { 2371 t.Fatal(err) 2372 } 2373 2374 r := &AbuseRateLimitError{ 2375 Response: &http.Response{ 2376 Request: &http.Request{Method: "PUT", URL: u}, 2377 StatusCode: http.StatusTooManyRequests, 2378 }, 2379 Message: "<msg>", 2380 } 2381 if got, want := r.Error(), "PUT https://example.com: 429 <msg>"; got != want { 2382 t.Errorf("AbuseRateLimitError = %q, want %q", got, want) 2383 } 2384 } 2385 2386 func TestAddOptions_QueryValues(t *testing.T) { 2387 if _, err := addOptions("yo", ""); err == nil { 2388 t.Error("addOptions err = nil, want error") 2389 } 2390 } 2391 2392 func TestBareDo_returnsOpenBody(t *testing.T) { 2393 client, mux, _, teardown := setup() 2394 defer teardown() 2395 2396 expectedBody := "Hello from the other side !" 2397 2398 mux.HandleFunc("/test-url", func(w http.ResponseWriter, r *http.Request) { 2399 testMethod(t, r, "GET") 2400 fmt.Fprint(w, expectedBody) 2401 }) 2402 2403 ctx := context.Background() 2404 req, err := client.NewRequest("GET", "test-url", nil) 2405 if err != nil { 2406 t.Fatalf("client.NewRequest returned error: %v", err) 2407 } 2408 2409 resp, err := client.BareDo(ctx, req) 2410 if err != nil { 2411 t.Fatalf("client.BareDo returned error: %v", err) 2412 } 2413 2414 got, err := io.ReadAll(resp.Body) 2415 if err != nil { 2416 t.Fatalf("io.ReadAll returned error: %v", err) 2417 } 2418 if string(got) != expectedBody { 2419 t.Fatalf("Expected %q, got %q", expectedBody, string(got)) 2420 } 2421 if err := resp.Body.Close(); err != nil { 2422 t.Fatalf("resp.Body.Close() returned error: %v", err) 2423 } 2424 } 2425 2426 // roundTripperFunc creates a mock RoundTripper (transport) 2427 type roundTripperFunc func(*http.Request) (*http.Response, error) 2428 2429 func (fn roundTripperFunc) RoundTrip(r *http.Request) (*http.Response, error) { 2430 return fn(r) 2431 } 2432 2433 func TestErrorResponse_Marshal(t *testing.T) { 2434 testJSONMarshal(t, &ErrorResponse{}, "{}") 2435 2436 u := &ErrorResponse{ 2437 Message: "msg", 2438 Errors: []Error{ 2439 { 2440 Resource: "res", 2441 Field: "f", 2442 Code: "c", 2443 Message: "msg", 2444 }, 2445 }, 2446 Block: &ErrorBlock{ 2447 Reason: "reason", 2448 CreatedAt: &Timestamp{referenceTime}, 2449 }, 2450 DocumentationURL: "doc", 2451 } 2452 2453 want := `{ 2454 "message": "msg", 2455 "errors": [ 2456 { 2457 "resource": "res", 2458 "field": "f", 2459 "code": "c", 2460 "message": "msg" 2461 } 2462 ], 2463 "block": { 2464 "reason": "reason", 2465 "created_at": ` + referenceTimeStr + ` 2466 }, 2467 "documentation_url": "doc" 2468 }` 2469 2470 testJSONMarshal(t, u, want) 2471 } 2472 2473 func TestErrorBlock_Marshal(t *testing.T) { 2474 testJSONMarshal(t, &ErrorBlock{}, "{}") 2475 2476 u := &ErrorBlock{ 2477 Reason: "reason", 2478 CreatedAt: &Timestamp{referenceTime}, 2479 } 2480 2481 want := `{ 2482 "reason": "reason", 2483 "created_at": ` + referenceTimeStr + ` 2484 }` 2485 2486 testJSONMarshal(t, u, want) 2487 } 2488 2489 func TestRateLimitError_Marshal(t *testing.T) { 2490 testJSONMarshal(t, &RateLimitError{}, "{}") 2491 2492 u := &RateLimitError{ 2493 Rate: Rate{ 2494 Limit: 1, 2495 Remaining: 1, 2496 Reset: Timestamp{referenceTime}, 2497 }, 2498 Message: "msg", 2499 } 2500 2501 want := `{ 2502 "Rate": { 2503 "limit": 1, 2504 "remaining": 1, 2505 "reset": ` + referenceTimeStr + ` 2506 }, 2507 "message": "msg" 2508 }` 2509 2510 testJSONMarshal(t, u, want) 2511 } 2512 2513 func TestAbuseRateLimitError_Marshal(t *testing.T) { 2514 testJSONMarshal(t, &AbuseRateLimitError{}, "{}") 2515 2516 u := &AbuseRateLimitError{ 2517 Message: "msg", 2518 } 2519 2520 want := `{ 2521 "message": "msg" 2522 }` 2523 2524 testJSONMarshal(t, u, want) 2525 } 2526 2527 func TestError_Marshal(t *testing.T) { 2528 testJSONMarshal(t, &Error{}, "{}") 2529 2530 u := &Error{ 2531 Resource: "res", 2532 Field: "field", 2533 Code: "code", 2534 Message: "msg", 2535 } 2536 2537 want := `{ 2538 "resource": "res", 2539 "field": "field", 2540 "code": "code", 2541 "message": "msg" 2542 }` 2543 2544 testJSONMarshal(t, u, want) 2545 } 2546 2547 func TestRate_Marshal(t *testing.T) { 2548 testJSONMarshal(t, &Rate{}, "{}") 2549 2550 u := &Rate{ 2551 Limit: 1, 2552 Remaining: 1, 2553 Reset: Timestamp{referenceTime}, 2554 } 2555 2556 want := `{ 2557 "limit": 1, 2558 "remaining": 1, 2559 "reset": ` + referenceTimeStr + ` 2560 }` 2561 2562 testJSONMarshal(t, u, want) 2563 } 2564 2565 func TestRateLimits_Marshal(t *testing.T) { 2566 testJSONMarshal(t, &RateLimits{}, "{}") 2567 2568 u := &RateLimits{ 2569 Core: &Rate{ 2570 Limit: 1, 2571 Remaining: 1, 2572 Reset: Timestamp{referenceTime}, 2573 }, 2574 Search: &Rate{ 2575 Limit: 1, 2576 Remaining: 1, 2577 Reset: Timestamp{referenceTime}, 2578 }, 2579 GraphQL: &Rate{ 2580 Limit: 1, 2581 Remaining: 1, 2582 Reset: Timestamp{referenceTime}, 2583 }, 2584 IntegrationManifest: &Rate{ 2585 Limit: 1, 2586 Remaining: 1, 2587 Reset: Timestamp{referenceTime}, 2588 }, 2589 SourceImport: &Rate{ 2590 Limit: 1, 2591 Remaining: 1, 2592 Reset: Timestamp{referenceTime}, 2593 }, 2594 CodeScanningUpload: &Rate{ 2595 Limit: 1, 2596 Remaining: 1, 2597 Reset: Timestamp{referenceTime}, 2598 }, 2599 ActionsRunnerRegistration: &Rate{ 2600 Limit: 1, 2601 Remaining: 1, 2602 Reset: Timestamp{referenceTime}, 2603 }, 2604 SCIM: &Rate{ 2605 Limit: 1, 2606 Remaining: 1, 2607 Reset: Timestamp{referenceTime}, 2608 }, 2609 } 2610 2611 want := `{ 2612 "core": { 2613 "limit": 1, 2614 "remaining": 1, 2615 "reset": ` + referenceTimeStr + ` 2616 }, 2617 "search": { 2618 "limit": 1, 2619 "remaining": 1, 2620 "reset": ` + referenceTimeStr + ` 2621 }, 2622 "graphql": { 2623 "limit": 1, 2624 "remaining": 1, 2625 "reset": ` + referenceTimeStr + ` 2626 }, 2627 "integration_manifest": { 2628 "limit": 1, 2629 "remaining": 1, 2630 "reset": ` + referenceTimeStr + ` 2631 }, 2632 "source_import": { 2633 "limit": 1, 2634 "remaining": 1, 2635 "reset": ` + referenceTimeStr + ` 2636 }, 2637 "code_scanning_upload": { 2638 "limit": 1, 2639 "remaining": 1, 2640 "reset": ` + referenceTimeStr + ` 2641 }, 2642 "actions_runner_registration": { 2643 "limit": 1, 2644 "remaining": 1, 2645 "reset": ` + referenceTimeStr + ` 2646 }, 2647 "scim": { 2648 "limit": 1, 2649 "remaining": 1, 2650 "reset": ` + referenceTimeStr + ` 2651 } 2652 }` 2653 2654 testJSONMarshal(t, u, want) 2655 } 2656 2657 func TestParseTokenExpiration(t *testing.T) { 2658 tests := []struct { 2659 header string 2660 want Timestamp 2661 }{ 2662 { 2663 header: "", 2664 want: Timestamp{}, 2665 }, 2666 { 2667 header: "this is a garbage", 2668 want: Timestamp{}, 2669 }, 2670 { 2671 header: "2021-09-03 02:34:04 UTC", 2672 want: Timestamp{time.Date(2021, time.September, 3, 2, 34, 4, 0, time.UTC)}, 2673 }, 2674 } 2675 2676 for _, tt := range tests { 2677 res := &http.Response{ 2678 Request: &http.Request{}, 2679 Header: http.Header{}, 2680 } 2681 2682 res.Header.Set(headerTokenExpiration, tt.header) 2683 exp := parseTokenExpiration(res) 2684 if !exp.Equal(tt.want) { 2685 t.Errorf("parseTokenExpiration returned %#v, want %#v", exp, tt.want) 2686 } 2687 } 2688 }