github.com/googleapis/api-linter@v1.65.2/rules/aip0233/response_message_name_test.go (about)

     1  // Copyright 2019 Google LLC
     2  //
     3  // Licensed under the Apache License, Version 2.0 (the "License");
     4  // you may not use this file except in compliance with the License.
     5  // You may obtain a copy of the License at
     6  //
     7  //     https://www.apache.org/licenses/LICENSE-2.0
     8  //
     9  // Unless required by applicable law or agreed to in writing, software
    10  // distributed under the License is distributed on an "AS IS" BASIS,
    11  // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    12  // See the License for the specific language governing permissions and
    13  // limitations under the License.
    14  
    15  package aip0233
    16  
    17  import (
    18  	"testing"
    19  
    20  	"github.com/googleapis/api-linter/rules/internal/testutils"
    21  )
    22  
    23  func TestResponseMessageName(t *testing.T) {
    24  	// Set up the testing permutations.
    25  	tests := []struct {
    26  		testName   string
    27  		MethodName string
    28  		Response   string
    29  		problems   testutils.Problems
    30  	}{
    31  		{
    32  			testName:   "Valid-BatchCreateBooksResponse",
    33  			MethodName: "BatchCreateBooks",
    34  			Response:   "BatchCreateBooksResponse",
    35  			problems:   testutils.Problems{},
    36  		},
    37  		{
    38  			testName:   "Invalid-MissMatchingMethodName",
    39  			MethodName: "BatchCreateBooks",
    40  			Response:   "BatchCreateBookResponse",
    41  			problems: testutils.Problems{{
    42  				Suggestion: "BatchCreateBooksResponse",
    43  			}},
    44  		},
    45  		{
    46  			testName:   "Irrelevant",
    47  			MethodName: "CreateBook",
    48  			Response:   "Book",
    49  			problems:   testutils.Problems{},
    50  		},
    51  	}
    52  
    53  	// Run each test individually.
    54  	for _, test := range tests {
    55  		t.Run(test.testName, func(t *testing.T) {
    56  			file := testutils.ParseProto3Tmpl(t, `
    57  				import "google/api/annotations.proto";
    58  				
    59  				service BookService {
    60  					rpc {{.MethodName}}({{.MethodName}}Request) returns ({{.Response}}) {
    61  						option (google.api.http) = {
    62  							post: "/v1/{parent=publishers/*}/"
    63  							body: "*"
    64  						};
    65  					}
    66  				}
    67  				
    68  				message {{.MethodName}}Request {}
    69  				
    70  				message {{.Response}}{}
    71  				`, test)
    72  
    73  			m := file.GetServices()[0].GetMethods()[0]
    74  
    75  			problems := responseMessageName.Lint(file)
    76  			if diff := test.problems.SetDescriptor(m).Diff(problems); diff != "" {
    77  				t.Errorf(diff)
    78  			}
    79  		})
    80  	}
    81  }
    82  
    83  // Other cases for long running response will be handled by AIP-0151
    84  func TestLongRunningResponse(t *testing.T) {
    85  	// Set up the testing permutations.
    86  	tests := []struct {
    87  		testName     string
    88  		ResponseType string
    89  		problems     testutils.Problems
    90  	}{
    91  		{
    92  			testName:     "Valid-LongRunning",
    93  			ResponseType: "BatchCreateBooksResponse",
    94  			problems:     testutils.Problems{},
    95  		},
    96  		{
    97  			testName: "Valid-LongRunningEmptyResponseType",
    98  			problems: testutils.Problems{},
    99  		},
   100  	}
   101  
   102  	// Run each test individually.
   103  	for _, test := range tests {
   104  		t.Run(test.testName, func(t *testing.T) {
   105  			file := testutils.ParseProto3Tmpl(t, `
   106  				import "google/api/annotations.proto";
   107  				import "google/longrunning/operations.proto";
   108  				
   109  				service BookService {
   110  					rpc BatchCreateBooks(BatchCreateBooksRequest) returns (google.longrunning.Operation) {
   111  						option (google.api.http) = {
   112  							post: "/v1/{parent=publishers/*}/books:batchCreate"
   113  							body: "*"
   114  						};
   115  						option (google.longrunning.operation_info) = {
   116  							response_type: "{{.ResponseType}}"
   117  						};
   118  					}
   119  				}
   120  				
   121  				message BatchCreateBooksRequest {}
   122  				
   123  				message BatchCreateBooksResponse{}
   124  				`, test)
   125  
   126  			m := file.GetServices()[0].GetMethods()[0]
   127  
   128  			problems := responseMessageName.Lint(file)
   129  			if diff := test.problems.SetDescriptor(m).Diff(problems); diff != "" {
   130  				t.Errorf(diff)
   131  			}
   132  		})
   133  	}
   134  }