github.com/kchristidis/fabric@v1.0.4-0.20171028114726-837acd08cde1/docs/source/Gerrit/reviewing.rst (about)

     1  Reviewing a Change
     2  ==================
     3  
     4  1. Click on a link for incoming or outgoing review.
     5  
     6  2. The details of the change and its current status are loaded:
     7  
     8  -  **Status:** Displays the current status of the change. In the example
     9     below, the status reads: Needs Verified.
    10  
    11  -  **Reply:** Click on this button after reviewing to add a final review
    12     message and a score, -1, 0 or +1.
    13  
    14  -  **Patch Sets:** If multiple revisions of a patch exist, this button
    15     enables navigation among revisions to see the changes. By default,
    16     the most recent revision is presented.
    17  
    18  -  **Download:** This button brings up another window with multiple
    19     options to download or checkout the current changeset. The button on
    20     the right copies the line to your clipboard. You can easily paste it
    21     into your git interface to work with the patch as you prefer.
    22  
    23  Underneath the commit information, the files that have been changed by
    24  this patch are displayed.
    25  
    26  3. Click on a filename to review it. Select the code base to
    27     differentiate against. The default is ``Base`` and it will generally
    28     be what is needed.
    29  
    30  4. The review page presents the changes made to the file. At the top of
    31     the review, the presentation shows some general navigation options.
    32     Navigate through the patch set using the arrows on the top right
    33     corner. It is possible to go to the previous or next file in the set
    34     or to return to the main change screen. Click on the yellow sticky
    35     pad to add comments to the whole file.
    36  
    37  The focus of the page is on the comparison window. The changes made are
    38  presented in green on the right versus the base version on the left.
    39  Double click to highlight the text within the actual change to provide
    40  feedback on a specific section of the code. Press *c* once the code is
    41  highlighted to add comments to that section.
    42  
    43  5. After adding the comment, it is saved as a *Draft*.
    44  
    45  6. Once you have reviewed all files and provided feedback, click the
    46     *green up arrow* at the top right to return to the main change page.
    47     Click the ``Reply`` button, write some final comments, and submit
    48     your score for the patch set. Click ``Post`` to submit the review of
    49     each reviewed file, as well as your final comment and score. Gerrit
    50     sends an email to the change-submitter and all listed reviewers.
    51     Finally, it logs the review for future reference. All individual
    52     comments are saved as *Draft* until the ``Post`` button is clicked.
    53  
    54  .. Licensed under Creative Commons Attribution 4.0 International License
    55     https://creativecommons.org/licenses/by/4.0/
    56