github.com/keybase/client/go@v0.0.0-20241007131713-f10651d043c8/kbfs/kbfsmd/root_metadata_v2_test.go

// Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.

package kbfsmd

import (
	"context"
	"fmt"
	"sort"
	"testing"

	"github.com/keybase/client/go/externals"
	"github.com/keybase/client/go/kbfs/kbfscodec"
	"github.com/keybase/client/go/kbfs/kbfscrypto"
	"github.com/keybase/client/go/kbfs/tlf"
	"github.com/keybase/client/go/protocol/keybase1"
	"github.com/keybase/go-codec/codec"
	"github.com/stretchr/testify/require"
)

func TestRootMetadataVersionV2(t *testing.T) {
	tlfID := tlf.FakeID(1, tlf.Private)

	// Metadata objects with unresolved assertions should have
	// InitialExtraMetadataVer.

	uid := keybase1.MakeTestUID(1)
	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, []keybase1.SocialAssertion{{}},
		nil, nil)
	require.NoError(t, err)

	rmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	require.Equal(t, InitialExtraMetadataVer, rmd.Version())

	// All other folders should use PreExtraMetadataVer.
	bh2, err := tlf.MakeHandle([]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
	require.NoError(t, err)

	rmd2, err := MakeInitialRootMetadata(
		InitialExtraMetadataVer, tlfID, bh2)
	require.NoError(t, err)

	require.Equal(t, PreExtraMetadataVer, rmd2.Version())

	// ... including if unresolved assertions get resolved.

	rmd.SetUnresolvedWriters(nil)
	require.Equal(t, PreExtraMetadataVer, rmd.Version())
}

func TestRootMetadataHardcodedV2(t *testing.T) {
	tlfID := tlf.FakeID(1, tlf.Private)

	uid := keybase1.MakeTestUID(1)
	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
	require.NoError(t, err)

	brmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	// This should msgpack-encode as a uint8 (0xcc), and not an
	// int8 (0xd0).
	brmd.Revision = 128

	codec := kbfscodec.NewMsgpack()

	// This was generated by starting with []byte{} and copying
	// the data in the error message for the require.Equal below.
	expectedBuf := []byte{
		0x8d, 0xa3, 0x42, 0x49, 0x44, 0xc4,
		0x10, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa9, 0x44, 0x69,
		0x73, 0x6b, 0x55, 0x73, 0x61, 0x67, 0x65, 0x0, 0xa5,
		0x46, 0x6c, 0x61, 0x67, 0x73, 0x0, 0xa2, 0x49, 0x44,
		0xc4, 0x10, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x16, 0xb1, 0x4c,
		0x61, 0x73, 0x74, 0x4d, 0x6f, 0x64, 0x69, 0x66, 0x79,
		0x69, 0x6e, 0x67, 0x55, 0x73, 0x65, 0x72, 0xa0, 0xb3,
		0x4c, 0x61, 0x73, 0x74, 0x4d, 0x6f, 0x64, 0x69, 0x66,
		0x79, 0x69, 0x6e, 0x67, 0x57, 0x72, 0x69, 0x74, 0x65,
		0x72, 0xa0, 0xa8, 0x50, 0x72, 0x65, 0x76, 0x52, 0x6f,
		0x6f, 0x74, 0xc0, 0xa8, 0x52, 0x65, 0x66, 0x42, 0x79,
		0x74, 0x65, 0x73, 0x0, 0xa8, 0x52, 0x65, 0x76, 0x69,
		0x73, 0x69, 0x6f, 0x6e, 0xcc, 0x80, 0xaa, 0x55, 0x6e,
		0x72, 0x65, 0x66, 0x42, 0x79, 0x74, 0x65, 0x73, 0x0,
		0xa6, 0x57, 0x46, 0x6c, 0x61, 0x67, 0x73, 0x0, 0xb5,
		0x57, 0x72, 0x69, 0x74, 0x65, 0x72, 0x4d, 0x65, 0x74,
		0x61, 0x64, 0x61, 0x74, 0x61, 0x53, 0x69, 0x67, 0x49,
		0x6e, 0x66, 0x6f, 0x83, 0xa1, 0x6b, 0xc0, 0xa1, 0x73,
		0xc0, 0xa1, 0x76, 0x0, 0xa4, 0x64, 0x61, 0x74, 0x61,
		0xc0,
	}

	buf, err := codec.Encode(brmd)
	require.NoError(t, err)
	require.Equal(t, expectedBuf, buf)
}

func TestWriterMetadataV2Empty(t *testing.T) {
	codec := kbfscodec.NewMsgpack()

	wmd := WriterMetadataV2{
		ID: tlf.FakeID(1, tlf.Public),
	}
	buf, err := codec.Encode(wmd)
	require.NoError(t, err)
	// Expected length derived by running with a known good
	// codec. If the length is greater, something might be broken
	// with omitempty with the Extra struct field.
	require.Equal(t, 112, len(buf))
}

// Test that old encoded WriterMetadataV2 objects (i.e., without any
// extra fields) can be deserialized and serialized to the same form,
// which is important for RootMetadataV2.IsValidAndSigned().
func testWriterMetadataV2UnchangedEncoding(t *testing.T, ver MetadataVer) {
	encodedWm := []byte{
		0x89, 0xa3, 0x42, 0x49, 0x44, 0xc4, 0x10, 0x0,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa9,
		0x44, 0x69, 0x73, 0x6b, 0x55, 0x73, 0x61, 0x67,
		0x65, 0x64, 0xa2, 0x49, 0x44, 0xc4, 0x10, 0x1,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
		0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x16, 0xb3,
		0x4c, 0x61, 0x73, 0x74, 0x4d, 0x6f, 0x64, 0x69,
		0x66, 0x79, 0x69, 0x6e, 0x67, 0x57, 0x72, 0x69,
		0x74, 0x65, 0x72, 0xa4, 0x75, 0x69, 0x64, 0x31,
		0xa8, 0x52, 0x65, 0x66, 0x42, 0x79, 0x74, 0x65,
		0x73, 0x63, 0xaa, 0x55, 0x6e, 0x72, 0x65, 0x66,
		0x42, 0x79, 0x74, 0x65, 0x73, 0x65, 0xa6, 0x57,
		0x46, 0x6c, 0x61, 0x67, 0x73, 0xa, 0xa7, 0x57,
		0x72, 0x69, 0x74, 0x65, 0x72, 0x73, 0x92, 0xa4,
		0x75, 0x69, 0x64, 0x31, 0xa4, 0x75, 0x69, 0x64,
		0x32, 0xa4, 0x64, 0x61, 0x74, 0x61, 0xc4, 0x2,
		0xa, 0xb,
	}

	expectedWm := WriterMetadataV2{
		SerializedPrivateMetadata: []byte{0xa, 0xb},
		LastModifyingWriter:       "uid1",
		Writers:                   []keybase1.UserOrTeamID{"uid1", "uid2"},
		ID:                        tlf.FakeID(1, tlf.Private),
		BID:                       NullBranchID,
		WFlags:                    0xa,
		DiskUsage:                 100,
		RefBytes:                  99,
		UnrefBytes:                101,
	}

	c := kbfscodec.NewMsgpack()

	var wm WriterMetadataV2
	err := c.Decode(encodedWm, &wm)
	require.NoError(t, err)

	require.Equal(t, expectedWm, wm)

	buf, err := c.Encode(wm)
	require.NoError(t, err)
	require.Equal(t, encodedWm, buf)
}

func TestWriterMetadataV2UnchangedEncoding(t *testing.T) {
	runTestOverMetadataVers(t, testWriterMetadataV2UnchangedEncoding)
}

// Test that WriterMetadataV2 has only a fixed (frozen) set of fields.
func TestWriterMetadataV2EncodedFields(t *testing.T) {
	sa1, _ := externals.NormalizeSocialAssertionStatic(context.Background(), "uid1@twitter")
	sa2, _ := externals.NormalizeSocialAssertionStatic(context.Background(), "uid2@twitter")
	// Usually exactly one of Writers/WKeys is filled in, but we
	// fill in both here for testing.
	wm := WriterMetadataV2{
		ID:      tlf.FakeID(0xa, tlf.Private),
		Writers: []keybase1.UserOrTeamID{"uid1", "uid2"},
		WKeys:   TLFWriterKeyGenerationsV2{{}},
		Extra: WriterMetadataExtraV2{
			UnresolvedWriters: []keybase1.SocialAssertion{sa1, sa2},
		},
	}

	c := kbfscodec.NewMsgpack()

	buf, err := c.Encode(wm)
	require.NoError(t, err)

	var m map[string]interface{}
	err = c.Decode(buf, &m)
	require.NoError(t, err)

	expectedFields := []string{
		"BID",
		"DiskUsage",
		"ID",
		"LastModifyingWriter",
		"RefBytes",
		"UnrefBytes",
		"WFlags",
		"WKeys",
		"Writers",
		"data",
		"x",
	}

	var fields []string
	for field := range m {
		fields = append(fields, field)
	}
	sort.Strings(fields)
	require.Equal(t, expectedFields, fields)
}

type writerMetadataExtraV2Future struct {
	WriterMetadataExtraV2
	kbfscodec.Extra
}

func (wmef writerMetadataExtraV2Future) toCurrent() WriterMetadataExtraV2 {
	return wmef.WriterMetadataExtraV2
}

type tlfWriterKeyGenerationsV2Future []*tlfWriterKeyBundleV2Future

func (wkgf tlfWriterKeyGenerationsV2Future) toCurrent() TLFWriterKeyGenerationsV2 {
	wkg := make(TLFWriterKeyGenerationsV2, len(wkgf))
	for i, wkbf := range wkgf {
		wkb := wkbf.toCurrent()
		wkg[i] = wkb
	}
	return wkg
}

type writerMetadataV2Future struct {
	WriterMetadataV2
	// Override WriterMetadata.WKeys.
	WKeys tlfWriterKeyGenerationsV2Future
	// Override WriterMetadata.Extra.
	//
	// TODO: Remove omitempty and omitemptycheckstruct once we use
	// a version of go-codec that supports omitemptyrecursive.
	Extra writerMetadataExtraV2Future `codec:"x,omitemptyrecursive,omitempty,omitemptycheckstruct"`
}

func (wmf writerMetadataV2Future) toCurrent() WriterMetadataV2 {
	wm := wmf.WriterMetadataV2
	wm.WKeys = wmf.WKeys.toCurrent()
	wm.Extra = wmf.Extra.toCurrent()
	return wm
}

func (wmf writerMetadataV2Future) ToCurrentStruct() kbfscodec.CurrentStruct {
	return wmf.toCurrent()
}

func makeFakeWriterMetadataV2Future(t *testing.T) writerMetadataV2Future {
	wmd := WriterMetadataV2{
		// This needs to be list format so it fails to compile if new fields
		// are added, effectively checking at compile time whether new fields
		// have been added
		[]byte{0xa, 0xb},
		"uid1",
		[]keybase1.UserOrTeamID{"uid1", "uid2"},
		nil,
		tlf.FakeID(1, tlf.Private),
		NullBranchID,
		0xa,
		100,
		0,
		99,
		101,
		0,
		WriterMetadataExtraV2{},
	}
	wkb := makeFakeTLFWriterKeyBundleV2Future(t)
	sa, _ := externals.NormalizeSocialAssertionStatic(context.Background(), "foo@twitter")
	return writerMetadataV2Future{
		wmd,
		tlfWriterKeyGenerationsV2Future{&wkb},
		writerMetadataExtraV2Future{
			WriterMetadataExtraV2{
				// This needs to be list format so it fails to compile if new
				// fields are added, effectively checking at compile time
				// whether new fields have been added
				[]keybase1.SocialAssertion{sa},
				codec.UnknownFieldSetHandler{},
			},
			kbfscodec.MakeExtraOrBust("WriterMetadata", t),
		},
	}
}

func TestWriterMetadataV2UnknownFields(t *testing.T) {
	testStructUnknownFields(t, makeFakeWriterMetadataV2Future(t))
}

type tlfReaderKeyGenerationsV2Future []*tlfReaderKeyBundleV2Future

func (rkgf tlfReaderKeyGenerationsV2Future) toCurrent() TLFReaderKeyGenerationsV2 {
	rkg := make(TLFReaderKeyGenerationsV2, len(rkgf))
	for i, rkbf := range rkgf {
		rkb := rkbf.toCurrent()
		rkg[i] = rkb
	}
	return rkg
}

// rootMetadataWrapper exists only to add extra depth to fields
// in RootMetadata, so that they may be overridden in
// rootMetadataV2Future.
type rootMetadataWrapper struct {
	RootMetadataV2
}

type rootMetadataV2Future struct {
	// Override RootMetadata.WriterMetadata. Put it first to work
	// around a bug in codec's field lookup code.
	//
	// TODO: Report and fix this bug upstream.
	writerMetadataV2Future

	rootMetadataWrapper
	// Override RootMetadata.RKeys.
	RKeys tlfReaderKeyGenerationsV2Future `codec:",omitempty"`
	kbfscodec.Extra
}

func (brmf *rootMetadataV2Future) toCurrent() RootMetadata {
	rm := brmf.rootMetadataWrapper.RootMetadataV2
	rm.WriterMetadataV2 = brmf.writerMetadataV2Future.toCurrent()
	rm.RKeys = brmf.RKeys.toCurrent()
	return &rm
}

func (brmf *rootMetadataV2Future) ToCurrentStruct() kbfscodec.CurrentStruct {
	return brmf.toCurrent()
}

func makeFakeRootMetadataV2Future(t *testing.T) *rootMetadataV2Future {
	wmf := makeFakeWriterMetadataV2Future(t)
	rkb := makeFakeTLFReaderKeyBundleV2Future(t)
	sa, _ := externals.NormalizeSocialAssertionStatic(context.Background(), "bar@github")
	rmf := rootMetadataV2Future{
		wmf,
		rootMetadataWrapper{
			RootMetadataV2{
				// This needs to be list format so it
				// fails to compile if new fields are
				// added, effectively checking at
				// compile time whether new fields
				// have been added
				WriterMetadataV2{},
				kbfscrypto.SignatureInfo{
					Version:      100,
					Signature:    []byte{0xc},
					VerifyingKey: kbfscrypto.MakeFakeVerifyingKeyOrBust("fake kid"),
				},
				"uid1",
				0xb,
				5,
				FakeID(1),
				nil,
				[]keybase1.SocialAssertion{sa},
				nil,
				nil,
				codec.UnknownFieldSetHandler{},
			},
		},
		[]*tlfReaderKeyBundleV2Future{&rkb},
		kbfscodec.MakeExtraOrBust("RootMetadata", t),
	}
	return &rmf
}

func TestRootMetadataV2UnknownFields(t *testing.T) {
	testStructUnknownFields(t, makeFakeRootMetadataV2Future(t))
}

func TestIsValidRekeyRequestBasicV2(t *testing.T) {
	tlfID := tlf.FakeID(1, tlf.Private)

	uid := keybase1.MakeTestUID(1)
	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
	require.NoError(t, err)

	brmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	ctx := context.Background()
	codec := kbfscodec.NewMsgpack()
	signer := kbfscrypto.SigningKeySigner{
		Key: kbfscrypto.MakeFakeSigningKeyOrBust("key1"),
	}

	err = brmd.SignWriterMetadataInternally(ctx, codec, signer)
	require.NoError(t, err)

	newBrmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)
	ok, err := newBrmd.IsValidRekeyRequest(
		codec, brmd, newBrmd.LastModifyingWriter(), nil, nil)
	require.NoError(t, err)
	// Should fail because the copy bit is unset.
	require.False(t, ok)

	// Set the copy bit; note the writer metadata is the same.
	newBrmd.SetWriterMetadataCopiedBit()

	signer2 := kbfscrypto.SigningKeySigner{
		Key: kbfscrypto.MakeFakeSigningKeyOrBust("key2"),
	}

	err = newBrmd.SignWriterMetadataInternally(ctx, codec, signer2)
	require.NoError(t, err)

	ok, err = newBrmd.IsValidRekeyRequest(
		codec, brmd, newBrmd.LastModifyingWriter(), nil, nil)
	require.NoError(t, err)
	// Should fail because of mismatched writer metadata siginfo.
	require.False(t, ok)

	// Re-sign to get the same signature.
	err = newBrmd.SignWriterMetadataInternally(ctx, codec, signer)
	require.NoError(t, err)
	ok, err = newBrmd.IsValidRekeyRequest(
		codec, brmd, newBrmd.LastModifyingWriter(), nil, nil)
	require.NoError(t, err)
	require.True(t, ok)
}

func TestRevokeRemovedDevicesV2(t *testing.T) {
	uid1 := keybase1.MakeTestUID(0x1)
	uid2 := keybase1.MakeTestUID(0x2)
	uid3 := keybase1.MakeTestUID(0x3)

	key1 := kbfscrypto.MakeFakeCryptPublicKeyOrBust("key1")
	key2 := kbfscrypto.MakeFakeCryptPublicKeyOrBust("key2")
	key3 := kbfscrypto.MakeFakeCryptPublicKeyOrBust("key3")

	half1a := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x1})
	half1b := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x2})
	half2a := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x3})
	half2b := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x4})
	half3a := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x5})
	half3b := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x6})

	id1a, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid1, key1, half1a)
	require.NoError(t, err)
	id1b, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid1, key1, half1b)
	require.NoError(t, err)
	id2a, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid2, key2, half2a)
	require.NoError(t, err)
	id2b, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid2, key2, half2b)
	require.NoError(t, err)
	id3a, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid3, key3, half3a)
	require.NoError(t, err)
	id3b, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid3, key3, half3b)
	require.NoError(t, err)

	tlfID := tlf.FakeID(1, tlf.Private)

	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid1.AsUserOrTeam(), uid2.AsUserOrTeam()},
		[]keybase1.UserOrTeamID{uid3.AsUserOrTeam()}, nil, nil, nil)
	require.NoError(t, err)

	brmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	brmd.WKeys = TLFWriterKeyGenerationsV2{
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{
					key1.KID(): TLFCryptKeyInfo{
						ServerHalfID: id1a,
						EPubKeyIndex: 0,
					},
				},
				uid2: DeviceKeyInfoMapV2{
					key2.KID(): TLFCryptKeyInfo{
						ServerHalfID: id2a,
						EPubKeyIndex: 1,
					},
				},
			},
		},
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{
					key1.KID(): TLFCryptKeyInfo{
						ServerHalfID: id1b,
						EPubKeyIndex: 0,
					},
				},
				uid2: DeviceKeyInfoMapV2{
					key2.KID(): TLFCryptKeyInfo{
						ServerHalfID: id2b,
						EPubKeyIndex: 0,
					},
				},
			},
		},
	}

	brmd.RKeys = TLFReaderKeyGenerationsV2{
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{
					key3.KID(): TLFCryptKeyInfo{
						ServerHalfID: id3a,
						EPubKeyIndex: 0,
					},
				},
			},
		},
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{
					key3.KID(): TLFCryptKeyInfo{
						ServerHalfID: id3b,
						EPubKeyIndex: 0,
					},
				},
			},
		},
	}

	updatedWriterKeys := UserDevicePublicKeys{
		uid1: {key1: true},
	}
	updatedReaderKeys := UserDevicePublicKeys{
		uid3: {key3: true},
	}

	removalInfo, err := brmd.RevokeRemovedDevices(
		updatedWriterKeys, updatedReaderKeys, nil)
	require.NoError(t, err)
	require.Equal(t, ServerHalfRemovalInfo{
		uid2: UserServerHalfRemovalInfo{
			UserRemoved: true,
			DeviceServerHalfIDs: DeviceServerHalfRemovalInfo{
				key2: []kbfscrypto.TLFCryptKeyServerHalfID{id2a, id2b},
			},
		},
	}, removalInfo)

	expectedWKeys := TLFWriterKeyGenerationsV2{
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{
					key1.KID(): TLFCryptKeyInfo{
						ServerHalfID: id1a,
						EPubKeyIndex: 0,
					},
				},
			},
		},
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{
					key1.KID(): TLFCryptKeyInfo{
						ServerHalfID: id1b,
						EPubKeyIndex: 0,
					},
				},
			},
		},
	}
	require.Equal(t, expectedWKeys, brmd.WKeys)

	expectedRKeys := TLFReaderKeyGenerationsV2{
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{
					key3.KID(): TLFCryptKeyInfo{
						ServerHalfID: id3a,
						EPubKeyIndex: 0,
					},
				},
			},
		},
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{
					key3.KID(): TLFCryptKeyInfo{
						ServerHalfID: id3b,
						EPubKeyIndex: 0,
					},
				},
			},
		},
	}
	require.Equal(t, expectedRKeys, brmd.RKeys)
}

// TestRevokeLastDeviceV2 checks behavior of RevokeRemovedDevices with
// respect to removing the last device of a user vs. removing the user
// completely.
func TestRevokeLastDeviceV2(t *testing.T) {
	uid1 := keybase1.MakeTestUID(0x1)
	uid2 := keybase1.MakeTestUID(0x2)
	uid3 := keybase1.MakeTestUID(0x3)
	uid4 := keybase1.MakeTestUID(0x4)

	key1 := kbfscrypto.MakeFakeCryptPublicKeyOrBust("key1")
	key2 := kbfscrypto.MakeFakeCryptPublicKeyOrBust("key2")

	half1 := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x1})
	half2 := kbfscrypto.MakeTLFCryptKeyServerHalf([32]byte{0x2})

	id1, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid1, key1, half1)
	require.NoError(t, err)
	id2, err := kbfscrypto.MakeTLFCryptKeyServerHalfID(uid2, key2, half2)
	require.NoError(t, err)

	tlfID := tlf.FakeID(1, tlf.Private)

	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid1.AsUserOrTeam(), uid2.AsUserOrTeam()},
		[]keybase1.UserOrTeamID{uid3.AsUserOrTeam(), uid4.AsUserOrTeam()},
		nil, nil, nil)
	require.NoError(t, err)

	brmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	brmd.WKeys = TLFWriterKeyGenerationsV2{
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{
					key1.KID(): TLFCryptKeyInfo{
						ServerHalfID: id1,
						EPubKeyIndex: 0,
					},
				},
				uid2: DeviceKeyInfoMapV2{
					key2.KID(): TLFCryptKeyInfo{
						ServerHalfID: id2,
						EPubKeyIndex: 1,
					},
				},
			},
		},
	}

	brmd.RKeys = TLFReaderKeyGenerationsV2{
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{},
				uid4: DeviceKeyInfoMapV2{},
			},
		},
	}

	updatedWriterKeys := UserDevicePublicKeys{
		uid1: {},
	}
	updatedReaderKeys := UserDevicePublicKeys{
		uid3: {},
	}

	removalInfo, err := brmd.RevokeRemovedDevices(
		updatedWriterKeys, updatedReaderKeys, nil)
	require.NoError(t, err)
	require.Equal(t, ServerHalfRemovalInfo{
		uid1: UserServerHalfRemovalInfo{
			DeviceServerHalfIDs: DeviceServerHalfRemovalInfo{
				key1: []kbfscrypto.TLFCryptKeyServerHalfID{id1},
			},
		},
		uid2: UserServerHalfRemovalInfo{
			UserRemoved: true,
			DeviceServerHalfIDs: DeviceServerHalfRemovalInfo{
				key2: []kbfscrypto.TLFCryptKeyServerHalfID{id2},
			},
		},
		uid4: UserServerHalfRemovalInfo{
			UserRemoved:         true,
			DeviceServerHalfIDs: DeviceServerHalfRemovalInfo{},
		},
	}, removalInfo)

	expectedWKeys := TLFWriterKeyGenerationsV2{
		TLFWriterKeyBundleV2{
			WKeys: UserDeviceKeyInfoMapV2{
				uid1: DeviceKeyInfoMapV2{},
			},
		},
	}
	require.Equal(t, expectedWKeys, brmd.WKeys)

	expectedRKeys := TLFReaderKeyGenerationsV2{
		TLFReaderKeyBundleV2{
			RKeys: UserDeviceKeyInfoMapV2{
				uid3: DeviceKeyInfoMapV2{},
			},
		},
	}
	require.Equal(t, expectedRKeys, brmd.RKeys)
}

// userDevicePrivateKeys is a map from users to that user's set of
// device private keys.
type userDevicePrivateKeys map[keybase1.UID]map[kbfscrypto.CryptPrivateKey]bool

func (udpk userDevicePrivateKeys) hasKeys() bool {
	for _, privKeys := range udpk {
		if len(privKeys) > 0 {
			return true
		}
	}
	return false
}

func (udpk userDevicePrivateKeys) toPublicKeys() UserDevicePublicKeys {
	pubKeys := make(UserDevicePublicKeys)
	for uid, privKeys := range udpk {
		pubKeys[uid] = make(DevicePublicKeys)
		for privKey := range privKeys {
			pubKey := privKey.GetPublicKey()
			pubKeys[uid][pubKey] = true
		}
	}
	return pubKeys
}

// expectedRekeyInfoV2 contains all the information needed to check a
// call to UpdateKeyBundles.
//
// If both writerPrivKeys and readerPrivKeys are empty, then
// ePubKeyIndex and ePubKey are ignored.
type expectedRekeyInfoV2 struct {
	writerPrivKeys, readerPrivKeys userDevicePrivateKeys
	serverHalves                   []UserDeviceKeyServerHalves
	ePubKeyIndex                   int
	ePubKey                        kbfscrypto.TLFEphemeralPublicKey
}

func checkCryptKeyInfo(t *testing.T, privKey kbfscrypto.CryptPrivateKey,
	serverHalf kbfscrypto.TLFCryptKeyServerHalf, expectedEPubKeyIndex int,
	expectedEPubKey kbfscrypto.TLFEphemeralPublicKey,
	expectedTLFCryptKey kbfscrypto.TLFCryptKey, info TLFCryptKeyInfo,
	ePubKey kbfscrypto.TLFEphemeralPublicKey) {
	require.Equal(t, expectedEPubKeyIndex, info.EPubKeyIndex)
	require.Equal(t, expectedEPubKey, ePubKey)

	clientHalf, err := kbfscrypto.DecryptTLFCryptKeyClientHalf(
		privKey, ePubKey, info.ClientHalf)
	require.NoError(t, err)

	tlfCryptKey := kbfscrypto.UnmaskTLFCryptKey(serverHalf, clientHalf)
	require.Equal(t, expectedTLFCryptKey, tlfCryptKey)
}

// checkGetTLFCryptKeyV2 checks that wkb and rkb (for the given
// KeyGen) contain the info necessary to get the TLF crypt key for
// each user in expected, which must all match expectedTLFCryptKey.
func checkGetTLFCryptKeyV2(t *testing.T, keyGen KeyGen,
	expected expectedRekeyInfoV2,
	expectedTLFCryptKey kbfscrypto.TLFCryptKey,
	wkb *TLFWriterKeyBundleV2, rkb *TLFReaderKeyBundleV2) {
	expectedServerHalves := expected.serverHalves[keyGen-FirstValidKeyGen]
	for uid, privKeys := range expected.writerPrivKeys {
		for privKey := range privKeys {
			pubKey := privKey.GetPublicKey()
			serverHalf, ok := expectedServerHalves[uid][pubKey]
			require.True(t, ok, "writer uid=%s, key=%s",
				uid, pubKey)

			info, ok := wkb.WKeys[uid][pubKey.KID()]
			require.True(t, ok)

			ePubKey := wkb.TLFEphemeralPublicKeys[info.EPubKeyIndex]

			checkCryptKeyInfo(t, privKey, serverHalf,
				expected.ePubKeyIndex, expected.ePubKey,
				expectedTLFCryptKey, info, ePubKey)
		}
	}

	for uid, privKeys := range expected.readerPrivKeys {
		for privKey := range privKeys {
			pubKey := privKey.GetPublicKey()
			serverHalf, ok := expectedServerHalves[uid][pubKey]
			require.True(t, ok, "reader uid=%s, key=%s",
				uid, pubKey)

			info, ok := rkb.RKeys[uid][pubKey.KID()]
			require.True(t, ok)

			_, _, ePubKey, err := GetEphemeralPublicKeyInfoV2(
				info, *wkb, *rkb)
			require.NoError(t, err)

			checkCryptKeyInfo(t, privKey, serverHalf,
				expected.ePubKeyIndex, expected.ePubKey,
				expectedTLFCryptKey, info, ePubKey)
		}
	}
}

// accumulatePublicKeys returns the union of each user's keys in
// pubKeys1 and pubKeys2. A user's keys in pubKeys1 and pubKeys2 must
// be disjoint.
func accumulatePublicKeys(
	pubKeys1, pubKeys2 UserDevicePublicKeys) UserDevicePublicKeys {
	pubKeys := make(UserDevicePublicKeys)
	for uid, keys := range pubKeys1 {
		pubKeys[uid] = make(DevicePublicKeys)
		for key := range keys {
			pubKeys[uid][key] = true
		}
	}
	for uid, keys := range pubKeys2 {
		if pubKeys[uid] == nil {
			pubKeys[uid] = make(DevicePublicKeys)
		}
		for key := range keys {
			if pubKeys[uid][key] {
				panic(fmt.Sprintf(
					"uid=%s key=%s exists in both",
					uid, key))
			}
			pubKeys[uid][key] = true
		}
	}
	return pubKeys
}

// unionPublicKeyUsers returns the union of the usersin pubKeys1 and
// pubKeys2, which must be disjoint. Not a deep copy.
func unionPublicKeyUsers(
	pubKeys1, pubKeys2 UserDevicePublicKeys) UserDevicePublicKeys {
	pubKeys := make(UserDevicePublicKeys)
	for uid, keys := range pubKeys1 {
		pubKeys[uid] = keys
	}
	for uid, keys := range pubKeys2 {
		if pubKeys[uid] != nil {
			panic(fmt.Sprintf("uid=%s exists in both", uid))
		}
		pubKeys[uid] = keys
	}
	return pubKeys
}

func userDeviceKeyInfoMapV2ToPublicKeys(
	udkimV2 UserDeviceKeyInfoMapV2) UserDevicePublicKeys {
	pubKeys := make(UserDevicePublicKeys)
	for uid, dkimV2 := range udkimV2 {
		pubKeys[uid] = make(DevicePublicKeys)
		for kid := range dkimV2 {
			pubKeys[uid][kbfscrypto.MakeCryptPublicKey(kid)] = true
		}
	}
	return pubKeys
}

func userDeviceServerHalvesToPublicKeys(
	serverHalves UserDeviceKeyServerHalves) UserDevicePublicKeys {
	pubKeys := make(UserDevicePublicKeys)
	for uid, keys := range serverHalves {
		pubKeys[uid] = make(DevicePublicKeys)
		for key := range keys {
			pubKeys[uid][key] = true
		}
	}
	return pubKeys
}

// checkKeyBundlesV2 checks that rmd's key bundles contain exactly the
// info expected from expectedRekeyInfos and expectedPubKey.
func checkKeyBundlesV2(t *testing.T, expectedRekeyInfos []expectedRekeyInfoV2,
	expectedTLFCryptKeys []kbfscrypto.TLFCryptKey,
	expectedPubKeys []kbfscrypto.TLFPublicKey, rmd *RootMetadataV2) {
	require.Equal(t, len(expectedTLFCryptKeys), len(expectedPubKeys))
	require.Equal(t, len(expectedTLFCryptKeys),
		int(rmd.LatestKeyGeneration()-FirstValidKeyGen+1))
	for keyGen := FirstValidKeyGen; keyGen <= rmd.LatestKeyGeneration(); keyGen++ {
		wkb, rkb, err := rmd.getTLFKeyBundles(keyGen)
		require.NoError(t, err)

		expectedWriterPubKeys := make(UserDevicePublicKeys)
		expectedReaderPubKeys := make(UserDevicePublicKeys)
		var expectedWriterEPublicKeys,
			expectedReaderEPublicKeys kbfscrypto.TLFEphemeralPublicKeys
		for _, expected := range expectedRekeyInfos {
			expectedWriterPubKeys = accumulatePublicKeys(
				expectedWriterPubKeys,
				expected.writerPrivKeys.toPublicKeys())
			expectedReaderPubKeys = accumulatePublicKeys(
				expectedReaderPubKeys,
				expected.readerPrivKeys.toPublicKeys())
			if expected.writerPrivKeys.hasKeys() ||
				expected.readerPrivKeys.hasKeys() {
				if expected.ePubKeyIndex >= 0 {
					require.Equal(t, expected.ePubKeyIndex,
						len(expectedWriterEPublicKeys))
					expectedWriterEPublicKeys = append(
						expectedWriterEPublicKeys,
						expected.ePubKey)
				} else {
					i := -1 - expected.ePubKeyIndex
					require.Equal(t, i,
						len(expectedReaderEPublicKeys))
					expectedReaderEPublicKeys = append(
						expectedReaderEPublicKeys,
						expected.ePubKey)
				}
			}
		}

		writerPubKeys := userDeviceKeyInfoMapV2ToPublicKeys(wkb.WKeys)
		readerPubKeys := userDeviceKeyInfoMapV2ToPublicKeys(rkb.RKeys)

		require.Equal(t, expectedWriterPubKeys, writerPubKeys)
		require.Equal(t, expectedReaderPubKeys, readerPubKeys)

		require.Equal(t, expectedWriterEPublicKeys,
			wkb.TLFEphemeralPublicKeys)
		require.Equal(t, expectedReaderEPublicKeys,
			rkb.TLFReaderEphemeralPublicKeys)

		require.Equal(t, expectedPubKeys[keyGen-FirstValidKeyGen],
			wkb.TLFPublicKey)

		for _, expected := range expectedRekeyInfos {
			require.Equal(t, len(expectedTLFCryptKeys),
				len(expected.serverHalves))
			expectedUserPubKeys := unionPublicKeyUsers(
				expected.writerPrivKeys.toPublicKeys(),
				expected.readerPrivKeys.toPublicKeys())
			userPubKeys := userDeviceServerHalvesToPublicKeys(
				expected.serverHalves[keyGen-FirstValidKeyGen])
			require.Equal(t, expectedUserPubKeys.RemoveKeylessUsersForTest(), userPubKeys)
			checkGetTLFCryptKeyV2(t, keyGen, expected,
				expectedTLFCryptKeys[keyGen-FirstValidKeyGen],
				wkb, rkb)
		}
	}
}

func TestRootMetadataV2UpdateKeyBundles(t *testing.T) {
	uid1 := keybase1.MakeTestUID(1)
	uid2 := keybase1.MakeTestUID(2)
	uid3 := keybase1.MakeTestUID(3)

	privKey1 := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key1")
	privKey2 := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key2")
	privKey3 := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key3")

	updatedWriterKeys := UserDevicePublicKeys{
		uid1: {privKey1.GetPublicKey(): true},
		uid2: {privKey2.GetPublicKey(): true},
	}

	updatedReaderKeys := UserDevicePublicKeys{
		uid3: {privKey3.GetPublicKey(): true},
	}

	tlfID := tlf.FakeID(1, tlf.Private)

	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid1.AsUserOrTeam(), uid2.AsUserOrTeam()},
		[]keybase1.UserOrTeamID{uid3.AsUserOrTeam()},
		[]keybase1.SocialAssertion{{}},
		nil, nil)
	require.NoError(t, err)

	rmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	codec := kbfscodec.NewMsgpack()

	ePubKey1, ePrivKey1, err := kbfscrypto.MakeRandomTLFEphemeralKeys()
	require.NoError(t, err)

	// Add first key generations.

	latestKeyGen := FirstValidKeyGen + 5
	var pubKeys []kbfscrypto.TLFPublicKey
	var tlfCryptKeys []kbfscrypto.TLFCryptKey
	var serverHalves1 []UserDeviceKeyServerHalves
	for keyGen := FirstValidKeyGen; keyGen <= latestKeyGen; keyGen++ {
		fakeKeyData := [32]byte{byte(keyGen)}
		pubKey := kbfscrypto.MakeTLFPublicKey(fakeKeyData)
		tlfCryptKey := kbfscrypto.MakeTLFCryptKey(fakeKeyData)

		// Use the same ephemeral keys for initial key
		// generations, even though that can't happen in
		// practice.
		_, serverHalves1Gen, err := rmd.AddKeyGeneration(codec,
			nil, updatedWriterKeys, updatedReaderKeys,
			ePubKey1, ePrivKey1,
			pubKey, kbfscrypto.TLFCryptKey{}, tlfCryptKey)
		require.NoError(t, err)
		serverHalves1 = append(serverHalves1, serverHalves1Gen)

		pubKeys = append(pubKeys, pubKey)
		tlfCryptKeys = append(tlfCryptKeys, tlfCryptKey)
	}

	expectedRekeyInfo1 := expectedRekeyInfoV2{
		writerPrivKeys: userDevicePrivateKeys{
			uid1: {privKey1: true},
			uid2: {privKey2: true},
		},
		readerPrivKeys: userDevicePrivateKeys{
			uid3: {privKey3: true},
		},
		serverHalves: serverHalves1,
		ePubKeyIndex: 0,
		ePubKey:      ePubKey1,
	}
	expectedRekeyInfos := []expectedRekeyInfoV2{expectedRekeyInfo1}

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Do update to check idempotency.

	serverHalves1b, err := rmd.UpdateKeyBundles(codec, nil,
		updatedWriterKeys, updatedReaderKeys,
		ePubKey1, ePrivKey1, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo1b := expectedRekeyInfoV2{
		serverHalves: serverHalves1b,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo1b)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Rekey.

	privKey1b := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key1b")
	updatedWriterKeys[uid1][privKey1b.GetPublicKey()] = true

	privKey3b := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key3b")
	updatedReaderKeys[uid3][privKey3b.GetPublicKey()] = true

	ePubKey2, ePrivKey2, err := kbfscrypto.MakeRandomTLFEphemeralKeys()
	require.NoError(t, err)

	serverHalves2, err := rmd.UpdateKeyBundles(codec, nil,
		updatedWriterKeys, updatedReaderKeys,
		ePubKey2, ePrivKey2, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo2 := expectedRekeyInfoV2{
		writerPrivKeys: userDevicePrivateKeys{
			uid1: {privKey1b: true},
		},
		readerPrivKeys: userDevicePrivateKeys{
			uid3: {privKey3b: true},
		},
		serverHalves: serverHalves2,
		ePubKeyIndex: 1,
		ePubKey:      ePubKey2,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo2)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Do again to check idempotency.

	serverHalves2b, err := rmd.UpdateKeyBundles(codec, nil,
		updatedWriterKeys, updatedReaderKeys,
		ePubKey2, ePrivKey2, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo2b := expectedRekeyInfoV2{
		serverHalves: serverHalves2b,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo2b)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Rekey writers only.

	privKey1c := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key1c")
	updatedWriterKeys[uid1][privKey1c.GetPublicKey()] = true

	ePubKey3, ePrivKey3, err := kbfscrypto.MakeRandomTLFEphemeralKeys()
	require.NoError(t, err)

	serverHalves3, err := rmd.UpdateKeyBundles(codec, nil,
		updatedWriterKeys, updatedReaderKeys,
		ePubKey3, ePrivKey3, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo3 := expectedRekeyInfoV2{
		writerPrivKeys: userDevicePrivateKeys{
			uid1: {privKey1c: true},
		},
		readerPrivKeys: nil,
		serverHalves:   serverHalves3,
		ePubKeyIndex:   2,
		ePubKey:        ePubKey3,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo3)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Do again to check idempotency.

	serverHalves3b, err := rmd.UpdateKeyBundles(codec, nil,
		updatedWriterKeys, updatedReaderKeys,
		ePubKey3, ePrivKey3, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo3b := expectedRekeyInfoV2{
		serverHalves: serverHalves3b,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo3b)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Reader rekey.

	privKey3c := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key3c")
	privKey3d := kbfscrypto.MakeFakeCryptPrivateKeyOrBust("key3d")
	updatedReaderKeys[uid3][privKey3c.GetPublicKey()] = true
	updatedReaderKeys[uid3][privKey3d.GetPublicKey()] = true

	ePubKey4, ePrivKey4, err := kbfscrypto.MakeRandomTLFEphemeralKeys()
	require.NoError(t, err)

	filteredReaderKeys := UserDevicePublicKeys{
		uid3: updatedReaderKeys[uid3],
	}
	serverHalves4, err := rmd.UpdateKeyBundles(codec, nil,
		nil, filteredReaderKeys, ePubKey4, ePrivKey4, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo4 := expectedRekeyInfoV2{
		writerPrivKeys: nil,
		readerPrivKeys: userDevicePrivateKeys{
			uid3: {privKey3c: true, privKey3d: true},
		},
		serverHalves: serverHalves4,
		ePubKeyIndex: -1,
		ePubKey:      ePubKey4,
	}
	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo4)
	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)

	// Do again to check idempotency.

	serverHalves4b, err := rmd.UpdateKeyBundles(codec, nil,
		nil, filteredReaderKeys, ePubKey4, ePrivKey4, tlfCryptKeys)
	require.NoError(t, err)

	expectedRekeyInfo4b := expectedRekeyInfoV2{
		serverHalves: serverHalves4b,
	}

	expectedRekeyInfos = append(expectedRekeyInfos, expectedRekeyInfo4b)

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)
}

// TestRootMetadataV2AddKeyGenerationKeylessUsers checks that
// keyless users are handled properly by AddKeyGeneration.
func TestRootMetadataV2AddKeyGenerationKeylessUsers(t *testing.T) {
	uid1 := keybase1.MakeTestUID(1)
	uid2 := keybase1.MakeTestUID(2)
	uid3 := keybase1.MakeTestUID(3)

	updatedWriterKeys := UserDevicePublicKeys{
		uid1: {},
		uid2: {},
	}

	updatedReaderKeys := UserDevicePublicKeys{
		uid3: {},
	}

	tlfID := tlf.FakeID(1, tlf.Private)

	bh, err := tlf.MakeHandle(
		[]keybase1.UserOrTeamID{uid1.AsUserOrTeam(), uid2.AsUserOrTeam()},
		[]keybase1.UserOrTeamID{uid3.AsUserOrTeam()},
		[]keybase1.SocialAssertion{{}},
		nil, nil)
	require.NoError(t, err)

	rmd, err := MakeInitialRootMetadataV2(tlfID, bh)
	require.NoError(t, err)

	codec := kbfscodec.NewMsgpack()

	ePubKey1, ePrivKey1, err := kbfscrypto.MakeRandomTLFEphemeralKeys()
	require.NoError(t, err)

	// Add first key generation.

	fakeKeyData := [32]byte{1}
	pubKey := kbfscrypto.MakeTLFPublicKey(fakeKeyData)
	tlfCryptKey := kbfscrypto.MakeTLFCryptKey(fakeKeyData)

	_, serverHalves1Gen, err := rmd.AddKeyGeneration(codec,
		nil, updatedWriterKeys, updatedReaderKeys,
		ePubKey1, ePrivKey1,
		pubKey, kbfscrypto.TLFCryptKey{}, tlfCryptKey)
	require.NoError(t, err)
	serverHalves1 := []UserDeviceKeyServerHalves{serverHalves1Gen}

	pubKeys := []kbfscrypto.TLFPublicKey{pubKey}
	tlfCryptKeys := []kbfscrypto.TLFCryptKey{tlfCryptKey}

	expectedRekeyInfo1 := expectedRekeyInfoV2{
		writerPrivKeys: userDevicePrivateKeys{
			uid1: {},
			uid2: {},
		},
		readerPrivKeys: userDevicePrivateKeys{
			uid3: {},
		},
		serverHalves: serverHalves1,
	}
	expectedRekeyInfos := []expectedRekeyInfoV2{expectedRekeyInfo1}

	checkKeyBundlesV2(t, expectedRekeyInfos, tlfCryptKeys, pubKeys, rmd)
}