github.com/khulnasoft-lab/defsec@v1.0.5-0.20230827010352-5e9f46893d95/rules/cloud/policies/nifcloud/computing/add_description_to_security_group_rule.go (about)

     1  package computing
     2  
     3  import (
     4  	"github.com/khulnasoft-lab/defsec/internal/rules"
     5  	"github.com/khulnasoft-lab/defsec/pkg/providers"
     6  	"github.com/khulnasoft-lab/defsec/pkg/scan"
     7  	"github.com/khulnasoft-lab/defsec/pkg/severity"
     8  	"github.com/khulnasoft-lab/defsec/pkg/state"
     9  )
    10  
    11  var CheckAddDescriptionToSecurityGroupRule = rules.Register(
    12  	scan.Rule{
    13  		AVDID:      "AVD-NIF-0003",
    14  		Aliases:    []string{"nifcloud-computing-add-description-to-security-group-rule"},
    15  		Provider:   providers.NifcloudProvider,
    16  		Service:    "computing",
    17  		ShortCode:  "add-description-to-security-group-rule",
    18  		Summary:    "Missing description for security group rule.",
    19  		Impact:     "Descriptions provide context for the firewall rule reasons",
    20  		Resolution: "Add descriptions for all security groups rules",
    21  		Explanation: `Security group rules should include a description for auditing purposes.
    22  
    23  Simplifies auditing, debugging, and managing security groups.`,
    24  		Links: []string{
    25  			"https://pfs.nifcloud.com/help/fw/rule_new.htm",
    26  		},
    27  		Terraform: &scan.EngineMetadata{
    28  			GoodExamples:        terraformAddDescriptionToSecurityGroupRuleGoodExamples,
    29  			BadExamples:         terraformAddDescriptionToSecurityGroupRuleBadExamples,
    30  			Links:               terraformAddDescriptionToSecurityGroupRuleLinks,
    31  			RemediationMarkdown: terraformAddDescriptionToSecurityGroupRuleRemediationMarkdown,
    32  		},
    33  		Severity: severity.Low,
    34  	},
    35  	func(s *state.State) (results scan.Results) {
    36  		for _, group := range s.Nifcloud.Computing.SecurityGroups {
    37  			for _, rule := range append(group.EgressRules, group.IngressRules...) {
    38  				if rule.Description.IsEmpty() {
    39  					results.Add(
    40  						"Security group rule does not have a description.",
    41  						rule.Description,
    42  					)
    43  				} else {
    44  					results.AddPassed(&rule)
    45  				}
    46  			}
    47  
    48  		}
    49  		return
    50  	},
    51  )