github.com/kubewharf/katalyst-core@v0.5.3/CONTRIBUTING.md (about)

     1  # Contributing to Katalyst Core
     2  
     3  ## Code of Conduct
     4  
     5  Please do check our [Code of Conduct](CODE_OF_CONDUCT.md) before making contributions.
     6  
     7  ## Topics
     8  
     9  * [Reporting security issues](#reporting-security-issues)
    10  * [Reporting general issues](#reporting-general-issues)
    11  * [Code and doc contribution](#code-and-doc-contribution)
    12  * [Engage to help anything](#engage-to-help-anything)
    13  
    14  ## Reporting security issues
    15  
    16  We take security issues seriously and discourage anyone to spread security issues. 
    17  If you find a security issue in Katalyst, please do not discuss it in public and even do not open a public issue. 
    18  Instead, we encourage you to send us a private email to [Maintainers](MAINTAINERS.md) to report the security issue.
    19  
    20  ## Reporting general issues
    21  
    22  Any user is welcome be a contributor. If you have any feedback for the project, feel free to open an issue.
    23  
    24  Since Katalyst development will be collaborated in a distributed manner, we appreciate **WELL-WRITTEN**, **DETAILED**, **EXPLICIT** issue reports. 
    25  To make communication more efficient, we suggest everyone to search if your issue is an existing one before filing a new issue. If you find it to be existing, please append your details in the issue comments.
    26  
    27  There are a lot of cases for which you could open an issue:
    28  
    29  * Bug report
    30  * Feature request
    31  * Performance issues
    32  * Feature proposal
    33  * Feature design
    34  * Help wanted
    35  * Doc incomplete
    36  * Test improvement
    37  * Any questions about the project, and so on
    38  
    39  Please remind that when filing a new issue, do remove the sensitive data from your post. 
    40  Sensitive data could be password, secret key, network locations, private business data and so on.
    41  
    42  ## Code and doc contribution
    43  
    44  Any action that may make Katalyst better is encouraged. The action can be realized via a PR (short for pull request).
    45  
    46  * If you find a typo, try to fix it!
    47  * If you find a bug, try to fix it!
    48  * If you find some redundant codes, try to remove them!
    49  * If you find some test cases missing, try to add them!
    50  * If you could enhance a feature, please **DO NOT** hesitate!
    51  * If you find code implicit, try to add comments to make it clear!
    52  * If you find tech debts, try to refactor them!
    53  * If you find document incorrect, please fix that!
    54  
    55  It is impossible to list them completely, we are looking forward to your pull requests.
    56  Before submitting a PR, we suggest you could take a look at the PR rules here.
    57  
    58  * [Workspace Preparation](#workspace-preparation)
    59  * [Branch Definition](#branch-definition)
    60  * [Commit Rules](#commit-rules)
    61  * [PR Description](#pr-description)
    62  
    63  ### Workspace Preparation
    64  
    65  We assume you have a GitHub ID already, then you could finish the preparation in the following steps:
    66  
    67  1. **FORK** Katalyst to your repository. To make this work, you just need to click the button `Fork` in top-right corner of [katalyst-core](https://github.com/kubewharf/katalyst-core) main page. Then you will end up with your repository in `https://github.com/<username>/katalyst-core`, in which `username` is your GitHub ID.
    68  2. **CLONE** your own repository to develop locally. Use `git clone https://github.com/<username>/katalyst-core.git` to clone repository to your local machine. Then you can create new branches to finish the change you wish to make.
    69  3. **Set Remote** upstream to be katalyst using the following two commands:
    70  
    71  ```
    72  git remote add upstream https://github.com/kubewharf/katalyst-core.git
    73  git remote set-url --push upstream no-pushing
    74  ```
    75  
    76  With this remote setting, you can check your git remote configuration like this:
    77  
    78  ```
    79  $ git remote -v
    80  origin     https://github.com/<username>/katalyst-core.git (fetch)
    81  origin     https://github.com/<username>/katalyst-core.git (push)
    82  upstream   https://github.com/kubewharf/katalyst-core.git (fetch)
    83  upstream   no-pushing (push)
    84  ```
    85  
    86  With above, we can easily synchronize local branches with upstream branches.
    87  
    88  ### Branch Definition
    89  
    90  Right now we assume every contribution via pull request is for the `main` branch in katalyst.
    91  There are several other branches such as rc branches, release branches and backport branches.
    92  Before officially releasing a version, we may check out a rc (release candidate) branch for more testings.
    93  When officially releasing a version, there may be a release branch before tagging which will be deleted after tagging.
    94  When backport some fixes to existing released version, we will check out backport branches.
    95  
    96  ### Commit Rules
    97  
    98  In Katalyst, we take two rules seriously for submitted PRs:
    99  
   100  * [Commit Message](#commit-message)
   101  * [Commit Content](#commit-content)
   102  
   103  #### Commit Message
   104  
   105  TODO
   106  
   107  #### Commit Content
   108  
   109  TODO
   110  
   111  ### PR Description
   112  
   113  PR is the only way to make change to Katalyst project. To help reviewers, we actually encourage contributors to make PR description as detailed as possible.
   114  
   115  ## Engage to help anything
   116  
   117  GitHub is the primary place for Katalyst contributors to collaborate. Although contributions via PR is an explicit way to help, we still call for any other types of helps.
   118  
   119  * Reply to other's issues if you could;
   120  * Help solve other user's problems;
   121  * Help review other's PR design;
   122  * Help review other's codes in PR;
   123  * Discuss Katalyst to make things clearer;
   124  * Advocate Katalyst technology beyond GitHub;
   125  * Write blogs on Katalyst, and so on.
   126  
   127  In a word, **ANY HELP CAN BE A CONTRIBUTION.**