github.com/kyma-incubator/compass/components/director@v0.0.0-20230623144113-d764f56ff805/pkg/graphql/labeldef_validation_test.go

package graphql_test

import (
	"encoding/json"
	"testing"

	"github.com/kyma-incubator/compass/components/director/internal/model"
	"github.com/kyma-incubator/compass/components/director/pkg/graphql"
	"github.com/kyma-incubator/compass/components/director/pkg/inputvalidation/inputvalidationtest"
	"github.com/stretchr/testify/require"
)

var (
	validScenario, _      = json.Marshal(model.NewScenariosSchema([]string{"test-scenario"}))
	validSchema           = graphql.JSONSchema(validScenario)
	invalidScenarioSchema = graphql.JSONSchema(`{"type": "string"}`)
	invalidSchema         = graphql.JSONSchema(`{invalid`)
)

func TestLabelDefinitionInput_Validate(t *testing.T) {
	testCases := []struct {
		Name          string
		Value         graphql.LabelDefinitionInput
		ExpectedValid bool
	}{
		{
			Name:          "ExpectedValid",
			Value:         fixValidLabelDefinitionInput(),
			ExpectedValid: true,
		},
		{
			Name: "ExpectedValid - Schema provided",
			Value: graphql.LabelDefinitionInput{
				Key:    model.ScenariosKey,
				Schema: &validSchema,
			},
			ExpectedValid: true,
		},
		{
			Name: "ExpectedValid - Scenarios schema",
			Value: graphql.LabelDefinitionInput{
				Key:    model.ScenariosKey,
				Schema: fixScenariosSchema(t),
			},
			ExpectedValid: true,
		},
		{
			Name: "Invalid - Invalid schema format",
			Value: graphql.LabelDefinitionInput{
				Key:    "ok",
				Schema: &invalidSchema,
			},
			ExpectedValid: false,
		},
		{
			Name: "Invalid - Scenarios schema invalid format",
			Value: graphql.LabelDefinitionInput{
				Key:    model.ScenariosKey,
				Schema: &invalidSchema,
			},
			ExpectedValid: false,
		},
		{
			Name: "Invalid - Scenarios schema invalid",
			Value: graphql.LabelDefinitionInput{
				Key:    model.ScenariosKey,
				Schema: &invalidScenarioSchema,
			},
			ExpectedValid: false,
		},
		{
			Name: "Invalid - Scenarios schema nil",
			Value: graphql.LabelDefinitionInput{
				Key:    model.ScenariosKey,
				Schema: nil,
			},
			ExpectedValid: false,
		},
		{
			Name: "Invalid - Scenarios schema with enum value which does not meet the regex - enum value contains invalid character",
			Value: graphql.LabelDefinitionInput{
				Key: model.ScenariosKey,
				Schema: jsonSchemaPtr(`{
					"type":        "array",
					"minItems":    1,
					"uniqueItems": true,
					"items": {
						"type": "string",
						"enum": ["DEFAULT", "Abc&Cde"]
					}
				}`),
			},
			ExpectedValid: false,
		},
		{
			Name: "Invalid - Scenarios schema with enum value which does not meet the regex - enum value too long",
			Value: graphql.LabelDefinitionInput{
				Key: model.ScenariosKey,
				Schema: jsonSchemaPtr(`{
					"type":        "array",
					"minItems":    1,
					"uniqueItems": true,
					"items": {
						"type": "string",
						"enum": ["DEFAULT", "Abcdefghijklmnopqrstuvwxyz1234567890Abcdefghijklmnopqrstuvwxyz1234567890Abcdefghijklmnopqrstuvwxyz1234567890Abcdefghijklmnopqrstuvwxyz1234567890"]
					}	
				}`),
			},
			ExpectedValid: false,
		},
	}

	for _, testCase := range testCases {
		t.Run(testCase.Name, func(t *testing.T) {
			//GIVEN
			sut := testCase.Value
			// WHEN
			err := sut.Validate()
			// THEN
			if testCase.ExpectedValid {
				require.NoError(t, err)
			} else {
				require.Error(t, err)
			}
		})
	}
}

func TestLabelDefinitionInput_Validate_Key(t *testing.T) {
	testCases := []struct {
		Name          string
		Value         string
		ExpectedValid bool
	}{
		{
			Name:          "ExpectedValid",
			Value:         model.ScenariosKey,
			ExpectedValid: true,
		},
		{
			Name:          "Invalid - Empty",
			Value:         inputvalidationtest.EmptyString,
			ExpectedValid: false,
		},
		{
			Name:          "Invalid - Too long",
			Value:         inputvalidationtest.String257Long,
			ExpectedValid: false,
		},
		{
			Name:          "Invalid - Unsupported characters in key",
			Value:         "not/valid",
			ExpectedValid: false,
		},
	}

	for _, testCase := range testCases {
		t.Run(testCase.Name, func(t *testing.T) {
			//GIVEN
			sut := fixValidLabelDefinitionInput()
			sut.Key = testCase.Value
			// WHEN
			err := sut.Validate()
			// THEN
			if testCase.ExpectedValid {
				require.NoError(t, err)
			} else {
				require.Error(t, err)
			}
		})
	}
}

func TestLabelDefinitionInput_Validate_Schema(t *testing.T) {
	testCases := []struct {
		Name          string
		Value         *graphql.JSONSchema
		ExpectedValid bool
	}{
		{
			Name:          "ExpectedValid",
			Value:         &validSchema,
			ExpectedValid: true,
		},
		{
			Name:          "ExpectedInvalid - Nil",
			Value:         (*graphql.JSONSchema)(nil),
			ExpectedValid: false,
		},
	}

	for _, testCase := range testCases {
		t.Run(testCase.Name, func(t *testing.T) {
			//GIVEN
			sut := fixValidLabelDefinitionInput()
			sut.Schema = testCase.Value
			// WHEN
			err := sut.Validate()
			// THEN
			if testCase.ExpectedValid {
				require.NoError(t, err)
			} else {
				require.Error(t, err)
			}
		})
	}
}

func fixValidLabelDefinitionInput() graphql.LabelDefinitionInput {
	return graphql.LabelDefinitionInput{
		Key:    model.ScenariosKey,
		Schema: &validSchema,
	}
}

func jsonSchemaPtr(schema string) *graphql.JSONSchema {
	s := graphql.JSONSchema(schema)
	return &s
}

func fixScenariosSchema(t *testing.T) *graphql.JSONSchema {
	marshalled, err := json.Marshal(model.NewScenariosSchema([]string{"test-scenario"}))
	require.NoError(t, err)
	return jsonSchemaPtr(string(marshalled))
}