github.com/kyma-project/kyma-environment-broker@v0.0.1/internal/storage/driver/postsql/conflict_test.go

package postsql_test

import (
	"context"
	"testing"
	"time"

	"github.com/kyma-project/kyma-environment-broker/internal"
	"github.com/kyma-project/kyma-environment-broker/internal/events"
	"github.com/kyma-project/kyma-environment-broker/internal/fixture"
	"github.com/kyma-project/kyma-environment-broker/internal/storage"
	"github.com/kyma-project/kyma-environment-broker/internal/storage/dberr"
	"github.com/pivotal-cf/brokerapi/v8/domain"
	"github.com/sirupsen/logrus"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

func TestConflict(t *testing.T) {

	ctx := context.Background()

	t.Run("Conflict Operations", func(t *testing.T) {

		t.Run("Plain operations - provisioning", func(t *testing.T) {
			containerCleanupFunc, cfg, err := storage.InitTestDBContainer(t.Logf, ctx, "test_DB_1")
			require.NoError(t, err)

			tablesCleanupFunc, err := storage.InitTestDBTables(t, cfg.ConnectionURL())
			defer tablesCleanupFunc()
			defer containerCleanupFunc()
			require.NoError(t, err)

			cipher := storage.NewEncrypter(cfg.SecretKey)
			brokerStorage, _, err := storage.NewFromConfig(cfg, events.Config{}, cipher, logrus.StandardLogger())
			require.NoError(t, err)
			require.NotNil(t, brokerStorage)

			givenOperation := fixture.FixOperation("operation-001", "inst-id", internal.OperationTypeProvision)
			givenOperation.State = domain.InProgress
			givenOperation.ProvisionerOperationID = "target-op-id"

			svc := brokerStorage.Operations()

			require.NoError(t, err)
			require.NotNil(t, brokerStorage)
			err = svc.InsertOperation(givenOperation)
			require.NoError(t, err)

			// when
			gotOperation1, err := svc.GetOperationByID("operation-001")
			require.NoError(t, err)

			gotOperation2, err := svc.GetOperationByID("operation-001")
			require.NoError(t, err)

			// when
			gotOperation1.Description = "new modified description 1"
			gotOperation2.Description = "new modified description 2"
			_, err = svc.UpdateOperation(*gotOperation1)
			require.NoError(t, err)

			_, err = svc.UpdateOperation(*gotOperation2)

			// then
			assertError(t, dberr.CodeConflict, err)

			// when
			err = svc.InsertOperation(*gotOperation1)

			// then
			assertError(t, dberr.CodeAlreadyExists, err)
		})

		t.Run("Plain operations - deprovisioning", func(t *testing.T) {
			containerCleanupFunc, cfg, err := storage.InitTestDBContainer(t.Logf, ctx, "test_DB_1")
			require.NoError(t, err)

			tablesCleanupFunc, err := storage.InitTestDBTables(t, cfg.ConnectionURL())
			defer tablesCleanupFunc()
			defer containerCleanupFunc()
			require.NoError(t, err)

			cipher := storage.NewEncrypter(cfg.SecretKey)
			brokerStorage, _, err := storage.NewFromConfig(cfg, events.Config{}, cipher, logrus.StandardLogger())
			require.NoError(t, err)
			require.NotNil(t, brokerStorage)

			givenOperation := fixture.FixOperation("operation-001", "inst-id", internal.OperationTypeDeprovision)
			givenOperation.State = domain.InProgress
			givenOperation.ProvisionerOperationID = "target-op-id"

			svc := brokerStorage.Operations()

			require.NoError(t, err)
			require.NotNil(t, brokerStorage)
			err = svc.InsertOperation(givenOperation)
			require.NoError(t, err)

			// when
			gotOperation1, err := svc.GetOperationByID("operation-001")
			require.NoError(t, err)

			gotOperation2, err := svc.GetOperationByID("operation-001")
			require.NoError(t, err)

			// when
			gotOperation1.Description = "new modified description 1"
			gotOperation2.Description = "new modified description 2"
			_, err = svc.UpdateOperation(*gotOperation1)
			require.NoError(t, err)

			_, err = svc.UpdateOperation(*gotOperation2)

			// then
			assertError(t, dberr.CodeConflict, err)

			// when
			err = svc.InsertOperation(*gotOperation1)

			// then
			assertError(t, dberr.CodeAlreadyExists, err)
		})

		t.Run("Provisioning", func(t *testing.T) {
			containerCleanupFunc, cfg, err := storage.InitTestDBContainer(t.Logf, ctx, "test_DB_1")
			require.NoError(t, err)

			tablesCleanupFunc, err := storage.InitTestDBTables(t, cfg.ConnectionURL())
			defer tablesCleanupFunc()
			defer containerCleanupFunc()
			require.NoError(t, err)

			cipher := storage.NewEncrypter(cfg.SecretKey)
			brokerStorage, _, err := storage.NewFromConfig(cfg, events.Config{}, cipher, logrus.StandardLogger())
			require.NoError(t, err)
			require.NotNil(t, brokerStorage)

			givenOperation := fixture.FixProvisioningOperation("operation-001", "inst-id")
			givenOperation.State = domain.InProgress
			givenOperation.ProvisionerOperationID = "target-op-id"

			svc := brokerStorage.Operations()

			require.NoError(t, err)
			require.NotNil(t, brokerStorage)
			err = svc.InsertOperation(givenOperation)
			require.NoError(t, err)

			// when
			gotOperation1, err := svc.GetProvisioningOperationByID("operation-001")
			require.NoError(t, err)

			gotOperation2, err := svc.GetProvisioningOperationByID("operation-001")
			require.NoError(t, err)

			// when
			gotOperation1.Description = "new modified description 1"
			gotOperation2.Description = "new modified description 2"
			_, err = svc.UpdateProvisioningOperation(*gotOperation1)
			require.NoError(t, err)

			_, err = svc.UpdateProvisioningOperation(*gotOperation2)

			// then
			assertError(t, dberr.CodeConflict, err)

			// when
			err = svc.InsertProvisioningOperation(*gotOperation1)

			// then
			assertError(t, dberr.CodeAlreadyExists, err)
		})

		t.Run("Deprovisioning", func(t *testing.T) {
			containerCleanupFunc, cfg, err := storage.InitTestDBContainer(t.Logf, ctx, "test_DB_1")
			require.NoError(t, err)
			defer containerCleanupFunc()

			tablesCleanupFunc, err := storage.InitTestDBTables(t, cfg.ConnectionURL())
			require.NoError(t, err)
			defer tablesCleanupFunc()

			cipher := storage.NewEncrypter(cfg.SecretKey)
			brokerStorage, _, err := storage.NewFromConfig(cfg, events.Config{}, cipher, logrus.StandardLogger())
			require.NoError(t, err)
			require.NotNil(t, brokerStorage)

			givenOperation := fixture.FixDeprovisioningOperation("operation-001", "inst-id")
			givenOperation.State = domain.InProgress
			givenOperation.ProvisionerOperationID = "target-op-id"

			svc := brokerStorage.Deprovisioning()

			err = svc.InsertDeprovisioningOperation(givenOperation)
			require.NoError(t, err)

			// when
			gotOperation1, err := svc.GetDeprovisioningOperationByID("operation-001")
			require.NoError(t, err)

			gotOperation2, err := svc.GetDeprovisioningOperationByID("operation-001")
			require.NoError(t, err)

			// when
			gotOperation1.Description = "new modified description 1"
			gotOperation2.Description = "new modified description 2"
			_, err = svc.UpdateDeprovisioningOperation(*gotOperation1)
			require.NoError(t, err)

			_, err = svc.UpdateDeprovisioningOperation(*gotOperation2)

			// then
			assertError(t, dberr.CodeConflict, err)

			// when
			err = svc.InsertDeprovisioningOperation(*gotOperation1)

			// then
			assertError(t, dberr.CodeAlreadyExists, err)
		})
	})

	t.Run("Conflict Instances", func(t *testing.T) {
		containerCleanupFunc, cfg, err := storage.InitTestDBContainer(t.Logf, ctx, "test_DB_1")
		require.NoError(t, err)
		defer containerCleanupFunc()

		tablesCleanupFunc, err := storage.InitTestDBTables(t, cfg.ConnectionURL())
		require.NoError(t, err)
		defer tablesCleanupFunc()

		cipher := storage.NewEncrypter(cfg.SecretKey)
		brokerStorage, _, err := storage.NewFromConfig(cfg, events.Config{}, cipher, logrus.StandardLogger())
		require.NoError(t, err)
		require.NotNil(t, brokerStorage)

		svc := brokerStorage.Instances()

		inst := internal.Instance{
			InstanceID:      "abcd-01234",
			RuntimeID:       "r-id-001",
			GlobalAccountID: "ga-001",
			SubAccountID:    "sa-001",
			ServiceID:       "service-id-001",
			ServiceName:     "awesome-service",
			ServicePlanID:   "plan-id",
			ServicePlanName: "awesome-plan",
			DashboardURL:    "",
			Parameters:      internal.ProvisioningParameters{},
			ProviderRegion:  "",
			CreatedAt:       time.Now(),
			Version:         0,
		}

		err = svc.Insert(inst)
		require.NoError(t, err)

		// try an update
		inst.DashboardURL = "http://kyma.org"
		newInst, err := svc.Update(inst)
		require.NoError(t, err)

		// try another update with old version - expect conflict
		inst.DashboardURL = "---"
		_, err = svc.Update(inst)
		require.Error(t, err)
		assert.True(t, dberr.IsConflict(err))

		// try second update with correct version
		newInst.DashboardURL = "http://new.kyma.com"
		_, err = svc.Update(*newInst)
		require.NoError(t, err)
	})
}

func assertError(t *testing.T, expectedCode int, err error) {
	require.Error(t, err)

	dbe, ok := err.(dberr.Error)
	if !ok {
		assert.Fail(t, "expected DB Error Conflict")
	}
	assert.Equal(t, expectedCode, dbe.Code())
}