github.com/loafoe/cli@v7.1.0+incompatible/integration/v6/push/deprecated_route_flags_test.go

package push

import (
	"io/ioutil"
	"os"

	"code.cloudfoundry.org/cli/integration/helpers"
	. "github.com/onsi/ginkgo"
	. "github.com/onsi/gomega"
	. "github.com/onsi/gomega/gbytes"
	. "github.com/onsi/gomega/gexec"
)

var _ = Describe("deprecated route command-line flags", func() {

	const deprecationTemplate = "Deprecation warning: Use of the '%[1]s' command-line flag option is deprecated in favor of the 'routes' property in the manifest. Please see https://docs.cloudfoundry.org/devguide/deploy-apps/manifest-attributes.html#routes for usage information. The '%[1]s' command-line flag option will be removed in the future."

	const legacyManifestDeprecationTemplate = `Deprecation warning: Specifying app manifest attributes at the top level is deprecated. Found: host.
Please see https://docs.cloudfoundry.org/devguide/deploy-apps/manifest-attributes.html#deprecated for alternatives and other app manifest deprecations. This feature will be removed in the future.`

	var (
		appName       string
		host          string
		privateDomain string
		localArgs     []string
		session       *Session
	)

	BeforeEach(func() {
		appName = helpers.NewAppName()
		host = helpers.NewAppName()

		privateDomain = helpers.NewDomainName()
		domain := helpers.NewDomain(organization, privateDomain)
		domain.Create()
	})
	When("with no manifest", func() {
		JustBeforeEach(func() {
			helpers.WithHelloWorldApp(func(dir string) {
				allArgs := []string{PushCommandName, appName, "--no-start"}
				allArgs = append(allArgs, localArgs...)
				session = helpers.CustomCF(helpers.CFEnv{WorkingDirectory: dir}, allArgs...)
				Eventually(session).Should(Exit(0))
			})
		})

		When("no deprecated flags are provided", func() {
			BeforeEach(func() {
				localArgs = []string{}
			})
			It("does not output a deprecation warning", func() {
				Expect(string(session.Err.Contents())).ToNot(ContainSubstring("command-line flag option is deprecated in favor of the 'routes' property in the manifest"))
			})
		})

		When("the -d (domains) flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"-d", privateDomain}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "-d"))
			})
		})

		When("the --hostname flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--hostname", host}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--hostname"))
			})
		})

		When("the --no-hostname flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--no-hostname", "-d", privateDomain}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--no-hostname"))
			})
		})

		When("the --route-path flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--route-path", "some-path"}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--route-path"))
			})
		})
	})

	When("with a legacy (no applications section) manifest", func() {
		var (
			pathToManifest string // Can be a filepath or a directory with a manifest.
		)

		BeforeEach(func() {
			tmpFile, err := ioutil.TempFile("", "manifest.yml")
			Expect(err).ToNot(HaveOccurred())
			pathToManifest = tmpFile.Name()
			Expect(tmpFile.Close()).ToNot(HaveOccurred())
		})

		AfterEach(func() {
			Expect(os.Remove(pathToManifest)).ToNot(HaveOccurred())
		})

		BeforeEach(func() {
			helpers.WriteManifest(pathToManifest, map[string]interface{}{
				"host": "blatz" + helpers.NewHostName(),
			})
		})
		JustBeforeEach(func() {
			helpers.WithHelloWorldApp(func(dir string) {
				allArgs := []string{PushCommandName, appName, "-f", pathToManifest, "--no-start"}
				allArgs = append(allArgs, localArgs...)
				session = helpers.CustomCF(helpers.CFEnv{WorkingDirectory: dir}, allArgs...)
				Eventually(session).Should(Exit(0))
			})
		})
		JustAfterEach(func() {
			Expect(session.Err).Should(Say(legacyManifestDeprecationTemplate))
		})

		When("no deprecated flags are provided", func() {
			BeforeEach(func() {
				localArgs = []string{}
			})
			It("does not output a deprecation warning", func() {
				Expect(string(session.Err.Contents())).ToNot(ContainSubstring("command-line flag option is deprecated in favor of the 'routes' property in the manifest"))
			})
		})

		When("the -d (domains) flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"-d", privateDomain}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "-d"))
			})
		})

		When("the --hostname flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--hostname", host}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--hostname"))
			})
		})

		When("the --no-hostname flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--no-hostname", "-d", privateDomain}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--no-hostname"))
			})
		})

		When("the --route-path flag is provided", func() {
			BeforeEach(func() {
				localArgs = []string{"--route-path", "some-path"}
			})
			It("outputs a deprecation warning", func() {
				Expect(session.Err).Should(Say(deprecationTemplate, "--route-path"))
			})
		})
	})

})