github.com/m3db/m3@v1.5.0/src/query/graphite/native/aggregation_functions_test.go

// Copyright (c) 2019 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

package native

import (
	"fmt"
	"math"
	"sort"
	"testing"
	"time"

	"github.com/m3db/m3/src/query/block"
	"github.com/m3db/m3/src/query/graphite/common"
	"github.com/m3db/m3/src/query/graphite/context"
	"github.com/m3db/m3/src/query/graphite/storage"
	"github.com/m3db/m3/src/query/graphite/ts"
	xgomock "github.com/m3db/m3/src/x/test"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/golang/mock/gomock"
)

var (
	consolidationStartTime = time.Now().Truncate(time.Minute).Add(10 * time.Second)
	consolidationEndTime   = consolidationStartTime.Add(1 * time.Minute)
)

func newConsolidationTestSeries() (*common.Context, []*ts.Series) {
	ctx := common.NewContext(common.ContextOptions{Start: consolidationStartTime, End: consolidationEndTime})

	testSeries := []*ts.Series{
		ts.NewSeries(ctx, "a", consolidationStartTime,
			ts.NewConstantValues(ctx, 10, 6, 10000)),
		ts.NewSeries(ctx, "b", consolidationStartTime.Add(-30*time.Second),
			ts.NewConstantValues(ctx, 15, 6, 10000)),
		ts.NewSeries(ctx, "c", consolidationStartTime.Add(30*time.Second),
			ts.NewConstantValues(ctx, 17, 6, 10000)),
		ts.NewSeries(ctx, "d", consolidationStartTime,
			ts.NewConstantValues(ctx, 3, 60, 1000)),
	}

	return ctx, testSeries
}

func testAggregatedSeries(
	t *testing.T,
	f func(ctx *common.Context, series multiplePathSpecs) (ts.SeriesList, error),
	ev1, ev2, ev3, ev4 float64,
	errorMessage string,
) {
	ctx, consolidationTestSeries := newConsolidationTestSeries()
	defer ctx.Close()

	input := ts.SeriesList{Values: consolidationTestSeries}

	r, err := f(ctx, multiplePathSpecs(input))
	require.Nil(t, err)

	series := r.Values
	require.Equal(t, 1, len(series))

	require.Equal(t, consolidationTestSeries[1].StartTime(), series[0].StartTime())
	require.Equal(t, consolidationTestSeries[2].EndTime(), series[0].EndTime())
	require.Equal(t, 12, series[0].Len())
	require.Equal(t, 10000, series[0].MillisPerStep())
	for i := 0; i < 3; i++ {
		n := series[0].ValueAt(i)
		assert.Equal(t, ev1, n, errorMessage, i)
	}
	for i := 3; i < 6; i++ {
		n := series[0].ValueAt(i)
		assert.Equal(t, ev2, n, errorMessage, i)
	}
	for i := 6; i < 9; i++ {
		n := series[0].ValueAt(i)
		assert.Equal(t, ev3, n, errorMessage, i)
	}
	for i := 9; i < 12; i++ {
		n := series[0].ValueAt(i)
		assert.Equal(t, ev4, n, errorMessage, i)
	}

	// nil input -> nil output
	for _, in := range [][]*ts.Series{nil, {}} {
		series, err := f(ctx, multiplePathSpecs(ts.SeriesList{
			Values: in,
		}))
		require.Nil(t, err)
		require.Equal(t, in, series.Values)
	}

	// single input -> same output
	singleSeries := []*ts.Series{consolidationTestSeries[0]}
	r, err = f(ctx, multiplePathSpecs(ts.SeriesList{
		Values: singleSeries,
	}))
	require.Nil(t, err)

	series = r.Values
	require.Equal(t, singleSeries[0].Len(), series[0].Len())
	for i := 0; i < series[0].Len(); i++ {
		assert.Equal(t, singleSeries[0].ValueAt(i), series[0].ValueAt(i))
	}
}

func TestMinSeries(t *testing.T) {
	testAggregatedSeries(t, minSeries, 15.0, 3.0, 3.0, 17.0, "invalid min value for step %d")
}

func TestMaxSeries(t *testing.T) {
	testAggregatedSeries(t, maxSeries, 15.0, 15.0, 17.0, 17.0, "invalid max value for step %d")
}

func TestSumSeries(t *testing.T) {
	testAggregatedSeries(t, func(ctx *common.Context, series multiplePathSpecs) (ts.SeriesList, error) {
		return sumSeries(ctx, series)
	}, 15.0, 28.0, 30.0, 17.0, "invalid sum value for step %d")
}

func TestStdDevSeries(t *testing.T) {
	var (
		ctrl          = xgomock.NewController(t)
		store         = storage.NewMockStorage(ctrl)
		engine        = NewEngine(store, CompileOptions{})
		start, _      = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:41:19 GMT")
		end, _        = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:43:19 GMT")
		ctx           = common.NewContext(common.ContextOptions{Start: start, End: end, Engine: engine})
		millisPerStep = 60000
		inputs        = []*ts.Series{
			ts.NewSeries(ctx, "servers.s2", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{10, 20, 30})),
			ts.NewSeries(ctx, "servers.s1", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{90, 80, 70})),
		}
	)

	expectedResults := []common.TestSeries{
		{
			Name: "stddevSeries(servers.s2,servers.s1)",
			Data: []float64{40, 30, 20},
		},
	}
	result, err := stddevSeries(ctx, multiplePathSpecs{
		Values: inputs,
	})
	require.NoError(t, err)
	common.CompareOutputsAndExpected(t, 60000, start, expectedResults, result.Values)
}

func TestPowSeries(t *testing.T) {
	var (
		ctrl      = xgomock.NewController(t)
		store     = storage.NewMockStorage(ctrl)
		now       = time.Now().Truncate(time.Hour)
		engine    = NewEngine(store, CompileOptions{})
		startTime = now.Add(-3 * time.Minute)
		endTime   = now.Add(-time.Minute)
		ctx       = common.NewContext(common.ContextOptions{
			Start:  startTime,
			End:    endTime,
			Engine: engine,
		})
	)

	fakeSeries1 := ts.NewSeries(ctx, "foo.bar.g.zed.g", startTime,
		common.NewTestSeriesValues(ctx, 60000, []float64{0, 1, 2, 3, 4}))
	fakeSeries2 := ts.NewSeries(ctx, "foo.bar.g.zed.g", startTime,
		common.NewTestSeriesValues(ctx, 60000, []float64{2, 4, 1, 3, 3}))
	fakeSeries3 := ts.NewSeries(ctx, "foo.bar.g.zed.g", startTime,
		common.NewTestSeriesValues(ctx, 60000, []float64{5, 4, 3, 2, 1}))

	listOfFakeSeries := []*ts.Series{fakeSeries1, fakeSeries2, fakeSeries3}

	expectedValues := []float64{0, 1, 8, 729, 64}
	result, err := powSeries(ctx, multiplePathSpecs(singlePathSpec{Values: listOfFakeSeries}))
	if err != nil {
		fmt.Println(err)
	}
	for i := 0; i < result.Values[0].Len(); i++ {
		require.Equal(t, result.Values[0].ValueAt(i), expectedValues[i])
	}
}

func TestAggregate(t *testing.T) {
	testAggregatedSeries(t, func(ctx *common.Context, series multiplePathSpecs) (ts.SeriesList, error) {
		return aggregate(ctx, singlePathSpec(series), "sum")
	}, 15.0, 28.0, 30.0, 17.0, "invalid sum value for step %d")

	testAggregatedSeries(t, func(ctx *common.Context, series multiplePathSpecs) (ts.SeriesList, error) {
		return aggregate(ctx, singlePathSpec(series), "maxSeries")
	}, 15.0, 15.0, 17.0, 17.0, "invalid max value for step %d")
}

func TestAggregateSeriesMedian(t *testing.T) {
	var (
		ctrl          = xgomock.NewController(t)
		store         = storage.NewMockStorage(ctrl)
		engine        = NewEngine(store, CompileOptions{})
		start, _      = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:41:19 GMT")
		end, _        = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:43:19 GMT")
		ctx           = common.NewContext(common.ContextOptions{Start: start, End: end, Engine: engine})
		millisPerStep = 60000
		inputs        = []*ts.Series{
			ts.NewSeries(ctx, "servers.s2", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{10, 20, 30})),
			ts.NewSeries(ctx, "servers.s1", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{90, 80, 70})),
			ts.NewSeries(ctx, "servers.s3", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{5, 100, 45})),
		}
	)

	expectedResults := []common.TestSeries{
		{
			Name: "medianSeries(servers.s2,servers.s1,servers.s3)",
			Data: []float64{10, 80, 45},
		},
	}
	result, err := aggregate(ctx, singlePathSpec{
		Values: inputs,
	}, "median")
	require.NoError(t, err)
	common.CompareOutputsAndExpected(t, 60000, start, expectedResults, result.Values)
}

type mockEngine struct {
	fn func(
		ctx context.Context,
		query string,
		options storage.FetchOptions,
	) (*storage.FetchResult, error)

	storage storage.Storage
}

func (e mockEngine) FetchByQuery(
	ctx context.Context,
	query string,
	opts storage.FetchOptions,
) (*storage.FetchResult, error) {
	return e.fn(ctx, query, opts)
}

func (e mockEngine) Storage() storage.Storage {
	return nil
}

func TestVariadicSumSeries(t *testing.T) {
	expr, err := Compile("sumSeries(foo.bar.*, foo.baz.*)", CompileOptions{})
	require.NoError(t, err)
	ctx := common.NewTestContext()
	ctx.Engine = mockEngine{fn: func(
		ctx context.Context,
		query string,
		options storage.FetchOptions,
	) (*storage.FetchResult, error) {
		start := options.StartTime
		switch query {
		case "foo.bar.*":
			return storage.NewFetchResult(ctx, []*ts.Series{
				ts.NewSeries(ctx, "foo.bar.a", start, ts.NewConstantValues(ctx, 1, 3, 1000)),
				ts.NewSeries(ctx, "foo.bar.b", start, ts.NewConstantValues(ctx, 2, 3, 1000)),
			}, block.NewResultMetadata()), nil
		case "foo.baz.*":
			return storage.NewFetchResult(ctx, []*ts.Series{
				ts.NewSeries(ctx, "foo.baz.a", start, ts.NewConstantValues(ctx, 3, 3, 1000)),
				ts.NewSeries(ctx, "foo.baz.b", start, ts.NewConstantValues(ctx, 4, 3, 1000)),
			}, block.ResultMetadata{
				Exhaustive: false,
				LocalOnly:  false,
				Warnings:   []block.Warning{{Name: "foo", Message: "bar"}},
			}), nil
		}
		return nil, fmt.Errorf("unexpected query: %s", query)
	}}

	r, err := expr.Execute(ctx)
	require.NoError(t, err)

	require.Equal(t, 1, r.Len())
	assert.Equal(t, []float64{10, 10, 10}, r.Values[0].SafeValues())
	assert.False(t, r.Metadata.Exhaustive)
	assert.False(t, r.Metadata.LocalOnly)
	require.Equal(t, 1, len(r.Metadata.Warnings))
	assert.Equal(t, "foo_bar", r.Metadata.Warnings[0].Header())
}

func TestDiffSeries(t *testing.T) {
	testAggregatedSeries(t, diffSeries, -15.0, -8.0, -10.0, -17.0, "invalid diff value for step %d")
}

func TestMultiplySeries(t *testing.T) {
	testAggregatedSeries(t, multiplySeries, 15.0, 450.0, 510.0, 17.0, "invalid product value for step %d")
}

func TestAverageSeries(t *testing.T) {
	testAggregatedSeries(t, averageSeries, 15.0, 28.0/3, 10.0, 17.0, "invalid avg value for step %d")
}

func TestDivideSeries(t *testing.T) {
	ctx, consolidationTestSeries := newConsolidationTestSeries()
	defer ctx.Close()

	// multiple series, different start/end times
	nan := math.NaN()
	series, err := divideSeries(ctx, singlePathSpec{
		Values: consolidationTestSeries[0:2],
	}, singlePathSpec{
		Values: consolidationTestSeries[2:3],
	})
	require.Nil(t, err)
	expected := []common.TestSeries{
		{
			Name: "divideSeries(a,c)",
			Data: []float64{nan, nan, nan, 0.5882, 0.5882, 0.5882, nan, nan, nan},
		},
		{
			Name: "divideSeries(b,c)",
			Data: []float64{nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan, nan},
		},
	}

	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime,
		[]common.TestSeries{expected[0]}, []*ts.Series{series.Values[0]})
	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime.Add(-30*time.Second),
		[]common.TestSeries{expected[1]}, []*ts.Series{series.Values[1]})

	// different millisPerStep, same start/end times
	series, err = divideSeries(ctx, singlePathSpec{
		Values: consolidationTestSeries[0:1],
	}, singlePathSpec{
		Values: consolidationTestSeries[3:4],
	})
	require.Nil(t, err)
	expected = []common.TestSeries{
		{
			Name: "divideSeries(a,d)",
			Data: []float64{3.3333, 3.3333, 3.3333, 3.3333, 3.33333, 3.3333},
		},
	}
	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime,
		[]common.TestSeries{expected[0]}, []*ts.Series{series.Values[0]})

	// empty series
	series, err = divideSeries(ctx, singlePathSpec{
		Values: []*ts.Series{},
	}, singlePathSpec{
		Values: consolidationTestSeries,
	})
	require.Nil(t, err)
	require.Equal(t, series, ts.NewSeriesList())
}

func TestDivideSeriesError(t *testing.T) {
	ctx, consolidationTestSeries := newConsolidationTestSeries()
	defer ctx.Close()

	// error - multiple divisor series
	_, err := divideSeries(ctx, singlePathSpec{
		Values: consolidationTestSeries,
	}, singlePathSpec{
		Values: consolidationTestSeries,
	})
	require.Error(t, err)
	require.Equal(t, err.Error(), "divideSeries second argument must reference exactly one series but instead has 4")
}

func TestDivideSeriesLists(t *testing.T) {
	ctx, consolidationTestSeries := newConsolidationTestSeries()
	defer ctx.Close()

	// multiple series, different start/end times
	nan := math.NaN()
	series, err := divideSeriesLists(ctx, singlePathSpec{
		Values: consolidationTestSeries[:2],
	}, singlePathSpec{
		Values: consolidationTestSeries[2:],
	})
	require.Nil(t, err)
	expected := []common.TestSeries{
		{
			Name: "divideSeries(a,c)",
			Data: []float64{nan, nan, nan, 0.5882, 0.5882, 0.5882, nan, nan, nan},
		},
		{
			Name: "divideSeries(b,d)",
			Data: []float64{nan, nan, nan, 5, 5, 5, nan, nan, nan},
		},
	}

	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime,
		[]common.TestSeries{expected[0]}, []*ts.Series{series.Values[0]})
	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime.Add(-30*time.Second),
		[]common.TestSeries{expected[1]}, []*ts.Series{series.Values[1]})

	// different millisPerStep, same start/end times
	consolidationTestSeries[0], consolidationTestSeries[2] = consolidationTestSeries[2], consolidationTestSeries[0]
	consolidationTestSeries[1], consolidationTestSeries[3] = consolidationTestSeries[3], consolidationTestSeries[1]
	series, err = divideSeriesLists(ctx, singlePathSpec{
		Values: consolidationTestSeries[:2],
	}, singlePathSpec{
		Values: consolidationTestSeries[2:],
	})
	require.Nil(t, err)
	expected = []common.TestSeries{
		{
			Name: "divideSeries(c,a)",
			Data: []float64{nan, nan, nan, 1.7, 1.7, 1.7, nan, nan, nan},
		},
		{
			Name: "divideSeries(d,b)",
			Data: []float64{nan, nan, nan, 0.2, 0.2, 0.2, nan, nan, nan},
		},
	}
	common.CompareOutputsAndExpected(t, 10000, consolidationStartTime,
		[]common.TestSeries{expected[0]}, []*ts.Series{series.Values[0]})

	// error - multiple divisor series
	series, err = divideSeries(ctx, singlePathSpec{
		Values: consolidationTestSeries,
	}, singlePathSpec{
		Values: consolidationTestSeries,
	})
	require.Error(t, err)
}

// TestDivideSeriesListsWithUnsortedSeriesInput ensures that if input into
// the function wasn't sorted as input that it becomes sorted before dividing
// two series lists (to ensure deterministic results).
func TestDivideSeriesListsWithUnsortedSeriesInput(t *testing.T) {
	start := time.Now().Truncate(time.Minute).Add(-10 * time.Minute)
	end := start.Add(5 * time.Minute)
	ctx := common.NewContext(common.ContextOptions{Start: start, End: end})

	dividend := []*ts.Series{
		ts.NewSeries(ctx, "a", start,
			ts.NewConstantValues(ctx, 1, 5, 60000)),
		ts.NewSeries(ctx, "c", start,
			ts.NewConstantValues(ctx, 3, 5, 60000)),
		ts.NewSeries(ctx, "b", start,
			ts.NewConstantValues(ctx, 2, 5, 60000)),
	}

	divisor := []*ts.Series{
		ts.NewSeries(ctx, "b", start,
			ts.NewConstantValues(ctx, 2, 5, 60000)),
		ts.NewSeries(ctx, "a", start,
			ts.NewConstantValues(ctx, 1, 5, 60000)),
		ts.NewSeries(ctx, "d", start,
			ts.NewConstantValues(ctx, 3, 5, 60000)),
	}

	actual, err := divideSeriesLists(ctx, singlePathSpec{
		Values: dividend,
	}, singlePathSpec{
		Values: divisor,
	})
	require.Nil(t, err)
	expected := []common.TestSeries{
		{
			Name: "divideSeries(a,a)",
			Data: []float64{1, 1, 1, 1, 1},
		},
		{
			Name: "divideSeries(b,b)",
			Data: []float64{1, 1, 1, 1, 1},
		},
		{
			Name: "divideSeries(c,d)",
			Data: []float64{1, 1, 1, 1, 1},
		},
	}

	common.CompareOutputsAndExpected(t, 60000, start, expected, actual.Values)
}

//nolint:govet
func TestAverageSeriesWithWildcards(t *testing.T) {
	ctx, _ := newConsolidationTestSeries()
	defer ctx.Close()

	input := []common.TestSeries{
		{"web.host-1.avg-response.value", []float64{70.0, 20.0, 30.0, 40.0, 50.0}},
		{"web.host-2.avg-response.value", []float64{20.0, 30.0, 40.0, 50.0, 60.0}},
		{"web.host-3.avg-response.value", []float64{30.0, 40.0, 80.0, 60.0, 70.0}},
		{"web.host-4.num-requests.value", []float64{10.0, 10.0, 15.0, 10.0, 15.0}},
	}
	expected := []common.TestSeries{
		{"web.avg-response", []float64{40.0, 30.0, 50.0, 50.0, 60.0}},
		{"web.num-requests", []float64{10.0, 10.0, 15.0, 10.0, 15.0}},
	}

	start := consolidationStartTime
	step := 12000
	timeSeries := generateSeriesList(ctx, start, input, step)
	output, err := averageSeriesWithWildcards(ctx, singlePathSpec{
		Values: timeSeries,
	}, 1, 3)
	require.NoError(t, err)
	sort.Sort(TimeSeriesPtrVector(output.Values))
	common.CompareOutputsAndExpected(t, step, start, expected, output.Values)
}

func createTestSeriesForAggregation() (*common.Context, []*ts.Series) {
	var (
		start, _ = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:41:19 GMT")
		end, _   = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:43:19 GMT")
		ctx      = common.NewContext(common.ContextOptions{Start: start, End: end})
		series   = []*ts.Series{
			ts.NewSeries(ctx, "servers.foo-1.pod1.status.500", start,
				ts.NewConstantValues(ctx, 2, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-2.pod1.status.500", start,
				ts.NewConstantValues(ctx, 4, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-3.pod1.status.500", start,
				ts.NewConstantValues(ctx, 6, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-1.pod2.status.500", start,
				ts.NewConstantValues(ctx, 8, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-2.pod2.status.500", start,
				ts.NewConstantValues(ctx, 10, 12, 10000)),

			ts.NewSeries(ctx, "servers.foo-1.pod1.status.400", start,
				ts.NewConstantValues(ctx, 20, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-2.pod1.status.400", start,
				ts.NewConstantValues(ctx, 30, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-3.pod2.status.400", start,
				ts.NewConstantValues(ctx, 40, 12, 10000)),
		}
	)
	return ctx, series
}

func TestSumSeriesWithWildcards(t *testing.T) {
	ctx, inputs := createTestSeriesForAggregation()
	defer ctx.Close()

	outSeries, err := sumSeriesWithWildcards(ctx, singlePathSpec{
		Values: inputs,
	}, 1, 2)
	require.NoError(t, err)
	require.Equal(t, 2, len(outSeries.Values))

	outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)

	expectedOutputs := []struct {
		name      string
		sumOfVals float64
	}{
		{"servers.status.400", 90 * 12},
		{"servers.status.500", 30 * 12},
	}

	for i, expected := range expectedOutputs {
		series := outSeries.Values[i]
		assert.Equal(t, expected.name, series.Name())
		assert.Equal(t, expected.sumOfVals, series.SafeSum())
	}
}

func TestMultiplySeriesWithWildcards(t *testing.T) {
	ctx, inputs := createTestSeriesForAggregation()
	defer func() { _ = ctx.Close() }()

	outSeries, err := multiplySeriesWithWildcards(ctx, singlePathSpec{
		Values: inputs,
	}, 1, 2)
	require.NoError(t, err)
	require.Equal(t, 2, len(outSeries.Values))

	outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)

	expectedOutputs := []struct {
		name      string
		sumOfVals float64
	}{
		{"servers.status.400", 20 * 30 * 40 * 12},
		{"servers.status.500", 2 * 4 * 6 * 8 * 10 * 12},
	}

	for i, expected := range expectedOutputs {
		series := outSeries.Values[i]
		assert.Equal(t, expected.name, series.Name())
		assert.Equal(t, expected.sumOfVals, series.SafeSum())
	}
}

func TestApplyByNode(t *testing.T) {
	var (
		ctrl          = xgomock.NewController(t)
		store         = storage.NewMockStorage(ctrl)
		engine        = NewEngine(store, CompileOptions{})
		start, _      = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:41:19 GMT")
		end, _        = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:43:19 GMT")
		ctx           = common.NewContext(common.ContextOptions{Start: start, End: end, Engine: engine})
		millisPerStep = 60000
		inputs        = []*ts.Series{
			ts.NewSeries(ctx, "servers.s1.disk.bytes_used", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{10, 20, 30})),
			ts.NewSeries(ctx, "servers.s1.disk.bytes_free", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{90, 80, 70})),
			ts.NewSeries(ctx, "servers.s2.disk.bytes_used", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{1, 2, 3})),
			ts.NewSeries(ctx, "servers.s2.disk.bytes_free", start,
				common.NewTestSeriesValues(ctx, millisPerStep, []float64{99, 98, 97})),
		}
	)

	defer ctrl.Finish()
	defer ctx.Close()

	store.EXPECT().FetchByQuery(gomock.Any(), "servers.s1.disk.bytes_used", gomock.Any()).Return(
		&storage.FetchResult{SeriesList: []*ts.Series{ts.NewSeries(ctx, "servers.s1.disk.bytes_used", start,
			common.NewTestSeriesValues(ctx, 60000, []float64{10, 20, 30}))}}, nil).Times(2)

	store.EXPECT().FetchByQuery(gomock.Any(), "servers.s1.disk.bytes_*", gomock.Any()).Return(
		&storage.FetchResult{SeriesList: []*ts.Series{
			ts.NewSeries(ctx, "servers.s1.disk.bytes_free", start,
				common.NewTestSeriesValues(ctx, 60000, []float64{90, 80, 70})),
			ts.NewSeries(ctx, "servers.s1.disk.bytes_used", start,
				common.NewTestSeriesValues(ctx, 60000, []float64{10, 20, 30})),
		}}, nil).Times(2)

	store.EXPECT().FetchByQuery(gomock.Any(), "servers.s2.disk.bytes_used", gomock.Any()).Return(
		&storage.FetchResult{SeriesList: []*ts.Series{ts.NewSeries(ctx, "servers.s2.disk.bytes_used", start,
			common.NewTestSeriesValues(ctx, 60000, []float64{1, 2, 3}))}}, nil).Times(2)

	store.EXPECT().FetchByQuery(gomock.Any(), "servers.s2.disk.bytes_*", gomock.Any()).Return(
		&storage.FetchResult{SeriesList: []*ts.Series{
			ts.NewSeries(ctx, "servers.s2.disk.bytes_free", start,
				common.NewTestSeriesValues(ctx, 60000, []float64{99, 98, 97})),
			ts.NewSeries(ctx, "servers.s2.disk.bytes_used", start,
				common.NewTestSeriesValues(ctx, 60000, []float64{1, 2, 3})),
		}}, nil).Times(2)

	tests := []struct {
		nodeNum          int
		templateFunction string
		newName          string
		expectedResults  []common.TestSeries
	}{
		{
			nodeNum:          1,
			templateFunction: "divideSeries(%.disk.bytes_used, sumSeries(%.disk.bytes_*))",
			newName:          "",
			expectedResults: []common.TestSeries{
				{
					Name: "divideSeries(servers.s1.disk.bytes_used,sumSeries(servers.s1.disk.bytes_*))",
					Data: []float64{0.10, 0.20, 0.30},
				},
				{
					Name: "divideSeries(servers.s2.disk.bytes_used,sumSeries(servers.s2.disk.bytes_*))",
					Data: []float64{0.01, 0.02, 0.03},
				},
			},
		},
		{
			nodeNum:          1,
			templateFunction: "divideSeries(%.disk.bytes_used, sumSeries(%.disk.bytes_*))",
			newName:          "%.disk.pct_used",
			expectedResults: []common.TestSeries{
				{
					Name: "servers.s1.disk.pct_used",
					Data: []float64{0.10, 0.20, 0.30},
				},
				{
					Name: "servers.s2.disk.pct_used",
					Data: []float64{0.01, 0.02, 0.03},
				},
			},
		},
	}

	for _, test := range tests {
		outSeries, err := applyByNode(
			ctx,
			singlePathSpec{
				Values: inputs,
			},
			test.nodeNum,
			test.templateFunction,
			test.newName,
		)
		require.NoError(t, err)
		require.Equal(t, len(test.expectedResults), len(outSeries.Values))

		outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)
		common.CompareOutputsAndExpected(t, 60000, start, test.expectedResults, outSeries.Values)
	}
}

func TestAggregateWithWildcards(t *testing.T) {
	ctx, inputs := createTestSeriesForAggregation()
	defer ctx.Close()

	type result struct {
		name      string
		sumOfVals float64
	}

	tests := []struct {
		fname           string
		nodes           []int
		expectedResults []result
	}{
		{"avg", []int{1, 2}, []result{
			{"servers.status.400", ((20 + 30 + 40) / 3) * 12},
			{"servers.status.500", ((2 + 4 + 6 + 8 + 10) / 5) * 12},
		}},
		{"max", []int{2, 4}, []result{
			{"servers.status.400", 40 * 12},
			{"servers.status.500", 10 * 12},
		}},
		{"min", []int{2, -1}, []result{
			{"servers.status.400", 20 * 12},
			{"servers.status.500", 2 * 12},
		}},
		{"median", []int{1, 2}, []result{
			{"servers.status.400", 30 * 12},
			{"servers.status.500", 6 * 12},
		}},
	}

	for _, test := range tests {
		outSeries, err := aggregateWithWildcards(ctx, singlePathSpec{
			Values: inputs,
		}, test.fname, 1, 2)
		require.NoError(t, err)
		require.Equal(t, 2, len(outSeries.Values))

		outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)

		for i, expected := range test.expectedResults {
			series := outSeries.Values[i]
			assert.Equal(t, expected.name, series.Name(), "wrong name for %v %s (%d)", test.nodes, test.fname, i)

			assert.Equal(t, expected.sumOfVals, series.SafeSum(),
				"wrong result for %v %s (%d)", test.nodes, test.fname, i)
		}
	}
}

func TestGroupByNode(t *testing.T) {
	ctx, inputs := createTestSeriesForAggregation()
	defer ctx.Close()

	type result struct {
		name      string
		sumOfVals float64
	}

	tests := []struct {
		fname           string
		node            int
		expectedResults []result
	}{
		{"avg", 4, []result{
			{"400", ((20 + 30 + 40) / 3) * 12},
			{"500", ((2 + 4 + 6 + 8 + 10) / 5) * 12},
		}},
		{"max", 2, []result{
			{"pod1", 30 * 12},
			{"pod2", 40 * 12},
		}},
		{"min", -1, []result{
			{"400", 20 * 12},
			{"500", 2 * 12},
		}},
	}

	for _, test := range tests {
		outSeries, err := groupByNode(ctx, singlePathSpec{
			Values: inputs,
		}, test.node, test.fname)
		require.NoError(t, err)
		require.Equal(t, len(test.expectedResults), len(outSeries.Values))

		outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)

		for i, expected := range test.expectedResults {
			series := outSeries.Values[i]
			assert.Equal(t, expected.name, series.Name(),
				"wrong name for %d %s (%d)", test.node, test.fname, i)
			assert.Equal(t, expected.sumOfVals, series.SafeSum(),
				"wrong result for %d %s (%d)", test.node, test.fname, i)
		}
	}
}

func TestGroupByNodes(t *testing.T) {
	var (
		start, _ = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:41:19 GMT")
		end, _   = time.Parse(time.RFC1123, "Mon, 27 Jul 2015 19:43:19 GMT")
		ctx      = common.NewContext(common.ContextOptions{Start: start, End: end})
		inputs   = []*ts.Series{
			ts.NewSeries(ctx, "transformNull(servers.foo-1.pod1.status.500)", start,
				ts.NewConstantValues(ctx, 2, 12, 10000)),
			ts.NewSeries(ctx, "scaleToSeconds(servers.foo-2.pod1.status.500,1)", start,
				ts.NewConstantValues(ctx, 4, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-3.pod1.status.500", start,
				ts.NewConstantValues(ctx, 6, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-1.pod2.status.500", start,
				ts.NewConstantValues(ctx, 8, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-2.pod2.status.500", start,
				ts.NewConstantValues(ctx, 10, 12, 10000)),

			ts.NewSeries(ctx, "servers.foo-1.pod1.status.400", start,
				ts.NewConstantValues(ctx, 20, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-2.pod1.status.400", start,
				ts.NewConstantValues(ctx, 30, 12, 10000)),
			ts.NewSeries(ctx, "servers.foo-3.pod2.status.400", start,
				ts.NewConstantValues(ctx, 40, 12, 10000)),
		}
	)

	defer ctx.Close()

	type result struct {
		name      string
		sumOfVals float64
	}

	tests := []struct {
		fname           string
		nodes           []int
		expectedResults []result
	}{
		{"avg", []int{2, 4}, []result{ // test normal group by nodes
			{"pod1.400", ((20 + 30) / 2) * 12},
			{"pod1.500", ((2 + 4 + 6) / 3) * 12},
			{"pod2.400", (40 / 1) * 12},
			{"pod2.500", ((8 + 10) / 2) * 12},
		}},
		{"max", []int{2, 4}, []result{ // test with different function
			{"pod1.400", 30 * 12},
			{"pod1.500", 6 * 12},
			{"pod2.400", 40 * 12},
			{"pod2.500", 10 * 12},
		}},
		{"median", []int{2, 4}, []result{ // test with different function
			{"pod1.400", ((20 + 30) / 2) * 12},
			{"pod1.500", 4 * 12},
			{"pod2.400", 40 * 12},
			{"pod2.500", ((8 + 10) / 2) * 12},
		}},
		{"max", []int{2, 4, 100}, []result{ // test with a node number that exceeds num parts
			{"pod1.400.", 30 * 12},
			{"pod1.500.", 6 * 12},
			{"pod2.400.", 40 * 12},
			{"pod2.500.", 10 * 12},
		}},
		{"min", []int{2, -1}, []result{ // test negative index handling
			{"pod1.400", 20 * 12},
			{"pod1.500", 2 * 12},
			{"pod2.400", 40 * 12},
			{"pod2.500", 8 * 12},
		}},
		{"sum", []int{}, []result{ // test empty slice handing.
			{
				"sumSeries(transformNull(servers.foo-1.pod1.status.500)," +
					"scaleToSeconds(servers.foo-2.pod1.status.500,1)," +
					"servers.foo-3.pod1.status.500,servers.foo-1.pod2.status.500," +
					"servers.foo-2.pod2.status.500,servers.foo-1.pod1.status.400," +
					"servers.foo-2.pod1.status.400,servers.foo-3.pod2.status.400)",
				(2 + 4 + 6 + 8 + 10 + 20 + 30 + 40) * 12,
			},
		}},
		{"sum", []int{100}, []result{ // test all nodes out of bounds
			{"", (2 + 4 + 6 + 8 + 10 + 20 + 30 + 40) * 12},
		}},
	}

	for _, test := range tests {
		outSeries, err := groupByNodes(ctx, singlePathSpec{
			Values: inputs,
		}, test.fname, test.nodes...)
		require.NoError(t, err)
		require.Equal(t, len(test.expectedResults), len(outSeries.Values))

		outSeries, _ = sortByName(ctx, singlePathSpec(outSeries), false, false)

		for i, expected := range test.expectedResults {
			series := outSeries.Values[i]
			assert.Equal(t, expected.name, series.Name(),
				"wrong name for %v %s (%d)", test.nodes, test.fname, i)
			assert.Equal(t, expected.sumOfVals, series.SafeSum(),
				"wrong result for %v %s (%d)", test.nodes, test.fname, i)
		}
	}
}

func TestWeightedAverage(t *testing.T) {
	ctx, _ := newConsolidationTestSeries()
	defer ctx.Close()

	means := []common.TestSeries{
		{Name: "web.host-1.avg-response.mean", Data: []float64{70.0, 20.0, 30.0, 0.0, 50.0}},
		{Name: "web.host-2.avg-response.mean", Data: []float64{20.0, 30.0, 40.0, 50.0, 60.0}},
		{Name: "web.host-3.avg-response.mean", Data: []float64{20.0, 30.0, 40.0, 50.0, 60.0}}, // no match
	}
	counts := []common.TestSeries{
		{Name: "web.host-1.avg-response.count", Data: []float64{1, 2, 3, 4, 5}},
		{Name: "web.host-2.avg-response.count", Data: []float64{10, 20, 30, 40, 50}},
		{Name: "web.host-4.avg-response.count", Data: []float64{10, 20, 30, 40, 50}}, // no match
	}
	expected := []common.TestSeries{
		{Name: "weightedAverage", Data: []float64{24.5454, 29.0909, 39.0909, 45.4545, 59.0909}},
	}

	// normal series
	start := consolidationStartTime
	step := 12000
	values := ts.SeriesList{Values: generateSeriesList(ctx, start, means, step)}
	weights := ts.SeriesList{Values: generateSeriesList(ctx, start, counts, step)}
	output, err := weightedAverage(ctx, singlePathSpec(values), singlePathSpec(weights), 1)
	require.NoError(t, err)
	sort.Sort(TimeSeriesPtrVector(output.Values))
	common.CompareOutputsAndExpected(t, step, start, expected, output.Values)

	// one series as input, should return the same as output no matter what the weight
	values = ts.SeriesList{Values: generateSeriesList(ctx, start, means[:1], step)}
	weights = ts.SeriesList{Values: generateSeriesList(ctx, start, counts[:1], step)}
	output, err = weightedAverage(ctx, singlePathSpec(values), singlePathSpec(weights), 1)
	require.NoError(t, err)
	common.CompareOutputsAndExpected(t, step, start,
		[]common.TestSeries{{Name: "weightedAverage", Data: means[0].Data}}, output.Values)

	// different steps should lead to error -- not supported yet
	values = ts.SeriesList{Values: generateSeriesList(ctx, start, means, step)}
	weights = ts.SeriesList{Values: generateSeriesList(ctx, start, counts, step*2)}
	output, err = weightedAverage(ctx, singlePathSpec(values), singlePathSpec(weights), 1)
	require.EqualError(t, err, "different step sizes in input series not supported")
}

func TestCountSeries(t *testing.T) {
	ctx, input := newConsolidationTestSeries()
	defer ctx.Close()

	results, err := countSeries(ctx, multiplePathSpecs(ts.SeriesList{
		Values: input,
	}))
	expected := common.TestSeries{
		Name: "countSeries(a,b,c,d)",
		Data: []float64{4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4},
	}
	require.Nil(t, err)
	common.CompareOutputsAndExpected(t, input[1].MillisPerStep(), input[1].StartTime(),
		[]common.TestSeries{expected}, results.Values)
}