github.com/mook-as/cf-cli@v7.0.0-beta.28.0.20200120190804-b91c115fae48+incompatible/command/v6/add_network_policy_command_test.go (about) 1 package v6_test 2 3 import ( 4 "code.cloudfoundry.org/cli/actor/actionerror" 5 "code.cloudfoundry.org/cli/actor/cfnetworkingaction" 6 "code.cloudfoundry.org/cli/actor/v3action" 7 "code.cloudfoundry.org/cli/command/commandfakes" 8 "code.cloudfoundry.org/cli/command/flag" 9 "code.cloudfoundry.org/cli/command/translatableerror" 10 . "code.cloudfoundry.org/cli/command/v6" 11 "code.cloudfoundry.org/cli/command/v6/v6fakes" 12 "code.cloudfoundry.org/cli/util/configv3" 13 "code.cloudfoundry.org/cli/util/ui" 14 . "github.com/onsi/ginkgo" 15 . "github.com/onsi/gomega" 16 . "github.com/onsi/gomega/gbytes" 17 ) 18 19 var _ = Describe("add-network-policy Command", func() { 20 var ( 21 cmd AddNetworkPolicyCommand 22 testUI *ui.UI 23 fakeConfig *commandfakes.FakeConfig 24 fakeSharedActor *commandfakes.FakeSharedActor 25 fakeNetworkPolicyActor *v6fakes.FakeAddNetworkPolicyActor 26 fakeMembershipActor *v6fakes.FakeMembershipActor 27 binaryName string 28 executeErr error 29 srcApp string 30 destApp string 31 protocol string 32 org string 33 space string 34 ) 35 36 BeforeEach(func() { 37 testUI = ui.NewTestUI(nil, NewBuffer(), NewBuffer()) 38 fakeConfig = new(commandfakes.FakeConfig) 39 fakeSharedActor = new(commandfakes.FakeSharedActor) 40 fakeNetworkPolicyActor = new(v6fakes.FakeAddNetworkPolicyActor) 41 fakeMembershipActor = new(v6fakes.FakeMembershipActor) 42 43 srcApp = "some-app" 44 destApp = "some-other-app" 45 protocol = "tcp" 46 org = "" 47 space = "" 48 49 cmd = AddNetworkPolicyCommand{ 50 UI: testUI, 51 Config: fakeConfig, 52 SharedActor: fakeSharedActor, 53 NetworkPolicyActor: fakeNetworkPolicyActor, 54 MembershipActor: fakeMembershipActor, 55 RequiredArgs: flag.AddNetworkPolicyArgs{SourceApp: srcApp}, 56 DestinationApp: destApp, 57 DestinationSpace: space, 58 DestinationOrg: org, 59 } 60 61 binaryName = "faceman" 62 fakeConfig.BinaryNameReturns(binaryName) 63 }) 64 65 JustBeforeEach(func() { 66 executeErr = cmd.Execute(nil) 67 }) 68 69 When("checking target fails", func() { 70 BeforeEach(func() { 71 fakeSharedActor.CheckTargetReturns(actionerror.NotLoggedInError{BinaryName: binaryName}) 72 }) 73 74 It("returns an error", func() { 75 Expect(executeErr).To(MatchError(actionerror.NotLoggedInError{BinaryName: binaryName})) 76 77 Expect(fakeSharedActor.CheckTargetCallCount()).To(Equal(1)) 78 checkTargetedOrg, checkTargetedSpace := fakeSharedActor.CheckTargetArgsForCall(0) 79 Expect(checkTargetedOrg).To(BeTrue()) 80 Expect(checkTargetedSpace).To(BeTrue()) 81 }) 82 }) 83 84 When("the user is logged in, an org is targeted, and a space is targeted", func() { 85 BeforeEach(func() { 86 fakeConfig.CurrentUserReturns(configv3.User{Name: "some-user"}, nil) 87 fakeConfig.TargetedSpaceReturns(configv3.Space{Name: "some-space", GUID: "some-space-guid"}) 88 fakeConfig.TargetedOrganizationReturns(configv3.Organization{Name: "some-org"}) 89 }) 90 91 When("protocol is specified but port is not", func() { 92 BeforeEach(func() { 93 cmd.Protocol = flag.NetworkProtocol{Protocol: protocol} 94 }) 95 96 It("returns an error", func() { 97 Expect(executeErr).To(MatchError(translatableerror.NetworkPolicyProtocolOrPortNotProvidedError{})) 98 Expect(testUI.Out).NotTo(Say(`Adding network policy`)) 99 }) 100 }) 101 102 When("port is specified but protocol is not", func() { 103 BeforeEach(func() { 104 cmd.Port = flag.NetworkPort{StartPort: 8080, EndPort: 8081} 105 }) 106 107 It("returns an error", func() { 108 Expect(executeErr).To(MatchError(translatableerror.NetworkPolicyProtocolOrPortNotProvidedError{})) 109 Expect(testUI.Out).NotTo(Say(`Adding network policy`)) 110 }) 111 }) 112 113 When("both protocol and port are specificed", func() { 114 BeforeEach(func() { 115 cmd.Protocol = flag.NetworkProtocol{Protocol: protocol} 116 cmd.Port = flag.NetworkPort{StartPort: 8080, EndPort: 8081} 117 }) 118 119 When("the policy creation is successful", func() { 120 BeforeEach(func() { 121 fakeNetworkPolicyActor.AddNetworkPolicyReturns(cfnetworkingaction.Warnings{"some-warning-1", "some-warning-2"}, nil) 122 }) 123 124 It("displays OK when no error occurs", func() { 125 Expect(executeErr).ToNot(HaveOccurred()) 126 Expect(fakeMembershipActor.GetOrganizationByNameCallCount()).To(Equal(0)) 127 Expect(fakeMembershipActor.GetSpaceByNameAndOrganizationCallCount()).To(Equal(0)) 128 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(1)) 129 passedSrcSpaceGuid, passedSrcAppName, passedDestSpaceGuid, passedDestAppName, passedProtocol, passedStartPort, passedEndPort := fakeNetworkPolicyActor.AddNetworkPolicyArgsForCall(0) 130 Expect(passedSrcSpaceGuid).To(Equal("some-space-guid")) 131 Expect(passedSrcAppName).To(Equal("some-app")) 132 Expect(passedDestSpaceGuid).To(Equal("some-space-guid")) 133 Expect(passedDestAppName).To(Equal("some-other-app")) 134 Expect(passedProtocol).To(Equal("tcp")) 135 Expect(passedStartPort).To(Equal(8080)) 136 Expect(passedEndPort).To(Equal(8081)) 137 138 Expect(testUI.Out).To(Say(`Adding network policy from app %s to app %s in org some-org / space some-space as some-user\.\.\.`, srcApp, destApp)) 139 Expect(testUI.Err).To(Say("some-warning-1")) 140 Expect(testUI.Err).To(Say("some-warning-2")) 141 Expect(testUI.Out).To(Say("OK")) 142 }) 143 }) 144 145 When("the policy creation is not successful", func() { 146 BeforeEach(func() { 147 fakeNetworkPolicyActor.AddNetworkPolicyReturns(cfnetworkingaction.Warnings{"some-warning-1", "some-warning-2"}, actionerror.ApplicationNotFoundError{Name: srcApp}) 148 }) 149 150 It("does not display OK when an error occurs", func() { 151 Expect(executeErr).To(MatchError(actionerror.ApplicationNotFoundError{Name: srcApp})) 152 153 Expect(testUI.Out).To(Say(`Adding network policy from app %s to app %s in org some-org / space some-space as some-user\.\.\.`, srcApp, destApp)) 154 Expect(testUI.Err).To(Say("some-warning-1")) 155 Expect(testUI.Err).To(Say("some-warning-2")) 156 Expect(testUI.Out).ToNot(Say("OK")) 157 }) 158 }) 159 }) 160 161 When("both protocol and port are not specified", func() { 162 It("defaults protocol to 'tcp' and port to '8080'", func() { 163 Expect(executeErr).ToNot(HaveOccurred()) 164 165 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(1)) 166 _, _, _, _, passedProtocol, passedStartPort, passedEndPort := fakeNetworkPolicyActor.AddNetworkPolicyArgsForCall(0) 167 Expect(passedProtocol).To(Equal("tcp")) 168 Expect(passedStartPort).To(Equal(8080)) 169 Expect(passedEndPort).To(Equal(8080)) 170 }) 171 }) 172 173 When("org is specified and space is not", func() { 174 BeforeEach(func() { 175 cmd.DestinationOrg = "bananarama" 176 cmd.DestinationSpace = "" 177 fakeMembershipActor.GetOrganizationByNameReturns(v3action.Organization{}, v3action.Warnings{}, actionerror.OrganizationNotFoundError{Name: "bananarama"}) 178 }) 179 180 It("returns an error", func() { 181 Expect(executeErr).To(MatchError(translatableerror.NetworkPolicyDestinationOrgWithoutSpaceError{})) 182 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(0)) 183 }) 184 }) 185 186 When("invalid org is specified", func() { 187 BeforeEach(func() { 188 cmd.DestinationOrg = "bananarama" 189 cmd.DestinationSpace = "hamdinger" 190 warnings := v3action.Warnings{"some-org-warning-1", "some-org-warning-2"} 191 fakeMembershipActor.GetOrganizationByNameReturns(v3action.Organization{}, warnings, actionerror.OrganizationNotFoundError{Name: "bananarama"}) 192 }) 193 194 It("returns an error", func() { 195 Expect(executeErr).To(MatchError(actionerror.OrganizationNotFoundError{Name: "bananarama"})) 196 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(0)) 197 }) 198 199 It("prints the warnings", func() { 200 Expect(testUI.Err).To(Say("some-org-warning-1")) 201 Expect(testUI.Err).To(Say("some-org-warning-2")) 202 }) 203 }) 204 205 When("a valid org but invalid space is specified", func() { 206 BeforeEach(func() { 207 cmd.DestinationOrg = "bananarama" 208 cmd.DestinationSpace = "hamdinger" 209 warnings := v3action.Warnings{"some-space-warning-1", "some-space-warning-2"} 210 fakeMembershipActor.GetOrganizationByNameReturns(v3action.Organization{GUID: "some-org-guid"}, v3action.Warnings{}, nil) 211 fakeMembershipActor.GetSpaceByNameAndOrganizationReturns(v3action.Space{}, warnings, actionerror.SpaceNotFoundError{Name: "bananarama"}) 212 }) 213 214 It("returns an error", func() { 215 passedSpaceName, passedOrgGuid := fakeMembershipActor.GetSpaceByNameAndOrganizationArgsForCall(0) 216 Expect(passedSpaceName).To(Equal("hamdinger")) 217 Expect(passedOrgGuid).To(Equal("some-org-guid")) 218 Expect(executeErr).To(MatchError(actionerror.SpaceNotFoundError{Name: "bananarama"})) 219 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(0)) 220 }) 221 222 It("prints the warnings", func() { 223 Expect(testUI.Err).To(Say("some-space-warning-1")) 224 Expect(testUI.Err).To(Say("some-space-warning-2")) 225 }) 226 }) 227 228 When("a destination space but no destination org is specified", func() { 229 BeforeEach(func() { 230 cmd.DestinationSpace = "hamdinger" 231 warnings := v3action.Warnings{"some-warning-1", "some-warning-2"} 232 fakeMembershipActor.GetSpaceByNameAndOrganizationReturns(v3action.Space{GUID: "some-other-space-guid"}, warnings, nil) 233 }) 234 235 It("displays OK", func() { 236 Expect(executeErr).ToNot(HaveOccurred()) 237 Expect(fakeMembershipActor.GetOrganizationByNameCallCount()).To(Equal(0)) 238 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(1)) 239 passedSrcSpaceGuid, _, passedDestSpaceGuid, _, _, _, _ := fakeNetworkPolicyActor.AddNetworkPolicyArgsForCall(0) 240 Expect(passedSrcSpaceGuid).To(Equal("some-space-guid")) 241 Expect(passedDestSpaceGuid).To(Equal("some-other-space-guid")) 242 243 Expect(testUI.Out).To(Say(`Adding network policy from app %s in org some-org / space some-space to app %s in org some-org / space hamdinger as some-user\.\.\.`, srcApp, destApp)) 244 Expect(testUI.Out).To(Say("OK")) 245 }) 246 247 It("prints the warnings", func() { 248 Expect(testUI.Err).To(Say("some-warning-1")) 249 Expect(testUI.Err).To(Say("some-warning-2")) 250 }) 251 }) 252 253 When("a destination org and space is specified for destination app", func() { 254 BeforeEach(func() { 255 cmd.DestinationOrg = "bananarama" 256 cmd.DestinationSpace = "hamdinger" 257 fakeMembershipActor.GetOrganizationByNameReturns(v3action.Organization{GUID: "some-org-guid"}, v3action.Warnings{"some-org-warning-1", "some-org-warning-2"}, nil) 258 fakeMembershipActor.GetSpaceByNameAndOrganizationReturns(v3action.Space{GUID: "some-other-space-guid"}, v3action.Warnings{"some-space-warning-1", "some-space-warning-2"}, nil) 259 fakeNetworkPolicyActor.AddNetworkPolicyReturns(cfnetworkingaction.Warnings{"some-add-warning-1", "some-add-warning-2"}, nil) 260 }) 261 262 It("displays OK", func() { 263 Expect(executeErr).ToNot(HaveOccurred()) 264 Expect(fakeNetworkPolicyActor.AddNetworkPolicyCallCount()).To(Equal(1)) 265 passedSrcSpaceGuid, _, passedDestSpaceGuid, _, _, _, _ := fakeNetworkPolicyActor.AddNetworkPolicyArgsForCall(0) 266 Expect(passedSrcSpaceGuid).To(Equal("some-space-guid")) 267 Expect(passedDestSpaceGuid).To(Equal("some-other-space-guid")) 268 269 Expect(testUI.Out).To(Say(`Adding network policy from app %s in org some-org / space some-space to app %s in org bananarama / space hamdinger as some-user\.\.\.`, srcApp, destApp)) 270 Expect(testUI.Err).To(Say("some-org-warning-1")) 271 Expect(testUI.Err).To(Say("some-org-warning-2")) 272 Expect(testUI.Err).To(Say("some-space-warning-1")) 273 Expect(testUI.Err).To(Say("some-space-warning-2")) 274 Expect(testUI.Err).To(Say("some-add-warning-1")) 275 Expect(testUI.Err).To(Say("some-add-warning-2")) 276 Expect(testUI.Out).To(Say("OK")) 277 }) 278 }) 279 }) 280 })