github.com/niedbalski/juju@v0.0.0-20190215020005-8ff100488e47/apiserver/apiserverhttp/mux_test.go

// Copyright 2018 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.

package apiserverhttp_test

import (
	"net/http"
	"net/http/httptest"
	"sync"
	"time"

	"github.com/juju/testing"
	jc "github.com/juju/testing/checkers"
	gc "gopkg.in/check.v1"

	"github.com/juju/juju/apiserver/apiserverhttp"
	coretesting "github.com/juju/juju/testing"
)

type MuxSuite struct {
	testing.IsolationSuite
	mux    *apiserverhttp.Mux
	server *httptest.Server
	client *http.Client
}

var _ = gc.Suite(&MuxSuite{})

func (s *MuxSuite) SetUpTest(c *gc.C) {
	s.IsolationSuite.SetUpTest(c)
	s.mux = apiserverhttp.NewMux()
	s.server = httptest.NewServer(s.mux)
	s.client = s.server.Client()
	s.AddCleanup(func(c *gc.C) {
		s.server.Close()
	})
}

func (s *MuxSuite) TestNotFound(c *gc.C) {
	resp, err := s.client.Get(s.server.URL + "/")
	c.Assert(err, jc.ErrorIsNil)
	defer resp.Body.Close()

	c.Assert(resp.StatusCode, gc.Equals, http.StatusNotFound)
}

func (s *MuxSuite) TestAddHandler(c *gc.C) {
	err := s.mux.AddHandler("GET", "/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
	c.Assert(err, jc.ErrorIsNil)

	resp, err := s.client.Get(s.server.URL + "/")
	c.Assert(err, jc.ErrorIsNil)
	defer resp.Body.Close()

	c.Assert(resp.StatusCode, gc.Equals, http.StatusOK)
}

func (s *MuxSuite) TestAddRemoveNotFound(c *gc.C) {
	s.mux.AddHandler("GET", "/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
	s.mux.RemoveHandler("GET", "/")

	resp, err := s.client.Get(s.server.URL + "/")
	c.Assert(err, jc.ErrorIsNil)
	defer resp.Body.Close()

	c.Assert(resp.StatusCode, gc.Equals, http.StatusNotFound)
}

func (s *MuxSuite) TestAddHandlerExists(c *gc.C) {
	s.mux.AddHandler("GET", "/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
	err := s.mux.AddHandler("GET", "/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
	c.Assert(err, gc.ErrorMatches, `handler for GET "/" already exists`)
}

func (s *MuxSuite) TestRemoveHandlerMissing(c *gc.C) {
	s.mux.RemoveHandler("GET", "/") // no-op
}

func (s *MuxSuite) TestMethodNotSupported(c *gc.C) {
	s.mux.AddHandler("POST", "/", http.NotFoundHandler())
	resp, err := s.client.Get(s.server.URL + "/")
	c.Assert(err, jc.ErrorIsNil)
	defer resp.Body.Close()

	c.Assert(resp.StatusCode, gc.Equals, http.StatusMethodNotAllowed)
}

func (s *MuxSuite) TestConcurrentAddHandler(c *gc.C) {
	err := s.mux.AddHandler("GET", "/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
	c.Assert(err, jc.ErrorIsNil)

	// Concurrently add and remove another handler to show that
	// adding and removing handlers will not race with request
	// handling.
	const N = 1000
	var wg sync.WaitGroup
	wg.Add(1)
	go func() {
		defer wg.Done()
		for i := 0; i < N; i++ {
			s.mux.AddHandler("POST", "/", http.NotFoundHandler())
			s.mux.RemoveHandler("POST", "/")
		}
	}()
	defer wg.Wait()

	for i := 0; i < N; i++ {
		resp, err := s.client.Get(s.server.URL + "/")
		c.Assert(err, jc.ErrorIsNil)
		resp.Body.Close()
		c.Assert(resp.StatusCode, gc.Equals, http.StatusOK)
	}
}

func (s *MuxSuite) TestConcurrentRemoveHandler(c *gc.C) {
	h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})

	// Concurrently add and remove another handler to show that
	// adding and removing handlers will not race with request
	// handling.
	const N = 500
	var wg sync.WaitGroup
	wg.Add(1)
	go func() {
		defer wg.Done()
		for i := 0; i < N; i++ {
			s.mux.AddHandler("GET", "/", h)
			// Sleep to give the client a
			// chance to hit the endpoint.
			time.Sleep(time.Millisecond)
			s.mux.RemoveHandler("GET", "/")
		}
	}()
	defer wg.Wait()

	var ok, notfound int
	for i := 0; i < N; i++ {
		resp, err := s.client.Get(s.server.URL + "/")
		c.Assert(err, jc.ErrorIsNil)
		resp.Body.Close()
		switch resp.StatusCode {
		case http.StatusOK:
			ok++
		case http.StatusNotFound:
			notfound++
		default:
			c.Fatalf(
				"got status %d, expected %d or %d",
				resp.StatusCode,
				http.StatusOK,
				http.StatusNotFound,
			)
		}
		time.Sleep(time.Millisecond)
	}
	c.Assert(ok, gc.Not(gc.Equals), 0)
	c.Assert(notfound, gc.Not(gc.Equals), 0)
}

func (s *MuxSuite) TestWait(c *gc.C) {
	// Check that mux.Wait() blocks until clients are all finished
	// with it.
	s.mux.AddClient()
	s.mux.AddClient()
	finished := make(chan struct{})
	go func() {
		defer close(finished)
		s.mux.Wait()
	}()

	select {
	case <-finished:
		c.Fatalf("should wait when there are clients")
	case <-time.After(coretesting.ShortWait):
	}

	s.mux.ClientDone()
	select {
	case <-finished:
		c.Fatalf("should wait when there is still a client")
	case <-time.After(coretesting.ShortWait):
	}

	s.mux.ClientDone()
	select {
	case <-finished:
	case <-time.After(coretesting.LongWait):
		c.Fatalf("should finish once clients are done")
	}
}