github.com/nikron/prototool@v1.3.0/internal/lint/check_rpcs_have_comments.go (about)

     1  // Copyright (c) 2018 Uber Technologies, Inc.
     2  //
     3  // Permission is hereby granted, free of charge, to any person obtaining a copy
     4  // of this software and associated documentation files (the "Software"), to deal
     5  // in the Software without restriction, including without limitation the rights
     6  // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
     7  // copies of the Software, and to permit persons to whom the Software is
     8  // furnished to do so, subject to the following conditions:
     9  //
    10  // The above copyright notice and this permission notice shall be included in
    11  // all copies or substantial portions of the Software.
    12  //
    13  // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
    14  // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
    15  // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
    16  // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
    17  // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
    18  // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
    19  // THE SOFTWARE.
    20  
    21  package lint
    22  
    23  import (
    24  	"fmt"
    25  	"strings"
    26  
    27  	"github.com/emicklei/proto"
    28  	"github.com/uber/prototool/internal/text"
    29  )
    30  
    31  var rpcsHaveCommentsLinter = NewLinter(
    32  	"RPCS_HAVE_COMMENTS",
    33  	`Verifies that all rpcs have a comment of the form "// RPCName ...".`,
    34  	checkRPCsHaveComments,
    35  )
    36  
    37  func checkRPCsHaveComments(add func(*text.Failure), dirPath string, descriptors []*proto.Proto) error {
    38  	return runVisitor(rpcsHaveCommentsVisitor{baseAddVisitor: newBaseAddVisitor(add)}, descriptors)
    39  }
    40  
    41  type rpcsHaveCommentsVisitor struct {
    42  	baseAddVisitor
    43  }
    44  
    45  func (v rpcsHaveCommentsVisitor) VisitService(service *proto.Service) {
    46  	for _, child := range service.Elements {
    47  		child.Accept(v)
    48  	}
    49  }
    50  
    51  func (v rpcsHaveCommentsVisitor) VisitRPC(rpc *proto.RPC) {
    52  	if rpc.Comment == nil || len(rpc.Comment.Lines) == 0 || !strings.HasPrefix(rpc.Comment.Lines[0], fmt.Sprintf(" %s ", rpc.Name)) {
    53  		v.AddFailuref(rpc.Position, `RPC %q needs a comment of the form "// %s ..."`, rpc.Name, rpc.Name)
    54  	}
    55  }