github.com/onflow/flow-go@v0.35.7-crescendo-preview.23-atree-inlining/consensus/hotstuff/committees/cluster_committee_test.go

package committees

import (
	"math/rand"
	"testing"

	"github.com/stretchr/testify/suite"

	"github.com/onflow/flow-go/consensus/hotstuff/model"
	"github.com/onflow/flow-go/model/cluster"
	"github.com/onflow/flow-go/model/flow"
	clusterstate "github.com/onflow/flow-go/state/cluster"
	"github.com/onflow/flow-go/state/protocol"
	protocolmock "github.com/onflow/flow-go/state/protocol/mock"
	"github.com/onflow/flow-go/state/protocol/prg"
	storagemock "github.com/onflow/flow-go/storage/mock"
	"github.com/onflow/flow-go/utils/unittest"
)

// ClusterSuite defines a test suite for the cluster committee.
type ClusterSuite struct {
	suite.Suite

	state    *protocolmock.State
	snap     *protocolmock.Snapshot
	cluster  *protocolmock.Cluster
	epoch    *protocolmock.Epoch
	payloads *storagemock.ClusterPayloads

	members flow.IdentityList
	root    *cluster.Block
	me      *flow.Identity

	com *Cluster
}

func TestClusterCommittee(t *testing.T) {
	suite.Run(t, new(ClusterSuite))
}

func (suite *ClusterSuite) SetupTest() {

	suite.state = new(protocolmock.State)
	suite.snap = new(protocolmock.Snapshot)
	suite.cluster = new(protocolmock.Cluster)
	suite.epoch = new(protocolmock.Epoch)
	suite.payloads = new(storagemock.ClusterPayloads)

	suite.members = unittest.IdentityListFixture(5, unittest.WithRole(flow.RoleCollection))
	suite.me = suite.members[0]
	counter := uint64(1)
	suite.root = clusterstate.CanonicalRootBlock(counter, suite.members.ToSkeleton())

	suite.cluster.On("EpochCounter").Return(counter)
	suite.cluster.On("Index").Return(uint(1))
	suite.cluster.On("Members").Return(suite.members.ToSkeleton())
	suite.cluster.On("RootBlock").Return(suite.root)
	suite.epoch.On("Counter").Return(counter, nil)
	suite.epoch.On("RandomSource").Return(unittest.SeedFixture(prg.RandomSourceLength), nil)

	var err error
	suite.com, err = NewClusterCommittee(
		suite.state,
		suite.payloads,
		suite.cluster,
		suite.epoch,
		suite.me.NodeID,
	)
	suite.Require().NoError(err)
}

// TestThresholds tests that the correct thresholds are returned.
func (suite *ClusterSuite) TestThresholds() {
	threshold, err := suite.com.QuorumThresholdForView(rand.Uint64())
	suite.Require().NoError(err)
	suite.Assert().Equal(WeightThresholdToBuildQC(suite.members.ToSkeleton().TotalWeight()), threshold)

	threshold, err = suite.com.TimeoutThresholdForView(rand.Uint64())
	suite.Require().NoError(err)
	suite.Assert().Equal(WeightThresholdToTimeout(suite.members.ToSkeleton().TotalWeight()), threshold)
}

// TestInvalidSigner tests that the InvalidSignerError sentinel is
// returned under the appropriate conditions.
func (suite *ClusterSuite) TestInvalidSigner() {

	// hook up cluster->main chain connection for root and non-root cluster block
	nonRootBlockID := unittest.IdentifierFixture()
	rootBlockID := suite.root.ID()

	refID := unittest.IdentifierFixture()            // reference block on main chain
	payload := cluster.EmptyPayload(refID)           // payload referencing main chain
	rootPayload := cluster.EmptyPayload(flow.ZeroID) // root cluster block payload

	suite.payloads.On("ByBlockID", nonRootBlockID).Return(&payload, nil)
	suite.payloads.On("ByBlockID", rootBlockID).Return(&rootPayload, nil)

	// a real cluster member which continues to be a valid member
	realClusterMember := suite.members[1]
	// a real cluster member which unstaked and is not active anymore
	// and the test's reference block
	realLeavingClusterMember := suite.members[2]
	realLeavingClusterMember.EpochParticipationStatus = flow.EpochParticipationStatusLeaving
	// a real cluster member which is ejected between cluster initialization and
	// the test's reference block
	realEjectedClusterMember := suite.members[3]
	realEjectedClusterMember.EpochParticipationStatus = flow.EpochParticipationStatusEjected
	realNonClusterMember := unittest.IdentityFixture(unittest.WithRole(flow.RoleCollection))
	fakeID := unittest.IdentifierFixture()

	suite.state.On("AtBlockID", refID).Return(suite.snap)
	suite.snap.On("Identity", realClusterMember.NodeID).Return(realClusterMember, nil)
	suite.snap.On("Identity", realLeavingClusterMember.NodeID).Return(realLeavingClusterMember, nil)
	suite.snap.On("Identity", realEjectedClusterMember.NodeID).Return(realEjectedClusterMember, nil)
	suite.snap.On("Identity", realNonClusterMember.NodeID).Return(realNonClusterMember, nil)
	suite.snap.On("Identity", fakeID).Return(nil, protocol.IdentityNotFoundError{})

	suite.Run("should return InvalidSignerError for non-existent signer", func() {
		suite.Run("root block", func() {
			_, err := suite.com.IdentityByBlock(rootBlockID, fakeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("non-root block", func() {
			_, err := suite.com.IdentityByBlock(nonRootBlockID, fakeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("by epoch", func() {
			_, err := suite.com.IdentityByEpoch(rand.Uint64(), fakeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
	})

	suite.Run("should return ErrInvalidSigner for existent but not active cluster member", func() {
		suite.Run("non-root block", func() {
			_, err := suite.com.IdentityByBlock(nonRootBlockID, realLeavingClusterMember.NodeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("by epoch", func() {
			actual, err := suite.com.IdentityByEpoch(rand.Uint64(), realLeavingClusterMember.NodeID)
			suite.Require().NoError(err)
			suite.Assert().Equal(realLeavingClusterMember.IdentitySkeleton, *actual)
		})
	})

	suite.Run("should return InvalidSignerError for existent non-cluster-member", func() {
		suite.Run("root block", func() {
			_, err := suite.com.IdentityByBlock(rootBlockID, realNonClusterMember.NodeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("non-root block", func() {
			_, err := suite.com.IdentityByBlock(nonRootBlockID, realNonClusterMember.NodeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("by epoch", func() {
			_, err := suite.com.IdentityByEpoch(rand.Uint64(), realNonClusterMember.NodeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
	})

	suite.Run("should return ErrInvalidSigner for existent but ejected cluster member", func() {
		suite.Run("non-root block", func() {
			_, err := suite.com.IdentityByBlock(nonRootBlockID, realEjectedClusterMember.NodeID)
			suite.Assert().True(model.IsInvalidSignerError(err))
		})
		suite.Run("by epoch", func() {
			actual, err := suite.com.IdentityByEpoch(rand.Uint64(), realEjectedClusterMember.NodeID)
			suite.Assert().NoError(err)
			suite.Assert().Equal(realEjectedClusterMember.IdentitySkeleton, *actual)
		})
	})

	suite.Run("should return identity for existent cluster member", func() {
		suite.Run("root block", func() {
			actual, err := suite.com.IdentityByBlock(rootBlockID, realClusterMember.NodeID)
			suite.Require().NoError(err)
			suite.Assert().Equal(realClusterMember, actual)
		})
		suite.Run("non-root block", func() {
			actual, err := suite.com.IdentityByBlock(nonRootBlockID, realClusterMember.NodeID)
			suite.Require().NoError(err)
			suite.Assert().Equal(realClusterMember, actual)
		})
		suite.Run("by epoch", func() {
			actual, err := suite.com.IdentityByEpoch(rand.Uint64(), realClusterMember.NodeID)
			suite.Require().NoError(err)
			suite.Assert().Equal(realClusterMember.IdentitySkeleton, *actual)
		})
	})
}