github.com/parquet-go/parquet-go@v0.21.1-0.20240501160520-b3c3a0c3ed6f/CONTRIBUTING.md (about) 1 # Contributing to segmentio/parquet 2 3 ## Code of Conduct 4 5 Help us keep the project open and inclusive. Please be kind to and 6 considerate of other developers, as we all have the same goal: make 7 the project as good as it can be. 8 9 * [Code of Conduct](./CODE_OF_CONDUCT.md) 10 11 ## Licensing 12 13 All third party contributors acknowledge that any contributions they provide 14 will be made under the same open source license that the open source project 15 is provided under. 16 17 ## Contributing 18 19 * Open an Issue to report bugs or discuss non-trivial changes. 20 * Open a Pull Request to submit a code change for review. 21 22 ### Guidelines for code review 23 24 It's good to do code review but we are busy and it's bad to wait for consensus 25 or opinions that might not arrive. Here are some guidelines 26 27 #### Changes where code review is optional 28 29 - Documentation changes 30 - Bug fixes where a reproducible test case exists 31 - Keeping the lights on style work (compat with new Parquet versions, new Go 32 versions, for example) 33 - Updates to the CI environment 34 - Adding additional benchmarks or test cases 35 - Pull requests that have been open for 30 days, where an attempt has been made 36 to contact another code owner, and no one has expressly requested changes 37 38 #### Changes that should get at least one code review from an owner 39 40 - Changes that may affect the performance of core library functionality 41 (serializing, deserializing Parquet data) by more than 2% 42 - Behavior changes 43 - New API or changes to existing API 44 45 ### Coding Rules 46 47 To ensure consistency throughout the source code, keep these rules in mind 48 when submitting contributions: 49 50 * All features or bug fixes must be tested by one or more tests. 51 * All exported types, functions, and symbols must be documented. 52 * All code must be formatted with `go fmt`.