github.com/qri-io/qri@v0.10.1-0.20220104210721-c771715036cb/cmd/rename_integration_test.go

package cmd

import (
	"fmt"
	"strings"
	"testing"

	"github.com/google/go-cmp/cmp"
	"github.com/qri-io/dataset"
	"github.com/qri-io/qfs"
	"github.com/qri-io/qri/dsref"
)

// Test that rename command only works with human-friendly references, those without paths
func TestRenameNeedsHumanName(t *testing.T) {
	run := NewTestRunner(t, "test_peer_rename_human", "rename_human")
	defer run.Delete()

	// Create a dataset and get the resolved reference to it
	output := run.MustExecCombinedOutErr(t, "qri save --body=testdata/movies/body_ten.csv me/first_name")
	ref := dsref.MustParse(parseRefFromSave(output))

	if !strings.HasPrefix(ref.Path, "/ipfs/") {
		t.Errorf("expected saved ref to start with '/ipfs/', but got %q", ref.Path)
	}

	// Parse error for the land-hand-side
	err := run.ExecCommand("qri rename test_peer_rename_human/invalid+name test_peer_rename_human/second_name")
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr := `original name: unexpected character at position 30: '+'`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	lhs := ref.Copy()

	// Given a resolved reference for the left-hand-side is an error
	err = run.ExecCommand(fmt.Sprintf("qri rename %s test_peer_rename_human/second_name", lhs))
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr = `original name: unexpected character '@', ref can only have username/name`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	// Make left-hand-side into a human-friendly path
	lhs.Path = ""

	// Parse error for the right-hand-side
	err = run.ExecCommand(fmt.Sprintf("qri rename %s test_peer_rename_human/invalid+name", lhs))
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr = `destination name: dataset name must start with a lower-case letter, and only contain lower-case letters, numbers, dashes, and underscore. Maximum length is 144 characters`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	// Create right-hand-side with a path
	rhs := ref.Copy()
	rhs.Name = "second_name"

	// Given a resolved reference for the right-hand-side is an error
	err = run.ExecCommand(fmt.Sprintf("qri rename %s %s", lhs, rhs))
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr = `destination name: unexpected character '@', ref can only have username/name`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	// Make right-hand-side into a human-friendly path
	rhs.Path = ""

	// Now the rename command works without error
	err = run.ExecCommand(fmt.Sprintf("qri rename %s %s", lhs, rhs))
	if err != nil {
		t.Errorf("got error: %s", err)
	}
}

// Test that rename can be used on names with bad upper-case characters, but only to rename them
// to be valid instead
func TestRenameAwayFromBadCase(t *testing.T) {
	run := NewTestRunner(t, "test_peer_rename_away_from_bad_case", "rename_away_from_bad_case")
	defer run.Delete()

	// Create a dataset with a valid name
	run.MustExec(t, "qri save --body=testdata/movies/body_ten.csv me/first_name")

	// Cannot rename the dataset to a name with bad upper-case characters
	err := run.ExecCommand("qri rename test_peer_rename_away_from_bad_case/first_name test_peer_rename_away_from_bad_case/useUpperCase")
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr := `destination name: dataset name must start with a lower-case letter, and only contain lower-case letters, numbers, dashes, and underscore. Maximum length is 144 characters`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	// Construct a dataset
	ds := dataset.Dataset{
		Structure: &dataset.Structure{
			Format: "json",
			Schema: dataset.BaseSchemaArray,
		},
	}
	ds.SetBodyFile(qfs.NewMemfileBytes("body.json", []byte("[[\"one\",2],[\"three\",4]]")))

	// Add the dataset to the repo directly, which avoids the name validation check.
	run.AddDatasetToRefstore(t, "test_peer_rename_away_from_bad_case/a_New_Dataset", &ds)

	// Cannot rename the dataset to a name with bad upper-case characters still
	err = run.ExecCommand("qri rename test_peer_rename_away_from_bad_case/a_New_Dataset test_peer_rename_away_from_bad_case/useUpperCase")
	if err == nil {
		t.Fatal("expected error, did not get one")
	}
	expectErr = `destination name: dataset name must start with a lower-case letter, and only contain lower-case letters, numbers, dashes, and underscore. Maximum length is 144 characters`
	if diff := cmp.Diff(expectErr, errorMessage(err)); diff != "" {
		t.Errorf("unexpected (-want +got):\n%s", diff)
	}

	// Okay to rename a name with bad upper-case characters to a new valid name
	err = run.ExecCommand("qri rename test_peer_rename_away_from_bad_case/a_New_Dataset test_peer_rename_away_from_bad_case/a_new_dataset")
	if err != nil {
		t.Errorf("got error: %s", err)
	}
}