github.com/sbinet/go@v0.0.0-20160827155028-54d7de7dd62b/src/net/http/serve_test.go (about) 1 // Copyright 2010 The Go Authors. All rights reserved. 2 // Use of this source code is governed by a BSD-style 3 // license that can be found in the LICENSE file. 4 5 // End-to-end serving tests 6 7 package http_test 8 9 import ( 10 "bufio" 11 "bytes" 12 "compress/gzip" 13 "context" 14 "crypto/tls" 15 "encoding/json" 16 "errors" 17 "fmt" 18 "internal/testenv" 19 "io" 20 "io/ioutil" 21 "log" 22 "math/rand" 23 "net" 24 . "net/http" 25 "net/http/httptest" 26 "net/http/httputil" 27 "net/http/internal" 28 "net/url" 29 "os" 30 "os/exec" 31 "reflect" 32 "runtime" 33 "runtime/debug" 34 "sort" 35 "strconv" 36 "strings" 37 "sync" 38 "sync/atomic" 39 "syscall" 40 "testing" 41 "time" 42 ) 43 44 type dummyAddr string 45 type oneConnListener struct { 46 conn net.Conn 47 } 48 49 func (l *oneConnListener) Accept() (c net.Conn, err error) { 50 c = l.conn 51 if c == nil { 52 err = io.EOF 53 return 54 } 55 err = nil 56 l.conn = nil 57 return 58 } 59 60 func (l *oneConnListener) Close() error { 61 return nil 62 } 63 64 func (l *oneConnListener) Addr() net.Addr { 65 return dummyAddr("test-address") 66 } 67 68 func (a dummyAddr) Network() string { 69 return string(a) 70 } 71 72 func (a dummyAddr) String() string { 73 return string(a) 74 } 75 76 type noopConn struct{} 77 78 func (noopConn) LocalAddr() net.Addr { return dummyAddr("local-addr") } 79 func (noopConn) RemoteAddr() net.Addr { return dummyAddr("remote-addr") } 80 func (noopConn) SetDeadline(t time.Time) error { return nil } 81 func (noopConn) SetReadDeadline(t time.Time) error { return nil } 82 func (noopConn) SetWriteDeadline(t time.Time) error { return nil } 83 84 type rwTestConn struct { 85 io.Reader 86 io.Writer 87 noopConn 88 89 closeFunc func() error // called if non-nil 90 closec chan bool // else, if non-nil, send value to it on close 91 } 92 93 func (c *rwTestConn) Close() error { 94 if c.closeFunc != nil { 95 return c.closeFunc() 96 } 97 select { 98 case c.closec <- true: 99 default: 100 } 101 return nil 102 } 103 104 type testConn struct { 105 readMu sync.Mutex // for TestHandlerBodyClose 106 readBuf bytes.Buffer 107 writeBuf bytes.Buffer 108 closec chan bool // if non-nil, send value to it on close 109 noopConn 110 } 111 112 func (c *testConn) Read(b []byte) (int, error) { 113 c.readMu.Lock() 114 defer c.readMu.Unlock() 115 return c.readBuf.Read(b) 116 } 117 118 func (c *testConn) Write(b []byte) (int, error) { 119 return c.writeBuf.Write(b) 120 } 121 122 func (c *testConn) Close() error { 123 select { 124 case c.closec <- true: 125 default: 126 } 127 return nil 128 } 129 130 // reqBytes treats req as a request (with \n delimiters) and returns it with \r\n delimiters, 131 // ending in \r\n\r\n 132 func reqBytes(req string) []byte { 133 return []byte(strings.Replace(strings.TrimSpace(req), "\n", "\r\n", -1) + "\r\n\r\n") 134 } 135 136 type handlerTest struct { 137 handler Handler 138 } 139 140 func newHandlerTest(h Handler) handlerTest { 141 return handlerTest{h} 142 } 143 144 func (ht handlerTest) rawResponse(req string) string { 145 reqb := reqBytes(req) 146 var output bytes.Buffer 147 conn := &rwTestConn{ 148 Reader: bytes.NewReader(reqb), 149 Writer: &output, 150 closec: make(chan bool, 1), 151 } 152 ln := &oneConnListener{conn: conn} 153 go Serve(ln, ht.handler) 154 <-conn.closec 155 return output.String() 156 } 157 158 func TestConsumingBodyOnNextConn(t *testing.T) { 159 defer afterTest(t) 160 conn := new(testConn) 161 for i := 0; i < 2; i++ { 162 conn.readBuf.Write([]byte( 163 "POST / HTTP/1.1\r\n" + 164 "Host: test\r\n" + 165 "Content-Length: 11\r\n" + 166 "\r\n" + 167 "foo=1&bar=1")) 168 } 169 170 reqNum := 0 171 ch := make(chan *Request) 172 servech := make(chan error) 173 listener := &oneConnListener{conn} 174 handler := func(res ResponseWriter, req *Request) { 175 reqNum++ 176 ch <- req 177 } 178 179 go func() { 180 servech <- Serve(listener, HandlerFunc(handler)) 181 }() 182 183 var req *Request 184 req = <-ch 185 if req == nil { 186 t.Fatal("Got nil first request.") 187 } 188 if req.Method != "POST" { 189 t.Errorf("For request #1's method, got %q; expected %q", 190 req.Method, "POST") 191 } 192 193 req = <-ch 194 if req == nil { 195 t.Fatal("Got nil first request.") 196 } 197 if req.Method != "POST" { 198 t.Errorf("For request #2's method, got %q; expected %q", 199 req.Method, "POST") 200 } 201 202 if serveerr := <-servech; serveerr != io.EOF { 203 t.Errorf("Serve returned %q; expected EOF", serveerr) 204 } 205 } 206 207 type stringHandler string 208 209 func (s stringHandler) ServeHTTP(w ResponseWriter, r *Request) { 210 w.Header().Set("Result", string(s)) 211 } 212 213 var handlers = []struct { 214 pattern string 215 msg string 216 }{ 217 {"/", "Default"}, 218 {"/someDir/", "someDir"}, 219 {"/#/", "hash"}, 220 {"someHost.com/someDir/", "someHost.com/someDir"}, 221 } 222 223 var vtests = []struct { 224 url string 225 expected string 226 }{ 227 {"http://localhost/someDir/apage", "someDir"}, 228 {"http://localhost/%23/apage", "hash"}, 229 {"http://localhost/otherDir/apage", "Default"}, 230 {"http://someHost.com/someDir/apage", "someHost.com/someDir"}, 231 {"http://otherHost.com/someDir/apage", "someDir"}, 232 {"http://otherHost.com/aDir/apage", "Default"}, 233 // redirections for trees 234 {"http://localhost/someDir", "/someDir/"}, 235 {"http://localhost/%23", "/%23/"}, 236 {"http://someHost.com/someDir", "/someDir/"}, 237 } 238 239 func TestHostHandlers(t *testing.T) { 240 defer afterTest(t) 241 mux := NewServeMux() 242 for _, h := range handlers { 243 mux.Handle(h.pattern, stringHandler(h.msg)) 244 } 245 ts := httptest.NewServer(mux) 246 defer ts.Close() 247 248 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 249 if err != nil { 250 t.Fatal(err) 251 } 252 defer conn.Close() 253 cc := httputil.NewClientConn(conn, nil) 254 for _, vt := range vtests { 255 var r *Response 256 var req Request 257 if req.URL, err = url.Parse(vt.url); err != nil { 258 t.Errorf("cannot parse url: %v", err) 259 continue 260 } 261 if err := cc.Write(&req); err != nil { 262 t.Errorf("writing request: %v", err) 263 continue 264 } 265 r, err := cc.Read(&req) 266 if err != nil { 267 t.Errorf("reading response: %v", err) 268 continue 269 } 270 switch r.StatusCode { 271 case StatusOK: 272 s := r.Header.Get("Result") 273 if s != vt.expected { 274 t.Errorf("Get(%q) = %q, want %q", vt.url, s, vt.expected) 275 } 276 case StatusMovedPermanently: 277 s := r.Header.Get("Location") 278 if s != vt.expected { 279 t.Errorf("Get(%q) = %q, want %q", vt.url, s, vt.expected) 280 } 281 default: 282 t.Errorf("Get(%q) unhandled status code %d", vt.url, r.StatusCode) 283 } 284 } 285 } 286 287 var serveMuxRegister = []struct { 288 pattern string 289 h Handler 290 }{ 291 {"/dir/", serve(200)}, 292 {"/search", serve(201)}, 293 {"codesearch.google.com/search", serve(202)}, 294 {"codesearch.google.com/", serve(203)}, 295 {"example.com/", HandlerFunc(checkQueryStringHandler)}, 296 } 297 298 // serve returns a handler that sends a response with the given code. 299 func serve(code int) HandlerFunc { 300 return func(w ResponseWriter, r *Request) { 301 w.WriteHeader(code) 302 } 303 } 304 305 // checkQueryStringHandler checks if r.URL.RawQuery has the same value 306 // as the URL excluding the scheme and the query string and sends 200 307 // response code if it is, 500 otherwise. 308 func checkQueryStringHandler(w ResponseWriter, r *Request) { 309 u := *r.URL 310 u.Scheme = "http" 311 u.Host = r.Host 312 u.RawQuery = "" 313 if "http://"+r.URL.RawQuery == u.String() { 314 w.WriteHeader(200) 315 } else { 316 w.WriteHeader(500) 317 } 318 } 319 320 var serveMuxTests = []struct { 321 method string 322 host string 323 path string 324 code int 325 pattern string 326 }{ 327 {"GET", "google.com", "/", 404, ""}, 328 {"GET", "google.com", "/dir", 301, "/dir/"}, 329 {"GET", "google.com", "/dir/", 200, "/dir/"}, 330 {"GET", "google.com", "/dir/file", 200, "/dir/"}, 331 {"GET", "google.com", "/search", 201, "/search"}, 332 {"GET", "google.com", "/search/", 404, ""}, 333 {"GET", "google.com", "/search/foo", 404, ""}, 334 {"GET", "codesearch.google.com", "/search", 202, "codesearch.google.com/search"}, 335 {"GET", "codesearch.google.com", "/search/", 203, "codesearch.google.com/"}, 336 {"GET", "codesearch.google.com", "/search/foo", 203, "codesearch.google.com/"}, 337 {"GET", "codesearch.google.com", "/", 203, "codesearch.google.com/"}, 338 {"GET", "images.google.com", "/search", 201, "/search"}, 339 {"GET", "images.google.com", "/search/", 404, ""}, 340 {"GET", "images.google.com", "/search/foo", 404, ""}, 341 {"GET", "google.com", "/../search", 301, "/search"}, 342 {"GET", "google.com", "/dir/..", 301, ""}, 343 {"GET", "google.com", "/dir/..", 301, ""}, 344 {"GET", "google.com", "/dir/./file", 301, "/dir/"}, 345 346 // The /foo -> /foo/ redirect applies to CONNECT requests 347 // but the path canonicalization does not. 348 {"CONNECT", "google.com", "/dir", 301, "/dir/"}, 349 {"CONNECT", "google.com", "/../search", 404, ""}, 350 {"CONNECT", "google.com", "/dir/..", 200, "/dir/"}, 351 {"CONNECT", "google.com", "/dir/..", 200, "/dir/"}, 352 {"CONNECT", "google.com", "/dir/./file", 200, "/dir/"}, 353 } 354 355 func TestServeMuxHandler(t *testing.T) { 356 mux := NewServeMux() 357 for _, e := range serveMuxRegister { 358 mux.Handle(e.pattern, e.h) 359 } 360 361 for _, tt := range serveMuxTests { 362 r := &Request{ 363 Method: tt.method, 364 Host: tt.host, 365 URL: &url.URL{ 366 Path: tt.path, 367 }, 368 } 369 h, pattern := mux.Handler(r) 370 rr := httptest.NewRecorder() 371 h.ServeHTTP(rr, r) 372 if pattern != tt.pattern || rr.Code != tt.code { 373 t.Errorf("%s %s %s = %d, %q, want %d, %q", tt.method, tt.host, tt.path, rr.Code, pattern, tt.code, tt.pattern) 374 } 375 } 376 } 377 378 var serveMuxTests2 = []struct { 379 method string 380 host string 381 url string 382 code int 383 redirOk bool 384 }{ 385 {"GET", "google.com", "/", 404, false}, 386 {"GET", "example.com", "/test/?example.com/test/", 200, false}, 387 {"GET", "example.com", "test/?example.com/test/", 200, true}, 388 } 389 390 // TestServeMuxHandlerRedirects tests that automatic redirects generated by 391 // mux.Handler() shouldn't clear the request's query string. 392 func TestServeMuxHandlerRedirects(t *testing.T) { 393 mux := NewServeMux() 394 for _, e := range serveMuxRegister { 395 mux.Handle(e.pattern, e.h) 396 } 397 398 for _, tt := range serveMuxTests2 { 399 tries := 1 400 turl := tt.url 401 for tries > 0 { 402 u, e := url.Parse(turl) 403 if e != nil { 404 t.Fatal(e) 405 } 406 r := &Request{ 407 Method: tt.method, 408 Host: tt.host, 409 URL: u, 410 } 411 h, _ := mux.Handler(r) 412 rr := httptest.NewRecorder() 413 h.ServeHTTP(rr, r) 414 if rr.Code != 301 { 415 if rr.Code != tt.code { 416 t.Errorf("%s %s %s = %d, want %d", tt.method, tt.host, tt.url, rr.Code, tt.code) 417 } 418 break 419 } 420 if !tt.redirOk { 421 t.Errorf("%s %s %s, unexpected redirect", tt.method, tt.host, tt.url) 422 break 423 } 424 turl = rr.HeaderMap.Get("Location") 425 tries-- 426 } 427 if tries < 0 { 428 t.Errorf("%s %s %s, too many redirects", tt.method, tt.host, tt.url) 429 } 430 } 431 } 432 433 // Tests for https://golang.org/issue/900 434 func TestMuxRedirectLeadingSlashes(t *testing.T) { 435 paths := []string{"//foo.txt", "///foo.txt", "/../../foo.txt"} 436 for _, path := range paths { 437 req, err := ReadRequest(bufio.NewReader(strings.NewReader("GET " + path + " HTTP/1.1\r\nHost: test\r\n\r\n"))) 438 if err != nil { 439 t.Errorf("%s", err) 440 } 441 mux := NewServeMux() 442 resp := httptest.NewRecorder() 443 444 mux.ServeHTTP(resp, req) 445 446 if loc, expected := resp.Header().Get("Location"), "/foo.txt"; loc != expected { 447 t.Errorf("Expected Location header set to %q; got %q", expected, loc) 448 return 449 } 450 451 if code, expected := resp.Code, StatusMovedPermanently; code != expected { 452 t.Errorf("Expected response code of StatusMovedPermanently; got %d", code) 453 return 454 } 455 } 456 } 457 458 func TestServerTimeouts(t *testing.T) { 459 if runtime.GOOS == "plan9" { 460 t.Skip("skipping test; see https://golang.org/issue/7237") 461 } 462 setParallel(t) 463 defer afterTest(t) 464 reqNum := 0 465 ts := httptest.NewUnstartedServer(HandlerFunc(func(res ResponseWriter, req *Request) { 466 reqNum++ 467 fmt.Fprintf(res, "req=%d", reqNum) 468 })) 469 ts.Config.ReadTimeout = 250 * time.Millisecond 470 ts.Config.WriteTimeout = 250 * time.Millisecond 471 ts.Start() 472 defer ts.Close() 473 474 // Hit the HTTP server successfully. 475 tr := &Transport{DisableKeepAlives: true} // they interfere with this test 476 defer tr.CloseIdleConnections() 477 c := &Client{Transport: tr} 478 r, err := c.Get(ts.URL) 479 if err != nil { 480 t.Fatalf("http Get #1: %v", err) 481 } 482 got, _ := ioutil.ReadAll(r.Body) 483 expected := "req=1" 484 if string(got) != expected { 485 t.Errorf("Unexpected response for request #1; got %q; expected %q", 486 string(got), expected) 487 } 488 489 // Slow client that should timeout. 490 t1 := time.Now() 491 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 492 if err != nil { 493 t.Fatalf("Dial: %v", err) 494 } 495 buf := make([]byte, 1) 496 n, err := conn.Read(buf) 497 latency := time.Since(t1) 498 if n != 0 || err != io.EOF { 499 t.Errorf("Read = %v, %v, wanted %v, %v", n, err, 0, io.EOF) 500 } 501 if latency < 200*time.Millisecond /* fudge from 250 ms above */ { 502 t.Errorf("got EOF after %s, want >= %s", latency, 200*time.Millisecond) 503 } 504 505 // Hit the HTTP server successfully again, verifying that the 506 // previous slow connection didn't run our handler. (that we 507 // get "req=2", not "req=3") 508 r, err = Get(ts.URL) 509 if err != nil { 510 t.Fatalf("http Get #2: %v", err) 511 } 512 got, _ = ioutil.ReadAll(r.Body) 513 expected = "req=2" 514 if string(got) != expected { 515 t.Errorf("Get #2 got %q, want %q", string(got), expected) 516 } 517 518 if !testing.Short() { 519 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 520 if err != nil { 521 t.Fatalf("Dial: %v", err) 522 } 523 defer conn.Close() 524 go io.Copy(ioutil.Discard, conn) 525 for i := 0; i < 5; i++ { 526 _, err := conn.Write([]byte("GET / HTTP/1.1\r\nHost: foo\r\n\r\n")) 527 if err != nil { 528 t.Fatalf("on write %d: %v", i, err) 529 } 530 time.Sleep(ts.Config.ReadTimeout / 2) 531 } 532 } 533 } 534 535 // golang.org/issue/4741 -- setting only a write timeout that triggers 536 // shouldn't cause a handler to block forever on reads (next HTTP 537 // request) that will never happen. 538 func TestOnlyWriteTimeout(t *testing.T) { 539 if runtime.GOOS == "plan9" { 540 t.Skip("skipping test; see https://golang.org/issue/7237") 541 } 542 defer afterTest(t) 543 var conn net.Conn 544 var afterTimeoutErrc = make(chan error, 1) 545 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, req *Request) { 546 buf := make([]byte, 512<<10) 547 _, err := w.Write(buf) 548 if err != nil { 549 t.Errorf("handler Write error: %v", err) 550 return 551 } 552 conn.SetWriteDeadline(time.Now().Add(-30 * time.Second)) 553 _, err = w.Write(buf) 554 afterTimeoutErrc <- err 555 })) 556 ts.Listener = trackLastConnListener{ts.Listener, &conn} 557 ts.Start() 558 defer ts.Close() 559 560 tr := &Transport{DisableKeepAlives: false} 561 defer tr.CloseIdleConnections() 562 c := &Client{Transport: tr} 563 564 errc := make(chan error) 565 go func() { 566 res, err := c.Get(ts.URL) 567 if err != nil { 568 errc <- err 569 return 570 } 571 _, err = io.Copy(ioutil.Discard, res.Body) 572 errc <- err 573 }() 574 select { 575 case err := <-errc: 576 if err == nil { 577 t.Errorf("expected an error from Get request") 578 } 579 case <-time.After(5 * time.Second): 580 t.Fatal("timeout waiting for Get error") 581 } 582 if err := <-afterTimeoutErrc; err == nil { 583 t.Error("expected write error after timeout") 584 } 585 } 586 587 // trackLastConnListener tracks the last net.Conn that was accepted. 588 type trackLastConnListener struct { 589 net.Listener 590 last *net.Conn // destination 591 } 592 593 func (l trackLastConnListener) Accept() (c net.Conn, err error) { 594 c, err = l.Listener.Accept() 595 *l.last = c 596 return 597 } 598 599 // TestIdentityResponse verifies that a handler can unset 600 func TestIdentityResponse(t *testing.T) { 601 defer afterTest(t) 602 handler := HandlerFunc(func(rw ResponseWriter, req *Request) { 603 rw.Header().Set("Content-Length", "3") 604 rw.Header().Set("Transfer-Encoding", req.FormValue("te")) 605 switch { 606 case req.FormValue("overwrite") == "1": 607 _, err := rw.Write([]byte("foo TOO LONG")) 608 if err != ErrContentLength { 609 t.Errorf("expected ErrContentLength; got %v", err) 610 } 611 case req.FormValue("underwrite") == "1": 612 rw.Header().Set("Content-Length", "500") 613 rw.Write([]byte("too short")) 614 default: 615 rw.Write([]byte("foo")) 616 } 617 }) 618 619 ts := httptest.NewServer(handler) 620 defer ts.Close() 621 622 // Note: this relies on the assumption (which is true) that 623 // Get sends HTTP/1.1 or greater requests. Otherwise the 624 // server wouldn't have the choice to send back chunked 625 // responses. 626 for _, te := range []string{"", "identity"} { 627 url := ts.URL + "/?te=" + te 628 res, err := Get(url) 629 if err != nil { 630 t.Fatalf("error with Get of %s: %v", url, err) 631 } 632 if cl, expected := res.ContentLength, int64(3); cl != expected { 633 t.Errorf("for %s expected res.ContentLength of %d; got %d", url, expected, cl) 634 } 635 if cl, expected := res.Header.Get("Content-Length"), "3"; cl != expected { 636 t.Errorf("for %s expected Content-Length header of %q; got %q", url, expected, cl) 637 } 638 if tl, expected := len(res.TransferEncoding), 0; tl != expected { 639 t.Errorf("for %s expected len(res.TransferEncoding) of %d; got %d (%v)", 640 url, expected, tl, res.TransferEncoding) 641 } 642 res.Body.Close() 643 } 644 645 // Verify that ErrContentLength is returned 646 url := ts.URL + "/?overwrite=1" 647 res, err := Get(url) 648 if err != nil { 649 t.Fatalf("error with Get of %s: %v", url, err) 650 } 651 res.Body.Close() 652 653 // Verify that the connection is closed when the declared Content-Length 654 // is larger than what the handler wrote. 655 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 656 if err != nil { 657 t.Fatalf("error dialing: %v", err) 658 } 659 _, err = conn.Write([]byte("GET /?underwrite=1 HTTP/1.1\r\nHost: foo\r\n\r\n")) 660 if err != nil { 661 t.Fatalf("error writing: %v", err) 662 } 663 664 // The ReadAll will hang for a failing test, so use a Timer to 665 // fail explicitly. 666 goTimeout(t, 2*time.Second, func() { 667 got, _ := ioutil.ReadAll(conn) 668 expectedSuffix := "\r\n\r\ntoo short" 669 if !strings.HasSuffix(string(got), expectedSuffix) { 670 t.Errorf("Expected output to end with %q; got response body %q", 671 expectedSuffix, string(got)) 672 } 673 }) 674 } 675 676 func testTCPConnectionCloses(t *testing.T, req string, h Handler) { 677 defer afterTest(t) 678 s := httptest.NewServer(h) 679 defer s.Close() 680 681 conn, err := net.Dial("tcp", s.Listener.Addr().String()) 682 if err != nil { 683 t.Fatal("dial error:", err) 684 } 685 defer conn.Close() 686 687 _, err = fmt.Fprint(conn, req) 688 if err != nil { 689 t.Fatal("print error:", err) 690 } 691 692 r := bufio.NewReader(conn) 693 res, err := ReadResponse(r, &Request{Method: "GET"}) 694 if err != nil { 695 t.Fatal("ReadResponse error:", err) 696 } 697 698 didReadAll := make(chan bool, 1) 699 go func() { 700 select { 701 case <-time.After(5 * time.Second): 702 t.Error("body not closed after 5s") 703 return 704 case <-didReadAll: 705 } 706 }() 707 708 _, err = ioutil.ReadAll(r) 709 if err != nil { 710 t.Fatal("read error:", err) 711 } 712 didReadAll <- true 713 714 if !res.Close { 715 t.Errorf("Response.Close = false; want true") 716 } 717 } 718 719 func testTCPConnectionStaysOpen(t *testing.T, req string, handler Handler) { 720 defer afterTest(t) 721 ts := httptest.NewServer(handler) 722 defer ts.Close() 723 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 724 if err != nil { 725 t.Fatal(err) 726 } 727 defer conn.Close() 728 br := bufio.NewReader(conn) 729 for i := 0; i < 2; i++ { 730 if _, err := io.WriteString(conn, req); err != nil { 731 t.Fatal(err) 732 } 733 res, err := ReadResponse(br, nil) 734 if err != nil { 735 t.Fatalf("res %d: %v", i+1, err) 736 } 737 if _, err := io.Copy(ioutil.Discard, res.Body); err != nil { 738 t.Fatalf("res %d body copy: %v", i+1, err) 739 } 740 res.Body.Close() 741 } 742 } 743 744 // TestServeHTTP10Close verifies that HTTP/1.0 requests won't be kept alive. 745 func TestServeHTTP10Close(t *testing.T) { 746 testTCPConnectionCloses(t, "GET / HTTP/1.0\r\n\r\n", HandlerFunc(func(w ResponseWriter, r *Request) { 747 ServeFile(w, r, "testdata/file") 748 })) 749 } 750 751 // TestClientCanClose verifies that clients can also force a connection to close. 752 func TestClientCanClose(t *testing.T) { 753 testTCPConnectionCloses(t, "GET / HTTP/1.1\r\nConnection: close\r\n\r\n", HandlerFunc(func(w ResponseWriter, r *Request) { 754 // Nothing. 755 })) 756 } 757 758 // TestHandlersCanSetConnectionClose verifies that handlers can force a connection to close, 759 // even for HTTP/1.1 requests. 760 func TestHandlersCanSetConnectionClose11(t *testing.T) { 761 testTCPConnectionCloses(t, "GET / HTTP/1.1\r\n\r\n", HandlerFunc(func(w ResponseWriter, r *Request) { 762 w.Header().Set("Connection", "close") 763 })) 764 } 765 766 func TestHandlersCanSetConnectionClose10(t *testing.T) { 767 testTCPConnectionCloses(t, "GET / HTTP/1.0\r\nConnection: keep-alive\r\n\r\n", HandlerFunc(func(w ResponseWriter, r *Request) { 768 w.Header().Set("Connection", "close") 769 })) 770 } 771 772 func TestHTTP2UpgradeClosesConnection(t *testing.T) { 773 testTCPConnectionCloses(t, "PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n", HandlerFunc(func(w ResponseWriter, r *Request) { 774 // Nothing. (if not hijacked, the server should close the connection 775 // afterwards) 776 })) 777 } 778 779 func send204(w ResponseWriter, r *Request) { w.WriteHeader(204) } 780 func send304(w ResponseWriter, r *Request) { w.WriteHeader(304) } 781 782 // Issue 15647: 204 responses can't have bodies, so HTTP/1.0 keep-alive conns should stay open. 783 func TestHTTP10KeepAlive204Response(t *testing.T) { 784 testTCPConnectionStaysOpen(t, "GET / HTTP/1.0\r\nConnection: keep-alive\r\n\r\n", HandlerFunc(send204)) 785 } 786 787 func TestHTTP11KeepAlive204Response(t *testing.T) { 788 testTCPConnectionStaysOpen(t, "GET / HTTP/1.1\r\nHost: foo\r\n\r\n", HandlerFunc(send204)) 789 } 790 791 func TestHTTP10KeepAlive304Response(t *testing.T) { 792 testTCPConnectionStaysOpen(t, 793 "GET / HTTP/1.0\r\nConnection: keep-alive\r\nIf-Modified-Since: Mon, 02 Jan 2006 15:04:05 GMT\r\n\r\n", 794 HandlerFunc(send304)) 795 } 796 797 // Issue 15703 798 func TestKeepAliveFinalChunkWithEOF(t *testing.T) { 799 defer afterTest(t) 800 cst := newClientServerTest(t, false /* h1 */, HandlerFunc(func(w ResponseWriter, r *Request) { 801 w.(Flusher).Flush() // force chunked encoding 802 w.Write([]byte("{\"Addr\": \"" + r.RemoteAddr + "\"}")) 803 })) 804 defer cst.close() 805 type data struct { 806 Addr string 807 } 808 var addrs [2]data 809 for i := range addrs { 810 res, err := cst.c.Get(cst.ts.URL) 811 if err != nil { 812 t.Fatal(err) 813 } 814 if err := json.NewDecoder(res.Body).Decode(&addrs[i]); err != nil { 815 t.Fatal(err) 816 } 817 if addrs[i].Addr == "" { 818 t.Fatal("no address") 819 } 820 res.Body.Close() 821 } 822 if addrs[0] != addrs[1] { 823 t.Fatalf("connection not reused") 824 } 825 } 826 827 func TestSetsRemoteAddr_h1(t *testing.T) { testSetsRemoteAddr(t, h1Mode) } 828 func TestSetsRemoteAddr_h2(t *testing.T) { testSetsRemoteAddr(t, h2Mode) } 829 830 func testSetsRemoteAddr(t *testing.T, h2 bool) { 831 defer afterTest(t) 832 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 833 fmt.Fprintf(w, "%s", r.RemoteAddr) 834 })) 835 defer cst.close() 836 837 res, err := cst.c.Get(cst.ts.URL) 838 if err != nil { 839 t.Fatalf("Get error: %v", err) 840 } 841 body, err := ioutil.ReadAll(res.Body) 842 if err != nil { 843 t.Fatalf("ReadAll error: %v", err) 844 } 845 ip := string(body) 846 if !strings.HasPrefix(ip, "127.0.0.1:") && !strings.HasPrefix(ip, "[::1]:") { 847 t.Fatalf("Expected local addr; got %q", ip) 848 } 849 } 850 851 type blockingRemoteAddrListener struct { 852 net.Listener 853 conns chan<- net.Conn 854 } 855 856 func (l *blockingRemoteAddrListener) Accept() (net.Conn, error) { 857 c, err := l.Listener.Accept() 858 if err != nil { 859 return nil, err 860 } 861 brac := &blockingRemoteAddrConn{ 862 Conn: c, 863 addrs: make(chan net.Addr, 1), 864 } 865 l.conns <- brac 866 return brac, nil 867 } 868 869 type blockingRemoteAddrConn struct { 870 net.Conn 871 addrs chan net.Addr 872 } 873 874 func (c *blockingRemoteAddrConn) RemoteAddr() net.Addr { 875 return <-c.addrs 876 } 877 878 // Issue 12943 879 func TestServerAllowsBlockingRemoteAddr(t *testing.T) { 880 defer afterTest(t) 881 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) { 882 fmt.Fprintf(w, "RA:%s", r.RemoteAddr) 883 })) 884 conns := make(chan net.Conn) 885 ts.Listener = &blockingRemoteAddrListener{ 886 Listener: ts.Listener, 887 conns: conns, 888 } 889 ts.Start() 890 defer ts.Close() 891 892 tr := &Transport{DisableKeepAlives: true} 893 defer tr.CloseIdleConnections() 894 c := &Client{Transport: tr, Timeout: time.Second} 895 896 fetch := func(response chan string) { 897 resp, err := c.Get(ts.URL) 898 if err != nil { 899 t.Error(err) 900 response <- "" 901 return 902 } 903 defer resp.Body.Close() 904 body, err := ioutil.ReadAll(resp.Body) 905 if err != nil { 906 t.Error(err) 907 response <- "" 908 return 909 } 910 response <- string(body) 911 } 912 913 // Start a request. The server will block on getting conn.RemoteAddr. 914 response1c := make(chan string, 1) 915 go fetch(response1c) 916 917 // Wait for the server to accept it; grab the connection. 918 conn1 := <-conns 919 920 // Start another request and grab its connection 921 response2c := make(chan string, 1) 922 go fetch(response2c) 923 var conn2 net.Conn 924 925 select { 926 case conn2 = <-conns: 927 case <-time.After(time.Second): 928 t.Fatal("Second Accept didn't happen") 929 } 930 931 // Send a response on connection 2. 932 conn2.(*blockingRemoteAddrConn).addrs <- &net.TCPAddr{ 933 IP: net.ParseIP("12.12.12.12"), Port: 12} 934 935 // ... and see it 936 response2 := <-response2c 937 if g, e := response2, "RA:12.12.12.12:12"; g != e { 938 t.Fatalf("response 2 addr = %q; want %q", g, e) 939 } 940 941 // Finish the first response. 942 conn1.(*blockingRemoteAddrConn).addrs <- &net.TCPAddr{ 943 IP: net.ParseIP("21.21.21.21"), Port: 21} 944 945 // ... and see it 946 response1 := <-response1c 947 if g, e := response1, "RA:21.21.21.21:21"; g != e { 948 t.Fatalf("response 1 addr = %q; want %q", g, e) 949 } 950 } 951 func TestIdentityResponseHeaders(t *testing.T) { 952 defer afterTest(t) 953 log.SetOutput(ioutil.Discard) // is noisy otherwise 954 defer log.SetOutput(os.Stderr) 955 956 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 957 w.Header().Set("Transfer-Encoding", "identity") 958 w.(Flusher).Flush() 959 fmt.Fprintf(w, "I am an identity response.") 960 })) 961 defer ts.Close() 962 963 res, err := Get(ts.URL) 964 if err != nil { 965 t.Fatalf("Get error: %v", err) 966 } 967 defer res.Body.Close() 968 969 if g, e := res.TransferEncoding, []string(nil); !reflect.DeepEqual(g, e) { 970 t.Errorf("expected TransferEncoding of %v; got %v", e, g) 971 } 972 if _, haveCL := res.Header["Content-Length"]; haveCL { 973 t.Errorf("Unexpected Content-Length") 974 } 975 if !res.Close { 976 t.Errorf("expected Connection: close; got %v", res.Close) 977 } 978 } 979 980 // TestHeadResponses verifies that all MIME type sniffing and Content-Length 981 // counting of GET requests also happens on HEAD requests. 982 func TestHeadResponses_h1(t *testing.T) { testHeadResponses(t, h1Mode) } 983 func TestHeadResponses_h2(t *testing.T) { testHeadResponses(t, h2Mode) } 984 985 func testHeadResponses(t *testing.T, h2 bool) { 986 defer afterTest(t) 987 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 988 _, err := w.Write([]byte("<html>")) 989 if err != nil { 990 t.Errorf("ResponseWriter.Write: %v", err) 991 } 992 993 // Also exercise the ReaderFrom path 994 _, err = io.Copy(w, strings.NewReader("789a")) 995 if err != nil { 996 t.Errorf("Copy(ResponseWriter, ...): %v", err) 997 } 998 })) 999 defer cst.close() 1000 res, err := cst.c.Head(cst.ts.URL) 1001 if err != nil { 1002 t.Error(err) 1003 } 1004 if len(res.TransferEncoding) > 0 { 1005 t.Errorf("expected no TransferEncoding; got %v", res.TransferEncoding) 1006 } 1007 if ct := res.Header.Get("Content-Type"); ct != "text/html; charset=utf-8" { 1008 t.Errorf("Content-Type: %q; want text/html; charset=utf-8", ct) 1009 } 1010 if v := res.ContentLength; v != 10 { 1011 t.Errorf("Content-Length: %d; want 10", v) 1012 } 1013 body, err := ioutil.ReadAll(res.Body) 1014 if err != nil { 1015 t.Error(err) 1016 } 1017 if len(body) > 0 { 1018 t.Errorf("got unexpected body %q", string(body)) 1019 } 1020 } 1021 1022 func TestTLSHandshakeTimeout(t *testing.T) { 1023 if runtime.GOOS == "plan9" { 1024 t.Skip("skipping test; see https://golang.org/issue/7237") 1025 } 1026 setParallel(t) 1027 defer afterTest(t) 1028 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) {})) 1029 errc := make(chanWriter, 10) // but only expecting 1 1030 ts.Config.ReadTimeout = 250 * time.Millisecond 1031 ts.Config.ErrorLog = log.New(errc, "", 0) 1032 ts.StartTLS() 1033 defer ts.Close() 1034 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 1035 if err != nil { 1036 t.Fatalf("Dial: %v", err) 1037 } 1038 defer conn.Close() 1039 goTimeout(t, 10*time.Second, func() { 1040 var buf [1]byte 1041 n, err := conn.Read(buf[:]) 1042 if err == nil || n != 0 { 1043 t.Errorf("Read = %d, %v; want an error and no bytes", n, err) 1044 } 1045 }) 1046 select { 1047 case v := <-errc: 1048 if !strings.Contains(v, "timeout") && !strings.Contains(v, "TLS handshake") { 1049 t.Errorf("expected a TLS handshake timeout error; got %q", v) 1050 } 1051 case <-time.After(5 * time.Second): 1052 t.Errorf("timeout waiting for logged error") 1053 } 1054 } 1055 1056 func TestTLSServer(t *testing.T) { 1057 defer afterTest(t) 1058 ts := httptest.NewTLSServer(HandlerFunc(func(w ResponseWriter, r *Request) { 1059 if r.TLS != nil { 1060 w.Header().Set("X-TLS-Set", "true") 1061 if r.TLS.HandshakeComplete { 1062 w.Header().Set("X-TLS-HandshakeComplete", "true") 1063 } 1064 } 1065 })) 1066 ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0) 1067 defer ts.Close() 1068 1069 // Connect an idle TCP connection to this server before we run 1070 // our real tests. This idle connection used to block forever 1071 // in the TLS handshake, preventing future connections from 1072 // being accepted. It may prevent future accidental blocking 1073 // in newConn. 1074 idleConn, err := net.Dial("tcp", ts.Listener.Addr().String()) 1075 if err != nil { 1076 t.Fatalf("Dial: %v", err) 1077 } 1078 defer idleConn.Close() 1079 goTimeout(t, 10*time.Second, func() { 1080 if !strings.HasPrefix(ts.URL, "https://") { 1081 t.Errorf("expected test TLS server to start with https://, got %q", ts.URL) 1082 return 1083 } 1084 noVerifyTransport := &Transport{ 1085 TLSClientConfig: &tls.Config{ 1086 InsecureSkipVerify: true, 1087 }, 1088 } 1089 client := &Client{Transport: noVerifyTransport} 1090 res, err := client.Get(ts.URL) 1091 if err != nil { 1092 t.Error(err) 1093 return 1094 } 1095 if res == nil { 1096 t.Errorf("got nil Response") 1097 return 1098 } 1099 defer res.Body.Close() 1100 if res.Header.Get("X-TLS-Set") != "true" { 1101 t.Errorf("expected X-TLS-Set response header") 1102 return 1103 } 1104 if res.Header.Get("X-TLS-HandshakeComplete") != "true" { 1105 t.Errorf("expected X-TLS-HandshakeComplete header") 1106 } 1107 }) 1108 } 1109 1110 // Issue 15908 1111 func TestAutomaticHTTP2_Serve_NoTLSConfig(t *testing.T) { 1112 testAutomaticHTTP2_Serve(t, nil, true) 1113 } 1114 1115 func TestAutomaticHTTP2_Serve_NonH2TLSConfig(t *testing.T) { 1116 testAutomaticHTTP2_Serve(t, &tls.Config{}, false) 1117 } 1118 1119 func TestAutomaticHTTP2_Serve_H2TLSConfig(t *testing.T) { 1120 testAutomaticHTTP2_Serve(t, &tls.Config{NextProtos: []string{"h2"}}, true) 1121 } 1122 1123 func testAutomaticHTTP2_Serve(t *testing.T, tlsConf *tls.Config, wantH2 bool) { 1124 defer afterTest(t) 1125 ln := newLocalListener(t) 1126 ln.Close() // immediately (not a defer!) 1127 var s Server 1128 s.TLSConfig = tlsConf 1129 if err := s.Serve(ln); err == nil { 1130 t.Fatal("expected an error") 1131 } 1132 gotH2 := s.TLSNextProto["h2"] != nil 1133 if gotH2 != wantH2 { 1134 t.Errorf("http2 configured = %v; want %v", gotH2, wantH2) 1135 } 1136 } 1137 1138 func TestAutomaticHTTP2_Serve_WithTLSConfig(t *testing.T) { 1139 defer afterTest(t) 1140 ln := newLocalListener(t) 1141 ln.Close() // immediately (not a defer!) 1142 var s Server 1143 // Set the TLSConfig. In reality, this would be the 1144 // *tls.Config given to tls.NewListener. 1145 s.TLSConfig = &tls.Config{ 1146 NextProtos: []string{"h2"}, 1147 } 1148 if err := s.Serve(ln); err == nil { 1149 t.Fatal("expected an error") 1150 } 1151 on := s.TLSNextProto["h2"] != nil 1152 if !on { 1153 t.Errorf("http2 wasn't automatically enabled") 1154 } 1155 } 1156 1157 func TestAutomaticHTTP2_ListenAndServe(t *testing.T) { 1158 cert, err := tls.X509KeyPair(internal.LocalhostCert, internal.LocalhostKey) 1159 if err != nil { 1160 t.Fatal(err) 1161 } 1162 testAutomaticHTTP2_ListenAndServe(t, &tls.Config{ 1163 Certificates: []tls.Certificate{cert}, 1164 }) 1165 } 1166 1167 func TestAutomaticHTTP2_ListenAndServe_GetCertificate(t *testing.T) { 1168 cert, err := tls.X509KeyPair(internal.LocalhostCert, internal.LocalhostKey) 1169 if err != nil { 1170 t.Fatal(err) 1171 } 1172 testAutomaticHTTP2_ListenAndServe(t, &tls.Config{ 1173 GetCertificate: func(clientHello *tls.ClientHelloInfo) (*tls.Certificate, error) { 1174 return &cert, nil 1175 }, 1176 }) 1177 } 1178 1179 func testAutomaticHTTP2_ListenAndServe(t *testing.T, tlsConf *tls.Config) { 1180 defer afterTest(t) 1181 defer SetTestHookServerServe(nil) 1182 var ok bool 1183 var s *Server 1184 const maxTries = 5 1185 var ln net.Listener 1186 Try: 1187 for try := 0; try < maxTries; try++ { 1188 ln = newLocalListener(t) 1189 addr := ln.Addr().String() 1190 ln.Close() 1191 t.Logf("Got %v", addr) 1192 lnc := make(chan net.Listener, 1) 1193 SetTestHookServerServe(func(s *Server, ln net.Listener) { 1194 lnc <- ln 1195 }) 1196 s = &Server{ 1197 Addr: addr, 1198 TLSConfig: tlsConf, 1199 } 1200 errc := make(chan error, 1) 1201 go func() { errc <- s.ListenAndServeTLS("", "") }() 1202 select { 1203 case err := <-errc: 1204 t.Logf("On try #%v: %v", try+1, err) 1205 continue 1206 case ln = <-lnc: 1207 ok = true 1208 t.Logf("Listening on %v", ln.Addr().String()) 1209 break Try 1210 } 1211 } 1212 if !ok { 1213 t.Fatalf("Failed to start up after %d tries", maxTries) 1214 } 1215 defer ln.Close() 1216 c, err := tls.Dial("tcp", ln.Addr().String(), &tls.Config{ 1217 InsecureSkipVerify: true, 1218 NextProtos: []string{"h2", "http/1.1"}, 1219 }) 1220 if err != nil { 1221 t.Fatal(err) 1222 } 1223 defer c.Close() 1224 if got, want := c.ConnectionState().NegotiatedProtocol, "h2"; got != want { 1225 t.Errorf("NegotiatedProtocol = %q; want %q", got, want) 1226 } 1227 if got, want := c.ConnectionState().NegotiatedProtocolIsMutual, true; got != want { 1228 t.Errorf("NegotiatedProtocolIsMutual = %v; want %v", got, want) 1229 } 1230 } 1231 1232 type serverExpectTest struct { 1233 contentLength int // of request body 1234 chunked bool 1235 expectation string // e.g. "100-continue" 1236 readBody bool // whether handler should read the body (if false, sends StatusUnauthorized) 1237 expectedResponse string // expected substring in first line of http response 1238 } 1239 1240 func expectTest(contentLength int, expectation string, readBody bool, expectedResponse string) serverExpectTest { 1241 return serverExpectTest{ 1242 contentLength: contentLength, 1243 expectation: expectation, 1244 readBody: readBody, 1245 expectedResponse: expectedResponse, 1246 } 1247 } 1248 1249 var serverExpectTests = []serverExpectTest{ 1250 // Normal 100-continues, case-insensitive. 1251 expectTest(100, "100-continue", true, "100 Continue"), 1252 expectTest(100, "100-cOntInUE", true, "100 Continue"), 1253 1254 // No 100-continue. 1255 expectTest(100, "", true, "200 OK"), 1256 1257 // 100-continue but requesting client to deny us, 1258 // so it never reads the body. 1259 expectTest(100, "100-continue", false, "401 Unauthorized"), 1260 // Likewise without 100-continue: 1261 expectTest(100, "", false, "401 Unauthorized"), 1262 1263 // Non-standard expectations are failures 1264 expectTest(0, "a-pony", false, "417 Expectation Failed"), 1265 1266 // Expect-100 requested but no body (is apparently okay: Issue 7625) 1267 expectTest(0, "100-continue", true, "200 OK"), 1268 // Expect-100 requested but handler doesn't read the body 1269 expectTest(0, "100-continue", false, "401 Unauthorized"), 1270 // Expect-100 continue with no body, but a chunked body. 1271 { 1272 expectation: "100-continue", 1273 readBody: true, 1274 chunked: true, 1275 expectedResponse: "100 Continue", 1276 }, 1277 } 1278 1279 // Tests that the server responds to the "Expect" request header 1280 // correctly. 1281 // http2 test: TestServer_Response_Automatic100Continue 1282 func TestServerExpect(t *testing.T) { 1283 defer afterTest(t) 1284 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 1285 // Note using r.FormValue("readbody") because for POST 1286 // requests that would read from r.Body, which we only 1287 // conditionally want to do. 1288 if strings.Contains(r.URL.RawQuery, "readbody=true") { 1289 ioutil.ReadAll(r.Body) 1290 w.Write([]byte("Hi")) 1291 } else { 1292 w.WriteHeader(StatusUnauthorized) 1293 } 1294 })) 1295 defer ts.Close() 1296 1297 runTest := func(test serverExpectTest) { 1298 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 1299 if err != nil { 1300 t.Fatalf("Dial: %v", err) 1301 } 1302 defer conn.Close() 1303 1304 // Only send the body immediately if we're acting like an HTTP client 1305 // that doesn't send 100-continue expectations. 1306 writeBody := test.contentLength != 0 && strings.ToLower(test.expectation) != "100-continue" 1307 1308 go func() { 1309 contentLen := fmt.Sprintf("Content-Length: %d", test.contentLength) 1310 if test.chunked { 1311 contentLen = "Transfer-Encoding: chunked" 1312 } 1313 _, err := fmt.Fprintf(conn, "POST /?readbody=%v HTTP/1.1\r\n"+ 1314 "Connection: close\r\n"+ 1315 "%s\r\n"+ 1316 "Expect: %s\r\nHost: foo\r\n\r\n", 1317 test.readBody, contentLen, test.expectation) 1318 if err != nil { 1319 t.Errorf("On test %#v, error writing request headers: %v", test, err) 1320 return 1321 } 1322 if writeBody { 1323 var targ io.WriteCloser = struct { 1324 io.Writer 1325 io.Closer 1326 }{ 1327 conn, 1328 ioutil.NopCloser(nil), 1329 } 1330 if test.chunked { 1331 targ = httputil.NewChunkedWriter(conn) 1332 } 1333 body := strings.Repeat("A", test.contentLength) 1334 _, err = fmt.Fprint(targ, body) 1335 if err == nil { 1336 err = targ.Close() 1337 } 1338 if err != nil { 1339 if !test.readBody { 1340 // Server likely already hung up on us. 1341 // See larger comment below. 1342 t.Logf("On test %#v, acceptable error writing request body: %v", test, err) 1343 return 1344 } 1345 t.Errorf("On test %#v, error writing request body: %v", test, err) 1346 } 1347 } 1348 }() 1349 bufr := bufio.NewReader(conn) 1350 line, err := bufr.ReadString('\n') 1351 if err != nil { 1352 if writeBody && !test.readBody { 1353 // This is an acceptable failure due to a possible TCP race: 1354 // We were still writing data and the server hung up on us. A TCP 1355 // implementation may send a RST if our request body data was known 1356 // to be lost, which may trigger our reads to fail. 1357 // See RFC 1122 page 88. 1358 t.Logf("On test %#v, acceptable error from ReadString: %v", test, err) 1359 return 1360 } 1361 t.Fatalf("On test %#v, ReadString: %v", test, err) 1362 } 1363 if !strings.Contains(line, test.expectedResponse) { 1364 t.Errorf("On test %#v, got first line = %q; want %q", test, line, test.expectedResponse) 1365 } 1366 } 1367 1368 for _, test := range serverExpectTests { 1369 runTest(test) 1370 } 1371 } 1372 1373 // Under a ~256KB (maxPostHandlerReadBytes) threshold, the server 1374 // should consume client request bodies that a handler didn't read. 1375 func TestServerUnreadRequestBodyLittle(t *testing.T) { 1376 defer afterTest(t) 1377 conn := new(testConn) 1378 body := strings.Repeat("x", 100<<10) 1379 conn.readBuf.Write([]byte(fmt.Sprintf( 1380 "POST / HTTP/1.1\r\n"+ 1381 "Host: test\r\n"+ 1382 "Content-Length: %d\r\n"+ 1383 "\r\n", len(body)))) 1384 conn.readBuf.Write([]byte(body)) 1385 1386 done := make(chan bool) 1387 1388 readBufLen := func() int { 1389 conn.readMu.Lock() 1390 defer conn.readMu.Unlock() 1391 return conn.readBuf.Len() 1392 } 1393 1394 ls := &oneConnListener{conn} 1395 go Serve(ls, HandlerFunc(func(rw ResponseWriter, req *Request) { 1396 defer close(done) 1397 if bufLen := readBufLen(); bufLen < len(body)/2 { 1398 t.Errorf("on request, read buffer length is %d; expected about 100 KB", bufLen) 1399 } 1400 rw.WriteHeader(200) 1401 rw.(Flusher).Flush() 1402 if g, e := readBufLen(), 0; g != e { 1403 t.Errorf("after WriteHeader, read buffer length is %d; want %d", g, e) 1404 } 1405 if c := rw.Header().Get("Connection"); c != "" { 1406 t.Errorf(`Connection header = %q; want ""`, c) 1407 } 1408 })) 1409 <-done 1410 } 1411 1412 // Over a ~256KB (maxPostHandlerReadBytes) threshold, the server 1413 // should ignore client request bodies that a handler didn't read 1414 // and close the connection. 1415 func TestServerUnreadRequestBodyLarge(t *testing.T) { 1416 if testing.Short() && testenv.Builder() == "" { 1417 t.Log("skipping in short mode") 1418 } 1419 conn := new(testConn) 1420 body := strings.Repeat("x", 1<<20) 1421 conn.readBuf.Write([]byte(fmt.Sprintf( 1422 "POST / HTTP/1.1\r\n"+ 1423 "Host: test\r\n"+ 1424 "Content-Length: %d\r\n"+ 1425 "\r\n", len(body)))) 1426 conn.readBuf.Write([]byte(body)) 1427 conn.closec = make(chan bool, 1) 1428 1429 ls := &oneConnListener{conn} 1430 go Serve(ls, HandlerFunc(func(rw ResponseWriter, req *Request) { 1431 if conn.readBuf.Len() < len(body)/2 { 1432 t.Errorf("on request, read buffer length is %d; expected about 1MB", conn.readBuf.Len()) 1433 } 1434 rw.WriteHeader(200) 1435 rw.(Flusher).Flush() 1436 if conn.readBuf.Len() < len(body)/2 { 1437 t.Errorf("post-WriteHeader, read buffer length is %d; expected about 1MB", conn.readBuf.Len()) 1438 } 1439 })) 1440 <-conn.closec 1441 1442 if res := conn.writeBuf.String(); !strings.Contains(res, "Connection: close") { 1443 t.Errorf("Expected a Connection: close header; got response: %s", res) 1444 } 1445 } 1446 1447 type handlerBodyCloseTest struct { 1448 bodySize int 1449 bodyChunked bool 1450 reqConnClose bool 1451 1452 wantEOFSearch bool // should Handler's Body.Close do Reads, looking for EOF? 1453 wantNextReq bool // should it find the next request on the same conn? 1454 } 1455 1456 func (t handlerBodyCloseTest) connectionHeader() string { 1457 if t.reqConnClose { 1458 return "Connection: close\r\n" 1459 } 1460 return "" 1461 } 1462 1463 var handlerBodyCloseTests = [...]handlerBodyCloseTest{ 1464 // Small enough to slurp past to the next request + 1465 // has Content-Length. 1466 0: { 1467 bodySize: 20 << 10, 1468 bodyChunked: false, 1469 reqConnClose: false, 1470 wantEOFSearch: true, 1471 wantNextReq: true, 1472 }, 1473 1474 // Small enough to slurp past to the next request + 1475 // is chunked. 1476 1: { 1477 bodySize: 20 << 10, 1478 bodyChunked: true, 1479 reqConnClose: false, 1480 wantEOFSearch: true, 1481 wantNextReq: true, 1482 }, 1483 1484 // Small enough to slurp past to the next request + 1485 // has Content-Length + 1486 // declares Connection: close (so pointless to read more). 1487 2: { 1488 bodySize: 20 << 10, 1489 bodyChunked: false, 1490 reqConnClose: true, 1491 wantEOFSearch: false, 1492 wantNextReq: false, 1493 }, 1494 1495 // Small enough to slurp past to the next request + 1496 // declares Connection: close, 1497 // but chunked, so it might have trailers. 1498 // TODO: maybe skip this search if no trailers were declared 1499 // in the headers. 1500 3: { 1501 bodySize: 20 << 10, 1502 bodyChunked: true, 1503 reqConnClose: true, 1504 wantEOFSearch: true, 1505 wantNextReq: false, 1506 }, 1507 1508 // Big with Content-Length, so give up immediately if we know it's too big. 1509 4: { 1510 bodySize: 1 << 20, 1511 bodyChunked: false, // has a Content-Length 1512 reqConnClose: false, 1513 wantEOFSearch: false, 1514 wantNextReq: false, 1515 }, 1516 1517 // Big chunked, so read a bit before giving up. 1518 5: { 1519 bodySize: 1 << 20, 1520 bodyChunked: true, 1521 reqConnClose: false, 1522 wantEOFSearch: true, 1523 wantNextReq: false, 1524 }, 1525 1526 // Big with Connection: close, but chunked, so search for trailers. 1527 // TODO: maybe skip this search if no trailers were declared 1528 // in the headers. 1529 6: { 1530 bodySize: 1 << 20, 1531 bodyChunked: true, 1532 reqConnClose: true, 1533 wantEOFSearch: true, 1534 wantNextReq: false, 1535 }, 1536 1537 // Big with Connection: close, so don't do any reads on Close. 1538 // With Content-Length. 1539 7: { 1540 bodySize: 1 << 20, 1541 bodyChunked: false, 1542 reqConnClose: true, 1543 wantEOFSearch: false, 1544 wantNextReq: false, 1545 }, 1546 } 1547 1548 func TestHandlerBodyClose(t *testing.T) { 1549 if testing.Short() && testenv.Builder() == "" { 1550 t.Skip("skipping in -short mode") 1551 } 1552 for i, tt := range handlerBodyCloseTests { 1553 testHandlerBodyClose(t, i, tt) 1554 } 1555 } 1556 1557 func testHandlerBodyClose(t *testing.T, i int, tt handlerBodyCloseTest) { 1558 conn := new(testConn) 1559 body := strings.Repeat("x", tt.bodySize) 1560 if tt.bodyChunked { 1561 conn.readBuf.WriteString("POST / HTTP/1.1\r\n" + 1562 "Host: test\r\n" + 1563 tt.connectionHeader() + 1564 "Transfer-Encoding: chunked\r\n" + 1565 "\r\n") 1566 cw := internal.NewChunkedWriter(&conn.readBuf) 1567 io.WriteString(cw, body) 1568 cw.Close() 1569 conn.readBuf.WriteString("\r\n") 1570 } else { 1571 conn.readBuf.Write([]byte(fmt.Sprintf( 1572 "POST / HTTP/1.1\r\n"+ 1573 "Host: test\r\n"+ 1574 tt.connectionHeader()+ 1575 "Content-Length: %d\r\n"+ 1576 "\r\n", len(body)))) 1577 conn.readBuf.Write([]byte(body)) 1578 } 1579 if !tt.reqConnClose { 1580 conn.readBuf.WriteString("GET / HTTP/1.1\r\nHost: test\r\n\r\n") 1581 } 1582 conn.closec = make(chan bool, 1) 1583 1584 readBufLen := func() int { 1585 conn.readMu.Lock() 1586 defer conn.readMu.Unlock() 1587 return conn.readBuf.Len() 1588 } 1589 1590 ls := &oneConnListener{conn} 1591 var numReqs int 1592 var size0, size1 int 1593 go Serve(ls, HandlerFunc(func(rw ResponseWriter, req *Request) { 1594 numReqs++ 1595 if numReqs == 1 { 1596 size0 = readBufLen() 1597 req.Body.Close() 1598 size1 = readBufLen() 1599 } 1600 })) 1601 <-conn.closec 1602 if numReqs < 1 || numReqs > 2 { 1603 t.Fatalf("%d. bug in test. unexpected number of requests = %d", i, numReqs) 1604 } 1605 didSearch := size0 != size1 1606 if didSearch != tt.wantEOFSearch { 1607 t.Errorf("%d. did EOF search = %v; want %v (size went from %d to %d)", i, didSearch, !didSearch, size0, size1) 1608 } 1609 if tt.wantNextReq && numReqs != 2 { 1610 t.Errorf("%d. numReq = %d; want 2", i, numReqs) 1611 } 1612 } 1613 1614 // testHandlerBodyConsumer represents a function injected into a test handler to 1615 // vary work done on a request Body. 1616 type testHandlerBodyConsumer struct { 1617 name string 1618 f func(io.ReadCloser) 1619 } 1620 1621 var testHandlerBodyConsumers = []testHandlerBodyConsumer{ 1622 {"nil", func(io.ReadCloser) {}}, 1623 {"close", func(r io.ReadCloser) { r.Close() }}, 1624 {"discard", func(r io.ReadCloser) { io.Copy(ioutil.Discard, r) }}, 1625 } 1626 1627 func TestRequestBodyReadErrorClosesConnection(t *testing.T) { 1628 defer afterTest(t) 1629 for _, handler := range testHandlerBodyConsumers { 1630 conn := new(testConn) 1631 conn.readBuf.WriteString("POST /public HTTP/1.1\r\n" + 1632 "Host: test\r\n" + 1633 "Transfer-Encoding: chunked\r\n" + 1634 "\r\n" + 1635 "hax\r\n" + // Invalid chunked encoding 1636 "GET /secret HTTP/1.1\r\n" + 1637 "Host: test\r\n" + 1638 "\r\n") 1639 1640 conn.closec = make(chan bool, 1) 1641 ls := &oneConnListener{conn} 1642 var numReqs int 1643 go Serve(ls, HandlerFunc(func(_ ResponseWriter, req *Request) { 1644 numReqs++ 1645 if strings.Contains(req.URL.Path, "secret") { 1646 t.Error("Request for /secret encountered, should not have happened.") 1647 } 1648 handler.f(req.Body) 1649 })) 1650 <-conn.closec 1651 if numReqs != 1 { 1652 t.Errorf("Handler %v: got %d reqs; want 1", handler.name, numReqs) 1653 } 1654 } 1655 } 1656 1657 func TestInvalidTrailerClosesConnection(t *testing.T) { 1658 defer afterTest(t) 1659 for _, handler := range testHandlerBodyConsumers { 1660 conn := new(testConn) 1661 conn.readBuf.WriteString("POST /public HTTP/1.1\r\n" + 1662 "Host: test\r\n" + 1663 "Trailer: hack\r\n" + 1664 "Transfer-Encoding: chunked\r\n" + 1665 "\r\n" + 1666 "3\r\n" + 1667 "hax\r\n" + 1668 "0\r\n" + 1669 "I'm not a valid trailer\r\n" + 1670 "GET /secret HTTP/1.1\r\n" + 1671 "Host: test\r\n" + 1672 "\r\n") 1673 1674 conn.closec = make(chan bool, 1) 1675 ln := &oneConnListener{conn} 1676 var numReqs int 1677 go Serve(ln, HandlerFunc(func(_ ResponseWriter, req *Request) { 1678 numReqs++ 1679 if strings.Contains(req.URL.Path, "secret") { 1680 t.Errorf("Handler %s, Request for /secret encountered, should not have happened.", handler.name) 1681 } 1682 handler.f(req.Body) 1683 })) 1684 <-conn.closec 1685 if numReqs != 1 { 1686 t.Errorf("Handler %s: got %d reqs; want 1", handler.name, numReqs) 1687 } 1688 } 1689 } 1690 1691 // slowTestConn is a net.Conn that provides a means to simulate parts of a 1692 // request being received piecemeal. Deadlines can be set and enforced in both 1693 // Read and Write. 1694 type slowTestConn struct { 1695 // over multiple calls to Read, time.Durations are slept, strings are read. 1696 script []interface{} 1697 closec chan bool 1698 1699 mu sync.Mutex // guards rd/wd 1700 rd, wd time.Time // read, write deadline 1701 noopConn 1702 } 1703 1704 func (c *slowTestConn) SetDeadline(t time.Time) error { 1705 c.SetReadDeadline(t) 1706 c.SetWriteDeadline(t) 1707 return nil 1708 } 1709 1710 func (c *slowTestConn) SetReadDeadline(t time.Time) error { 1711 c.mu.Lock() 1712 defer c.mu.Unlock() 1713 c.rd = t 1714 return nil 1715 } 1716 1717 func (c *slowTestConn) SetWriteDeadline(t time.Time) error { 1718 c.mu.Lock() 1719 defer c.mu.Unlock() 1720 c.wd = t 1721 return nil 1722 } 1723 1724 func (c *slowTestConn) Read(b []byte) (n int, err error) { 1725 c.mu.Lock() 1726 defer c.mu.Unlock() 1727 restart: 1728 if !c.rd.IsZero() && time.Now().After(c.rd) { 1729 return 0, syscall.ETIMEDOUT 1730 } 1731 if len(c.script) == 0 { 1732 return 0, io.EOF 1733 } 1734 1735 switch cue := c.script[0].(type) { 1736 case time.Duration: 1737 if !c.rd.IsZero() { 1738 // If the deadline falls in the middle of our sleep window, deduct 1739 // part of the sleep, then return a timeout. 1740 if remaining := c.rd.Sub(time.Now()); remaining < cue { 1741 c.script[0] = cue - remaining 1742 time.Sleep(remaining) 1743 return 0, syscall.ETIMEDOUT 1744 } 1745 } 1746 c.script = c.script[1:] 1747 time.Sleep(cue) 1748 goto restart 1749 1750 case string: 1751 n = copy(b, cue) 1752 // If cue is too big for the buffer, leave the end for the next Read. 1753 if len(cue) > n { 1754 c.script[0] = cue[n:] 1755 } else { 1756 c.script = c.script[1:] 1757 } 1758 1759 default: 1760 panic("unknown cue in slowTestConn script") 1761 } 1762 1763 return 1764 } 1765 1766 func (c *slowTestConn) Close() error { 1767 select { 1768 case c.closec <- true: 1769 default: 1770 } 1771 return nil 1772 } 1773 1774 func (c *slowTestConn) Write(b []byte) (int, error) { 1775 if !c.wd.IsZero() && time.Now().After(c.wd) { 1776 return 0, syscall.ETIMEDOUT 1777 } 1778 return len(b), nil 1779 } 1780 1781 func TestRequestBodyTimeoutClosesConnection(t *testing.T) { 1782 if testing.Short() { 1783 t.Skip("skipping in -short mode") 1784 } 1785 defer afterTest(t) 1786 for _, handler := range testHandlerBodyConsumers { 1787 conn := &slowTestConn{ 1788 script: []interface{}{ 1789 "POST /public HTTP/1.1\r\n" + 1790 "Host: test\r\n" + 1791 "Content-Length: 10000\r\n" + 1792 "\r\n", 1793 "foo bar baz", 1794 600 * time.Millisecond, // Request deadline should hit here 1795 "GET /secret HTTP/1.1\r\n" + 1796 "Host: test\r\n" + 1797 "\r\n", 1798 }, 1799 closec: make(chan bool, 1), 1800 } 1801 ls := &oneConnListener{conn} 1802 1803 var numReqs int 1804 s := Server{ 1805 Handler: HandlerFunc(func(_ ResponseWriter, req *Request) { 1806 numReqs++ 1807 if strings.Contains(req.URL.Path, "secret") { 1808 t.Error("Request for /secret encountered, should not have happened.") 1809 } 1810 handler.f(req.Body) 1811 }), 1812 ReadTimeout: 400 * time.Millisecond, 1813 } 1814 go s.Serve(ls) 1815 <-conn.closec 1816 1817 if numReqs != 1 { 1818 t.Errorf("Handler %v: got %d reqs; want 1", handler.name, numReqs) 1819 } 1820 } 1821 } 1822 1823 func TestTimeoutHandler_h1(t *testing.T) { testTimeoutHandler(t, h1Mode) } 1824 func TestTimeoutHandler_h2(t *testing.T) { testTimeoutHandler(t, h2Mode) } 1825 func testTimeoutHandler(t *testing.T, h2 bool) { 1826 defer afterTest(t) 1827 sendHi := make(chan bool, 1) 1828 writeErrors := make(chan error, 1) 1829 sayHi := HandlerFunc(func(w ResponseWriter, r *Request) { 1830 <-sendHi 1831 _, werr := w.Write([]byte("hi")) 1832 writeErrors <- werr 1833 }) 1834 timeout := make(chan time.Time, 1) // write to this to force timeouts 1835 cst := newClientServerTest(t, h2, NewTestTimeoutHandler(sayHi, timeout)) 1836 defer cst.close() 1837 1838 // Succeed without timing out: 1839 sendHi <- true 1840 res, err := cst.c.Get(cst.ts.URL) 1841 if err != nil { 1842 t.Error(err) 1843 } 1844 if g, e := res.StatusCode, StatusOK; g != e { 1845 t.Errorf("got res.StatusCode %d; expected %d", g, e) 1846 } 1847 body, _ := ioutil.ReadAll(res.Body) 1848 if g, e := string(body), "hi"; g != e { 1849 t.Errorf("got body %q; expected %q", g, e) 1850 } 1851 if g := <-writeErrors; g != nil { 1852 t.Errorf("got unexpected Write error on first request: %v", g) 1853 } 1854 1855 // Times out: 1856 timeout <- time.Time{} 1857 res, err = cst.c.Get(cst.ts.URL) 1858 if err != nil { 1859 t.Error(err) 1860 } 1861 if g, e := res.StatusCode, StatusServiceUnavailable; g != e { 1862 t.Errorf("got res.StatusCode %d; expected %d", g, e) 1863 } 1864 body, _ = ioutil.ReadAll(res.Body) 1865 if !strings.Contains(string(body), "<title>Timeout</title>") { 1866 t.Errorf("expected timeout body; got %q", string(body)) 1867 } 1868 1869 // Now make the previously-timed out handler speak again, 1870 // which verifies the panic is handled: 1871 sendHi <- true 1872 if g, e := <-writeErrors, ErrHandlerTimeout; g != e { 1873 t.Errorf("expected Write error of %v; got %v", e, g) 1874 } 1875 } 1876 1877 // See issues 8209 and 8414. 1878 func TestTimeoutHandlerRace(t *testing.T) { 1879 defer afterTest(t) 1880 1881 delayHi := HandlerFunc(func(w ResponseWriter, r *Request) { 1882 ms, _ := strconv.Atoi(r.URL.Path[1:]) 1883 if ms == 0 { 1884 ms = 1 1885 } 1886 for i := 0; i < ms; i++ { 1887 w.Write([]byte("hi")) 1888 time.Sleep(time.Millisecond) 1889 } 1890 }) 1891 1892 ts := httptest.NewServer(TimeoutHandler(delayHi, 20*time.Millisecond, "")) 1893 defer ts.Close() 1894 1895 var wg sync.WaitGroup 1896 gate := make(chan bool, 10) 1897 n := 50 1898 if testing.Short() { 1899 n = 10 1900 gate = make(chan bool, 3) 1901 } 1902 for i := 0; i < n; i++ { 1903 gate <- true 1904 wg.Add(1) 1905 go func() { 1906 defer wg.Done() 1907 defer func() { <-gate }() 1908 res, err := Get(fmt.Sprintf("%s/%d", ts.URL, rand.Intn(50))) 1909 if err == nil { 1910 io.Copy(ioutil.Discard, res.Body) 1911 res.Body.Close() 1912 } 1913 }() 1914 } 1915 wg.Wait() 1916 } 1917 1918 // See issues 8209 and 8414. 1919 func TestTimeoutHandlerRaceHeader(t *testing.T) { 1920 defer afterTest(t) 1921 1922 delay204 := HandlerFunc(func(w ResponseWriter, r *Request) { 1923 w.WriteHeader(204) 1924 }) 1925 1926 ts := httptest.NewServer(TimeoutHandler(delay204, time.Nanosecond, "")) 1927 defer ts.Close() 1928 1929 var wg sync.WaitGroup 1930 gate := make(chan bool, 50) 1931 n := 500 1932 if testing.Short() { 1933 n = 10 1934 } 1935 for i := 0; i < n; i++ { 1936 gate <- true 1937 wg.Add(1) 1938 go func() { 1939 defer wg.Done() 1940 defer func() { <-gate }() 1941 res, err := Get(ts.URL) 1942 if err != nil { 1943 t.Error(err) 1944 return 1945 } 1946 defer res.Body.Close() 1947 io.Copy(ioutil.Discard, res.Body) 1948 }() 1949 } 1950 wg.Wait() 1951 } 1952 1953 // Issue 9162 1954 func TestTimeoutHandlerRaceHeaderTimeout(t *testing.T) { 1955 defer afterTest(t) 1956 sendHi := make(chan bool, 1) 1957 writeErrors := make(chan error, 1) 1958 sayHi := HandlerFunc(func(w ResponseWriter, r *Request) { 1959 w.Header().Set("Content-Type", "text/plain") 1960 <-sendHi 1961 _, werr := w.Write([]byte("hi")) 1962 writeErrors <- werr 1963 }) 1964 timeout := make(chan time.Time, 1) // write to this to force timeouts 1965 cst := newClientServerTest(t, h1Mode, NewTestTimeoutHandler(sayHi, timeout)) 1966 defer cst.close() 1967 1968 // Succeed without timing out: 1969 sendHi <- true 1970 res, err := cst.c.Get(cst.ts.URL) 1971 if err != nil { 1972 t.Error(err) 1973 } 1974 if g, e := res.StatusCode, StatusOK; g != e { 1975 t.Errorf("got res.StatusCode %d; expected %d", g, e) 1976 } 1977 body, _ := ioutil.ReadAll(res.Body) 1978 if g, e := string(body), "hi"; g != e { 1979 t.Errorf("got body %q; expected %q", g, e) 1980 } 1981 if g := <-writeErrors; g != nil { 1982 t.Errorf("got unexpected Write error on first request: %v", g) 1983 } 1984 1985 // Times out: 1986 timeout <- time.Time{} 1987 res, err = cst.c.Get(cst.ts.URL) 1988 if err != nil { 1989 t.Error(err) 1990 } 1991 if g, e := res.StatusCode, StatusServiceUnavailable; g != e { 1992 t.Errorf("got res.StatusCode %d; expected %d", g, e) 1993 } 1994 body, _ = ioutil.ReadAll(res.Body) 1995 if !strings.Contains(string(body), "<title>Timeout</title>") { 1996 t.Errorf("expected timeout body; got %q", string(body)) 1997 } 1998 1999 // Now make the previously-timed out handler speak again, 2000 // which verifies the panic is handled: 2001 sendHi <- true 2002 if g, e := <-writeErrors, ErrHandlerTimeout; g != e { 2003 t.Errorf("expected Write error of %v; got %v", e, g) 2004 } 2005 } 2006 2007 // Issue 14568. 2008 func TestTimeoutHandlerStartTimerWhenServing(t *testing.T) { 2009 if testing.Short() { 2010 t.Skip("skipping sleeping test in -short mode") 2011 } 2012 defer afterTest(t) 2013 var handler HandlerFunc = func(w ResponseWriter, _ *Request) { 2014 w.WriteHeader(StatusNoContent) 2015 } 2016 timeout := 300 * time.Millisecond 2017 ts := httptest.NewServer(TimeoutHandler(handler, timeout, "")) 2018 defer ts.Close() 2019 // Issue was caused by the timeout handler starting the timer when 2020 // was created, not when the request. So wait for more than the timeout 2021 // to ensure that's not the case. 2022 time.Sleep(2 * timeout) 2023 res, err := Get(ts.URL) 2024 if err != nil { 2025 t.Fatal(err) 2026 } 2027 defer res.Body.Close() 2028 if res.StatusCode != StatusNoContent { 2029 t.Errorf("got res.StatusCode %d, want %v", res.StatusCode, StatusNoContent) 2030 } 2031 } 2032 2033 // https://golang.org/issue/15948 2034 func TestTimeoutHandlerEmptyResponse(t *testing.T) { 2035 defer afterTest(t) 2036 var handler HandlerFunc = func(w ResponseWriter, _ *Request) { 2037 // No response. 2038 } 2039 timeout := 300 * time.Millisecond 2040 ts := httptest.NewServer(TimeoutHandler(handler, timeout, "")) 2041 defer ts.Close() 2042 2043 res, err := Get(ts.URL) 2044 if err != nil { 2045 t.Fatal(err) 2046 } 2047 defer res.Body.Close() 2048 if res.StatusCode != StatusOK { 2049 t.Errorf("got res.StatusCode %d, want %v", res.StatusCode, StatusOK) 2050 } 2051 } 2052 2053 // Verifies we don't path.Clean() on the wrong parts in redirects. 2054 func TestRedirectMunging(t *testing.T) { 2055 req, _ := NewRequest("GET", "http://example.com/", nil) 2056 2057 resp := httptest.NewRecorder() 2058 Redirect(resp, req, "/foo?next=http://bar.com/", 302) 2059 if g, e := resp.Header().Get("Location"), "/foo?next=http://bar.com/"; g != e { 2060 t.Errorf("Location header was %q; want %q", g, e) 2061 } 2062 2063 resp = httptest.NewRecorder() 2064 Redirect(resp, req, "http://localhost:8080/_ah/login?continue=http://localhost:8080/", 302) 2065 if g, e := resp.Header().Get("Location"), "http://localhost:8080/_ah/login?continue=http://localhost:8080/"; g != e { 2066 t.Errorf("Location header was %q; want %q", g, e) 2067 } 2068 } 2069 2070 func TestRedirectBadPath(t *testing.T) { 2071 // This used to crash. It's not valid input (bad path), but it 2072 // shouldn't crash. 2073 rr := httptest.NewRecorder() 2074 req := &Request{ 2075 Method: "GET", 2076 URL: &url.URL{ 2077 Scheme: "http", 2078 Path: "not-empty-but-no-leading-slash", // bogus 2079 }, 2080 } 2081 Redirect(rr, req, "", 304) 2082 if rr.Code != 304 { 2083 t.Errorf("Code = %d; want 304", rr.Code) 2084 } 2085 } 2086 2087 // Test different URL formats and schemes 2088 func TestRedirectURLFormat(t *testing.T) { 2089 req, _ := NewRequest("GET", "http://example.com/qux/", nil) 2090 2091 var tests = []struct { 2092 in string 2093 want string 2094 }{ 2095 // normal http 2096 {"http://foobar.com/baz", "http://foobar.com/baz"}, 2097 // normal https 2098 {"https://foobar.com/baz", "https://foobar.com/baz"}, 2099 // custom scheme 2100 {"test://foobar.com/baz", "test://foobar.com/baz"}, 2101 // schemeless 2102 {"//foobar.com/baz", "//foobar.com/baz"}, 2103 // relative to the root 2104 {"/foobar.com/baz", "/foobar.com/baz"}, 2105 // relative to the current path 2106 {"foobar.com/baz", "/qux/foobar.com/baz"}, 2107 // relative to the current path (+ going upwards) 2108 {"../quux/foobar.com/baz", "/quux/foobar.com/baz"}, 2109 // incorrect number of slashes 2110 {"///foobar.com/baz", "/foobar.com/baz"}, 2111 } 2112 2113 for _, tt := range tests { 2114 rec := httptest.NewRecorder() 2115 Redirect(rec, req, tt.in, 302) 2116 if got := rec.Header().Get("Location"); got != tt.want { 2117 t.Errorf("Redirect(%q) generated Location header %q; want %q", tt.in, got, tt.want) 2118 } 2119 } 2120 } 2121 2122 // TestZeroLengthPostAndResponse exercises an optimization done by the Transport: 2123 // when there is no body (either because the method doesn't permit a body, or an 2124 // explicit Content-Length of zero is present), then the transport can re-use the 2125 // connection immediately. But when it re-uses the connection, it typically closes 2126 // the previous request's body, which is not optimal for zero-lengthed bodies, 2127 // as the client would then see http.ErrBodyReadAfterClose and not 0, io.EOF. 2128 func TestZeroLengthPostAndResponse_h1(t *testing.T) { 2129 testZeroLengthPostAndResponse(t, h1Mode) 2130 } 2131 func TestZeroLengthPostAndResponse_h2(t *testing.T) { 2132 testZeroLengthPostAndResponse(t, h2Mode) 2133 } 2134 2135 func testZeroLengthPostAndResponse(t *testing.T, h2 bool) { 2136 defer afterTest(t) 2137 cst := newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, r *Request) { 2138 all, err := ioutil.ReadAll(r.Body) 2139 if err != nil { 2140 t.Fatalf("handler ReadAll: %v", err) 2141 } 2142 if len(all) != 0 { 2143 t.Errorf("handler got %d bytes; expected 0", len(all)) 2144 } 2145 rw.Header().Set("Content-Length", "0") 2146 })) 2147 defer cst.close() 2148 2149 req, err := NewRequest("POST", cst.ts.URL, strings.NewReader("")) 2150 if err != nil { 2151 t.Fatal(err) 2152 } 2153 req.ContentLength = 0 2154 2155 var resp [5]*Response 2156 for i := range resp { 2157 resp[i], err = cst.c.Do(req) 2158 if err != nil { 2159 t.Fatalf("client post #%d: %v", i, err) 2160 } 2161 } 2162 2163 for i := range resp { 2164 all, err := ioutil.ReadAll(resp[i].Body) 2165 if err != nil { 2166 t.Fatalf("req #%d: client ReadAll: %v", i, err) 2167 } 2168 if len(all) != 0 { 2169 t.Errorf("req #%d: client got %d bytes; expected 0", i, len(all)) 2170 } 2171 } 2172 } 2173 2174 func TestHandlerPanicNil_h1(t *testing.T) { testHandlerPanic(t, false, h1Mode, nil) } 2175 func TestHandlerPanicNil_h2(t *testing.T) { testHandlerPanic(t, false, h2Mode, nil) } 2176 2177 func TestHandlerPanic_h1(t *testing.T) { 2178 testHandlerPanic(t, false, h1Mode, "intentional death for testing") 2179 } 2180 func TestHandlerPanic_h2(t *testing.T) { 2181 testHandlerPanic(t, false, h2Mode, "intentional death for testing") 2182 } 2183 2184 func TestHandlerPanicWithHijack(t *testing.T) { 2185 // Only testing HTTP/1, and our http2 server doesn't support hijacking. 2186 testHandlerPanic(t, true, h1Mode, "intentional death for testing") 2187 } 2188 2189 func testHandlerPanic(t *testing.T, withHijack, h2 bool, panicValue interface{}) { 2190 defer afterTest(t) 2191 // Unlike the other tests that set the log output to ioutil.Discard 2192 // to quiet the output, this test uses a pipe. The pipe serves three 2193 // purposes: 2194 // 2195 // 1) The log.Print from the http server (generated by the caught 2196 // panic) will go to the pipe instead of stderr, making the 2197 // output quiet. 2198 // 2199 // 2) We read from the pipe to verify that the handler 2200 // actually caught the panic and logged something. 2201 // 2202 // 3) The blocking Read call prevents this TestHandlerPanic 2203 // function from exiting before the HTTP server handler 2204 // finishes crashing. If this text function exited too 2205 // early (and its defer log.SetOutput(os.Stderr) ran), 2206 // then the crash output could spill into the next test. 2207 pr, pw := io.Pipe() 2208 log.SetOutput(pw) 2209 defer log.SetOutput(os.Stderr) 2210 defer pw.Close() 2211 2212 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 2213 if withHijack { 2214 rwc, _, err := w.(Hijacker).Hijack() 2215 if err != nil { 2216 t.Logf("unexpected error: %v", err) 2217 } 2218 defer rwc.Close() 2219 } 2220 panic(panicValue) 2221 })) 2222 defer cst.close() 2223 2224 // Do a blocking read on the log output pipe so its logging 2225 // doesn't bleed into the next test. But wait only 5 seconds 2226 // for it. 2227 done := make(chan bool, 1) 2228 go func() { 2229 buf := make([]byte, 4<<10) 2230 _, err := pr.Read(buf) 2231 pr.Close() 2232 if err != nil && err != io.EOF { 2233 t.Error(err) 2234 } 2235 done <- true 2236 }() 2237 2238 _, err := cst.c.Get(cst.ts.URL) 2239 if err == nil { 2240 t.Logf("expected an error") 2241 } 2242 2243 if panicValue == nil { 2244 return 2245 } 2246 2247 select { 2248 case <-done: 2249 return 2250 case <-time.After(5 * time.Second): 2251 t.Fatal("expected server handler to log an error") 2252 } 2253 } 2254 2255 func TestServerNoDate_h1(t *testing.T) { testServerNoHeader(t, h1Mode, "Date") } 2256 func TestServerNoDate_h2(t *testing.T) { testServerNoHeader(t, h2Mode, "Date") } 2257 func TestServerNoContentType_h1(t *testing.T) { testServerNoHeader(t, h1Mode, "Content-Type") } 2258 func TestServerNoContentType_h2(t *testing.T) { testServerNoHeader(t, h2Mode, "Content-Type") } 2259 2260 func testServerNoHeader(t *testing.T, h2 bool, header string) { 2261 defer afterTest(t) 2262 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 2263 w.Header()[header] = nil 2264 io.WriteString(w, "<html>foo</html>") // non-empty 2265 })) 2266 defer cst.close() 2267 res, err := cst.c.Get(cst.ts.URL) 2268 if err != nil { 2269 t.Fatal(err) 2270 } 2271 res.Body.Close() 2272 if got, ok := res.Header[header]; ok { 2273 t.Fatalf("Expected no %s header; got %q", header, got) 2274 } 2275 } 2276 2277 func TestStripPrefix(t *testing.T) { 2278 defer afterTest(t) 2279 h := HandlerFunc(func(w ResponseWriter, r *Request) { 2280 w.Header().Set("X-Path", r.URL.Path) 2281 }) 2282 ts := httptest.NewServer(StripPrefix("/foo", h)) 2283 defer ts.Close() 2284 2285 res, err := Get(ts.URL + "/foo/bar") 2286 if err != nil { 2287 t.Fatal(err) 2288 } 2289 if g, e := res.Header.Get("X-Path"), "/bar"; g != e { 2290 t.Errorf("test 1: got %s, want %s", g, e) 2291 } 2292 res.Body.Close() 2293 2294 res, err = Get(ts.URL + "/bar") 2295 if err != nil { 2296 t.Fatal(err) 2297 } 2298 if g, e := res.StatusCode, 404; g != e { 2299 t.Errorf("test 2: got status %v, want %v", g, e) 2300 } 2301 res.Body.Close() 2302 } 2303 2304 func TestRequestLimit_h1(t *testing.T) { testRequestLimit(t, h1Mode) } 2305 func TestRequestLimit_h2(t *testing.T) { testRequestLimit(t, h2Mode) } 2306 func testRequestLimit(t *testing.T, h2 bool) { 2307 defer afterTest(t) 2308 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 2309 t.Fatalf("didn't expect to get request in Handler") 2310 })) 2311 defer cst.close() 2312 req, _ := NewRequest("GET", cst.ts.URL, nil) 2313 var bytesPerHeader = len("header12345: val12345\r\n") 2314 for i := 0; i < ((DefaultMaxHeaderBytes+4096)/bytesPerHeader)+1; i++ { 2315 req.Header.Set(fmt.Sprintf("header%05d", i), fmt.Sprintf("val%05d", i)) 2316 } 2317 res, err := cst.c.Do(req) 2318 if err != nil { 2319 // Some HTTP clients may fail on this undefined behavior (server replying and 2320 // closing the connection while the request is still being written), but 2321 // we do support it (at least currently), so we expect a response below. 2322 t.Fatalf("Do: %v", err) 2323 } 2324 defer res.Body.Close() 2325 if res.StatusCode != 431 { 2326 t.Fatalf("expected 431 response status; got: %d %s", res.StatusCode, res.Status) 2327 } 2328 } 2329 2330 type neverEnding byte 2331 2332 func (b neverEnding) Read(p []byte) (n int, err error) { 2333 for i := range p { 2334 p[i] = byte(b) 2335 } 2336 return len(p), nil 2337 } 2338 2339 type countReader struct { 2340 r io.Reader 2341 n *int64 2342 } 2343 2344 func (cr countReader) Read(p []byte) (n int, err error) { 2345 n, err = cr.r.Read(p) 2346 atomic.AddInt64(cr.n, int64(n)) 2347 return 2348 } 2349 2350 func TestRequestBodyLimit_h1(t *testing.T) { testRequestBodyLimit(t, h1Mode) } 2351 func TestRequestBodyLimit_h2(t *testing.T) { testRequestBodyLimit(t, h2Mode) } 2352 func testRequestBodyLimit(t *testing.T, h2 bool) { 2353 defer afterTest(t) 2354 const limit = 1 << 20 2355 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 2356 r.Body = MaxBytesReader(w, r.Body, limit) 2357 n, err := io.Copy(ioutil.Discard, r.Body) 2358 if err == nil { 2359 t.Errorf("expected error from io.Copy") 2360 } 2361 if n != limit { 2362 t.Errorf("io.Copy = %d, want %d", n, limit) 2363 } 2364 })) 2365 defer cst.close() 2366 2367 nWritten := new(int64) 2368 req, _ := NewRequest("POST", cst.ts.URL, io.LimitReader(countReader{neverEnding('a'), nWritten}, limit*200)) 2369 2370 // Send the POST, but don't care it succeeds or not. The 2371 // remote side is going to reply and then close the TCP 2372 // connection, and HTTP doesn't really define if that's 2373 // allowed or not. Some HTTP clients will get the response 2374 // and some (like ours, currently) will complain that the 2375 // request write failed, without reading the response. 2376 // 2377 // But that's okay, since what we're really testing is that 2378 // the remote side hung up on us before we wrote too much. 2379 _, _ = cst.c.Do(req) 2380 2381 if atomic.LoadInt64(nWritten) > limit*100 { 2382 t.Errorf("handler restricted the request body to %d bytes, but client managed to write %d", 2383 limit, nWritten) 2384 } 2385 } 2386 2387 // TestClientWriteShutdown tests that if the client shuts down the write 2388 // side of their TCP connection, the server doesn't send a 400 Bad Request. 2389 func TestClientWriteShutdown(t *testing.T) { 2390 if runtime.GOOS == "plan9" { 2391 t.Skip("skipping test; see https://golang.org/issue/7237") 2392 } 2393 defer afterTest(t) 2394 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {})) 2395 defer ts.Close() 2396 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2397 if err != nil { 2398 t.Fatalf("Dial: %v", err) 2399 } 2400 err = conn.(*net.TCPConn).CloseWrite() 2401 if err != nil { 2402 t.Fatalf("Dial: %v", err) 2403 } 2404 donec := make(chan bool) 2405 go func() { 2406 defer close(donec) 2407 bs, err := ioutil.ReadAll(conn) 2408 if err != nil { 2409 t.Fatalf("ReadAll: %v", err) 2410 } 2411 got := string(bs) 2412 if got != "" { 2413 t.Errorf("read %q from server; want nothing", got) 2414 } 2415 }() 2416 select { 2417 case <-donec: 2418 case <-time.After(10 * time.Second): 2419 t.Fatalf("timeout") 2420 } 2421 } 2422 2423 // Tests that chunked server responses that write 1 byte at a time are 2424 // buffered before chunk headers are added, not after chunk headers. 2425 func TestServerBufferedChunking(t *testing.T) { 2426 conn := new(testConn) 2427 conn.readBuf.Write([]byte("GET / HTTP/1.1\r\nHost: foo\r\n\r\n")) 2428 conn.closec = make(chan bool, 1) 2429 ls := &oneConnListener{conn} 2430 go Serve(ls, HandlerFunc(func(rw ResponseWriter, req *Request) { 2431 rw.(Flusher).Flush() // force the Header to be sent, in chunking mode, not counting the length 2432 rw.Write([]byte{'x'}) 2433 rw.Write([]byte{'y'}) 2434 rw.Write([]byte{'z'}) 2435 })) 2436 <-conn.closec 2437 if !bytes.HasSuffix(conn.writeBuf.Bytes(), []byte("\r\n\r\n3\r\nxyz\r\n0\r\n\r\n")) { 2438 t.Errorf("response didn't end with a single 3 byte 'xyz' chunk; got:\n%q", 2439 conn.writeBuf.Bytes()) 2440 } 2441 } 2442 2443 // Tests that the server flushes its response headers out when it's 2444 // ignoring the response body and waits a bit before forcefully 2445 // closing the TCP connection, causing the client to get a RST. 2446 // See https://golang.org/issue/3595 2447 func TestServerGracefulClose(t *testing.T) { 2448 defer afterTest(t) 2449 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 2450 Error(w, "bye", StatusUnauthorized) 2451 })) 2452 defer ts.Close() 2453 2454 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2455 if err != nil { 2456 t.Fatal(err) 2457 } 2458 defer conn.Close() 2459 const bodySize = 5 << 20 2460 req := []byte(fmt.Sprintf("POST / HTTP/1.1\r\nHost: foo.com\r\nContent-Length: %d\r\n\r\n", bodySize)) 2461 for i := 0; i < bodySize; i++ { 2462 req = append(req, 'x') 2463 } 2464 writeErr := make(chan error) 2465 go func() { 2466 _, err := conn.Write(req) 2467 writeErr <- err 2468 }() 2469 br := bufio.NewReader(conn) 2470 lineNum := 0 2471 for { 2472 line, err := br.ReadString('\n') 2473 if err == io.EOF { 2474 break 2475 } 2476 if err != nil { 2477 t.Fatalf("ReadLine: %v", err) 2478 } 2479 lineNum++ 2480 if lineNum == 1 && !strings.Contains(line, "401 Unauthorized") { 2481 t.Errorf("Response line = %q; want a 401", line) 2482 } 2483 } 2484 // Wait for write to finish. This is a broken pipe on both 2485 // Darwin and Linux, but checking this isn't the point of 2486 // the test. 2487 <-writeErr 2488 } 2489 2490 func TestCaseSensitiveMethod_h1(t *testing.T) { testCaseSensitiveMethod(t, h1Mode) } 2491 func TestCaseSensitiveMethod_h2(t *testing.T) { testCaseSensitiveMethod(t, h2Mode) } 2492 func testCaseSensitiveMethod(t *testing.T, h2 bool) { 2493 defer afterTest(t) 2494 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 2495 if r.Method != "get" { 2496 t.Errorf(`Got method %q; want "get"`, r.Method) 2497 } 2498 })) 2499 defer cst.close() 2500 req, _ := NewRequest("get", cst.ts.URL, nil) 2501 res, err := cst.c.Do(req) 2502 if err != nil { 2503 t.Error(err) 2504 return 2505 } 2506 2507 res.Body.Close() 2508 } 2509 2510 // TestContentLengthZero tests that for both an HTTP/1.0 and HTTP/1.1 2511 // request (both keep-alive), when a Handler never writes any 2512 // response, the net/http package adds a "Content-Length: 0" response 2513 // header. 2514 func TestContentLengthZero(t *testing.T) { 2515 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) {})) 2516 defer ts.Close() 2517 2518 for _, version := range []string{"HTTP/1.0", "HTTP/1.1"} { 2519 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2520 if err != nil { 2521 t.Fatalf("error dialing: %v", err) 2522 } 2523 _, err = fmt.Fprintf(conn, "GET / %v\r\nConnection: keep-alive\r\nHost: foo\r\n\r\n", version) 2524 if err != nil { 2525 t.Fatalf("error writing: %v", err) 2526 } 2527 req, _ := NewRequest("GET", "/", nil) 2528 res, err := ReadResponse(bufio.NewReader(conn), req) 2529 if err != nil { 2530 t.Fatalf("error reading response: %v", err) 2531 } 2532 if te := res.TransferEncoding; len(te) > 0 { 2533 t.Errorf("For version %q, Transfer-Encoding = %q; want none", version, te) 2534 } 2535 if cl := res.ContentLength; cl != 0 { 2536 t.Errorf("For version %q, Content-Length = %v; want 0", version, cl) 2537 } 2538 conn.Close() 2539 } 2540 } 2541 2542 func TestCloseNotifier(t *testing.T) { 2543 defer afterTest(t) 2544 gotReq := make(chan bool, 1) 2545 sawClose := make(chan bool, 1) 2546 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) { 2547 gotReq <- true 2548 cc := rw.(CloseNotifier).CloseNotify() 2549 <-cc 2550 sawClose <- true 2551 })) 2552 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2553 if err != nil { 2554 t.Fatalf("error dialing: %v", err) 2555 } 2556 diec := make(chan bool) 2557 go func() { 2558 _, err = fmt.Fprintf(conn, "GET / HTTP/1.1\r\nConnection: keep-alive\r\nHost: foo\r\n\r\n") 2559 if err != nil { 2560 t.Fatal(err) 2561 } 2562 <-diec 2563 conn.Close() 2564 }() 2565 For: 2566 for { 2567 select { 2568 case <-gotReq: 2569 diec <- true 2570 case <-sawClose: 2571 break For 2572 case <-time.After(5 * time.Second): 2573 t.Fatal("timeout") 2574 } 2575 } 2576 ts.Close() 2577 } 2578 2579 // Tests that a pipelined request causes the first request's Handler's CloseNotify 2580 // channel to fire. Previously it deadlocked. 2581 // 2582 // Issue 13165 2583 func TestCloseNotifierPipelined(t *testing.T) { 2584 defer afterTest(t) 2585 gotReq := make(chan bool, 2) 2586 sawClose := make(chan bool, 2) 2587 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) { 2588 gotReq <- true 2589 cc := rw.(CloseNotifier).CloseNotify() 2590 <-cc 2591 sawClose <- true 2592 })) 2593 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2594 if err != nil { 2595 t.Fatalf("error dialing: %v", err) 2596 } 2597 diec := make(chan bool, 1) 2598 go func() { 2599 const req = "GET / HTTP/1.1\r\nConnection: keep-alive\r\nHost: foo\r\n\r\n" 2600 _, err = io.WriteString(conn, req+req) // two requests 2601 if err != nil { 2602 t.Fatal(err) 2603 } 2604 <-diec 2605 conn.Close() 2606 }() 2607 reqs := 0 2608 closes := 0 2609 For: 2610 for { 2611 select { 2612 case <-gotReq: 2613 reqs++ 2614 if reqs > 2 { 2615 t.Fatal("too many requests") 2616 } else if reqs > 1 { 2617 diec <- true 2618 } 2619 case <-sawClose: 2620 closes++ 2621 if closes > 1 { 2622 break For 2623 } 2624 case <-time.After(5 * time.Second): 2625 ts.CloseClientConnections() 2626 t.Fatal("timeout") 2627 } 2628 } 2629 ts.Close() 2630 } 2631 2632 func TestCloseNotifierChanLeak(t *testing.T) { 2633 defer afterTest(t) 2634 req := reqBytes("GET / HTTP/1.0\nHost: golang.org") 2635 for i := 0; i < 20; i++ { 2636 var output bytes.Buffer 2637 conn := &rwTestConn{ 2638 Reader: bytes.NewReader(req), 2639 Writer: &output, 2640 closec: make(chan bool, 1), 2641 } 2642 ln := &oneConnListener{conn: conn} 2643 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 2644 // Ignore the return value and never read from 2645 // it, testing that we don't leak goroutines 2646 // on the sending side: 2647 _ = rw.(CloseNotifier).CloseNotify() 2648 }) 2649 go Serve(ln, handler) 2650 <-conn.closec 2651 } 2652 } 2653 2654 // Tests that we can use CloseNotifier in one request, and later call Hijack 2655 // on a second request on the same connection. 2656 // 2657 // It also tests that the connReader stitches together its background 2658 // 1-byte read for CloseNotifier when CloseNotifier doesn't fire with 2659 // the rest of the second HTTP later. 2660 // 2661 // Issue 9763. 2662 // HTTP/1-only test. (http2 doesn't have Hijack) 2663 func TestHijackAfterCloseNotifier(t *testing.T) { 2664 defer afterTest(t) 2665 script := make(chan string, 2) 2666 script <- "closenotify" 2667 script <- "hijack" 2668 close(script) 2669 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 2670 plan := <-script 2671 switch plan { 2672 default: 2673 panic("bogus plan; too many requests") 2674 case "closenotify": 2675 w.(CloseNotifier).CloseNotify() // discard result 2676 w.Header().Set("X-Addr", r.RemoteAddr) 2677 case "hijack": 2678 c, _, err := w.(Hijacker).Hijack() 2679 if err != nil { 2680 t.Errorf("Hijack in Handler: %v", err) 2681 return 2682 } 2683 if _, ok := c.(*net.TCPConn); !ok { 2684 // Verify it's not wrapped in some type. 2685 // Not strictly a go1 compat issue, but in practice it probably is. 2686 t.Errorf("type of hijacked conn is %T; want *net.TCPConn", c) 2687 } 2688 fmt.Fprintf(c, "HTTP/1.0 200 OK\r\nX-Addr: %v\r\nContent-Length: 0\r\n\r\n", r.RemoteAddr) 2689 c.Close() 2690 return 2691 } 2692 })) 2693 defer ts.Close() 2694 res1, err := Get(ts.URL) 2695 if err != nil { 2696 log.Fatal(err) 2697 } 2698 res2, err := Get(ts.URL) 2699 if err != nil { 2700 log.Fatal(err) 2701 } 2702 addr1 := res1.Header.Get("X-Addr") 2703 addr2 := res2.Header.Get("X-Addr") 2704 if addr1 == "" || addr1 != addr2 { 2705 t.Errorf("addr1, addr2 = %q, %q; want same", addr1, addr2) 2706 } 2707 } 2708 2709 func TestHijackBeforeRequestBodyRead(t *testing.T) { 2710 defer afterTest(t) 2711 var requestBody = bytes.Repeat([]byte("a"), 1<<20) 2712 bodyOkay := make(chan bool, 1) 2713 gotCloseNotify := make(chan bool, 1) 2714 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 2715 defer close(bodyOkay) // caller will read false if nothing else 2716 2717 reqBody := r.Body 2718 r.Body = nil // to test that server.go doesn't use this value. 2719 2720 gone := w.(CloseNotifier).CloseNotify() 2721 slurp, err := ioutil.ReadAll(reqBody) 2722 if err != nil { 2723 t.Errorf("Body read: %v", err) 2724 return 2725 } 2726 if len(slurp) != len(requestBody) { 2727 t.Errorf("Backend read %d request body bytes; want %d", len(slurp), len(requestBody)) 2728 return 2729 } 2730 if !bytes.Equal(slurp, requestBody) { 2731 t.Error("Backend read wrong request body.") // 1MB; omitting details 2732 return 2733 } 2734 bodyOkay <- true 2735 select { 2736 case <-gone: 2737 gotCloseNotify <- true 2738 case <-time.After(5 * time.Second): 2739 gotCloseNotify <- false 2740 } 2741 })) 2742 defer ts.Close() 2743 2744 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2745 if err != nil { 2746 t.Fatal(err) 2747 } 2748 defer conn.Close() 2749 2750 fmt.Fprintf(conn, "POST / HTTP/1.1\r\nHost: foo\r\nContent-Length: %d\r\n\r\n%s", 2751 len(requestBody), requestBody) 2752 if !<-bodyOkay { 2753 // already failed. 2754 return 2755 } 2756 conn.Close() 2757 if !<-gotCloseNotify { 2758 t.Error("timeout waiting for CloseNotify") 2759 } 2760 } 2761 2762 func TestOptions(t *testing.T) { 2763 uric := make(chan string, 2) // only expect 1, but leave space for 2 2764 mux := NewServeMux() 2765 mux.HandleFunc("/", func(w ResponseWriter, r *Request) { 2766 uric <- r.RequestURI 2767 }) 2768 ts := httptest.NewServer(mux) 2769 defer ts.Close() 2770 2771 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 2772 if err != nil { 2773 t.Fatal(err) 2774 } 2775 defer conn.Close() 2776 2777 // An OPTIONS * request should succeed. 2778 _, err = conn.Write([]byte("OPTIONS * HTTP/1.1\r\nHost: foo.com\r\n\r\n")) 2779 if err != nil { 2780 t.Fatal(err) 2781 } 2782 br := bufio.NewReader(conn) 2783 res, err := ReadResponse(br, &Request{Method: "OPTIONS"}) 2784 if err != nil { 2785 t.Fatal(err) 2786 } 2787 if res.StatusCode != 200 { 2788 t.Errorf("Got non-200 response to OPTIONS *: %#v", res) 2789 } 2790 2791 // A GET * request on a ServeMux should fail. 2792 _, err = conn.Write([]byte("GET * HTTP/1.1\r\nHost: foo.com\r\n\r\n")) 2793 if err != nil { 2794 t.Fatal(err) 2795 } 2796 res, err = ReadResponse(br, &Request{Method: "GET"}) 2797 if err != nil { 2798 t.Fatal(err) 2799 } 2800 if res.StatusCode != 400 { 2801 t.Errorf("Got non-400 response to GET *: %#v", res) 2802 } 2803 2804 res, err = Get(ts.URL + "/second") 2805 if err != nil { 2806 t.Fatal(err) 2807 } 2808 res.Body.Close() 2809 if got := <-uric; got != "/second" { 2810 t.Errorf("Handler saw request for %q; want /second", got) 2811 } 2812 } 2813 2814 // Tests regarding the ordering of Write, WriteHeader, Header, and 2815 // Flush calls. In Go 1.0, rw.WriteHeader immediately flushed the 2816 // (*response).header to the wire. In Go 1.1, the actual wire flush is 2817 // delayed, so we could maybe tack on a Content-Length and better 2818 // Content-Type after we see more (or all) of the output. To preserve 2819 // compatibility with Go 1, we need to be careful to track which 2820 // headers were live at the time of WriteHeader, so we write the same 2821 // ones, even if the handler modifies them (~erroneously) after the 2822 // first Write. 2823 func TestHeaderToWire(t *testing.T) { 2824 tests := []struct { 2825 name string 2826 handler func(ResponseWriter, *Request) 2827 check func(output string) error 2828 }{ 2829 { 2830 name: "write without Header", 2831 handler: func(rw ResponseWriter, r *Request) { 2832 rw.Write([]byte("hello world")) 2833 }, 2834 check: func(got string) error { 2835 if !strings.Contains(got, "Content-Length:") { 2836 return errors.New("no content-length") 2837 } 2838 if !strings.Contains(got, "Content-Type: text/plain") { 2839 return errors.New("no content-type") 2840 } 2841 return nil 2842 }, 2843 }, 2844 { 2845 name: "Header mutation before write", 2846 handler: func(rw ResponseWriter, r *Request) { 2847 h := rw.Header() 2848 h.Set("Content-Type", "some/type") 2849 rw.Write([]byte("hello world")) 2850 h.Set("Too-Late", "bogus") 2851 }, 2852 check: func(got string) error { 2853 if !strings.Contains(got, "Content-Length:") { 2854 return errors.New("no content-length") 2855 } 2856 if !strings.Contains(got, "Content-Type: some/type") { 2857 return errors.New("wrong content-type") 2858 } 2859 if strings.Contains(got, "Too-Late") { 2860 return errors.New("don't want too-late header") 2861 } 2862 return nil 2863 }, 2864 }, 2865 { 2866 name: "write then useless Header mutation", 2867 handler: func(rw ResponseWriter, r *Request) { 2868 rw.Write([]byte("hello world")) 2869 rw.Header().Set("Too-Late", "Write already wrote headers") 2870 }, 2871 check: func(got string) error { 2872 if strings.Contains(got, "Too-Late") { 2873 return errors.New("header appeared from after WriteHeader") 2874 } 2875 return nil 2876 }, 2877 }, 2878 { 2879 name: "flush then write", 2880 handler: func(rw ResponseWriter, r *Request) { 2881 rw.(Flusher).Flush() 2882 rw.Write([]byte("post-flush")) 2883 rw.Header().Set("Too-Late", "Write already wrote headers") 2884 }, 2885 check: func(got string) error { 2886 if !strings.Contains(got, "Transfer-Encoding: chunked") { 2887 return errors.New("not chunked") 2888 } 2889 if strings.Contains(got, "Too-Late") { 2890 return errors.New("header appeared from after WriteHeader") 2891 } 2892 return nil 2893 }, 2894 }, 2895 { 2896 name: "header then flush", 2897 handler: func(rw ResponseWriter, r *Request) { 2898 rw.Header().Set("Content-Type", "some/type") 2899 rw.(Flusher).Flush() 2900 rw.Write([]byte("post-flush")) 2901 rw.Header().Set("Too-Late", "Write already wrote headers") 2902 }, 2903 check: func(got string) error { 2904 if !strings.Contains(got, "Transfer-Encoding: chunked") { 2905 return errors.New("not chunked") 2906 } 2907 if strings.Contains(got, "Too-Late") { 2908 return errors.New("header appeared from after WriteHeader") 2909 } 2910 if !strings.Contains(got, "Content-Type: some/type") { 2911 return errors.New("wrong content-type") 2912 } 2913 return nil 2914 }, 2915 }, 2916 { 2917 name: "sniff-on-first-write content-type", 2918 handler: func(rw ResponseWriter, r *Request) { 2919 rw.Write([]byte("<html><head></head><body>some html</body></html>")) 2920 rw.Header().Set("Content-Type", "x/wrong") 2921 }, 2922 check: func(got string) error { 2923 if !strings.Contains(got, "Content-Type: text/html") { 2924 return errors.New("wrong content-type; want html") 2925 } 2926 return nil 2927 }, 2928 }, 2929 { 2930 name: "explicit content-type wins", 2931 handler: func(rw ResponseWriter, r *Request) { 2932 rw.Header().Set("Content-Type", "some/type") 2933 rw.Write([]byte("<html><head></head><body>some html</body></html>")) 2934 }, 2935 check: func(got string) error { 2936 if !strings.Contains(got, "Content-Type: some/type") { 2937 return errors.New("wrong content-type; want html") 2938 } 2939 return nil 2940 }, 2941 }, 2942 { 2943 name: "empty handler", 2944 handler: func(rw ResponseWriter, r *Request) { 2945 }, 2946 check: func(got string) error { 2947 if !strings.Contains(got, "Content-Type: text/plain") { 2948 return errors.New("wrong content-type; want text/plain") 2949 } 2950 if !strings.Contains(got, "Content-Length: 0") { 2951 return errors.New("want 0 content-length") 2952 } 2953 return nil 2954 }, 2955 }, 2956 { 2957 name: "only Header, no write", 2958 handler: func(rw ResponseWriter, r *Request) { 2959 rw.Header().Set("Some-Header", "some-value") 2960 }, 2961 check: func(got string) error { 2962 if !strings.Contains(got, "Some-Header") { 2963 return errors.New("didn't get header") 2964 } 2965 return nil 2966 }, 2967 }, 2968 { 2969 name: "WriteHeader call", 2970 handler: func(rw ResponseWriter, r *Request) { 2971 rw.WriteHeader(404) 2972 rw.Header().Set("Too-Late", "some-value") 2973 }, 2974 check: func(got string) error { 2975 if !strings.Contains(got, "404") { 2976 return errors.New("wrong status") 2977 } 2978 if strings.Contains(got, "Too-Late") { 2979 return errors.New("shouldn't have seen Too-Late") 2980 } 2981 return nil 2982 }, 2983 }, 2984 } 2985 for _, tc := range tests { 2986 ht := newHandlerTest(HandlerFunc(tc.handler)) 2987 got := ht.rawResponse("GET / HTTP/1.1\nHost: golang.org") 2988 if err := tc.check(got); err != nil { 2989 t.Errorf("%s: %v\nGot response:\n%s", tc.name, err, got) 2990 } 2991 } 2992 } 2993 2994 // goTimeout runs f, failing t if f takes more than ns to complete. 2995 func goTimeout(t *testing.T, d time.Duration, f func()) { 2996 ch := make(chan bool, 2) 2997 timer := time.AfterFunc(d, func() { 2998 t.Errorf("Timeout expired after %v", d) 2999 ch <- true 3000 }) 3001 defer timer.Stop() 3002 go func() { 3003 defer func() { ch <- true }() 3004 f() 3005 }() 3006 <-ch 3007 } 3008 3009 type errorListener struct { 3010 errs []error 3011 } 3012 3013 func (l *errorListener) Accept() (c net.Conn, err error) { 3014 if len(l.errs) == 0 { 3015 return nil, io.EOF 3016 } 3017 err = l.errs[0] 3018 l.errs = l.errs[1:] 3019 return 3020 } 3021 3022 func (l *errorListener) Close() error { 3023 return nil 3024 } 3025 3026 func (l *errorListener) Addr() net.Addr { 3027 return dummyAddr("test-address") 3028 } 3029 3030 func TestAcceptMaxFds(t *testing.T) { 3031 log.SetOutput(ioutil.Discard) // is noisy otherwise 3032 defer log.SetOutput(os.Stderr) 3033 3034 ln := &errorListener{[]error{ 3035 &net.OpError{ 3036 Op: "accept", 3037 Err: syscall.EMFILE, 3038 }}} 3039 err := Serve(ln, HandlerFunc(HandlerFunc(func(ResponseWriter, *Request) {}))) 3040 if err != io.EOF { 3041 t.Errorf("got error %v, want EOF", err) 3042 } 3043 } 3044 3045 func TestWriteAfterHijack(t *testing.T) { 3046 req := reqBytes("GET / HTTP/1.1\nHost: golang.org") 3047 var buf bytes.Buffer 3048 wrotec := make(chan bool, 1) 3049 conn := &rwTestConn{ 3050 Reader: bytes.NewReader(req), 3051 Writer: &buf, 3052 closec: make(chan bool, 1), 3053 } 3054 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 3055 conn, bufrw, err := rw.(Hijacker).Hijack() 3056 if err != nil { 3057 t.Error(err) 3058 return 3059 } 3060 go func() { 3061 bufrw.Write([]byte("[hijack-to-bufw]")) 3062 bufrw.Flush() 3063 conn.Write([]byte("[hijack-to-conn]")) 3064 conn.Close() 3065 wrotec <- true 3066 }() 3067 }) 3068 ln := &oneConnListener{conn: conn} 3069 go Serve(ln, handler) 3070 <-conn.closec 3071 <-wrotec 3072 if g, w := buf.String(), "[hijack-to-bufw][hijack-to-conn]"; g != w { 3073 t.Errorf("wrote %q; want %q", g, w) 3074 } 3075 } 3076 3077 func TestDoubleHijack(t *testing.T) { 3078 req := reqBytes("GET / HTTP/1.1\nHost: golang.org") 3079 var buf bytes.Buffer 3080 conn := &rwTestConn{ 3081 Reader: bytes.NewReader(req), 3082 Writer: &buf, 3083 closec: make(chan bool, 1), 3084 } 3085 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 3086 conn, _, err := rw.(Hijacker).Hijack() 3087 if err != nil { 3088 t.Error(err) 3089 return 3090 } 3091 _, _, err = rw.(Hijacker).Hijack() 3092 if err == nil { 3093 t.Errorf("got err = nil; want err != nil") 3094 } 3095 conn.Close() 3096 }) 3097 ln := &oneConnListener{conn: conn} 3098 go Serve(ln, handler) 3099 <-conn.closec 3100 } 3101 3102 // https://golang.org/issue/5955 3103 // Note that this does not test the "request too large" 3104 // exit path from the http server. This is intentional; 3105 // not sending Connection: close is just a minor wire 3106 // optimization and is pointless if dealing with a 3107 // badly behaved client. 3108 func TestHTTP10ConnectionHeader(t *testing.T) { 3109 defer afterTest(t) 3110 3111 mux := NewServeMux() 3112 mux.Handle("/", HandlerFunc(func(ResponseWriter, *Request) {})) 3113 ts := httptest.NewServer(mux) 3114 defer ts.Close() 3115 3116 // net/http uses HTTP/1.1 for requests, so write requests manually 3117 tests := []struct { 3118 req string // raw http request 3119 expect []string // expected Connection header(s) 3120 }{ 3121 { 3122 req: "GET / HTTP/1.0\r\n\r\n", 3123 expect: nil, 3124 }, 3125 { 3126 req: "OPTIONS * HTTP/1.0\r\n\r\n", 3127 expect: nil, 3128 }, 3129 { 3130 req: "GET / HTTP/1.0\r\nConnection: keep-alive\r\n\r\n", 3131 expect: []string{"keep-alive"}, 3132 }, 3133 } 3134 3135 for _, tt := range tests { 3136 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 3137 if err != nil { 3138 t.Fatal("dial err:", err) 3139 } 3140 3141 _, err = fmt.Fprint(conn, tt.req) 3142 if err != nil { 3143 t.Fatal("conn write err:", err) 3144 } 3145 3146 resp, err := ReadResponse(bufio.NewReader(conn), &Request{Method: "GET"}) 3147 if err != nil { 3148 t.Fatal("ReadResponse err:", err) 3149 } 3150 conn.Close() 3151 resp.Body.Close() 3152 3153 got := resp.Header["Connection"] 3154 if !reflect.DeepEqual(got, tt.expect) { 3155 t.Errorf("wrong Connection headers for request %q. Got %q expect %q", tt.req, got, tt.expect) 3156 } 3157 } 3158 } 3159 3160 // See golang.org/issue/5660 3161 func TestServerReaderFromOrder_h1(t *testing.T) { testServerReaderFromOrder(t, h1Mode) } 3162 func TestServerReaderFromOrder_h2(t *testing.T) { testServerReaderFromOrder(t, h2Mode) } 3163 func testServerReaderFromOrder(t *testing.T, h2 bool) { 3164 defer afterTest(t) 3165 pr, pw := io.Pipe() 3166 const size = 3 << 20 3167 cst := newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, req *Request) { 3168 rw.Header().Set("Content-Type", "text/plain") // prevent sniffing path 3169 done := make(chan bool) 3170 go func() { 3171 io.Copy(rw, pr) 3172 close(done) 3173 }() 3174 time.Sleep(25 * time.Millisecond) // give Copy a chance to break things 3175 n, err := io.Copy(ioutil.Discard, req.Body) 3176 if err != nil { 3177 t.Errorf("handler Copy: %v", err) 3178 return 3179 } 3180 if n != size { 3181 t.Errorf("handler Copy = %d; want %d", n, size) 3182 } 3183 pw.Write([]byte("hi")) 3184 pw.Close() 3185 <-done 3186 })) 3187 defer cst.close() 3188 3189 req, err := NewRequest("POST", cst.ts.URL, io.LimitReader(neverEnding('a'), size)) 3190 if err != nil { 3191 t.Fatal(err) 3192 } 3193 res, err := cst.c.Do(req) 3194 if err != nil { 3195 t.Fatal(err) 3196 } 3197 all, err := ioutil.ReadAll(res.Body) 3198 if err != nil { 3199 t.Fatal(err) 3200 } 3201 res.Body.Close() 3202 if string(all) != "hi" { 3203 t.Errorf("Body = %q; want hi", all) 3204 } 3205 } 3206 3207 // Issue 6157, Issue 6685 3208 func TestCodesPreventingContentTypeAndBody(t *testing.T) { 3209 for _, code := range []int{StatusNotModified, StatusNoContent, StatusContinue} { 3210 ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { 3211 if r.URL.Path == "/header" { 3212 w.Header().Set("Content-Length", "123") 3213 } 3214 w.WriteHeader(code) 3215 if r.URL.Path == "/more" { 3216 w.Write([]byte("stuff")) 3217 } 3218 })) 3219 for _, req := range []string{ 3220 "GET / HTTP/1.0", 3221 "GET /header HTTP/1.0", 3222 "GET /more HTTP/1.0", 3223 "GET / HTTP/1.1\nHost: foo", 3224 "GET /header HTTP/1.1\nHost: foo", 3225 "GET /more HTTP/1.1\nHost: foo", 3226 } { 3227 got := ht.rawResponse(req) 3228 wantStatus := fmt.Sprintf("%d %s", code, StatusText(code)) 3229 if !strings.Contains(got, wantStatus) { 3230 t.Errorf("Code %d: Wanted %q Modified for %q: %s", code, wantStatus, req, got) 3231 } else if strings.Contains(got, "Content-Length") { 3232 t.Errorf("Code %d: Got a Content-Length from %q: %s", code, req, got) 3233 } else if strings.Contains(got, "stuff") { 3234 t.Errorf("Code %d: Response contains a body from %q: %s", code, req, got) 3235 } 3236 } 3237 } 3238 } 3239 3240 func TestContentTypeOkayOn204(t *testing.T) { 3241 ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { 3242 w.Header().Set("Content-Length", "123") // suppressed 3243 w.Header().Set("Content-Type", "foo/bar") 3244 w.WriteHeader(204) 3245 })) 3246 got := ht.rawResponse("GET / HTTP/1.1\nHost: foo") 3247 if !strings.Contains(got, "Content-Type: foo/bar") { 3248 t.Errorf("Response = %q; want Content-Type: foo/bar", got) 3249 } 3250 if strings.Contains(got, "Content-Length: 123") { 3251 t.Errorf("Response = %q; don't want a Content-Length", got) 3252 } 3253 } 3254 3255 // Issue 6995 3256 // A server Handler can receive a Request, and then turn around and 3257 // give a copy of that Request.Body out to the Transport (e.g. any 3258 // proxy). So then two people own that Request.Body (both the server 3259 // and the http client), and both think they can close it on failure. 3260 // Therefore, all incoming server requests Bodies need to be thread-safe. 3261 func TestTransportAndServerSharedBodyRace_h1(t *testing.T) { 3262 testTransportAndServerSharedBodyRace(t, h1Mode) 3263 } 3264 func TestTransportAndServerSharedBodyRace_h2(t *testing.T) { 3265 testTransportAndServerSharedBodyRace(t, h2Mode) 3266 } 3267 func testTransportAndServerSharedBodyRace(t *testing.T, h2 bool) { 3268 defer afterTest(t) 3269 3270 const bodySize = 1 << 20 3271 3272 // errorf is like t.Errorf, but also writes to println. When 3273 // this test fails, it hangs. This helps debugging and I've 3274 // added this enough times "temporarily". It now gets added 3275 // full time. 3276 errorf := func(format string, args ...interface{}) { 3277 v := fmt.Sprintf(format, args...) 3278 println(v) 3279 t.Error(v) 3280 } 3281 3282 unblockBackend := make(chan bool) 3283 backend := newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, req *Request) { 3284 gone := rw.(CloseNotifier).CloseNotify() 3285 didCopy := make(chan interface{}) 3286 go func() { 3287 n, err := io.CopyN(rw, req.Body, bodySize) 3288 didCopy <- []interface{}{n, err} 3289 }() 3290 isGone := false 3291 Loop: 3292 for { 3293 select { 3294 case <-didCopy: 3295 break Loop 3296 case <-gone: 3297 isGone = true 3298 case <-time.After(time.Second): 3299 println("1 second passes in backend, proxygone=", isGone) 3300 } 3301 } 3302 <-unblockBackend 3303 })) 3304 var quitTimer *time.Timer 3305 defer func() { quitTimer.Stop() }() 3306 defer backend.close() 3307 3308 backendRespc := make(chan *Response, 1) 3309 var proxy *clientServerTest 3310 proxy = newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, req *Request) { 3311 req2, _ := NewRequest("POST", backend.ts.URL, req.Body) 3312 req2.ContentLength = bodySize 3313 cancel := make(chan struct{}) 3314 req2.Cancel = cancel 3315 3316 bresp, err := proxy.c.Do(req2) 3317 if err != nil { 3318 errorf("Proxy outbound request: %v", err) 3319 return 3320 } 3321 _, err = io.CopyN(ioutil.Discard, bresp.Body, bodySize/2) 3322 if err != nil { 3323 errorf("Proxy copy error: %v", err) 3324 return 3325 } 3326 backendRespc <- bresp // to close later 3327 3328 // Try to cause a race: Both the Transport and the proxy handler's Server 3329 // will try to read/close req.Body (aka req2.Body) 3330 if h2 { 3331 close(cancel) 3332 } else { 3333 proxy.c.Transport.(*Transport).CancelRequest(req2) 3334 } 3335 rw.Write([]byte("OK")) 3336 })) 3337 defer proxy.close() 3338 defer func() { 3339 // Before we shut down our two httptest.Servers, start a timer. 3340 // We choose 7 seconds because httptest.Server starts logging 3341 // warnings to stderr at 5 seconds. If we don't disarm this bomb 3342 // in 7 seconds (after the two httptest.Server.Close calls above), 3343 // then we explode with stacks. 3344 quitTimer = time.AfterFunc(7*time.Second, func() { 3345 debug.SetTraceback("ALL") 3346 stacks := make([]byte, 1<<20) 3347 stacks = stacks[:runtime.Stack(stacks, true)] 3348 fmt.Fprintf(os.Stderr, "%s", stacks) 3349 log.Fatalf("Timeout.") 3350 }) 3351 }() 3352 3353 defer close(unblockBackend) 3354 req, _ := NewRequest("POST", proxy.ts.URL, io.LimitReader(neverEnding('a'), bodySize)) 3355 res, err := proxy.c.Do(req) 3356 if err != nil { 3357 t.Fatalf("Original request: %v", err) 3358 } 3359 3360 // Cleanup, so we don't leak goroutines. 3361 res.Body.Close() 3362 select { 3363 case res := <-backendRespc: 3364 res.Body.Close() 3365 default: 3366 // We failed earlier. (e.g. on proxy.c.Do(req2)) 3367 } 3368 } 3369 3370 // Test that a hanging Request.Body.Read from another goroutine can't 3371 // cause the Handler goroutine's Request.Body.Close to block. 3372 func TestRequestBodyCloseDoesntBlock(t *testing.T) { 3373 t.Skipf("Skipping known issue; see golang.org/issue/7121") 3374 if testing.Short() { 3375 t.Skip("skipping in -short mode") 3376 } 3377 defer afterTest(t) 3378 3379 readErrCh := make(chan error, 1) 3380 errCh := make(chan error, 2) 3381 3382 server := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) { 3383 go func(body io.Reader) { 3384 _, err := body.Read(make([]byte, 100)) 3385 readErrCh <- err 3386 }(req.Body) 3387 time.Sleep(500 * time.Millisecond) 3388 })) 3389 defer server.Close() 3390 3391 closeConn := make(chan bool) 3392 defer close(closeConn) 3393 go func() { 3394 conn, err := net.Dial("tcp", server.Listener.Addr().String()) 3395 if err != nil { 3396 errCh <- err 3397 return 3398 } 3399 defer conn.Close() 3400 _, err = conn.Write([]byte("POST / HTTP/1.1\r\nConnection: close\r\nHost: foo\r\nContent-Length: 100000\r\n\r\n")) 3401 if err != nil { 3402 errCh <- err 3403 return 3404 } 3405 // And now just block, making the server block on our 3406 // 100000 bytes of body that will never arrive. 3407 <-closeConn 3408 }() 3409 select { 3410 case err := <-readErrCh: 3411 if err == nil { 3412 t.Error("Read was nil. Expected error.") 3413 } 3414 case err := <-errCh: 3415 t.Error(err) 3416 case <-time.After(5 * time.Second): 3417 t.Error("timeout") 3418 } 3419 } 3420 3421 // test that ResponseWriter implements io.stringWriter. 3422 func TestResponseWriterWriteString(t *testing.T) { 3423 okc := make(chan bool, 1) 3424 ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { 3425 type stringWriter interface { 3426 WriteString(s string) (n int, err error) 3427 } 3428 _, ok := w.(stringWriter) 3429 okc <- ok 3430 })) 3431 ht.rawResponse("GET / HTTP/1.0") 3432 select { 3433 case ok := <-okc: 3434 if !ok { 3435 t.Error("ResponseWriter did not implement io.stringWriter") 3436 } 3437 default: 3438 t.Error("handler was never called") 3439 } 3440 } 3441 3442 func TestAppendTime(t *testing.T) { 3443 var b [len(TimeFormat)]byte 3444 t1 := time.Date(2013, 9, 21, 15, 41, 0, 0, time.FixedZone("CEST", 2*60*60)) 3445 res := ExportAppendTime(b[:0], t1) 3446 t2, err := ParseTime(string(res)) 3447 if err != nil { 3448 t.Fatalf("Error parsing time: %s", err) 3449 } 3450 if !t1.Equal(t2) { 3451 t.Fatalf("Times differ; expected: %v, got %v (%s)", t1, t2, string(res)) 3452 } 3453 } 3454 3455 func TestServerConnState(t *testing.T) { 3456 defer afterTest(t) 3457 handler := map[string]func(w ResponseWriter, r *Request){ 3458 "/": func(w ResponseWriter, r *Request) { 3459 fmt.Fprintf(w, "Hello.") 3460 }, 3461 "/close": func(w ResponseWriter, r *Request) { 3462 w.Header().Set("Connection", "close") 3463 fmt.Fprintf(w, "Hello.") 3464 }, 3465 "/hijack": func(w ResponseWriter, r *Request) { 3466 c, _, _ := w.(Hijacker).Hijack() 3467 c.Write([]byte("HTTP/1.0 200 OK\r\nConnection: close\r\n\r\nHello.")) 3468 c.Close() 3469 }, 3470 "/hijack-panic": func(w ResponseWriter, r *Request) { 3471 c, _, _ := w.(Hijacker).Hijack() 3472 c.Write([]byte("HTTP/1.0 200 OK\r\nConnection: close\r\n\r\nHello.")) 3473 c.Close() 3474 panic("intentional panic") 3475 }, 3476 } 3477 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) { 3478 handler[r.URL.Path](w, r) 3479 })) 3480 defer ts.Close() 3481 3482 var mu sync.Mutex // guard stateLog and connID 3483 var stateLog = map[int][]ConnState{} 3484 var connID = map[net.Conn]int{} 3485 3486 ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0) 3487 ts.Config.ConnState = func(c net.Conn, state ConnState) { 3488 if c == nil { 3489 t.Errorf("nil conn seen in state %s", state) 3490 return 3491 } 3492 mu.Lock() 3493 defer mu.Unlock() 3494 id, ok := connID[c] 3495 if !ok { 3496 id = len(connID) + 1 3497 connID[c] = id 3498 } 3499 stateLog[id] = append(stateLog[id], state) 3500 } 3501 ts.Start() 3502 3503 mustGet(t, ts.URL+"/") 3504 mustGet(t, ts.URL+"/close") 3505 3506 mustGet(t, ts.URL+"/") 3507 mustGet(t, ts.URL+"/", "Connection", "close") 3508 3509 mustGet(t, ts.URL+"/hijack") 3510 mustGet(t, ts.URL+"/hijack-panic") 3511 3512 // New->Closed 3513 { 3514 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 3515 if err != nil { 3516 t.Fatal(err) 3517 } 3518 c.Close() 3519 } 3520 3521 // New->Active->Closed 3522 { 3523 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 3524 if err != nil { 3525 t.Fatal(err) 3526 } 3527 if _, err := io.WriteString(c, "BOGUS REQUEST\r\n\r\n"); err != nil { 3528 t.Fatal(err) 3529 } 3530 c.Read(make([]byte, 1)) // block until server hangs up on us 3531 c.Close() 3532 } 3533 3534 // New->Idle->Closed 3535 { 3536 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 3537 if err != nil { 3538 t.Fatal(err) 3539 } 3540 if _, err := io.WriteString(c, "GET / HTTP/1.1\r\nHost: foo\r\n\r\n"); err != nil { 3541 t.Fatal(err) 3542 } 3543 res, err := ReadResponse(bufio.NewReader(c), nil) 3544 if err != nil { 3545 t.Fatal(err) 3546 } 3547 if _, err := io.Copy(ioutil.Discard, res.Body); err != nil { 3548 t.Fatal(err) 3549 } 3550 c.Close() 3551 } 3552 3553 want := map[int][]ConnState{ 3554 1: {StateNew, StateActive, StateIdle, StateActive, StateClosed}, 3555 2: {StateNew, StateActive, StateIdle, StateActive, StateClosed}, 3556 3: {StateNew, StateActive, StateHijacked}, 3557 4: {StateNew, StateActive, StateHijacked}, 3558 5: {StateNew, StateClosed}, 3559 6: {StateNew, StateActive, StateClosed}, 3560 7: {StateNew, StateActive, StateIdle, StateClosed}, 3561 } 3562 logString := func(m map[int][]ConnState) string { 3563 var b bytes.Buffer 3564 var keys []int 3565 for id := range m { 3566 keys = append(keys, id) 3567 } 3568 sort.Ints(keys) 3569 for _, id := range keys { 3570 fmt.Fprintf(&b, "Conn %d: ", id) 3571 for _, s := range m[id] { 3572 fmt.Fprintf(&b, "%s ", s) 3573 } 3574 b.WriteString("\n") 3575 } 3576 return b.String() 3577 } 3578 3579 for i := 0; i < 5; i++ { 3580 time.Sleep(time.Duration(i) * 50 * time.Millisecond) 3581 mu.Lock() 3582 match := reflect.DeepEqual(stateLog, want) 3583 mu.Unlock() 3584 if match { 3585 return 3586 } 3587 } 3588 3589 mu.Lock() 3590 t.Errorf("Unexpected events.\nGot log: %s\n Want: %s\n", logString(stateLog), logString(want)) 3591 mu.Unlock() 3592 } 3593 3594 func mustGet(t *testing.T, url string, headers ...string) { 3595 req, err := NewRequest("GET", url, nil) 3596 if err != nil { 3597 t.Fatal(err) 3598 } 3599 for len(headers) > 0 { 3600 req.Header.Add(headers[0], headers[1]) 3601 headers = headers[2:] 3602 } 3603 res, err := DefaultClient.Do(req) 3604 if err != nil { 3605 t.Errorf("Error fetching %s: %v", url, err) 3606 return 3607 } 3608 _, err = ioutil.ReadAll(res.Body) 3609 defer res.Body.Close() 3610 if err != nil { 3611 t.Errorf("Error reading %s: %v", url, err) 3612 } 3613 } 3614 3615 func TestServerKeepAlivesEnabled(t *testing.T) { 3616 defer afterTest(t) 3617 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) {})) 3618 ts.Config.SetKeepAlivesEnabled(false) 3619 ts.Start() 3620 defer ts.Close() 3621 res, err := Get(ts.URL) 3622 if err != nil { 3623 t.Fatal(err) 3624 } 3625 defer res.Body.Close() 3626 if !res.Close { 3627 t.Errorf("Body.Close == false; want true") 3628 } 3629 } 3630 3631 // golang.org/issue/7856 3632 func TestServerEmptyBodyRace_h1(t *testing.T) { testServerEmptyBodyRace(t, h1Mode) } 3633 func TestServerEmptyBodyRace_h2(t *testing.T) { testServerEmptyBodyRace(t, h2Mode) } 3634 func testServerEmptyBodyRace(t *testing.T, h2 bool) { 3635 defer afterTest(t) 3636 var n int32 3637 cst := newClientServerTest(t, h2, HandlerFunc(func(rw ResponseWriter, req *Request) { 3638 atomic.AddInt32(&n, 1) 3639 })) 3640 defer cst.close() 3641 var wg sync.WaitGroup 3642 const reqs = 20 3643 for i := 0; i < reqs; i++ { 3644 wg.Add(1) 3645 go func() { 3646 defer wg.Done() 3647 res, err := cst.c.Get(cst.ts.URL) 3648 if err != nil { 3649 t.Error(err) 3650 return 3651 } 3652 defer res.Body.Close() 3653 _, err = io.Copy(ioutil.Discard, res.Body) 3654 if err != nil { 3655 t.Error(err) 3656 return 3657 } 3658 }() 3659 } 3660 wg.Wait() 3661 if got := atomic.LoadInt32(&n); got != reqs { 3662 t.Errorf("handler ran %d times; want %d", got, reqs) 3663 } 3664 } 3665 3666 func TestServerConnStateNew(t *testing.T) { 3667 sawNew := false // if the test is buggy, we'll race on this variable. 3668 srv := &Server{ 3669 ConnState: func(c net.Conn, state ConnState) { 3670 if state == StateNew { 3671 sawNew = true // testing that this write isn't racy 3672 } 3673 }, 3674 Handler: HandlerFunc(func(w ResponseWriter, r *Request) {}), // irrelevant 3675 } 3676 srv.Serve(&oneConnListener{ 3677 conn: &rwTestConn{ 3678 Reader: strings.NewReader("GET / HTTP/1.1\r\nHost: foo\r\n\r\n"), 3679 Writer: ioutil.Discard, 3680 }, 3681 }) 3682 if !sawNew { // testing that this read isn't racy 3683 t.Error("StateNew not seen") 3684 } 3685 } 3686 3687 type closeWriteTestConn struct { 3688 rwTestConn 3689 didCloseWrite bool 3690 } 3691 3692 func (c *closeWriteTestConn) CloseWrite() error { 3693 c.didCloseWrite = true 3694 return nil 3695 } 3696 3697 func TestCloseWrite(t *testing.T) { 3698 var srv Server 3699 var testConn closeWriteTestConn 3700 c := ExportServerNewConn(&srv, &testConn) 3701 ExportCloseWriteAndWait(c) 3702 if !testConn.didCloseWrite { 3703 t.Error("didn't see CloseWrite call") 3704 } 3705 } 3706 3707 // This verifies that a handler can Flush and then Hijack. 3708 // 3709 // An similar test crashed once during development, but it was only 3710 // testing this tangentially and temporarily until another TODO was 3711 // fixed. 3712 // 3713 // So add an explicit test for this. 3714 func TestServerFlushAndHijack(t *testing.T) { 3715 defer afterTest(t) 3716 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 3717 io.WriteString(w, "Hello, ") 3718 w.(Flusher).Flush() 3719 conn, buf, _ := w.(Hijacker).Hijack() 3720 buf.WriteString("6\r\nworld!\r\n0\r\n\r\n") 3721 if err := buf.Flush(); err != nil { 3722 t.Error(err) 3723 } 3724 if err := conn.Close(); err != nil { 3725 t.Error(err) 3726 } 3727 })) 3728 defer ts.Close() 3729 res, err := Get(ts.URL) 3730 if err != nil { 3731 t.Fatal(err) 3732 } 3733 defer res.Body.Close() 3734 all, err := ioutil.ReadAll(res.Body) 3735 if err != nil { 3736 t.Fatal(err) 3737 } 3738 if want := "Hello, world!"; string(all) != want { 3739 t.Errorf("Got %q; want %q", all, want) 3740 } 3741 } 3742 3743 // golang.org/issue/8534 -- the Server shouldn't reuse a connection 3744 // for keep-alive after it's seen any Write error (e.g. a timeout) on 3745 // that net.Conn. 3746 // 3747 // To test, verify we don't timeout or see fewer unique client 3748 // addresses (== unique connections) than requests. 3749 func TestServerKeepAliveAfterWriteError(t *testing.T) { 3750 if testing.Short() { 3751 t.Skip("skipping in -short mode") 3752 } 3753 defer afterTest(t) 3754 const numReq = 3 3755 addrc := make(chan string, numReq) 3756 ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) { 3757 addrc <- r.RemoteAddr 3758 time.Sleep(500 * time.Millisecond) 3759 w.(Flusher).Flush() 3760 })) 3761 ts.Config.WriteTimeout = 250 * time.Millisecond 3762 ts.Start() 3763 defer ts.Close() 3764 3765 errc := make(chan error, numReq) 3766 go func() { 3767 defer close(errc) 3768 for i := 0; i < numReq; i++ { 3769 res, err := Get(ts.URL) 3770 if res != nil { 3771 res.Body.Close() 3772 } 3773 errc <- err 3774 } 3775 }() 3776 3777 timeout := time.NewTimer(numReq * 2 * time.Second) // 4x overkill 3778 defer timeout.Stop() 3779 addrSeen := map[string]bool{} 3780 numOkay := 0 3781 for { 3782 select { 3783 case v := <-addrc: 3784 addrSeen[v] = true 3785 case err, ok := <-errc: 3786 if !ok { 3787 if len(addrSeen) != numReq { 3788 t.Errorf("saw %d unique client addresses; want %d", len(addrSeen), numReq) 3789 } 3790 if numOkay != 0 { 3791 t.Errorf("got %d successful client requests; want 0", numOkay) 3792 } 3793 return 3794 } 3795 if err == nil { 3796 numOkay++ 3797 } 3798 case <-timeout.C: 3799 t.Fatal("timeout waiting for requests to complete") 3800 } 3801 } 3802 } 3803 3804 // Issue 9987: shouldn't add automatic Content-Length (or 3805 // Content-Type) if a Transfer-Encoding was set by the handler. 3806 func TestNoContentLengthIfTransferEncoding(t *testing.T) { 3807 defer afterTest(t) 3808 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 3809 w.Header().Set("Transfer-Encoding", "foo") 3810 io.WriteString(w, "<html>") 3811 })) 3812 defer ts.Close() 3813 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 3814 if err != nil { 3815 t.Fatalf("Dial: %v", err) 3816 } 3817 defer c.Close() 3818 if _, err := io.WriteString(c, "GET / HTTP/1.1\r\nHost: foo\r\n\r\n"); err != nil { 3819 t.Fatal(err) 3820 } 3821 bs := bufio.NewScanner(c) 3822 var got bytes.Buffer 3823 for bs.Scan() { 3824 if strings.TrimSpace(bs.Text()) == "" { 3825 break 3826 } 3827 got.WriteString(bs.Text()) 3828 got.WriteByte('\n') 3829 } 3830 if err := bs.Err(); err != nil { 3831 t.Fatal(err) 3832 } 3833 if strings.Contains(got.String(), "Content-Length") { 3834 t.Errorf("Unexpected Content-Length in response headers: %s", got.String()) 3835 } 3836 if strings.Contains(got.String(), "Content-Type") { 3837 t.Errorf("Unexpected Content-Type in response headers: %s", got.String()) 3838 } 3839 } 3840 3841 // tolerate extra CRLF(s) before Request-Line on subsequent requests on a conn 3842 // Issue 10876. 3843 func TestTolerateCRLFBeforeRequestLine(t *testing.T) { 3844 req := []byte("POST / HTTP/1.1\r\nHost: golang.org\r\nContent-Length: 3\r\n\r\nABC" + 3845 "\r\n\r\n" + // <-- this stuff is bogus, but we'll ignore it 3846 "GET / HTTP/1.1\r\nHost: golang.org\r\n\r\n") 3847 var buf bytes.Buffer 3848 conn := &rwTestConn{ 3849 Reader: bytes.NewReader(req), 3850 Writer: &buf, 3851 closec: make(chan bool, 1), 3852 } 3853 ln := &oneConnListener{conn: conn} 3854 numReq := 0 3855 go Serve(ln, HandlerFunc(func(rw ResponseWriter, r *Request) { 3856 numReq++ 3857 })) 3858 <-conn.closec 3859 if numReq != 2 { 3860 t.Errorf("num requests = %d; want 2", numReq) 3861 t.Logf("Res: %s", buf.Bytes()) 3862 } 3863 } 3864 3865 func TestIssue13893_Expect100(t *testing.T) { 3866 // test that the Server doesn't filter out Expect headers. 3867 req := reqBytes(`PUT /readbody HTTP/1.1 3868 User-Agent: PycURL/7.22.0 3869 Host: 127.0.0.1:9000 3870 Accept: */* 3871 Expect: 100-continue 3872 Content-Length: 10 3873 3874 HelloWorld 3875 3876 `) 3877 var buf bytes.Buffer 3878 conn := &rwTestConn{ 3879 Reader: bytes.NewReader(req), 3880 Writer: &buf, 3881 closec: make(chan bool, 1), 3882 } 3883 ln := &oneConnListener{conn: conn} 3884 go Serve(ln, HandlerFunc(func(w ResponseWriter, r *Request) { 3885 if _, ok := r.Header["Expect"]; !ok { 3886 t.Error("Expect header should not be filtered out") 3887 } 3888 })) 3889 <-conn.closec 3890 } 3891 3892 func TestIssue11549_Expect100(t *testing.T) { 3893 req := reqBytes(`PUT /readbody HTTP/1.1 3894 User-Agent: PycURL/7.22.0 3895 Host: 127.0.0.1:9000 3896 Accept: */* 3897 Expect: 100-continue 3898 Content-Length: 10 3899 3900 HelloWorldPUT /noreadbody HTTP/1.1 3901 User-Agent: PycURL/7.22.0 3902 Host: 127.0.0.1:9000 3903 Accept: */* 3904 Expect: 100-continue 3905 Content-Length: 10 3906 3907 GET /should-be-ignored HTTP/1.1 3908 Host: foo 3909 3910 `) 3911 var buf bytes.Buffer 3912 conn := &rwTestConn{ 3913 Reader: bytes.NewReader(req), 3914 Writer: &buf, 3915 closec: make(chan bool, 1), 3916 } 3917 ln := &oneConnListener{conn: conn} 3918 numReq := 0 3919 go Serve(ln, HandlerFunc(func(w ResponseWriter, r *Request) { 3920 numReq++ 3921 if r.URL.Path == "/readbody" { 3922 ioutil.ReadAll(r.Body) 3923 } 3924 io.WriteString(w, "Hello world!") 3925 })) 3926 <-conn.closec 3927 if numReq != 2 { 3928 t.Errorf("num requests = %d; want 2", numReq) 3929 } 3930 if !strings.Contains(buf.String(), "Connection: close\r\n") { 3931 t.Errorf("expected 'Connection: close' in response; got: %s", buf.String()) 3932 } 3933 } 3934 3935 // If a Handler finishes and there's an unread request body, 3936 // verify the server try to do implicit read on it before replying. 3937 func TestHandlerFinishSkipBigContentLengthRead(t *testing.T) { 3938 conn := &testConn{closec: make(chan bool)} 3939 conn.readBuf.Write([]byte(fmt.Sprintf( 3940 "POST / HTTP/1.1\r\n" + 3941 "Host: test\r\n" + 3942 "Content-Length: 9999999999\r\n" + 3943 "\r\n" + strings.Repeat("a", 1<<20)))) 3944 3945 ls := &oneConnListener{conn} 3946 var inHandlerLen int 3947 go Serve(ls, HandlerFunc(func(rw ResponseWriter, req *Request) { 3948 inHandlerLen = conn.readBuf.Len() 3949 rw.WriteHeader(404) 3950 })) 3951 <-conn.closec 3952 afterHandlerLen := conn.readBuf.Len() 3953 3954 if afterHandlerLen != inHandlerLen { 3955 t.Errorf("unexpected implicit read. Read buffer went from %d -> %d", inHandlerLen, afterHandlerLen) 3956 } 3957 } 3958 3959 func TestHandlerSetsBodyNil_h1(t *testing.T) { testHandlerSetsBodyNil(t, h1Mode) } 3960 func TestHandlerSetsBodyNil_h2(t *testing.T) { testHandlerSetsBodyNil(t, h2Mode) } 3961 func testHandlerSetsBodyNil(t *testing.T, h2 bool) { 3962 defer afterTest(t) 3963 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 3964 r.Body = nil 3965 fmt.Fprintf(w, "%v", r.RemoteAddr) 3966 })) 3967 defer cst.close() 3968 get := func() string { 3969 res, err := cst.c.Get(cst.ts.URL) 3970 if err != nil { 3971 t.Fatal(err) 3972 } 3973 defer res.Body.Close() 3974 slurp, err := ioutil.ReadAll(res.Body) 3975 if err != nil { 3976 t.Fatal(err) 3977 } 3978 return string(slurp) 3979 } 3980 a, b := get(), get() 3981 if a != b { 3982 t.Errorf("Failed to reuse connections between requests: %v vs %v", a, b) 3983 } 3984 } 3985 3986 // Test that we validate the Host header. 3987 // Issue 11206 (invalid bytes in Host) and 13624 (Host present in HTTP/1.1) 3988 func TestServerValidatesHostHeader(t *testing.T) { 3989 tests := []struct { 3990 proto string 3991 host string 3992 want int 3993 }{ 3994 {"HTTP/0.9", "", 400}, 3995 3996 {"HTTP/1.1", "", 400}, 3997 {"HTTP/1.1", "Host: \r\n", 200}, 3998 {"HTTP/1.1", "Host: 1.2.3.4\r\n", 200}, 3999 {"HTTP/1.1", "Host: foo.com\r\n", 200}, 4000 {"HTTP/1.1", "Host: foo-bar_baz.com\r\n", 200}, 4001 {"HTTP/1.1", "Host: foo.com:80\r\n", 200}, 4002 {"HTTP/1.1", "Host: ::1\r\n", 200}, 4003 {"HTTP/1.1", "Host: [::1]\r\n", 200}, // questionable without port, but accept it 4004 {"HTTP/1.1", "Host: [::1]:80\r\n", 200}, 4005 {"HTTP/1.1", "Host: [::1%25en0]:80\r\n", 200}, 4006 {"HTTP/1.1", "Host: 1.2.3.4\r\n", 200}, 4007 {"HTTP/1.1", "Host: \x06\r\n", 400}, 4008 {"HTTP/1.1", "Host: \xff\r\n", 400}, 4009 {"HTTP/1.1", "Host: {\r\n", 400}, 4010 {"HTTP/1.1", "Host: }\r\n", 400}, 4011 {"HTTP/1.1", "Host: first\r\nHost: second\r\n", 400}, 4012 4013 // HTTP/1.0 can lack a host header, but if present 4014 // must play by the rules too: 4015 {"HTTP/1.0", "", 200}, 4016 {"HTTP/1.0", "Host: first\r\nHost: second\r\n", 400}, 4017 {"HTTP/1.0", "Host: \xff\r\n", 400}, 4018 4019 // Make an exception for HTTP upgrade requests: 4020 {"PRI * HTTP/2.0", "", 200}, 4021 4022 // But not other HTTP/2 stuff: 4023 {"PRI / HTTP/2.0", "", 400}, 4024 {"GET / HTTP/2.0", "", 400}, 4025 {"GET / HTTP/3.0", "", 400}, 4026 } 4027 for _, tt := range tests { 4028 conn := &testConn{closec: make(chan bool, 1)} 4029 methodTarget := "GET / " 4030 if !strings.HasPrefix(tt.proto, "HTTP/") { 4031 methodTarget = "" 4032 } 4033 io.WriteString(&conn.readBuf, methodTarget+tt.proto+"\r\n"+tt.host+"\r\n") 4034 4035 ln := &oneConnListener{conn} 4036 go Serve(ln, HandlerFunc(func(ResponseWriter, *Request) {})) 4037 <-conn.closec 4038 res, err := ReadResponse(bufio.NewReader(&conn.writeBuf), nil) 4039 if err != nil { 4040 t.Errorf("For %s %q, ReadResponse: %v", tt.proto, tt.host, res) 4041 continue 4042 } 4043 if res.StatusCode != tt.want { 4044 t.Errorf("For %s %q, Status = %d; want %d", tt.proto, tt.host, res.StatusCode, tt.want) 4045 } 4046 } 4047 } 4048 4049 func TestServerHandlersCanHandleH2PRI(t *testing.T) { 4050 const upgradeResponse = "upgrade here" 4051 defer afterTest(t) 4052 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 4053 conn, br, err := w.(Hijacker).Hijack() 4054 defer conn.Close() 4055 if r.Method != "PRI" || r.RequestURI != "*" { 4056 t.Errorf("Got method/target %q %q; want PRI *", r.Method, r.RequestURI) 4057 return 4058 } 4059 if !r.Close { 4060 t.Errorf("Request.Close = true; want false") 4061 } 4062 const want = "SM\r\n\r\n" 4063 buf := make([]byte, len(want)) 4064 n, err := io.ReadFull(br, buf) 4065 if err != nil || string(buf[:n]) != want { 4066 t.Errorf("Read = %v, %v (%q), want %q", n, err, buf[:n], want) 4067 return 4068 } 4069 io.WriteString(conn, upgradeResponse) 4070 })) 4071 defer ts.Close() 4072 4073 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 4074 if err != nil { 4075 t.Fatalf("Dial: %v", err) 4076 } 4077 defer c.Close() 4078 io.WriteString(c, "PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n") 4079 slurp, err := ioutil.ReadAll(c) 4080 if err != nil { 4081 t.Fatal(err) 4082 } 4083 if string(slurp) != upgradeResponse { 4084 t.Errorf("Handler response = %q; want %q", slurp, upgradeResponse) 4085 } 4086 } 4087 4088 // Test that we validate the valid bytes in HTTP/1 headers. 4089 // Issue 11207. 4090 func TestServerValidatesHeaders(t *testing.T) { 4091 tests := []struct { 4092 header string 4093 want int 4094 }{ 4095 {"", 200}, 4096 {"Foo: bar\r\n", 200}, 4097 {"X-Foo: bar\r\n", 200}, 4098 {"Foo: a space\r\n", 200}, 4099 4100 {"A space: foo\r\n", 400}, // space in header 4101 {"foo\xffbar: foo\r\n", 400}, // binary in header 4102 {"foo\x00bar: foo\r\n", 400}, // binary in header 4103 4104 {"foo: foo foo\r\n", 200}, // LWS space is okay 4105 {"foo: foo\tfoo\r\n", 200}, // LWS tab is okay 4106 {"foo: foo\x00foo\r\n", 400}, // CTL 0x00 in value is bad 4107 {"foo: foo\x7ffoo\r\n", 400}, // CTL 0x7f in value is bad 4108 {"foo: foo\xfffoo\r\n", 200}, // non-ASCII high octets in value are fine 4109 } 4110 for _, tt := range tests { 4111 conn := &testConn{closec: make(chan bool, 1)} 4112 io.WriteString(&conn.readBuf, "GET / HTTP/1.1\r\nHost: foo\r\n"+tt.header+"\r\n") 4113 4114 ln := &oneConnListener{conn} 4115 go Serve(ln, HandlerFunc(func(ResponseWriter, *Request) {})) 4116 <-conn.closec 4117 res, err := ReadResponse(bufio.NewReader(&conn.writeBuf), nil) 4118 if err != nil { 4119 t.Errorf("For %q, ReadResponse: %v", tt.header, res) 4120 continue 4121 } 4122 if res.StatusCode != tt.want { 4123 t.Errorf("For %q, Status = %d; want %d", tt.header, res.StatusCode, tt.want) 4124 } 4125 } 4126 } 4127 4128 func TestServerRequestContextCancel_ServeHTTPDone_h1(t *testing.T) { 4129 testServerRequestContextCancel_ServeHTTPDone(t, h1Mode) 4130 } 4131 func TestServerRequestContextCancel_ServeHTTPDone_h2(t *testing.T) { 4132 testServerRequestContextCancel_ServeHTTPDone(t, h2Mode) 4133 } 4134 func testServerRequestContextCancel_ServeHTTPDone(t *testing.T, h2 bool) { 4135 defer afterTest(t) 4136 ctxc := make(chan context.Context, 1) 4137 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 4138 ctx := r.Context() 4139 select { 4140 case <-ctx.Done(): 4141 t.Error("should not be Done in ServeHTTP") 4142 default: 4143 } 4144 ctxc <- ctx 4145 })) 4146 defer cst.close() 4147 res, err := cst.c.Get(cst.ts.URL) 4148 if err != nil { 4149 t.Fatal(err) 4150 } 4151 res.Body.Close() 4152 ctx := <-ctxc 4153 select { 4154 case <-ctx.Done(): 4155 default: 4156 t.Error("context should be done after ServeHTTP completes") 4157 } 4158 } 4159 4160 func TestServerRequestContextCancel_ConnClose(t *testing.T) { 4161 // Currently the context is not canceled when the connection 4162 // is closed because we're not reading from the connection 4163 // until after ServeHTTP for the previous handler is done. 4164 // Until the server code is modified to always be in a read 4165 // (Issue 15224), this test doesn't work yet. 4166 t.Skip("TODO(bradfitz): this test doesn't yet work; golang.org/issue/15224") 4167 defer afterTest(t) 4168 inHandler := make(chan struct{}) 4169 handlerDone := make(chan struct{}) 4170 ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { 4171 close(inHandler) 4172 select { 4173 case <-r.Context().Done(): 4174 case <-time.After(3 * time.Second): 4175 t.Errorf("timeout waiting for context to be done") 4176 } 4177 close(handlerDone) 4178 })) 4179 defer ts.Close() 4180 c, err := net.Dial("tcp", ts.Listener.Addr().String()) 4181 if err != nil { 4182 t.Fatal(err) 4183 } 4184 defer c.Close() 4185 io.WriteString(c, "GET / HTTP/1.1\r\nHost: foo\r\n\r\n") 4186 select { 4187 case <-inHandler: 4188 case <-time.After(3 * time.Second): 4189 t.Fatalf("timeout waiting to see ServeHTTP get called") 4190 } 4191 c.Close() // this should trigger the context being done 4192 4193 select { 4194 case <-handlerDone: 4195 case <-time.After(3 * time.Second): 4196 t.Fatalf("timeout waiting to see ServeHTTP exit") 4197 } 4198 } 4199 4200 func TestServerContext_ServerContextKey_h1(t *testing.T) { 4201 testServerContext_ServerContextKey(t, h1Mode) 4202 } 4203 func TestServerContext_ServerContextKey_h2(t *testing.T) { 4204 testServerContext_ServerContextKey(t, h2Mode) 4205 } 4206 func testServerContext_ServerContextKey(t *testing.T, h2 bool) { 4207 defer afterTest(t) 4208 cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { 4209 ctx := r.Context() 4210 got := ctx.Value(ServerContextKey) 4211 if _, ok := got.(*Server); !ok { 4212 t.Errorf("context value = %T; want *http.Server", got) 4213 } 4214 4215 got = ctx.Value(LocalAddrContextKey) 4216 if addr, ok := got.(net.Addr); !ok { 4217 t.Errorf("local addr value = %T; want net.Addr", got) 4218 } else if fmt.Sprint(addr) != r.Host { 4219 t.Errorf("local addr = %v; want %v", addr, r.Host) 4220 } 4221 })) 4222 defer cst.close() 4223 res, err := cst.c.Get(cst.ts.URL) 4224 if err != nil { 4225 t.Fatal(err) 4226 } 4227 res.Body.Close() 4228 } 4229 4230 // https://golang.org/issue/15960 4231 func TestHandlerSetTransferEncodingChunked(t *testing.T) { 4232 defer afterTest(t) 4233 ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { 4234 w.Header().Set("Transfer-Encoding", "chunked") 4235 w.Write([]byte("hello")) 4236 })) 4237 resp := ht.rawResponse("GET / HTTP/1.1\nHost: foo") 4238 const hdr = "Transfer-Encoding: chunked" 4239 if n := strings.Count(resp, hdr); n != 1 { 4240 t.Errorf("want 1 occurrence of %q in response, got %v\nresponse: %v", hdr, n, resp) 4241 } 4242 } 4243 4244 // https://golang.org/issue/16063 4245 func TestHandlerSetTransferEncodingGzip(t *testing.T) { 4246 defer afterTest(t) 4247 ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { 4248 w.Header().Set("Transfer-Encoding", "gzip") 4249 gz := gzip.NewWriter(w) 4250 gz.Write([]byte("hello")) 4251 gz.Close() 4252 })) 4253 resp := ht.rawResponse("GET / HTTP/1.1\nHost: foo") 4254 for _, v := range []string{"gzip", "chunked"} { 4255 hdr := "Transfer-Encoding: " + v 4256 if n := strings.Count(resp, hdr); n != 1 { 4257 t.Errorf("want 1 occurrence of %q in response, got %v\nresponse: %v", hdr, n, resp) 4258 } 4259 } 4260 } 4261 4262 func BenchmarkClientServer(b *testing.B) { 4263 b.ReportAllocs() 4264 b.StopTimer() 4265 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, r *Request) { 4266 fmt.Fprintf(rw, "Hello world.\n") 4267 })) 4268 defer ts.Close() 4269 b.StartTimer() 4270 4271 for i := 0; i < b.N; i++ { 4272 res, err := Get(ts.URL) 4273 if err != nil { 4274 b.Fatal("Get:", err) 4275 } 4276 all, err := ioutil.ReadAll(res.Body) 4277 res.Body.Close() 4278 if err != nil { 4279 b.Fatal("ReadAll:", err) 4280 } 4281 body := string(all) 4282 if body != "Hello world.\n" { 4283 b.Fatal("Got body:", body) 4284 } 4285 } 4286 4287 b.StopTimer() 4288 } 4289 4290 func BenchmarkClientServerParallel4(b *testing.B) { 4291 benchmarkClientServerParallel(b, 4, false) 4292 } 4293 4294 func BenchmarkClientServerParallel64(b *testing.B) { 4295 benchmarkClientServerParallel(b, 64, false) 4296 } 4297 4298 func BenchmarkClientServerParallelTLS4(b *testing.B) { 4299 benchmarkClientServerParallel(b, 4, true) 4300 } 4301 4302 func BenchmarkClientServerParallelTLS64(b *testing.B) { 4303 benchmarkClientServerParallel(b, 64, true) 4304 } 4305 4306 func benchmarkClientServerParallel(b *testing.B, parallelism int, useTLS bool) { 4307 b.ReportAllocs() 4308 ts := httptest.NewUnstartedServer(HandlerFunc(func(rw ResponseWriter, r *Request) { 4309 fmt.Fprintf(rw, "Hello world.\n") 4310 })) 4311 if useTLS { 4312 ts.StartTLS() 4313 } else { 4314 ts.Start() 4315 } 4316 defer ts.Close() 4317 b.ResetTimer() 4318 b.SetParallelism(parallelism) 4319 b.RunParallel(func(pb *testing.PB) { 4320 noVerifyTransport := &Transport{ 4321 TLSClientConfig: &tls.Config{ 4322 InsecureSkipVerify: true, 4323 }, 4324 } 4325 defer noVerifyTransport.CloseIdleConnections() 4326 client := &Client{Transport: noVerifyTransport} 4327 for pb.Next() { 4328 res, err := client.Get(ts.URL) 4329 if err != nil { 4330 b.Logf("Get: %v", err) 4331 continue 4332 } 4333 all, err := ioutil.ReadAll(res.Body) 4334 res.Body.Close() 4335 if err != nil { 4336 b.Logf("ReadAll: %v", err) 4337 continue 4338 } 4339 body := string(all) 4340 if body != "Hello world.\n" { 4341 panic("Got body: " + body) 4342 } 4343 } 4344 }) 4345 } 4346 4347 // A benchmark for profiling the server without the HTTP client code. 4348 // The client code runs in a subprocess. 4349 // 4350 // For use like: 4351 // $ go test -c 4352 // $ ./http.test -test.run=XX -test.bench=BenchmarkServer -test.benchtime=15s -test.cpuprofile=http.prof 4353 // $ go tool pprof http.test http.prof 4354 // (pprof) web 4355 func BenchmarkServer(b *testing.B) { 4356 b.ReportAllocs() 4357 // Child process mode; 4358 if url := os.Getenv("TEST_BENCH_SERVER_URL"); url != "" { 4359 n, err := strconv.Atoi(os.Getenv("TEST_BENCH_CLIENT_N")) 4360 if err != nil { 4361 panic(err) 4362 } 4363 for i := 0; i < n; i++ { 4364 res, err := Get(url) 4365 if err != nil { 4366 log.Panicf("Get: %v", err) 4367 } 4368 all, err := ioutil.ReadAll(res.Body) 4369 res.Body.Close() 4370 if err != nil { 4371 log.Panicf("ReadAll: %v", err) 4372 } 4373 body := string(all) 4374 if body != "Hello world.\n" { 4375 log.Panicf("Got body: %q", body) 4376 } 4377 } 4378 os.Exit(0) 4379 return 4380 } 4381 4382 var res = []byte("Hello world.\n") 4383 b.StopTimer() 4384 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, r *Request) { 4385 rw.Header().Set("Content-Type", "text/html; charset=utf-8") 4386 rw.Write(res) 4387 })) 4388 defer ts.Close() 4389 b.StartTimer() 4390 4391 cmd := exec.Command(os.Args[0], "-test.run=XXXX", "-test.bench=BenchmarkServer$") 4392 cmd.Env = append([]string{ 4393 fmt.Sprintf("TEST_BENCH_CLIENT_N=%d", b.N), 4394 fmt.Sprintf("TEST_BENCH_SERVER_URL=%s", ts.URL), 4395 }, os.Environ()...) 4396 out, err := cmd.CombinedOutput() 4397 if err != nil { 4398 b.Errorf("Test failure: %v, with output: %s", err, out) 4399 } 4400 } 4401 4402 // getNoBody wraps Get but closes any Response.Body before returning the response. 4403 func getNoBody(urlStr string) (*Response, error) { 4404 res, err := Get(urlStr) 4405 if err != nil { 4406 return nil, err 4407 } 4408 res.Body.Close() 4409 return res, nil 4410 } 4411 4412 // A benchmark for profiling the client without the HTTP server code. 4413 // The server code runs in a subprocess. 4414 func BenchmarkClient(b *testing.B) { 4415 b.ReportAllocs() 4416 b.StopTimer() 4417 defer afterTest(b) 4418 4419 var data = []byte("Hello world.\n") 4420 if server := os.Getenv("TEST_BENCH_SERVER"); server != "" { 4421 // Server process mode. 4422 port := os.Getenv("TEST_BENCH_SERVER_PORT") // can be set by user 4423 if port == "" { 4424 port = "0" 4425 } 4426 ln, err := net.Listen("tcp", "localhost:"+port) 4427 if err != nil { 4428 fmt.Fprintln(os.Stderr, err.Error()) 4429 os.Exit(1) 4430 } 4431 fmt.Println(ln.Addr().String()) 4432 HandleFunc("/", func(w ResponseWriter, r *Request) { 4433 r.ParseForm() 4434 if r.Form.Get("stop") != "" { 4435 os.Exit(0) 4436 } 4437 w.Header().Set("Content-Type", "text/html; charset=utf-8") 4438 w.Write(data) 4439 }) 4440 var srv Server 4441 log.Fatal(srv.Serve(ln)) 4442 } 4443 4444 // Start server process. 4445 cmd := exec.Command(os.Args[0], "-test.run=XXXX", "-test.bench=BenchmarkClient$") 4446 cmd.Env = append(os.Environ(), "TEST_BENCH_SERVER=yes") 4447 cmd.Stderr = os.Stderr 4448 stdout, err := cmd.StdoutPipe() 4449 if err != nil { 4450 b.Fatal(err) 4451 } 4452 if err := cmd.Start(); err != nil { 4453 b.Fatalf("subprocess failed to start: %v", err) 4454 } 4455 defer cmd.Process.Kill() 4456 4457 // Wait for the server in the child process to respond and tell us 4458 // its listening address, once it's started listening: 4459 timer := time.AfterFunc(10*time.Second, func() { 4460 cmd.Process.Kill() 4461 }) 4462 defer timer.Stop() 4463 bs := bufio.NewScanner(stdout) 4464 if !bs.Scan() { 4465 b.Fatalf("failed to read listening URL from child: %v", bs.Err()) 4466 } 4467 url := "http://" + strings.TrimSpace(bs.Text()) + "/" 4468 timer.Stop() 4469 if _, err := getNoBody(url); err != nil { 4470 b.Fatalf("initial probe of child process failed: %v", err) 4471 } 4472 4473 done := make(chan error) 4474 go func() { 4475 done <- cmd.Wait() 4476 }() 4477 4478 // Do b.N requests to the server. 4479 b.StartTimer() 4480 for i := 0; i < b.N; i++ { 4481 res, err := Get(url) 4482 if err != nil { 4483 b.Fatalf("Get: %v", err) 4484 } 4485 body, err := ioutil.ReadAll(res.Body) 4486 res.Body.Close() 4487 if err != nil { 4488 b.Fatalf("ReadAll: %v", err) 4489 } 4490 if !bytes.Equal(body, data) { 4491 b.Fatalf("Got body: %q", body) 4492 } 4493 } 4494 b.StopTimer() 4495 4496 // Instruct server process to stop. 4497 getNoBody(url + "?stop=yes") 4498 select { 4499 case err := <-done: 4500 if err != nil { 4501 b.Fatalf("subprocess failed: %v", err) 4502 } 4503 case <-time.After(5 * time.Second): 4504 b.Fatalf("subprocess did not stop") 4505 } 4506 } 4507 4508 func BenchmarkServerFakeConnNoKeepAlive(b *testing.B) { 4509 b.ReportAllocs() 4510 req := reqBytes(`GET / HTTP/1.0 4511 Host: golang.org 4512 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 4513 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.52 Safari/537.17 4514 Accept-Encoding: gzip,deflate,sdch 4515 Accept-Language: en-US,en;q=0.8 4516 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 4517 `) 4518 res := []byte("Hello world!\n") 4519 4520 conn := &testConn{ 4521 // testConn.Close will not push into the channel 4522 // if it's full. 4523 closec: make(chan bool, 1), 4524 } 4525 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 4526 rw.Header().Set("Content-Type", "text/html; charset=utf-8") 4527 rw.Write(res) 4528 }) 4529 ln := new(oneConnListener) 4530 for i := 0; i < b.N; i++ { 4531 conn.readBuf.Reset() 4532 conn.writeBuf.Reset() 4533 conn.readBuf.Write(req) 4534 ln.conn = conn 4535 Serve(ln, handler) 4536 <-conn.closec 4537 } 4538 } 4539 4540 // repeatReader reads content count times, then EOFs. 4541 type repeatReader struct { 4542 content []byte 4543 count int 4544 off int 4545 } 4546 4547 func (r *repeatReader) Read(p []byte) (n int, err error) { 4548 if r.count <= 0 { 4549 return 0, io.EOF 4550 } 4551 n = copy(p, r.content[r.off:]) 4552 r.off += n 4553 if r.off == len(r.content) { 4554 r.count-- 4555 r.off = 0 4556 } 4557 return 4558 } 4559 4560 func BenchmarkServerFakeConnWithKeepAlive(b *testing.B) { 4561 b.ReportAllocs() 4562 4563 req := reqBytes(`GET / HTTP/1.1 4564 Host: golang.org 4565 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 4566 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.52 Safari/537.17 4567 Accept-Encoding: gzip,deflate,sdch 4568 Accept-Language: en-US,en;q=0.8 4569 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 4570 `) 4571 res := []byte("Hello world!\n") 4572 4573 conn := &rwTestConn{ 4574 Reader: &repeatReader{content: req, count: b.N}, 4575 Writer: ioutil.Discard, 4576 closec: make(chan bool, 1), 4577 } 4578 handled := 0 4579 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 4580 handled++ 4581 rw.Header().Set("Content-Type", "text/html; charset=utf-8") 4582 rw.Write(res) 4583 }) 4584 ln := &oneConnListener{conn: conn} 4585 go Serve(ln, handler) 4586 <-conn.closec 4587 if b.N != handled { 4588 b.Errorf("b.N=%d but handled %d", b.N, handled) 4589 } 4590 } 4591 4592 // same as above, but representing the most simple possible request 4593 // and handler. Notably: the handler does not call rw.Header(). 4594 func BenchmarkServerFakeConnWithKeepAliveLite(b *testing.B) { 4595 b.ReportAllocs() 4596 4597 req := reqBytes(`GET / HTTP/1.1 4598 Host: golang.org 4599 `) 4600 res := []byte("Hello world!\n") 4601 4602 conn := &rwTestConn{ 4603 Reader: &repeatReader{content: req, count: b.N}, 4604 Writer: ioutil.Discard, 4605 closec: make(chan bool, 1), 4606 } 4607 handled := 0 4608 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 4609 handled++ 4610 rw.Write(res) 4611 }) 4612 ln := &oneConnListener{conn: conn} 4613 go Serve(ln, handler) 4614 <-conn.closec 4615 if b.N != handled { 4616 b.Errorf("b.N=%d but handled %d", b.N, handled) 4617 } 4618 } 4619 4620 const someResponse = "<html>some response</html>" 4621 4622 // A Response that's just no bigger than 2KB, the buffer-before-chunking threshold. 4623 var response = bytes.Repeat([]byte(someResponse), 2<<10/len(someResponse)) 4624 4625 // Both Content-Type and Content-Length set. Should be no buffering. 4626 func BenchmarkServerHandlerTypeLen(b *testing.B) { 4627 benchmarkHandler(b, HandlerFunc(func(w ResponseWriter, r *Request) { 4628 w.Header().Set("Content-Type", "text/html") 4629 w.Header().Set("Content-Length", strconv.Itoa(len(response))) 4630 w.Write(response) 4631 })) 4632 } 4633 4634 // A Content-Type is set, but no length. No sniffing, but will count the Content-Length. 4635 func BenchmarkServerHandlerNoLen(b *testing.B) { 4636 benchmarkHandler(b, HandlerFunc(func(w ResponseWriter, r *Request) { 4637 w.Header().Set("Content-Type", "text/html") 4638 w.Write(response) 4639 })) 4640 } 4641 4642 // A Content-Length is set, but the Content-Type will be sniffed. 4643 func BenchmarkServerHandlerNoType(b *testing.B) { 4644 benchmarkHandler(b, HandlerFunc(func(w ResponseWriter, r *Request) { 4645 w.Header().Set("Content-Length", strconv.Itoa(len(response))) 4646 w.Write(response) 4647 })) 4648 } 4649 4650 // Neither a Content-Type or Content-Length, so sniffed and counted. 4651 func BenchmarkServerHandlerNoHeader(b *testing.B) { 4652 benchmarkHandler(b, HandlerFunc(func(w ResponseWriter, r *Request) { 4653 w.Write(response) 4654 })) 4655 } 4656 4657 func benchmarkHandler(b *testing.B, h Handler) { 4658 b.ReportAllocs() 4659 req := reqBytes(`GET / HTTP/1.1 4660 Host: golang.org 4661 `) 4662 conn := &rwTestConn{ 4663 Reader: &repeatReader{content: req, count: b.N}, 4664 Writer: ioutil.Discard, 4665 closec: make(chan bool, 1), 4666 } 4667 handled := 0 4668 handler := HandlerFunc(func(rw ResponseWriter, r *Request) { 4669 handled++ 4670 h.ServeHTTP(rw, r) 4671 }) 4672 ln := &oneConnListener{conn: conn} 4673 go Serve(ln, handler) 4674 <-conn.closec 4675 if b.N != handled { 4676 b.Errorf("b.N=%d but handled %d", b.N, handled) 4677 } 4678 } 4679 4680 func BenchmarkServerHijack(b *testing.B) { 4681 b.ReportAllocs() 4682 req := reqBytes(`GET / HTTP/1.1 4683 Host: golang.org 4684 `) 4685 h := HandlerFunc(func(w ResponseWriter, r *Request) { 4686 conn, _, err := w.(Hijacker).Hijack() 4687 if err != nil { 4688 panic(err) 4689 } 4690 conn.Close() 4691 }) 4692 conn := &rwTestConn{ 4693 Writer: ioutil.Discard, 4694 closec: make(chan bool, 1), 4695 } 4696 ln := &oneConnListener{conn: conn} 4697 for i := 0; i < b.N; i++ { 4698 conn.Reader = bytes.NewReader(req) 4699 ln.conn = conn 4700 Serve(ln, h) 4701 <-conn.closec 4702 } 4703 } 4704 4705 func BenchmarkCloseNotifier(b *testing.B) { 4706 b.ReportAllocs() 4707 b.StopTimer() 4708 sawClose := make(chan bool) 4709 ts := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) { 4710 <-rw.(CloseNotifier).CloseNotify() 4711 sawClose <- true 4712 })) 4713 defer ts.Close() 4714 tot := time.NewTimer(5 * time.Second) 4715 defer tot.Stop() 4716 b.StartTimer() 4717 for i := 0; i < b.N; i++ { 4718 conn, err := net.Dial("tcp", ts.Listener.Addr().String()) 4719 if err != nil { 4720 b.Fatalf("error dialing: %v", err) 4721 } 4722 _, err = fmt.Fprintf(conn, "GET / HTTP/1.1\r\nConnection: keep-alive\r\nHost: foo\r\n\r\n") 4723 if err != nil { 4724 b.Fatal(err) 4725 } 4726 conn.Close() 4727 tot.Reset(5 * time.Second) 4728 select { 4729 case <-sawClose: 4730 case <-tot.C: 4731 b.Fatal("timeout") 4732 } 4733 } 4734 b.StopTimer() 4735 } 4736 4737 // Verify this doesn't race (Issue 16505) 4738 func TestConcurrentServerServe(t *testing.T) { 4739 for i := 0; i < 100; i++ { 4740 ln1 := &oneConnListener{conn: nil} 4741 ln2 := &oneConnListener{conn: nil} 4742 srv := Server{} 4743 go func() { srv.Serve(ln1) }() 4744 go func() { srv.Serve(ln2) }() 4745 } 4746 }