github.com/sdbaiguanghe/helm@v2.16.7+incompatible/cmd/helm/installer/install_test.go

/*
Copyright The Helm Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package installer // import "k8s.io/helm/cmd/helm/installer"

import (
	"os"
	"path/filepath"
	"reflect"
	"testing"

	"github.com/ghodss/yaml"
	appsv1 "k8s.io/api/apps/v1"
	"k8s.io/api/core/v1"
	apierrors "k8s.io/apimachinery/pkg/api/errors"
	"k8s.io/apimachinery/pkg/runtime"
	"k8s.io/client-go/kubernetes/fake"
	testcore "k8s.io/client-go/testing"

	"k8s.io/helm/pkg/chartutil"
	"k8s.io/helm/pkg/version"
)

func TestDeployment(t *testing.T) {
	tests := []struct {
		name            string
		image           string
		canary          bool
		expect          string
		imagePullPolicy v1.PullPolicy
	}{
		{"default", "", false, "gcr.io/kubernetes-helm/tiller:" + version.Version, "IfNotPresent"},
		{"canary", "example.com/tiller", true, "gcr.io/kubernetes-helm/tiller:canary", "Always"},
		{"custom", "example.com/tiller:latest", false, "example.com/tiller:latest", "IfNotPresent"},
	}

	for _, tt := range tests {
		dep, err := Deployment(&Options{Namespace: v1.NamespaceDefault, ImageSpec: tt.image, UseCanary: tt.canary})
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}

		// Unreleased versions of helm don't have a release image. See issue 3370
		if tt.name == "default" && version.BuildMetadata == "unreleased" {
			tt.expect = "gcr.io/kubernetes-helm/tiller:canary"
		}
		if got := dep.Spec.Template.Spec.Containers[0].Image; got != tt.expect {
			t.Errorf("%s: expected image %q, got %q", tt.name, tt.expect, got)
		}

		if got := dep.Spec.Template.Spec.Containers[0].ImagePullPolicy; got != tt.imagePullPolicy {
			t.Errorf("%s: expected imagePullPolicy %q, got %q", tt.name, tt.imagePullPolicy, got)
		}

		if got := dep.Spec.Template.Spec.Containers[0].Env[0].Value; got != v1.NamespaceDefault {
			t.Errorf("%s: expected namespace %q, got %q", tt.name, v1.NamespaceDefault, got)
		}
	}
}

func TestDeploymentForServiceAccount(t *testing.T) {
	tests := []struct {
		name            string
		image           string
		canary          bool
		expect          string
		imagePullPolicy v1.PullPolicy
		serviceAccount  string
	}{
		{"withSA", "", false, "gcr.io/kubernetes-helm/tiller:latest", "IfNotPresent", "service-account"},
		{"withoutSA", "", false, "gcr.io/kubernetes-helm/tiller:latest", "IfNotPresent", ""},
	}
	for _, tt := range tests {
		opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: tt.image, UseCanary: tt.canary, ServiceAccount: tt.serviceAccount}
		d, err := Deployment(opts)
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}

		if got := d.Spec.Template.Spec.ServiceAccountName; got != tt.serviceAccount {
			t.Errorf("%s: expected service account value %q, got %q", tt.name, tt.serviceAccount, got)
		}
		if got := *d.Spec.Template.Spec.AutomountServiceAccountToken; got != false {
			t.Errorf("%s: expected AutomountServiceAccountToken = %t, got %t", tt.name, false, got)
		}

		opts.AutoMountServiceAccountToken = true
		d, err = Deployment(opts)
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}
		if got := *d.Spec.Template.Spec.AutomountServiceAccountToken; got != true {
			t.Errorf("%s: expected AutomountServiceAccountToken = %t, got %t", tt.name, true, got)
		}
	}
}

func TestDeployment_WithTLS(t *testing.T) {
	tests := []struct {
		opts   Options
		name   string
		enable string
		verify string
	}{
		{
			Options{Namespace: v1.NamespaceDefault, EnableTLS: true, VerifyTLS: true},
			"tls enable (true), tls verify (true)",
			"1",
			"1",
		},
		{
			Options{Namespace: v1.NamespaceDefault, EnableTLS: true, VerifyTLS: false},
			"tls enable (true), tls verify (false)",
			"1",
			"",
		},
		{
			Options{Namespace: v1.NamespaceDefault, EnableTLS: false, VerifyTLS: true},
			"tls enable (false), tls verify (true)",
			"1",
			"1",
		},
	}
	for _, tt := range tests {
		d, err := Deployment(&tt.opts)
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}

		// verify environment variable in deployment reflect the use of tls being enabled.
		if got := d.Spec.Template.Spec.Containers[0].Env[2].Value; got != tt.verify {
			t.Errorf("%s: expected tls verify env value %q, got %q", tt.name, tt.verify, got)
		}
		if got := d.Spec.Template.Spec.Containers[0].Env[3].Value; got != tt.enable {
			t.Errorf("%s: expected tls enable env value %q, got %q", tt.name, tt.enable, got)
		}
	}
}

func TestServiceManifest(t *testing.T) {
	svc := Service(v1.NamespaceDefault)

	if got := svc.ObjectMeta.Namespace; got != v1.NamespaceDefault {
		t.Errorf("expected namespace %s, got %s", v1.NamespaceDefault, got)
	}
}

func TestSecretManifest(t *testing.T) {
	obj, err := Secret(&Options{
		VerifyTLS:     true,
		EnableTLS:     true,
		Namespace:     v1.NamespaceDefault,
		TLSKeyFile:    tlsTestFile(t, "key.pem"),
		TLSCertFile:   tlsTestFile(t, "crt.pem"),
		TLSCaCertFile: tlsTestFile(t, "ca.pem"),
	})

	if err != nil {
		t.Fatalf("error %q", err)
	}

	if got := obj.ObjectMeta.Namespace; got != v1.NamespaceDefault {
		t.Errorf("expected namespace %s, got %s", v1.NamespaceDefault, got)
	}
	if _, ok := obj.Data["tls.key"]; !ok {
		t.Errorf("missing 'tls.key' in generated secret object")
	}
	if _, ok := obj.Data["tls.crt"]; !ok {
		t.Errorf("missing 'tls.crt' in generated secret object")
	}
	if _, ok := obj.Data["ca.crt"]; !ok {
		t.Errorf("missing 'ca.crt' in generated secret object")
	}
}

func TestInstall(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"

	fc := &fake.Clientset{}
	fc.AddReactor("create", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*appsv1.Deployment)
		l := obj.GetLabels()
		if reflect.DeepEqual(l, map[string]string{"app": "helm"}) {
			t.Errorf("expected labels = '', got '%s'", l)
		}
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		ports := len(obj.Spec.Template.Spec.Containers[0].Ports)
		if ports != 2 {
			t.Errorf("expected ports = 2, got '%d'", ports)
		}
		replicas := obj.Spec.Replicas
		if int(*replicas) != 1 {
			t.Errorf("expected replicas = 1, got '%d'", replicas)
		}
		return true, obj, nil
	})
	fc.AddReactor("create", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*v1.Service)
		l := obj.GetLabels()
		if reflect.DeepEqual(l, map[string]string{"app": "helm"}) {
			t.Errorf("expected labels = '', got '%s'", l)
		}
		n := obj.ObjectMeta.Namespace
		if n != v1.NamespaceDefault {
			t.Errorf("expected namespace = '%s', got '%s'", v1.NamespaceDefault, n)
		}
		return true, obj, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image}
	if err := Install(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 2 {
		t.Errorf("unexpected actions: %v, expected 2 actions got %d", actions, len(actions))
	}
}

func TestInstallHA(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"

	fc := &fake.Clientset{}
	fc.AddReactor("create", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*appsv1.Deployment)
		replicas := obj.Spec.Replicas
		if int(*replicas) != 2 {
			t.Errorf("expected replicas = 2, got '%d'", replicas)
		}
		return true, obj, nil
	})

	opts := &Options{
		Namespace: v1.NamespaceDefault,
		ImageSpec: image,
		Replicas:  2,
	}
	if err := Install(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}
}

func TestInstall_WithTLS(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"
	name := "tiller-secret"

	fc := &fake.Clientset{}
	fc.AddReactor("create", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*appsv1.Deployment)
		l := obj.GetLabels()
		if reflect.DeepEqual(l, map[string]string{"app": "helm"}) {
			t.Errorf("expected labels = '', got '%s'", l)
		}
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		return true, obj, nil
	})
	fc.AddReactor("create", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*v1.Service)
		l := obj.GetLabels()
		if reflect.DeepEqual(l, map[string]string{"app": "helm"}) {
			t.Errorf("expected labels = '', got '%s'", l)
		}
		n := obj.ObjectMeta.Namespace
		if n != v1.NamespaceDefault {
			t.Errorf("expected namespace = '%s', got '%s'", v1.NamespaceDefault, n)
		}
		return true, obj, nil
	})
	fc.AddReactor("create", "secrets", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*v1.Secret)
		if l := obj.GetLabels(); reflect.DeepEqual(l, map[string]string{"app": "helm"}) {
			t.Errorf("expected labels = '', got '%s'", l)
		}
		if n := obj.ObjectMeta.Namespace; n != v1.NamespaceDefault {
			t.Errorf("expected namespace = '%s', got '%s'", v1.NamespaceDefault, n)
		}
		if s := obj.ObjectMeta.Name; s != name {
			t.Errorf("expected name = '%s', got '%s'", name, s)
		}
		if _, ok := obj.Data["tls.key"]; !ok {
			t.Errorf("missing 'tls.key' in generated secret object")
		}
		if _, ok := obj.Data["tls.crt"]; !ok {
			t.Errorf("missing 'tls.crt' in generated secret object")
		}
		if _, ok := obj.Data["ca.crt"]; !ok {
			t.Errorf("missing 'ca.crt' in generated secret object")
		}
		return true, obj, nil
	})

	opts := &Options{
		Namespace:     v1.NamespaceDefault,
		ImageSpec:     image,
		EnableTLS:     true,
		VerifyTLS:     true,
		TLSKeyFile:    tlsTestFile(t, "key.pem"),
		TLSCertFile:   tlsTestFile(t, "crt.pem"),
		TLSCaCertFile: tlsTestFile(t, "ca.pem"),
	}

	if err := Install(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 3 {
		t.Errorf("unexpected actions: %v, expected 3 actions got %d", actions, len(actions))
	}
}

func TestInstall_canary(t *testing.T) {
	fc := &fake.Clientset{}
	fc.AddReactor("create", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != "gcr.io/kubernetes-helm/tiller:canary" {
			t.Errorf("expected canary image, got '%s'", i)
		}
		return true, obj, nil
	})
	fc.AddReactor("create", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*v1.Service)
		return true, obj, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, UseCanary: true}
	if err := Install(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 2 {
		t.Errorf("unexpected actions: %v, expected 2 actions got %d", actions, len(actions))
	}
}

func TestUpgrade(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"
	serviceAccount := "newServiceAccount"
	existingDeployment, _ := generateDeployment(&Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      "imageToReplace:v1.0.0",
		ServiceAccount: "serviceAccountToReplace",
		UseCanary:      false,
	})
	existingService := generateService(v1.NamespaceDefault)

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		sa := obj.Spec.Template.Spec.ServiceAccountName
		if sa != serviceAccount {
			t.Errorf("expected serviceAccountName = '%s', got '%s'", serviceAccount, sa)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingService, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image, ServiceAccount: serviceAccount}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 3 {
		t.Errorf("unexpected actions: %v, expected 3 actions got %d", actions, len(actions))
	}
}

func TestUpgrade_serviceNotFound(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"

	existingDeployment, _ := generateDeployment(&Options{
		Namespace: v1.NamespaceDefault,
		ImageSpec: "imageToReplace",
		UseCanary: false,
	})

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, nil, apierrors.NewNotFound(v1.Resource("services"), "1")
	})
	fc.AddReactor("create", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.CreateAction).GetObject().(*v1.Service)
		n := obj.ObjectMeta.Namespace
		if n != v1.NamespaceDefault {
			t.Errorf("expected namespace = '%s', got '%s'", v1.NamespaceDefault, n)
		}
		return true, obj, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 4 {
		t.Errorf("unexpected actions: %v, expected 4 actions got %d", actions, len(actions))
	}
}

func TestUgrade_newerVersion(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"
	serviceAccount := "newServiceAccount"
	existingDeployment, _ := generateDeployment(&Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      "imageToReplace:v100.5.0",
		ServiceAccount: "serviceAccountToReplace",
		UseCanary:      false,
	})
	existingService := generateService(v1.NamespaceDefault)

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		sa := obj.Spec.Template.Spec.ServiceAccountName
		if sa != serviceAccount {
			t.Errorf("expected serviceAccountName = '%s', got '%s'", serviceAccount, sa)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingService, nil
	})

	opts := &Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      image,
		ServiceAccount: serviceAccount,
		ForceUpgrade:   false,
	}
	if err := Upgrade(fc, opts); err == nil {
		t.Errorf("Expected error because the deployed version is newer")
	}

	if actions := fc.Actions(); len(actions) != 1 {
		t.Errorf("unexpected actions: %v, expected 1 action got %d", actions, len(actions))
	}

	opts = &Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      image,
		ServiceAccount: serviceAccount,
		ForceUpgrade:   true,
	}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 4 {
		t.Errorf("unexpected actions: %v, expected 4 action got %d", actions, len(actions))
	}
}

func TestUpgrade_identical(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"
	serviceAccount := "newServiceAccount"
	existingDeployment, _ := generateDeployment(&Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      "imageToReplace:v2.0.0",
		ServiceAccount: "serviceAccountToReplace",
		UseCanary:      false,
	})
	existingService := generateService(v1.NamespaceDefault)

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		sa := obj.Spec.Template.Spec.ServiceAccountName
		if sa != serviceAccount {
			t.Errorf("expected serviceAccountName = '%s', got '%s'", serviceAccount, sa)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingService, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image, ServiceAccount: serviceAccount}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 3 {
		t.Errorf("unexpected actions: %v, expected 3 actions got %d", actions, len(actions))
	}
}

func TestUpgrade_canaryClient(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:canary"
	serviceAccount := "newServiceAccount"
	existingDeployment, _ := generateDeployment(&Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      "imageToReplace:v1.0.0",
		ServiceAccount: "serviceAccountToReplace",
		UseCanary:      false,
	})
	existingService := generateService(v1.NamespaceDefault)

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		sa := obj.Spec.Template.Spec.ServiceAccountName
		if sa != serviceAccount {
			t.Errorf("expected serviceAccountName = '%s', got '%s'", serviceAccount, sa)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingService, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image, ServiceAccount: serviceAccount}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 3 {
		t.Errorf("unexpected actions: %v, expected 3 actions got %d", actions, len(actions))
	}
}

func TestUpgrade_canaryServer(t *testing.T) {
	image := "gcr.io/kubernetes-helm/tiller:v2.0.0"
	serviceAccount := "newServiceAccount"
	existingDeployment, _ := generateDeployment(&Options{
		Namespace:      v1.NamespaceDefault,
		ImageSpec:      "imageToReplace:canary",
		ServiceAccount: "serviceAccountToReplace",
		UseCanary:      false,
	})
	existingService := generateService(v1.NamespaceDefault)

	fc := &fake.Clientset{}
	fc.AddReactor("get", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingDeployment, nil
	})
	fc.AddReactor("update", "deployments", func(action testcore.Action) (bool, runtime.Object, error) {
		obj := action.(testcore.UpdateAction).GetObject().(*appsv1.Deployment)
		i := obj.Spec.Template.Spec.Containers[0].Image
		if i != image {
			t.Errorf("expected image = '%s', got '%s'", image, i)
		}
		sa := obj.Spec.Template.Spec.ServiceAccountName
		if sa != serviceAccount {
			t.Errorf("expected serviceAccountName = '%s', got '%s'", serviceAccount, sa)
		}
		return true, obj, nil
	})
	fc.AddReactor("get", "services", func(action testcore.Action) (bool, runtime.Object, error) {
		return true, existingService, nil
	})

	opts := &Options{Namespace: v1.NamespaceDefault, ImageSpec: image, ServiceAccount: serviceAccount}
	if err := Upgrade(fc, opts); err != nil {
		t.Errorf("unexpected error: %#+v", err)
	}

	if actions := fc.Actions(); len(actions) != 3 {
		t.Errorf("unexpected actions: %v, expected 3 actions got %d", actions, len(actions))
	}
}

func tlsTestFile(t *testing.T, path string) string {
	const tlsTestDir = "../../../testdata"
	path = filepath.Join(tlsTestDir, path)
	if _, err := os.Stat(path); os.IsNotExist(err) {
		t.Fatalf("tls test file %s does not exist", path)
	}
	return path
}

func TestDeployment_WithNodeSelectors(t *testing.T) {
	tests := []struct {
		opts   Options
		name   string
		expect map[string]interface{}
	}{
		{
			Options{Namespace: v1.NamespaceDefault, NodeSelectors: "app=tiller"},
			"nodeSelector app=tiller",
			map[string]interface{}{"app": "tiller"},
		},
		{
			Options{Namespace: v1.NamespaceDefault, NodeSelectors: "app=tiller,helm=rocks"},
			"nodeSelector app=tiller, helm=rocks",
			map[string]interface{}{"app": "tiller", "helm": "rocks"},
		},
		// note: nodeSelector key and value are strings
		{
			Options{Namespace: v1.NamespaceDefault, NodeSelectors: "app=tiller,minCoolness=1"},
			"nodeSelector app=tiller, helm=rocks",
			map[string]interface{}{"app": "tiller", "minCoolness": "1"},
		},
	}
	for _, tt := range tests {
		d, err := Deployment(&tt.opts)
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}

		// Verify that environment variables in Deployment reflect the use of TLS being enabled.
		got := d.Spec.Template.Spec.NodeSelector
		for k, v := range tt.expect {
			if got[k] != v {
				t.Errorf("%s: expected nodeSelector value %q, got %q", tt.name, tt.expect, got)
			}
		}
	}
}

func TestDeployment_WithSetValues(t *testing.T) {
	tests := []struct {
		opts       Options
		name       string
		expectPath string
		expect     interface{}
	}{
		{
			Options{Namespace: v1.NamespaceDefault, Values: []string{"spec.template.spec.nodeselector.app=tiller"}},
			"setValues spec.template.spec.nodeSelector.app=tiller",
			"spec.template.spec.nodeSelector.app",
			"tiller",
		},
		{
			Options{Namespace: v1.NamespaceDefault, Values: []string{"spec.replicas=2"}},
			"setValues spec.replicas=2",
			"spec.replicas",
			2,
		},
		{
			Options{Namespace: v1.NamespaceDefault, Values: []string{"spec.template.spec.activedeadlineseconds=120"}},
			"setValues spec.template.spec.activedeadlineseconds=120",
			"spec.template.spec.activeDeadlineSeconds",
			120,
		},
	}
	for _, tt := range tests {
		d, err := Deployment(&tt.opts)
		if err != nil {
			t.Fatalf("%s: error %q", tt.name, err)
		}

		o, err := yaml.Marshal(d)
		if err != nil {
			t.Errorf("Error marshaling Deployment: %s", err)
		}

		values, err := chartutil.ReadValues(o)
		if err != nil {
			t.Errorf("Error converting Deployment manifest to Values: %s", err)
		}
		// path value
		pv, err := values.PathValue(tt.expectPath)
		if err != nil {
			t.Errorf("Error retrieving path value from Deployment Values: %s", err)
		}

		// convert our expected value to match the result type for comparison
		ev := tt.expect
		switch pvt := pv.(type) {
		case float64:
			floatType := reflect.TypeOf(float64(0))
			v := reflect.ValueOf(ev)
			v = reflect.Indirect(v)
			if !v.Type().ConvertibleTo(floatType) {
				t.Fatalf("Error converting expected value %v to float64", v.Type())
			}
			fv := v.Convert(floatType)
			if fv.Float() != pvt {
				t.Errorf("%s: expected value %q, got %q", tt.name, tt.expect, pv)
			}
		default:
			if pv != tt.expect {
				t.Errorf("%s: expected value %q, got %q", tt.name, tt.expect, pv)
			}
		}
	}
}