github.com/tilt-dev/tilt@v0.36.0/internal/engine/buildcontrol/build_control_test.go

package buildcontrol

import (
	"fmt"
	"path/filepath"
	"testing"
	"time"

	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

	"github.com/tilt-dev/tilt/pkg/apis/core/v1alpha1"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	v1 "k8s.io/api/core/v1"

	"github.com/tilt-dev/tilt/internal/container"
	"github.com/tilt-dev/tilt/internal/k8s"
	"github.com/tilt-dev/tilt/internal/k8s/testyaml"
	"github.com/tilt-dev/tilt/internal/store"
	"github.com/tilt-dev/tilt/internal/store/k8sconv"
	"github.com/tilt-dev/tilt/internal/testutils/manifestbuilder"
	"github.com/tilt-dev/tilt/internal/testutils/tempdir"
	"github.com/tilt-dev/tilt/pkg/model"
)

func TestNextTargetToBuildDoesntReturnCurrentlyBuildingTarget(t *testing.T) {
	f := newTestFixture(t)

	mt := f.upsertK8sManifest("k8s1")
	f.st.UpsertManifestTarget(mt)

	// Verify this target is normally next-to-build
	f.assertNextTargetToBuild(mt.Manifest.Name)

	// If target is currently building, should NOT be next-to-build
	mt.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNoTargetNextToBuild()
}

func TestCurrentlyBuildingK8sResourceDisablesLocalScheduling(t *testing.T) {
	f := newTestFixture(t)

	k8s1 := f.upsertK8sManifest("k8s1")
	k8s2 := f.upsertK8sManifest("k8s2")
	f.upsertLocalManifest("local1")

	f.assertNextTargetToBuild("local1")

	k8s1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNextTargetToBuild("k8s2")
	f.assertHold("local1", store.HoldReasonIsUnparallelizableTarget)

	k8s2.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNoTargetNextToBuild()
}

func TestCurrentlyBuildingK8sResourceDoesNotCreateHoldIfResourceNotPending(t *testing.T) {
	f := newTestFixture(t)

	k8s1 := f.upsertK8sManifest("k8s1")
	k8s2 := f.upsertK8sManifest("k8s2")
	f.upsertLocalManifest("local1", func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithTriggerMode(model.TriggerModeManual)
	})

	f.assertHold("local1", store.HoldReasonNone)

	k8s1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNextTargetToBuild("k8s2")
	f.assertHold("local1", store.HoldReasonNone)

	k8s2.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNoTargetNextToBuild()
	f.assertHold("local1", store.HoldReasonNone)
}

func TestCurrentlyBuildingUncategorizedDisablesOtherK8sTargets(t *testing.T) {
	f := newTestFixture(t)

	_ = f.upsertK8sManifest("k8s1")
	k8sUnresourced := f.upsertK8sManifest(model.UnresourcedYAMLManifestName)
	_ = f.upsertK8sManifest("k8s2")

	f.assertNextTargetToBuild(model.UnresourcedYAMLManifestName)
	k8sUnresourced.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNoTargetNextToBuild()
	for _, mn := range []model.ManifestName{"k8s1", "k8s2"} {
		f.assertHold(mn, store.HoldReasonWaitingForUncategorized, model.ManifestName("uncategorized").TargetID())
	}
}

func TestK8sDependsOnLocal(t *testing.T) {
	f := newTestFixture(t)

	k8s1 := f.upsertK8sManifest("k8s1", withResourceDeps("local1"))
	k8s2 := f.upsertK8sManifest("k8s2")
	local1 := f.upsertLocalManifest("local1")

	f.assertNextTargetToBuild("local1")

	f.assertHold("k8s1", store.HoldReasonWaitingForDep, model.ManifestName("local1").TargetID())
	f.assertHold("k8s2", store.HoldReasonNone)

	local1.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	lrs := local1.State.LocalRuntimeState()
	lrs.LastReadyOrSucceededTime = time.Now()
	local1.State.RuntimeState = lrs

	f.assertNextTargetToBuild("k8s1")
	k8s1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNextTargetToBuild("k8s2")

	_ = k8s2
}

func TestLocalDependsOnNonWorkloadK8s(t *testing.T) {
	f := newTestFixture(t)

	local1 := f.upsertLocalManifest("local1", withResourceDeps("k8s1"))
	k8s1 := f.upsertK8sManifest("k8s1", withK8sPodReadiness(model.PodReadinessIgnore))
	k8s2 := f.upsertK8sManifest("k8s2", withK8sPodReadiness(model.PodReadinessIgnore))

	f.assertNextTargetToBuild("k8s1")
	f.assertHold("local1", store.HoldReasonWaitingForDep, model.ManifestName("k8s1").TargetID())
	f.assertHold("k8s1", store.HoldReasonNone)
	f.assertHold("k8s2", store.HoldReasonNone)

	k8s1.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	k8s1.State.RuntimeState = store.K8sRuntimeState{
		PodReadinessMode:            model.PodReadinessIgnore,
		HasEverDeployedSuccessfully: true,
	}

	f.assertNextTargetToBuild("local1")
	local1.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	f.assertNextTargetToBuild("k8s2")

	_ = k8s2
}

func TestK8sDependsOnCluster(t *testing.T) {
	f := newTestFixture(t)

	f.st.Clusters["default"].Status.Error = "connection error"

	_ = f.upsertK8sManifest("k8s1")
	f.assertNoTargetNextToBuild()
	f.assertHoldOnRefs("k8s1", store.HoldReasonCluster, v1alpha1.UIResourceStateWaitingOnRef{
		Group:      "tilt.dev",
		APIVersion: "v1alpha1",
		Kind:       "Cluster",
		Name:       "default",
	})

	f.st.Clusters["default"].Status.Error = ""
	f.assertNextTargetToBuild("k8s1")
}

func TestK8sDependsOnCluster_TwoClusters(t *testing.T) {
	f := newTestFixture(t)

	f.st.Clusters["default"].Status.Error = "connection error"

	_ = f.upsertK8sManifest("k8s1")
	dc1 := f.upsertDCManifest("dc1")
	f.assertNextTargetToBuild("dc1")
	dc1.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	f.assertNoTargetNextToBuild()

	f.assertHoldOnRefs("k8s1", store.HoldReasonCluster, v1alpha1.UIResourceStateWaitingOnRef{
		Group:      "tilt.dev",
		APIVersion: "v1alpha1",
		Kind:       "Cluster",
		Name:       "default",
	})

	f.st.Clusters["default"].Status.Error = ""
	f.assertNextTargetToBuild("k8s1")
}

func TestCurrentlyBuildingLocalResourceDisablesK8sScheduling(t *testing.T) {
	f := newTestFixture(t)

	f.upsertK8sManifest("k8s1")
	f.upsertK8sManifest("k8s2")
	local1 := f.upsertLocalManifest("local1")
	f.upsertLocalManifest("local2")

	f.assertNextTargetToBuild("local1")
	local1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNoTargetNextToBuild()
	for _, mn := range []model.ManifestName{"k8s1", "k8s2", "local2"} {
		f.assertHold(mn, store.HoldReasonWaitingForUnparallelizableTarget, model.ManifestName("local1").TargetID())
	}
}

func TestCurrentlyBuildingParallelLocalResource(t *testing.T) {
	f := newTestFixture(t)

	f.upsertK8sManifest("k8s1")
	local1 := f.upsertLocalManifest("local1", func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithLocalAllowParallel(true)
	})
	local2 := f.upsertLocalManifest("local2", func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithLocalAllowParallel(true)
	})

	f.assertNextTargetToBuild("local1")

	local1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNextTargetToBuild("local2")

	local2.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}
	f.assertNextTargetToBuild("k8s1")
}

func TestTriggerIneligibleResource(t *testing.T) {
	f := newTestFixture(t)

	// local1 has a build in progress
	local1 := f.upsertLocalManifest("local1", func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithLocalAllowParallel(true)
	})
	local1.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}

	// local2 is not parallelizable
	local2 := f.upsertLocalManifest("local2")

	f.st.AppendToTriggerQueue(local1.Manifest.Name, model.BuildReasonFlagTriggerCLI)
	f.st.AppendToTriggerQueue(local2.Manifest.Name, model.BuildReasonFlagTriggerCLI)
	f.assertNoTargetNextToBuild()
}

func TestTwoK8sTargetsWithBaseImage(t *testing.T) {
	f := newTestFixture(t)

	baseImage := newDockerImageTarget("sancho-base")
	sanchoOneImage := newDockerImageTarget("sancho-one").
		WithImageMapDeps([]string{baseImage.ImageMapName()})
	sanchoTwoImage := newDockerImageTarget("sancho-two").
		WithImageMapDeps([]string{baseImage.ImageMapName()})

	sanchoOne := f.upsertManifest(manifestbuilder.New(f, "sancho-one").
		WithImageTargets(baseImage, sanchoOneImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())
	f.upsertManifest(manifestbuilder.New(f, "sancho-two").
		WithImageTargets(baseImage, sanchoTwoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())

	f.assertNextTargetToBuild("sancho-one")

	sanchoOne.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}

	f.assertNoTargetNextToBuild()
	f.assertHold("sancho-two", store.HoldReasonBuildingComponent, baseImage.ID())

	delete(sanchoOne.State.CurrentBuilds, "buildcontrol")
	sanchoOne.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})

	f.assertNextTargetToBuild("sancho-two")
}

func TestLiveUpdateMainImageHold(t *testing.T) {
	f := newTestFixture(t)

	srcFile := f.JoinPath("src", "a.txt")
	f.WriteFile(srcFile, "hello")
	luSpec := v1alpha1.LiveUpdateSpec{
		BasePath: f.Path(),
		Syncs: []v1alpha1.LiveUpdateSync{
			{LocalPath: "src", ContainerPath: "/src"},
		},
		Sources: []v1alpha1.LiveUpdateSource{
			{FileWatch: "image:sancho"},
		},
		Selector: v1alpha1.LiveUpdateSelector{
			Kubernetes: &v1alpha1.LiveUpdateKubernetesSelector{
				ContainerName: "c",
			},
		},
	}
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{Spec: luSpec}

	baseImage := newDockerImageTarget("sancho-base")
	sanchoImage := newDockerImageTarget("sancho").
		WithLiveUpdateSpec("sancho", luSpec).
		WithImageMapDeps([]string{baseImage.ImageMapName()})

	sancho := f.upsertManifest(manifestbuilder.New(f, "sancho").
		WithImageTargets(baseImage, sanchoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())

	f.assertNextTargetToBuild("sancho")
	sancho.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})

	resource := &k8sconv.KubernetesResource{
		FilteredPods: []v1alpha1.Pod{
			*readyPod("pod-1", sanchoImage.ImageMapSpec.Selector),
		},
	}
	f.st.KubernetesResources["sancho"] = resource

	bs, ok := sancho.State.BuildStatus(sanchoImage.ID())
	require.True(t, ok)
	bs.FileChanges[srcFile] = time.Now()
	f.assertNoTargetNextToBuild()
	f.assertHold("sancho", store.HoldReasonReconciling)

	// If the live update is failing, we have to rebuild.
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{
		Spec:   luSpec,
		Status: v1alpha1.LiveUpdateStatus{Failed: &v1alpha1.LiveUpdateStateFailed{Reason: "fake-reason"}},
	}
	f.assertNextTargetToBuild("sancho")

	// reset to a good state.
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{Spec: luSpec}
	f.assertNoTargetNextToBuild()

	// If the base image has a change, we have to rebuild.
	bs, ok = sancho.State.BuildStatus(baseImage.ID())
	require.True(t, ok)
	bs.FileChanges[srcFile] = time.Now()
	f.assertNextTargetToBuild("sancho")
}

// Test to make sure the buildcontroller does the translation
// correctly between the image target with the file watch
// and the image target matching the deployed container.
func TestLiveUpdateBaseImageHold(t *testing.T) {
	f := newTestFixture(t)

	srcFile := f.JoinPath("base", "a.txt")
	f.WriteFile(srcFile, "hello")

	luSpec := v1alpha1.LiveUpdateSpec{
		BasePath: f.Path(),
		Syncs: []v1alpha1.LiveUpdateSync{
			{LocalPath: "base", ContainerPath: "/base"},
		},
		Sources: []v1alpha1.LiveUpdateSource{
			{FileWatch: "image:sancho-base"},
		},
	}
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{Spec: luSpec}

	baseImage := newDockerImageTarget("sancho-base")
	sanchoImage := newDockerImageTarget("sancho").
		WithLiveUpdateSpec("sancho", luSpec).
		WithImageMapDeps([]string{baseImage.ImageMapName()})

	sancho := f.upsertManifest(manifestbuilder.New(f, "sancho").
		WithImageTargets(baseImage, sanchoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())

	f.assertNextTargetToBuild("sancho")
	sancho.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})

	resource := &k8sconv.KubernetesResource{
		FilteredPods: []v1alpha1.Pod{
			*readyPod("pod-1", sanchoImage.Selector),
		},
	}
	f.st.KubernetesResources["sancho"] = resource

	bs, ok := sancho.State.BuildStatus(baseImage.ID())
	require.True(t, ok)
	bs.FileChanges[srcFile] = time.Now()
	f.assertNoTargetNextToBuild()
	f.assertHold("sancho", store.HoldReasonReconciling)

	// If the live update is failing, we have to rebuild.
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{
		Spec:   luSpec,
		Status: v1alpha1.LiveUpdateStatus{Failed: &v1alpha1.LiveUpdateStateFailed{Reason: "fake-reason"}},
	}
	f.assertNextTargetToBuild("sancho")

	// reset to a good state.
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{Spec: luSpec}
	f.assertNoTargetNextToBuild()

	// If the deploy image has a change, we have to rebuild.
	bs, ok = sancho.State.BuildStatus(sanchoImage.ID())
	require.True(t, ok)
	bs.FileChanges[srcFile] = time.Now()
	f.assertNextTargetToBuild("sancho")
}

func TestTwoK8sTargetsWithBaseImagePrebuilt(t *testing.T) {
	f := newTestFixture(t)

	baseImage := newDockerImageTarget("sancho-base")
	sanchoOneImage := newDockerImageTarget("sancho-one").
		WithImageMapDeps([]string{baseImage.ImageMapName()})
	sanchoTwoImage := newDockerImageTarget("sancho-two").
		WithImageMapDeps([]string{baseImage.ImageMapName()})

	sanchoOne := f.upsertManifest(manifestbuilder.New(f, "sancho-one").
		WithImageTargets(baseImage, sanchoOneImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())
	sanchoTwo := f.upsertManifest(manifestbuilder.New(f, "sancho-two").
		WithImageTargets(baseImage, sanchoTwoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())

	bs, ok := sanchoOne.State.BuildStatus(baseImage.ID())
	require.True(t, ok)
	bs.LastResult = store.ImageBuildResult{}
	bs, ok = sanchoTwo.State.BuildStatus(baseImage.ID())
	require.True(t, ok)
	bs.LastResult = store.ImageBuildResult{}

	f.assertNextTargetToBuild("sancho-one")

	sanchoOne.State.CurrentBuilds["buildcontrol"] = model.BuildRecord{StartTime: time.Now()}

	// Make sure sancho-two can start while sanchoOne is still pending.
	f.assertNextTargetToBuild("sancho-two")
}

func TestHoldForDeploy(t *testing.T) {
	f := newTestFixture(t)

	srcFile := f.JoinPath("src", "a.txt")
	objFile := f.JoinPath("obj", "a.out")
	fallbackFile := f.JoinPath("src", "package.json")
	f.WriteFile(srcFile, "hello")
	f.WriteFile(objFile, "hello")
	f.WriteFile(fallbackFile, "hello")

	luSpec := v1alpha1.LiveUpdateSpec{
		BasePath:  f.Path(),
		StopPaths: []string{filepath.Join("src", "package.json")},
		Syncs:     []v1alpha1.LiveUpdateSync{{LocalPath: "src", ContainerPath: "/src"}},
		Selector: v1alpha1.LiveUpdateSelector{
			Kubernetes: &v1alpha1.LiveUpdateKubernetesSelector{
				ContainerName: "c",
			},
		},
	}
	sanchoImage := newDockerImageTarget("sancho").
		WithLiveUpdateSpec("sancho", luSpec).
		WithDockerImage(v1alpha1.DockerImageSpec{Context: f.Path()})
	sancho := f.upsertManifest(manifestbuilder.New(f, "sancho").
		WithImageTargets(sanchoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		Build())

	f.assertNextTargetToBuild("sancho")

	sancho.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	f.assertNoTargetNextToBuild()

	status, ok := sancho.State.BuildStatus(sanchoImage.ID())
	require.True(t, ok)
	status.FileChanges[objFile] = time.Now().Add(-2 * time.Second)
	f.assertNextTargetToBuild("sancho")
	status.ConsumedChanges = time.Now().Add(-2 * time.Second)

	status.FileChanges[fallbackFile] = time.Now().Add(-time.Second)
	f.assertNextTargetToBuild("sancho")
	status.ConsumedChanges = time.Now().Add(-time.Second)

	status.FileChanges[srcFile] = time.Now()
	f.assertNoTargetNextToBuild()
	f.assertHold("sancho", store.HoldReasonWaitingForDeploy)

	resource := &k8sconv.KubernetesResource{
		FilteredPods: []v1alpha1.Pod{},
	}
	f.st.KubernetesResources["sancho"] = resource

	resource.FilteredPods = append(resource.FilteredPods, *readyPod("pod-1", sanchoImage.Selector))
	f.assertNextTargetToBuild("sancho")

	resource.FilteredPods[0] = *crashingPod("pod-1", sanchoImage.Selector)
	f.assertNextTargetToBuild("sancho")

	resource.FilteredPods[0] = *crashedInThePastPod("pod-1", sanchoImage.Selector)
	f.assertNextTargetToBuild("sancho")

	resource.FilteredPods[0] = *sidecarCrashedPod("pod-1", sanchoImage.Selector)
	f.assertNextTargetToBuild("sancho")

	resource.FilteredPods[0] = *completedPod("pod-1", sanchoImage.Selector)
	f.assertNextTargetToBuild("sancho")
}

func TestHoldForManualLiveUpdate(t *testing.T) {
	f := newTestFixture(t)

	srcFile := f.JoinPath("src", "a.txt")
	f.WriteFile(srcFile, "hello")

	luSpec := v1alpha1.LiveUpdateSpec{
		BasePath: f.Path(),
		Syncs:    []v1alpha1.LiveUpdateSync{{LocalPath: "src", ContainerPath: "/src"}},
		Sources: []v1alpha1.LiveUpdateSource{
			{FileWatch: "image:sancho"},
		},
	}
	sanchoImage := newDockerImageTarget("sancho").
		WithLiveUpdateSpec("sancho", luSpec).
		WithDockerImage(v1alpha1.DockerImageSpec{Context: f.Path()})
	sancho := f.upsertManifest(manifestbuilder.New(f, "sancho").
		WithImageTargets(sanchoImage).
		WithK8sYAML(testyaml.SanchoYAML).
		WithTriggerMode(model.TriggerModeManualWithAutoInit).
		Build())

	f.assertNextTargetToBuild("sancho")

	// Set the live-update state to healthy.
	sancho.State.AddCompletedBuild(model.BuildRecord{
		StartTime:  time.Now(),
		FinishTime: time.Now(),
	})
	resource := &k8sconv.KubernetesResource{
		FilteredPods: []v1alpha1.Pod{*completedPod("pod-1", sanchoImage.Selector)},
	}
	f.st.KubernetesResources["sancho"] = resource
	f.st.LiveUpdates["sancho"] = &v1alpha1.LiveUpdate{Spec: luSpec}
	f.assertNoTargetNextToBuild()

	// This shouldn't trigger a full-build, because it will be handled by the live-updater.
	status, ok := sancho.State.BuildStatus(sanchoImage.ID())
	require.True(t, ok)
	f.st.AppendToTriggerQueue(sancho.Manifest.Name, model.BuildReasonFlagTriggerCLI)
	status.FileChanges[srcFile] = time.Now()
	f.assertNoTargetNextToBuild()

	// This should trigger a full-rebuild, because we have a trigger without pending changes.
	status.ConsumedChanges = time.Now()
	f.assertNextTargetToBuild("sancho")
}

func TestHoldDisabled(t *testing.T) {
	f := newTestFixture(t)

	f.upsertLocalManifest("local")
	f.st.ManifestTargets["local"].State.DisableState = v1alpha1.DisableStateDisabled
	f.assertNoTargetNextToBuild()
}

func TestHoldIfAnyDisableStatusPending(t *testing.T) {
	f := newTestFixture(t)

	f.upsertLocalManifest("local1")
	f.upsertLocalManifest("local2")
	f.upsertLocalManifest("local3")
	f.st.ManifestTargets["local2"].State.DisableState = v1alpha1.DisableStatePending

	f.assertHold("local1", store.HoldReasonTiltfileReload, model.TargetID{Type: "manifest", Name: "local2"})
	f.assertHold("local2", store.HoldReasonTiltfileReload, model.TargetID{Type: "manifest", Name: "local2"})
	f.assertHold("local3", store.HoldReasonTiltfileReload, model.TargetID{Type: "manifest", Name: "local2"})
	f.assertNoTargetNextToBuild()
}

func readyPod(podID k8s.PodID, ref string) *v1alpha1.Pod {
	return &v1alpha1.Pod{
		Name:   podID.String(),
		Phase:  string(v1.PodRunning),
		Status: "Running",
		Containers: []v1alpha1.Container{
			{
				ID:    string(podID + "-container"),
				Name:  "c",
				Ready: true,
				Image: ref,
				State: v1alpha1.ContainerState{
					Running: &v1alpha1.ContainerStateRunning{StartedAt: metav1.Now()},
				},
			},
		},
	}
}

func crashingPod(podID k8s.PodID, ref string) *v1alpha1.Pod {
	return &v1alpha1.Pod{
		Name:   podID.String(),
		Phase:  string(v1.PodRunning),
		Status: "CrashLoopBackOff",
		Containers: []v1alpha1.Container{
			{
				ID:       string(podID + "-container"),
				Name:     "c",
				Ready:    false,
				Image:    ref,
				Restarts: 1,
				State: v1alpha1.ContainerState{
					Terminated: &v1alpha1.ContainerStateTerminated{
						StartedAt:  metav1.Now(),
						FinishedAt: metav1.Now(),
						Reason:     "Error",
						ExitCode:   127,
					}},
			},
		},
	}
}

func crashedInThePastPod(podID k8s.PodID, ref string) *v1alpha1.Pod {
	return &v1alpha1.Pod{
		Name:   podID.String(),
		Phase:  string(v1.PodRunning),
		Status: "Ready",
		Containers: []v1alpha1.Container{
			{
				ID:       string(podID + "-container"),
				Name:     "c",
				Ready:    true,
				Image:    ref,
				Restarts: 1,
				State: v1alpha1.ContainerState{
					Running: &v1alpha1.ContainerStateRunning{StartedAt: metav1.Now()},
				},
			},
		},
	}
}

func sidecarCrashedPod(podID k8s.PodID, ref string) *v1alpha1.Pod {
	return &v1alpha1.Pod{
		Name:   podID.String(),
		Phase:  string(v1.PodRunning),
		Status: "Ready",
		Containers: []v1alpha1.Container{
			{
				ID:       string(podID + "-container"),
				Name:     "c",
				Ready:    true,
				Image:    ref,
				Restarts: 0,
				State: v1alpha1.ContainerState{
					Running: &v1alpha1.ContainerStateRunning{StartedAt: metav1.Now()},
				},
			},
			{
				ID:       string(podID + "-sidecar"),
				Name:     "s",
				Ready:    false,
				Image:    container.MustParseNamed("sidecar").String(),
				Restarts: 1,
				State: v1alpha1.ContainerState{
					Terminated: &v1alpha1.ContainerStateTerminated{
						StartedAt:  metav1.Now(),
						FinishedAt: metav1.Now(),
						Reason:     "Error",
						ExitCode:   127,
					}},
			},
		},
	}
}

func completedPod(podID k8s.PodID, ref string) *v1alpha1.Pod {
	return &v1alpha1.Pod{
		Name:   podID.String(),
		Phase:  string(v1.PodSucceeded),
		Status: "Completed",
		Containers: []v1alpha1.Container{
			{
				ID:       string(podID + "-container"),
				Name:     "c",
				Ready:    false,
				Image:    ref,
				Restarts: 0,
				State: v1alpha1.ContainerState{
					Terminated: &v1alpha1.ContainerStateTerminated{
						StartedAt:  metav1.Now(),
						FinishedAt: metav1.Now(),
						Reason:     "Success!",
						ExitCode:   0,
					}},
			},
		},
	}
}

type testFixture struct {
	*tempdir.TempDirFixture
	t  *testing.T
	st *store.EngineState
}

func newTestFixture(t *testing.T) testFixture {
	f := tempdir.NewTempDirFixture(t)
	st := store.NewState()
	st.Clusters["docker"] = &v1alpha1.Cluster{
		Status: v1alpha1.ClusterStatus{
			Arch: "amd64",
		},
	}
	st.Clusters["default"] = &v1alpha1.Cluster{
		Status: v1alpha1.ClusterStatus{
			Arch: "amd64",
		},
	}
	return testFixture{
		TempDirFixture: f,
		t:              t,
		st:             st,
	}
}

func (f *testFixture) assertHold(m model.ManifestName, reason store.HoldReason, holdOn ...model.TargetID) {
	f.T().Helper()
	_, hs := NextTargetToBuild(*f.st)
	hold := store.Hold{
		Reason: reason,
		HoldOn: holdOn,
	}
	assert.Equal(f.t, hold, hs[m])
}

func (f *testFixture) assertHoldOnRefs(m model.ManifestName, reason store.HoldReason, onRefs ...v1alpha1.UIResourceStateWaitingOnRef) {
	f.T().Helper()
	_, hs := NextTargetToBuild(*f.st)
	hold := store.Hold{
		Reason: reason,
		OnRefs: onRefs,
	}
	assert.Equal(f.t, hold, hs[m])
}

func (f *testFixture) assertNextTargetToBuild(expected model.ManifestName) {
	f.T().Helper()
	next, holds := NextTargetToBuild(*f.st)
	require.NotNil(f.t, next, "expected next target %s but got: nil. holds: %v", expected, holds)
	actual := next.Manifest.Name
	assert.Equal(f.t, expected, actual, "expected next target to be %s but got %s", expected, actual)
}

func (f *testFixture) assertNoTargetNextToBuild() {
	f.T().Helper()
	next, _ := NextTargetToBuild(*f.st)
	if next != nil {
		f.t.Fatalf("expected no next target to build, but got %s", next.Manifest.Name)
	}
}

func (f *testFixture) upsertManifest(m model.Manifest) *store.ManifestTarget {
	mt := store.NewManifestTarget(m)
	mt.State.DisableState = v1alpha1.DisableStateEnabled
	f.st.UpsertManifestTarget(mt)
	return mt
}

func (f *testFixture) upsertK8sManifest(name model.ManifestName, opts ...manifestOption) *store.ManifestTarget {
	b := manifestbuilder.New(f, name)
	for _, o := range opts {
		b = o(b)
	}
	return f.upsertManifest(b.WithK8sYAML(testyaml.SanchoYAML).Build())
}

func (f *testFixture) upsertDCManifest(name model.ManifestName, opts ...manifestOption) *store.ManifestTarget {
	b := manifestbuilder.New(f, name)
	for _, o := range opts {
		b = o(b)
	}
	return f.upsertManifest(b.WithDockerCompose().Build())
}

func (f *testFixture) upsertLocalManifest(name model.ManifestName, opts ...manifestOption) *store.ManifestTarget {
	b := manifestbuilder.New(f, name)
	for _, o := range opts {
		b = o(b)
	}
	return f.upsertManifest(b.WithLocalResource(fmt.Sprintf("exec-%s", name), nil).Build())
}

type manifestOption func(manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder

func withResourceDeps(deps ...string) manifestOption {
	return manifestOption(func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithResourceDeps(deps...)
	})
}
func withK8sPodReadiness(pr model.PodReadinessMode) manifestOption {
	return manifestOption(func(m manifestbuilder.ManifestBuilder) manifestbuilder.ManifestBuilder {
		return m.WithK8sPodReadiness(pr)
	})
}