github.com/tirogen/go-ethereum@v1.10.12-0.20221226051715-250cfede41b6/core/state/snapshot/difflayer.go (about)

     1  // Copyright 2019 The go-ethereum Authors
     2  // This file is part of the go-ethereum library.
     3  //
     4  // The go-ethereum library is free software: you can redistribute it and/or modify
     5  // it under the terms of the GNU Lesser General Public License as published by
     6  // the Free Software Foundation, either version 3 of the License, or
     7  // (at your option) any later version.
     8  //
     9  // The go-ethereum library is distributed in the hope that it will be useful,
    10  // but WITHOUT ANY WARRANTY; without even the implied warranty of
    11  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    12  // GNU Lesser General Public License for more details.
    13  //
    14  // You should have received a copy of the GNU Lesser General Public License
    15  // along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
    16  
    17  package snapshot
    18  
    19  import (
    20  	"encoding/binary"
    21  	"fmt"
    22  	"math"
    23  	"math/rand"
    24  	"sort"
    25  	"sync"
    26  	"sync/atomic"
    27  	"time"
    28  
    29  	bloomfilter "github.com/holiman/bloomfilter/v2"
    30  	"github.com/tirogen/go-ethereum/common"
    31  	"github.com/tirogen/go-ethereum/rlp"
    32  )
    33  
    34  var (
    35  	// aggregatorMemoryLimit is the maximum size of the bottom-most diff layer
    36  	// that aggregates the writes from above until it's flushed into the disk
    37  	// layer.
    38  	//
    39  	// Note, bumping this up might drastically increase the size of the bloom
    40  	// filters that's stored in every diff layer. Don't do that without fully
    41  	// understanding all the implications.
    42  	aggregatorMemoryLimit = uint64(4 * 1024 * 1024)
    43  
    44  	// aggregatorItemLimit is an approximate number of items that will end up
    45  	// in the agregator layer before it's flushed out to disk. A plain account
    46  	// weighs around 14B (+hash), a storage slot 32B (+hash), a deleted slot
    47  	// 0B (+hash). Slots are mostly set/unset in lockstep, so that average at
    48  	// 16B (+hash). All in all, the average entry seems to be 15+32=47B. Use a
    49  	// smaller number to be on the safe side.
    50  	aggregatorItemLimit = aggregatorMemoryLimit / 42
    51  
    52  	// bloomTargetError is the target false positive rate when the aggregator
    53  	// layer is at its fullest. The actual value will probably move around up
    54  	// and down from this number, it's mostly a ballpark figure.
    55  	//
    56  	// Note, dropping this down might drastically increase the size of the bloom
    57  	// filters that's stored in every diff layer. Don't do that without fully
    58  	// understanding all the implications.
    59  	bloomTargetError = 0.02
    60  
    61  	// bloomSize is the ideal bloom filter size given the maximum number of items
    62  	// it's expected to hold and the target false positive error rate.
    63  	bloomSize = math.Ceil(float64(aggregatorItemLimit) * math.Log(bloomTargetError) / math.Log(1/math.Pow(2, math.Log(2))))
    64  
    65  	// bloomFuncs is the ideal number of bits a single entry should set in the
    66  	// bloom filter to keep its size to a minimum (given it's size and maximum
    67  	// entry count).
    68  	bloomFuncs = math.Round((bloomSize / float64(aggregatorItemLimit)) * math.Log(2))
    69  
    70  	// the bloom offsets are runtime constants which determines which part of the
    71  	// account/storage hash the hasher functions looks at, to determine the
    72  	// bloom key for an account/slot. This is randomized at init(), so that the
    73  	// global population of nodes do not all display the exact same behaviour with
    74  	// regards to bloom content
    75  	bloomDestructHasherOffset = 0
    76  	bloomAccountHasherOffset  = 0
    77  	bloomStorageHasherOffset  = 0
    78  )
    79  
    80  func init() {
    81  	// Init the bloom offsets in the range [0:24] (requires 8 bytes)
    82  	bloomDestructHasherOffset = rand.Intn(25)
    83  	bloomAccountHasherOffset = rand.Intn(25)
    84  	bloomStorageHasherOffset = rand.Intn(25)
    85  
    86  	// The destruct and account blooms must be different, as the storage slots
    87  	// will check for destruction too for every bloom miss. It should not collide
    88  	// with modified accounts.
    89  	for bloomAccountHasherOffset == bloomDestructHasherOffset {
    90  		bloomAccountHasherOffset = rand.Intn(25)
    91  	}
    92  }
    93  
    94  // diffLayer represents a collection of modifications made to a state snapshot
    95  // after running a block on top. It contains one sorted list for the account trie
    96  // and one-one list for each storage tries.
    97  //
    98  // The goal of a diff layer is to act as a journal, tracking recent modifications
    99  // made to the state, that have not yet graduated into a semi-immutable state.
   100  type diffLayer struct {
   101  	origin *diskLayer // Base disk layer to directly use on bloom misses
   102  	parent snapshot   // Parent snapshot modified by this one, never nil
   103  	memory uint64     // Approximate guess as to how much memory we use
   104  
   105  	root  common.Hash // Root hash to which this snapshot diff belongs to
   106  	stale uint32      // Signals that the layer became stale (state progressed)
   107  
   108  	// destructSet is a very special helper marker. If an account is marked as
   109  	// deleted, then it's recorded in this set. However it's allowed that an account
   110  	// is included here but still available in other sets(e.g. storageData). The
   111  	// reason is the diff layer includes all the changes in a *block*. It can
   112  	// happen that in the tx_1, account A is self-destructed while in the tx_2
   113  	// it's recreated. But we still need this marker to indicate the "old" A is
   114  	// deleted, all data in other set belongs to the "new" A.
   115  	destructSet map[common.Hash]struct{}               // Keyed markers for deleted (and potentially) recreated accounts
   116  	accountList []common.Hash                          // List of account for iteration. If it exists, it's sorted, otherwise it's nil
   117  	accountData map[common.Hash][]byte                 // Keyed accounts for direct retrieval (nil means deleted)
   118  	storageList map[common.Hash][]common.Hash          // List of storage slots for iterated retrievals, one per account. Any existing lists are sorted if non-nil
   119  	storageData map[common.Hash]map[common.Hash][]byte // Keyed storage slots for direct retrieval. one per account (nil means deleted)
   120  
   121  	diffed *bloomfilter.Filter // Bloom filter tracking all the diffed items up to the disk layer
   122  
   123  	lock sync.RWMutex
   124  }
   125  
   126  // destructBloomHasher is a wrapper around a common.Hash to satisfy the interface
   127  // API requirements of the bloom library used. It's used to convert a destruct
   128  // event into a 64 bit mini hash.
   129  type destructBloomHasher common.Hash
   130  
   131  func (h destructBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
   132  func (h destructBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
   133  func (h destructBloomHasher) Reset()                            { panic("not implemented") }
   134  func (h destructBloomHasher) BlockSize() int                    { panic("not implemented") }
   135  func (h destructBloomHasher) Size() int                         { return 8 }
   136  func (h destructBloomHasher) Sum64() uint64 {
   137  	return binary.BigEndian.Uint64(h[bloomDestructHasherOffset : bloomDestructHasherOffset+8])
   138  }
   139  
   140  // accountBloomHasher is a wrapper around a common.Hash to satisfy the interface
   141  // API requirements of the bloom library used. It's used to convert an account
   142  // hash into a 64 bit mini hash.
   143  type accountBloomHasher common.Hash
   144  
   145  func (h accountBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
   146  func (h accountBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
   147  func (h accountBloomHasher) Reset()                            { panic("not implemented") }
   148  func (h accountBloomHasher) BlockSize() int                    { panic("not implemented") }
   149  func (h accountBloomHasher) Size() int                         { return 8 }
   150  func (h accountBloomHasher) Sum64() uint64 {
   151  	return binary.BigEndian.Uint64(h[bloomAccountHasherOffset : bloomAccountHasherOffset+8])
   152  }
   153  
   154  // storageBloomHasher is a wrapper around a [2]common.Hash to satisfy the interface
   155  // API requirements of the bloom library used. It's used to convert an account
   156  // hash into a 64 bit mini hash.
   157  type storageBloomHasher [2]common.Hash
   158  
   159  func (h storageBloomHasher) Write(p []byte) (n int, err error) { panic("not implemented") }
   160  func (h storageBloomHasher) Sum(b []byte) []byte               { panic("not implemented") }
   161  func (h storageBloomHasher) Reset()                            { panic("not implemented") }
   162  func (h storageBloomHasher) BlockSize() int                    { panic("not implemented") }
   163  func (h storageBloomHasher) Size() int                         { return 8 }
   164  func (h storageBloomHasher) Sum64() uint64 {
   165  	return binary.BigEndian.Uint64(h[0][bloomStorageHasherOffset:bloomStorageHasherOffset+8]) ^
   166  		binary.BigEndian.Uint64(h[1][bloomStorageHasherOffset:bloomStorageHasherOffset+8])
   167  }
   168  
   169  // newDiffLayer creates a new diff on top of an existing snapshot, whether that's a low
   170  // level persistent database or a hierarchical diff already.
   171  func newDiffLayer(parent snapshot, root common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
   172  	// Create the new layer with some pre-allocated data segments
   173  	dl := &diffLayer{
   174  		parent:      parent,
   175  		root:        root,
   176  		destructSet: destructs,
   177  		accountData: accounts,
   178  		storageData: storage,
   179  		storageList: make(map[common.Hash][]common.Hash),
   180  	}
   181  	switch parent := parent.(type) {
   182  	case *diskLayer:
   183  		dl.rebloom(parent)
   184  	case *diffLayer:
   185  		dl.rebloom(parent.origin)
   186  	default:
   187  		panic("unknown parent type")
   188  	}
   189  	// Sanity check that accounts or storage slots are never nil
   190  	for accountHash, blob := range accounts {
   191  		if blob == nil {
   192  			panic(fmt.Sprintf("account %#x nil", accountHash))
   193  		}
   194  		// Determine memory size and track the dirty writes
   195  		dl.memory += uint64(common.HashLength + len(blob))
   196  		snapshotDirtyAccountWriteMeter.Mark(int64(len(blob)))
   197  	}
   198  	for accountHash, slots := range storage {
   199  		if slots == nil {
   200  			panic(fmt.Sprintf("storage %#x nil", accountHash))
   201  		}
   202  		// Determine memory size and track the dirty writes
   203  		for _, data := range slots {
   204  			dl.memory += uint64(common.HashLength + len(data))
   205  			snapshotDirtyStorageWriteMeter.Mark(int64(len(data)))
   206  		}
   207  	}
   208  	dl.memory += uint64(len(destructs) * common.HashLength)
   209  	return dl
   210  }
   211  
   212  // rebloom discards the layer's current bloom and rebuilds it from scratch based
   213  // on the parent's and the local diffs.
   214  func (dl *diffLayer) rebloom(origin *diskLayer) {
   215  	dl.lock.Lock()
   216  	defer dl.lock.Unlock()
   217  
   218  	defer func(start time.Time) {
   219  		snapshotBloomIndexTimer.Update(time.Since(start))
   220  	}(time.Now())
   221  
   222  	// Inject the new origin that triggered the rebloom
   223  	dl.origin = origin
   224  
   225  	// Retrieve the parent bloom or create a fresh empty one
   226  	if parent, ok := dl.parent.(*diffLayer); ok {
   227  		parent.lock.RLock()
   228  		dl.diffed, _ = parent.diffed.Copy()
   229  		parent.lock.RUnlock()
   230  	} else {
   231  		dl.diffed, _ = bloomfilter.New(uint64(bloomSize), uint64(bloomFuncs))
   232  	}
   233  	// Iterate over all the accounts and storage slots and index them
   234  	for hash := range dl.destructSet {
   235  		dl.diffed.Add(destructBloomHasher(hash))
   236  	}
   237  	for hash := range dl.accountData {
   238  		dl.diffed.Add(accountBloomHasher(hash))
   239  	}
   240  	for accountHash, slots := range dl.storageData {
   241  		for storageHash := range slots {
   242  			dl.diffed.Add(storageBloomHasher{accountHash, storageHash})
   243  		}
   244  	}
   245  	// Calculate the current false positive rate and update the error rate meter.
   246  	// This is a bit cheating because subsequent layers will overwrite it, but it
   247  	// should be fine, we're only interested in ballpark figures.
   248  	k := float64(dl.diffed.K())
   249  	n := float64(dl.diffed.N())
   250  	m := float64(dl.diffed.M())
   251  	snapshotBloomErrorGauge.Update(math.Pow(1.0-math.Exp((-k)*(n+0.5)/(m-1)), k))
   252  }
   253  
   254  // Root returns the root hash for which this snapshot was made.
   255  func (dl *diffLayer) Root() common.Hash {
   256  	return dl.root
   257  }
   258  
   259  // Parent returns the subsequent layer of a diff layer.
   260  func (dl *diffLayer) Parent() snapshot {
   261  	dl.lock.RLock()
   262  	defer dl.lock.RUnlock()
   263  
   264  	return dl.parent
   265  }
   266  
   267  // Stale return whether this layer has become stale (was flattened across) or if
   268  // it's still live.
   269  func (dl *diffLayer) Stale() bool {
   270  	return atomic.LoadUint32(&dl.stale) != 0
   271  }
   272  
   273  // Account directly retrieves the account associated with a particular hash in
   274  // the snapshot slim data format.
   275  func (dl *diffLayer) Account(hash common.Hash) (*Account, error) {
   276  	data, err := dl.AccountRLP(hash)
   277  	if err != nil {
   278  		return nil, err
   279  	}
   280  	if len(data) == 0 { // can be both nil and []byte{}
   281  		return nil, nil
   282  	}
   283  	account := new(Account)
   284  	if err := rlp.DecodeBytes(data, account); err != nil {
   285  		panic(err)
   286  	}
   287  	return account, nil
   288  }
   289  
   290  // AccountRLP directly retrieves the account RLP associated with a particular
   291  // hash in the snapshot slim data format.
   292  //
   293  // Note the returned account is not a copy, please don't modify it.
   294  func (dl *diffLayer) AccountRLP(hash common.Hash) ([]byte, error) {
   295  	// Check the bloom filter first whether there's even a point in reaching into
   296  	// all the maps in all the layers below
   297  	dl.lock.RLock()
   298  	hit := dl.diffed.Contains(accountBloomHasher(hash))
   299  	if !hit {
   300  		hit = dl.diffed.Contains(destructBloomHasher(hash))
   301  	}
   302  	var origin *diskLayer
   303  	if !hit {
   304  		origin = dl.origin // extract origin while holding the lock
   305  	}
   306  	dl.lock.RUnlock()
   307  
   308  	// If the bloom filter misses, don't even bother with traversing the memory
   309  	// diff layers, reach straight into the bottom persistent disk layer
   310  	if origin != nil {
   311  		snapshotBloomAccountMissMeter.Mark(1)
   312  		return origin.AccountRLP(hash)
   313  	}
   314  	// The bloom filter hit, start poking in the internal maps
   315  	return dl.accountRLP(hash, 0)
   316  }
   317  
   318  // accountRLP is an internal version of AccountRLP that skips the bloom filter
   319  // checks and uses the internal maps to try and retrieve the data. It's meant
   320  // to be used if a higher layer's bloom filter hit already.
   321  func (dl *diffLayer) accountRLP(hash common.Hash, depth int) ([]byte, error) {
   322  	dl.lock.RLock()
   323  	defer dl.lock.RUnlock()
   324  
   325  	// If the layer was flattened into, consider it invalid (any live reference to
   326  	// the original should be marked as unusable).
   327  	if dl.Stale() {
   328  		return nil, ErrSnapshotStale
   329  	}
   330  	// If the account is known locally, return it
   331  	if data, ok := dl.accountData[hash]; ok {
   332  		snapshotDirtyAccountHitMeter.Mark(1)
   333  		snapshotDirtyAccountHitDepthHist.Update(int64(depth))
   334  		snapshotDirtyAccountReadMeter.Mark(int64(len(data)))
   335  		snapshotBloomAccountTrueHitMeter.Mark(1)
   336  		return data, nil
   337  	}
   338  	// If the account is known locally, but deleted, return it
   339  	if _, ok := dl.destructSet[hash]; ok {
   340  		snapshotDirtyAccountHitMeter.Mark(1)
   341  		snapshotDirtyAccountHitDepthHist.Update(int64(depth))
   342  		snapshotDirtyAccountInexMeter.Mark(1)
   343  		snapshotBloomAccountTrueHitMeter.Mark(1)
   344  		return nil, nil
   345  	}
   346  	// Account unknown to this diff, resolve from parent
   347  	if diff, ok := dl.parent.(*diffLayer); ok {
   348  		return diff.accountRLP(hash, depth+1)
   349  	}
   350  	// Failed to resolve through diff layers, mark a bloom error and use the disk
   351  	snapshotBloomAccountFalseHitMeter.Mark(1)
   352  	return dl.parent.AccountRLP(hash)
   353  }
   354  
   355  // Storage directly retrieves the storage data associated with a particular hash,
   356  // within a particular account. If the slot is unknown to this diff, it's parent
   357  // is consulted.
   358  //
   359  // Note the returned slot is not a copy, please don't modify it.
   360  func (dl *diffLayer) Storage(accountHash, storageHash common.Hash) ([]byte, error) {
   361  	// Check the bloom filter first whether there's even a point in reaching into
   362  	// all the maps in all the layers below
   363  	dl.lock.RLock()
   364  	hit := dl.diffed.Contains(storageBloomHasher{accountHash, storageHash})
   365  	if !hit {
   366  		hit = dl.diffed.Contains(destructBloomHasher(accountHash))
   367  	}
   368  	var origin *diskLayer
   369  	if !hit {
   370  		origin = dl.origin // extract origin while holding the lock
   371  	}
   372  	dl.lock.RUnlock()
   373  
   374  	// If the bloom filter misses, don't even bother with traversing the memory
   375  	// diff layers, reach straight into the bottom persistent disk layer
   376  	if origin != nil {
   377  		snapshotBloomStorageMissMeter.Mark(1)
   378  		return origin.Storage(accountHash, storageHash)
   379  	}
   380  	// The bloom filter hit, start poking in the internal maps
   381  	return dl.storage(accountHash, storageHash, 0)
   382  }
   383  
   384  // storage is an internal version of Storage that skips the bloom filter checks
   385  // and uses the internal maps to try and retrieve the data. It's meant  to be
   386  // used if a higher layer's bloom filter hit already.
   387  func (dl *diffLayer) storage(accountHash, storageHash common.Hash, depth int) ([]byte, error) {
   388  	dl.lock.RLock()
   389  	defer dl.lock.RUnlock()
   390  
   391  	// If the layer was flattened into, consider it invalid (any live reference to
   392  	// the original should be marked as unusable).
   393  	if dl.Stale() {
   394  		return nil, ErrSnapshotStale
   395  	}
   396  	// If the account is known locally, try to resolve the slot locally
   397  	if storage, ok := dl.storageData[accountHash]; ok {
   398  		if data, ok := storage[storageHash]; ok {
   399  			snapshotDirtyStorageHitMeter.Mark(1)
   400  			snapshotDirtyStorageHitDepthHist.Update(int64(depth))
   401  			if n := len(data); n > 0 {
   402  				snapshotDirtyStorageReadMeter.Mark(int64(n))
   403  			} else {
   404  				snapshotDirtyStorageInexMeter.Mark(1)
   405  			}
   406  			snapshotBloomStorageTrueHitMeter.Mark(1)
   407  			return data, nil
   408  		}
   409  	}
   410  	// If the account is known locally, but deleted, return an empty slot
   411  	if _, ok := dl.destructSet[accountHash]; ok {
   412  		snapshotDirtyStorageHitMeter.Mark(1)
   413  		snapshotDirtyStorageHitDepthHist.Update(int64(depth))
   414  		snapshotDirtyStorageInexMeter.Mark(1)
   415  		snapshotBloomStorageTrueHitMeter.Mark(1)
   416  		return nil, nil
   417  	}
   418  	// Storage slot unknown to this diff, resolve from parent
   419  	if diff, ok := dl.parent.(*diffLayer); ok {
   420  		return diff.storage(accountHash, storageHash, depth+1)
   421  	}
   422  	// Failed to resolve through diff layers, mark a bloom error and use the disk
   423  	snapshotBloomStorageFalseHitMeter.Mark(1)
   424  	return dl.parent.Storage(accountHash, storageHash)
   425  }
   426  
   427  // Update creates a new layer on top of the existing snapshot diff tree with
   428  // the specified data items.
   429  func (dl *diffLayer) Update(blockRoot common.Hash, destructs map[common.Hash]struct{}, accounts map[common.Hash][]byte, storage map[common.Hash]map[common.Hash][]byte) *diffLayer {
   430  	return newDiffLayer(dl, blockRoot, destructs, accounts, storage)
   431  }
   432  
   433  // flatten pushes all data from this point downwards, flattening everything into
   434  // a single diff at the bottom. Since usually the lowermost diff is the largest,
   435  // the flattening builds up from there in reverse.
   436  func (dl *diffLayer) flatten() snapshot {
   437  	// If the parent is not diff, we're the first in line, return unmodified
   438  	parent, ok := dl.parent.(*diffLayer)
   439  	if !ok {
   440  		return dl
   441  	}
   442  	// Parent is a diff, flatten it first (note, apart from weird corned cases,
   443  	// flatten will realistically only ever merge 1 layer, so there's no need to
   444  	// be smarter about grouping flattens together).
   445  	parent = parent.flatten().(*diffLayer)
   446  
   447  	parent.lock.Lock()
   448  	defer parent.lock.Unlock()
   449  
   450  	// Before actually writing all our data to the parent, first ensure that the
   451  	// parent hasn't been 'corrupted' by someone else already flattening into it
   452  	if atomic.SwapUint32(&parent.stale, 1) != 0 {
   453  		panic("parent diff layer is stale") // we've flattened into the same parent from two children, boo
   454  	}
   455  	// Overwrite all the updated accounts blindly, merge the sorted list
   456  	for hash := range dl.destructSet {
   457  		parent.destructSet[hash] = struct{}{}
   458  		delete(parent.accountData, hash)
   459  		delete(parent.storageData, hash)
   460  	}
   461  	for hash, data := range dl.accountData {
   462  		parent.accountData[hash] = data
   463  	}
   464  	// Overwrite all the updated storage slots (individually)
   465  	for accountHash, storage := range dl.storageData {
   466  		// If storage didn't exist (or was deleted) in the parent, overwrite blindly
   467  		if _, ok := parent.storageData[accountHash]; !ok {
   468  			parent.storageData[accountHash] = storage
   469  			continue
   470  		}
   471  		// Storage exists in both parent and child, merge the slots
   472  		comboData := parent.storageData[accountHash]
   473  		for storageHash, data := range storage {
   474  			comboData[storageHash] = data
   475  		}
   476  	}
   477  	// Return the combo parent
   478  	return &diffLayer{
   479  		parent:      parent.parent,
   480  		origin:      parent.origin,
   481  		root:        dl.root,
   482  		destructSet: parent.destructSet,
   483  		accountData: parent.accountData,
   484  		storageData: parent.storageData,
   485  		storageList: make(map[common.Hash][]common.Hash),
   486  		diffed:      dl.diffed,
   487  		memory:      parent.memory + dl.memory,
   488  	}
   489  }
   490  
   491  // AccountList returns a sorted list of all accounts in this diffLayer, including
   492  // the deleted ones.
   493  //
   494  // Note, the returned slice is not a copy, so do not modify it.
   495  func (dl *diffLayer) AccountList() []common.Hash {
   496  	// If an old list already exists, return it
   497  	dl.lock.RLock()
   498  	list := dl.accountList
   499  	dl.lock.RUnlock()
   500  
   501  	if list != nil {
   502  		return list
   503  	}
   504  	// No old sorted account list exists, generate a new one
   505  	dl.lock.Lock()
   506  	defer dl.lock.Unlock()
   507  
   508  	dl.accountList = make([]common.Hash, 0, len(dl.destructSet)+len(dl.accountData))
   509  	for hash := range dl.accountData {
   510  		dl.accountList = append(dl.accountList, hash)
   511  	}
   512  	for hash := range dl.destructSet {
   513  		if _, ok := dl.accountData[hash]; !ok {
   514  			dl.accountList = append(dl.accountList, hash)
   515  		}
   516  	}
   517  	sort.Sort(hashes(dl.accountList))
   518  	dl.memory += uint64(len(dl.accountList) * common.HashLength)
   519  	return dl.accountList
   520  }
   521  
   522  // StorageList returns a sorted list of all storage slot hashes in this diffLayer
   523  // for the given account. If the whole storage is destructed in this layer, then
   524  // an additional flag *destructed = true* will be returned, otherwise the flag is
   525  // false. Besides, the returned list will include the hash of deleted storage slot.
   526  // Note a special case is an account is deleted in a prior tx but is recreated in
   527  // the following tx with some storage slots set. In this case the returned list is
   528  // not empty but the flag is true.
   529  //
   530  // Note, the returned slice is not a copy, so do not modify it.
   531  func (dl *diffLayer) StorageList(accountHash common.Hash) ([]common.Hash, bool) {
   532  	dl.lock.RLock()
   533  	_, destructed := dl.destructSet[accountHash]
   534  	if _, ok := dl.storageData[accountHash]; !ok {
   535  		// Account not tracked by this layer
   536  		dl.lock.RUnlock()
   537  		return nil, destructed
   538  	}
   539  	// If an old list already exists, return it
   540  	if list, exist := dl.storageList[accountHash]; exist {
   541  		dl.lock.RUnlock()
   542  		return list, destructed // the cached list can't be nil
   543  	}
   544  	dl.lock.RUnlock()
   545  
   546  	// No old sorted account list exists, generate a new one
   547  	dl.lock.Lock()
   548  	defer dl.lock.Unlock()
   549  
   550  	storageMap := dl.storageData[accountHash]
   551  	storageList := make([]common.Hash, 0, len(storageMap))
   552  	for k := range storageMap {
   553  		storageList = append(storageList, k)
   554  	}
   555  	sort.Sort(hashes(storageList))
   556  	dl.storageList[accountHash] = storageList
   557  	dl.memory += uint64(len(dl.storageList)*common.HashLength + common.HashLength)
   558  	return storageList, destructed
   559  }