github.com/verrazzano/verrazzano@v1.7.1/tools/vz/pkg/analysis/main_test.go

// Copyright (c) 2021, 2024, Oracle and/or its affiliates.
// Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
package analysis

import (
	"fmt"
	"os"
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/verrazzano/verrazzano/tools/vz/pkg/internal/util/log"
	"github.com/verrazzano/verrazzano/tools/vz/pkg/internal/util/report"
	vzhelper "github.com/verrazzano/verrazzano/tools/vz/test/helpers"
	"k8s.io/cli-runtime/pkg/genericclioptions"
)

// TestHandleMain Tests the handleMain function
// GIVEN a call to handleMain
// WHEN with valid/invalid inputs
// THEN exit codes returned are as expected
func TestHandleMain(_ *testing.T) {
	// This is setting up the main.logger, do NOT set it as a var here (or you will get a nil reference running
	// the test)
	logger = log.GetDebugEnabledLogger()
	analyzerType = "cluster"
}

// TestAnalyzeBad Tests the main Analyze function
// GIVEN a call to Analyze
// WHEN with invalid inputs
// THEN errors are generated as expected
func TestExecuteAnalysisBadArgs(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	// Call the analyzer with an unknown type, give it a good cluster dump directory
	err := Analyze(rc, logger, "badnamehere", "../test/cluster/image-pull-case1")
	assert.NotNil(t, err)
	// TODO: Check error message is what we expected here

}
func TestProblemPodsInCattleSystem(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/testCattleSystempods")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.Nil(t, reportedIssues)
	assert.False(t, len(reportedIssues) > 0)
	problemPodsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.PodProblemsNotReported {
			problemPodsFound++
		}

	}
	assert.True(t, problemPodsFound == 0)
}

// TestImagePullCase1 Tests that analysis of a cluster dump with image pull issues is handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows image pull issues
// THEN a report is generated with image pull issues identified
func TestImagePull(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/image-pull-case1")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	imagePullsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.ImagePullNotFound {
			imagePullsFound++
		}
	}
	assert.True(t, imagePullsFound > 0)
}

// TestInsufficientMemory Tests that analysis of a cluster dump with pods that failed due to insufficient memory
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with insufficient memory problems
// THEN a report is generated with issues identified
func TestInsufficientMemory(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/insufficient-mem")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	issuesFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.InsufficientMemory {
			issuesFound++
		}
	}
	assert.True(t, issuesFound > 0)
}

// TestProblemPodsNotReportedUninstall Tests that analysis of a cluster dump with pods that have unknown issues during
// uninstall, is handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestProblemPodsNotReportedUninstall(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/problem-pods")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemPodsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.PodProblemsNotReported {
			problemPodsFound++
		}
	}
	assert.True(t, problemPodsFound > 0)
}

// TestProblemPodsNotReportedInstall Tests that analysis of a cluster dump with pods that have unknown issues during
// install, is handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestProblemPodsNotReportedInstall(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/problem-pods-install")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)

	exceededLBLimit := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IngressLBLimitExceeded {
			exceededLBLimit++
		}

	}
	assert.True(t, exceededLBLimit > 0)
}

// TestLBIpNotSet Tests that analysis of a cluster dump where LB issue occurred with no IP set is handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
// Note: With the latest changes to platform operator and analysis tool, the issue is reported differently.
// Commenting the test for now, and added a new test TestLBIpNotFound
//func TestLBIpNotSet(t *testing.T) {
//	logger := log.GetDebugEnabledLogger()

//	err := Analyze(logger, "cluster", "../internal/test/cluster/lb-ipnotset")
//	assert.Nil(t, err)

//	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
//	assert.NotNil(t, reportedIssues)
//	assert.True(t, len(reportedIssues) > 0)
//	problemsFound := 0
//	for _, issue := range reportedIssues {
//		if issue.Type == report.IngressNoLoadBalancerIP {
//			problemsFound++
//		}
//	}
//	assert.True(t, problemsFound > 0)
//}

// TestLBIpNotFound Tests that analysis of a cluster dump where no IP was found for load balancer
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestLBIpNotFound(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/ingress-ip-not-found")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IngressNoIPFound {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestIstioLBIpNotFound Tests that analysis of a cluster dump where no Istio Gateway IP was found
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows services with external IP problems
// THEN a report is generated with issues identified
func TestIstioLBIpNotFound(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/istio-ingress-ip-not-found")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IstioIngressNoIP {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TODO: Enable this test once there is a cluster dump for this use case
// TestIngressInstall Tests that analysis of a cluster dump where Ingress install failed without more info handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
// func TestIngressInstall(t *testing.T) {
//	logger := log.GetDebugEnabledLogger()

//	err := Analyze(logger, "cluster", "../internal/test/cluster/ingress-install-unknown")
//	assert.Nil(t, err)

//	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
//	assert.NotNil(t, reportedIssues)
//	assert.True(t, len(reportedIssues) > 0)
//	problemsFound := 0
//	for _, issue := range reportedIssues {
//		if issue.Type == report.IngressInstallFailure {
//			problemsFound++
//		}
//	}
//	assert.True(t, problemsFound > 0)
//}

// TestLBLimitExceeded Test that analysis of a cluster dump where Ingress install failed due to LoadBalancer service limit handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestLBLimitExceeded(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/ingress-lb-limit")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IngressLBLimitExceeded {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestOciIPLimitExceeded Tests that analysis of a cluster dump where Ingress install failed due to OCI limit handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestOciIPLimitExceeded(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/ingress-oci-limit")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IngressOciIPLimitExceeded {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestOciLBInvalidShape Tests that analysis of a cluster dump where an invalid shape specified for OCI load balancer
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestOciLBInvalidShape(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/ingress-invalid-shape")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IngressShapeInvalid {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestPendingPods that analysis of a cluster dump where pending pods only is handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
func TestPendingPods(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/pending-pods")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.PendingPods {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestUnknownInstall Tests that analysis of a cluster dump where install failed without more info handled
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows pods with problems that are not known issues
// THEN a report is generated with problem pod issues identified
// Commenting this test as there might not be an install issue like this now.
//func TestUnknownInstall(t *testing.T) {
//	logger := log.GetDebugEnabledLogger()

//	err := Analyze(logger, "cluster", "../internal/test/cluster/install-unknown")
//	assert.Nil(t, err)

//	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
//	assert.NotNil(t, reportedIssues)
//	assert.True(t, len(reportedIssues) > 0)
//	problemsFound := 0
//	for _, issue := range reportedIssues {
//		if issue.Type == report.InstallFailure {
//			problemsFound++
//		}
//	}
//	assert.True(t, problemsFound > 0)
//}

// TestIstioIngressInstallFailure Tests that analysis of a cluster dump when IstioIngressLoadBalancer was not created
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows private subnet not allowed in public LB.
// THEN a report is generated with issues identified
func TestIstioIngressInstallFailure(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/istio-loadbalancer-creation-issue")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.IstioIngressPrivateSubnet {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestComponentsNotReadyNoErrorMsg Tests that analysis of a cluster dump where there are failed components with no error message in the VPO logs
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows that there is install failure with no known root cause
// THEN a report is generated with supporting messages from the events related to those failed components' pods
func TestComponentsNotReadyNoErrorMsg(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/components-not-ready")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)

	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.InstallFailure {
			problemsFound++
			// Two supporting messages are always included. Rest should come from events related to failed components
			assert.True(t, len(issue.SupportingData[0].Messages) > 2)
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestExternalDNSConfigurationIssue Tests that analysis of a cluster dump when dns(oci,custom dns) was not configured
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows private subnet not allowed in public LB.
// THEN a report is generated with issues identified
func TestExternalDNSConfigurationIssue(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/external-dns-issue")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.ExternalDNSConfigureIssue {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestResourceJSONWithVerrazzanoFormat Tests that analysis of a cluster dump
// when there is an install failure and the verrazzano-resource.json contains Verrazzano type instead of VerrazzanoList type
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows components not in ready state
// THEN a report is generated with install failure
func TestResourceJSONWithVerrazzanoFormat(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/install-failure-verrazzano-format-json")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		fmt.Println(issue)
		if issue.Type == report.InstallFailure {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestKeycloakDataMigrationFailure tests that analysis of a cluster dump when keycloak data migration during upgrade has failed
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot data load job failure
// THEN a report is generated with issues identified
func TestKeycloakDataMigrationFailure(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/keycloak-data-migration-failure")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.KeycloakDataMigrationFailure {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// TestCertificateVZClientHangingIssue tests analysis of a cluster dump when the VZ Client is hanging
// GIVEN a call to analyze a cluster-snapshot
// WHEN the VZ Client is hanging on a certificate, but the certificate is not expired
// THEN a report is generated with issues identified
// This test also tests for detecting a separate expired certificate in the certificates.json
func TestCertificateVZClientHangingIssue(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/testCLIHangingIssue")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.VZClientHangingIssueDueToLongCertificateApproval {
			problemsFound++
		}
		if issue.Type == report.CertificateExpired {
			problemsFound++
		}
	}
	assert.True(t, problemsFound == 2)
}

// TestBlockStorageFailure Tests that analysis of a cluster dump when Block Storage limit is exceeded
// GIVEN a call to analyze a cluster-snapshot
// WHEN the cluster-snapshot shows private subnet not allowed in public LB.
// THEN a report is generated with issues identified
func TestBlockStorageFailure(t *testing.T) {
	logger := log.GetDebugEnabledLogger()
	stdoutFile, stderrFile := createStdTempFiles(t)
	defer func() {
		os.Remove(stdoutFile.Name())
		os.Remove(stderrFile.Name())
	}()
	rc := vzhelper.NewFakeRootCmdContext(genericclioptions.IOStreams{In: os.Stdin, Out: stdoutFile, ErrOut: stderrFile})
	report.ClearReports()
	err := Analyze(rc, logger, "cluster", "../internal/test/cluster/blockstorage-limitexceeded")
	assert.Nil(t, err)

	reportedIssues := report.GetAllSourcesFilteredIssues(logger, true, 0, 0)
	assert.NotNil(t, reportedIssues)
	assert.True(t, len(reportedIssues) > 0)
	problemsFound := 0
	for _, issue := range reportedIssues {
		if issue.Type == report.BlockStorageLimitExceeded {
			problemsFound++
		}
	}
	assert.True(t, problemsFound > 0)
}

// createStdTempFiles creates temporary files for stdout and stderr.
func createStdTempFiles(t *testing.T) (*os.File, *os.File) {
	stdoutFile, err := os.CreateTemp("", "tmpstdout")
	assert.NoError(t, err)

	stderrFile, err := os.CreateTemp("", "tmpstderr")
	assert.NoError(t, err)

	return stdoutFile, stderrFile
}