github.com/zppinho/prow@v0.0.0-20240510014325-1738badeb017/cmd/phony/examples/review_approve_submitted.json (about) 1 { 2 "sender": { 3 "avatar_url": "https://avatars1.githubusercontent.com/u/5442475?v=4", 4 "html_url": "https://github.com/luxas", 5 "node_id": "MDQ6VXNlcjU0NDI0NzU=", 6 "gravatar_id": "", 7 "site_admin": false, 8 "login": "luxas", 9 "type": "User", 10 "id": 5442475 11 }, 12 "repository": { 13 "stargazers_count": 39280, 14 "mirror_url": null, 15 "updated_at": "2018-07-27T16:53:46Z", 16 "private": false, 17 "has_wiki": false, 18 "full_name": "kubernetes/kubernetes", 19 "owner": { 20 "avatar_url": "https://avatars2.githubusercontent.com/u/13629408?v=4", 21 "html_url": "https://github.com/kubernetes", 22 "node_id": "MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4", 23 "gravatar_id": "", 24 "site_admin": false, 25 "login": "kubernetes", 26 "type": "Organization", 27 "id": 13629408 28 }, 29 "id": 20580498, 30 "description": "Production-Grade Container Scheduling and Management", 31 "archived": false, 32 "has_pages": false, 33 "open_issues_count": 3190, 34 "has_projects": true, 35 "clone_url": "https://github.com/kubernetes/kubernetes.git", 36 "watchers_count": 39280, 37 "size": 794946, 38 "homepage": "http://kubernetes.io", 39 "fork": false, 40 "watchers": 39280, 41 "html_url": "https://github.com/kubernetes/kubernetes", 42 "forks": 13699, 43 "open_issues": 3190, 44 "node_id": "MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==", 45 "git_url": "git://github.com/kubernetes/kubernetes.git", 46 "svn_url": "https://github.com/kubernetes/kubernetes", 47 "has_issues": true, 48 "ssh_url": "git@github.com:kubernetes/kubernetes.git", 49 "has_downloads": true, 50 "license": { 51 "spdx_id": "Apache-2.0", 52 "node_id": "MDc6TGljZW5zZTI=", 53 "name": "Apache License 2.0", 54 "key": "apache-2.0" 55 }, 56 "name": "kubernetes", 57 "language": "Go", 58 "created_at": "2014-06-06T22:56:04Z", 59 "pushed_at": "2018-07-27T16:56:47Z", 60 "forks_count": 13699, 61 "default_branch": "master" 62 }, 63 "review": { 64 "body": "This LGTM now\r\nWhat I came to think about now is, do we actually support building these images _on the non-amd64 platform_ or do we instead crossbuild and publish?\r\nIf we go with the \"crossbuild and publish\" approach (which I think is in the end is kinda okay), we can just use the `golang:1.9` image as-is for the build.", 65 "commit_id": "90680e35391e777b5d1e49ad0c9dd7c4946bb459", 66 "submitted_at": "2018-07-27T17:01:20Z", 67 "author_association": "MEMBER", 68 "html_url": "https://github.com/kubernetes/kubernetes/pull/66686#pullrequestreview-141192367", 69 "state": "approved", 70 "node_id": "MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MTQxMTkyMzY3", 71 "_links": { 72 "html": { 73 "href": "https://github.com/kubernetes/kubernetes/pull/66686#pullrequestreview-141192367" 74 }, 75 "pull_request": { 76 "href": "https://api.github.com/repos/kubernetes/kubernetes/pulls/66686" 77 } 78 }, 79 "user": { 80 "avatar_url": "https://avatars1.githubusercontent.com/u/5442475?v=4", 81 "html_url": "https://github.com/luxas", 82 "node_id": "MDQ6VXNlcjU0NDI0NzU=", 83 "gravatar_id": "", 84 "site_admin": false, 85 "login": "luxas", 86 "type": "User", 87 "id": 5442475 88 }, 89 "id": 141192367 90 }, 91 "pull_request": { 92 "merge_commit_sha": "29375fdfddac11ccf9922d7bd49e246efa74d255", 93 "labels": [ 94 { 95 "default": false, 96 "name": "cncf-cla: yes", 97 "color": "bfe5bf", 98 "node_id": "MDU6TGFiZWw0NzczOTcwODY=", 99 "id": 477397086 100 }, 101 { 102 "default": false, 103 "name": "do-not-merge/hold", 104 "color": "e11d21", 105 "node_id": "MDU6TGFiZWw2ODc1NjU4MDQ=", 106 "id": 687565804 107 }, 108 { 109 "default": false, 110 "name": "release-note-none", 111 "color": "c2e0c6", 112 "node_id": "MDU6TGFiZWwzNDk1MzAyNDk=", 113 "id": 349530249 114 }, 115 { 116 "default": false, 117 "name": "size/M", 118 "color": "eebb00", 119 "node_id": "MDU6TGFiZWwyNTM0NTA5MzQ=", 120 "id": 253450934 121 } 122 ], 123 "number": 66686, 124 "assignee": null, 125 "closed_at": null, 126 "requested_reviewers": [], 127 "id": 204248756, 128 "title": "test image for a release 1.7 based sample-apiserver", 129 "merged_at": null, 130 "state": "open", 131 "_links": { 132 "review_comment": { 133 "href": "https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}" 134 }, 135 "commits": { 136 "href": "https://api.github.com/repos/kubernetes/kubernetes/pulls/66686/commits" 137 }, 138 "self": { 139 "href": "https://api.github.com/repos/kubernetes/kubernetes/pulls/66686" 140 }, 141 "review_comments": { 142 "href": "https://api.github.com/repos/kubernetes/kubernetes/pulls/66686/comments" 143 }, 144 "html": { 145 "href": "https://github.com/kubernetes/kubernetes/pull/66686" 146 }, 147 "comments": { 148 "href": "https://api.github.com/repos/kubernetes/kubernetes/issues/66686/comments" 149 }, 150 "issue": { 151 "href": "https://api.github.com/repos/kubernetes/kubernetes/issues/66686" 152 }, 153 "statuses": { 154 "href": "https://api.github.com/repos/kubernetes/kubernetes/statuses/90680e35391e777b5d1e49ad0c9dd7c4946bb459" 155 } 156 }, 157 "diff_url": "https://github.com/kubernetes/kubernetes/pull/66686.diff", 158 "body": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nIn our e2e test suite we have use an image \"registry.k8s.io/e2e-test-images:k8s-aggregator-sample-apiserver:1.7v2\". We need a way to build a fresh image that can we can use instead of that one. Especially we need one that has a multi-arch fat manifest so e2e tests can be run across multiple architectures.\r\n\r\nThis is especially important since we are in the process of promoting the test in question to the conformance suite - https://github.com/kubernetes/kubernetes/pull/63947\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n/cc @mkumatag \r\n/cc @ixdy \r\n/cc @luxas \r\n\r\n**Release note**:\r\n<!-- Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n", 159 "head": { 160 "repo": { 161 "stargazers_count": 1, 162 "mirror_url": null, 163 "updated_at": "2018-07-27T11:33:41Z", 164 "private": false, 165 "has_wiki": true, 166 "full_name": "dims/kubernetes", 167 "owner": { 168 "avatar_url": "https://avatars2.githubusercontent.com/u/23304?v=4", 169 "html_url": "https://github.com/dims", 170 "node_id": "MDQ6VXNlcjIzMzA0", 171 "gravatar_id": "", 172 "site_admin": false, 173 "login": "dims", 174 "type": "User", 175 "id": 23304 176 }, 177 "id": 58837596, 178 "description": "Container Cluster Manager from Google", 179 "archived": false, 180 "has_pages": false, 181 "open_issues_count": 0, 182 "has_projects": true, 183 "clone_url": "https://github.com/dims/kubernetes.git", 184 "watchers_count": 1, 185 "size": 570894, 186 "homepage": "http://kubernetes.io", 187 "fork": true, 188 "watchers": 1, 189 "html_url": "https://github.com/dims/kubernetes", 190 "forks": 0, 191 "open_issues": 0, 192 "node_id": "MDEwOlJlcG9zaXRvcnk1ODgzNzU5Ng==", 193 "git_url": "git://github.com/dims/kubernetes.git", 194 "svn_url": "https://github.com/dims/kubernetes", 195 "has_issues": false, 196 "ssh_url": "git@github.com:dims/kubernetes.git", 197 "has_downloads": true, 198 "license": { 199 "spdx_id": "Apache-2.0", 200 "node_id": "MDc6TGljZW5zZTI=", 201 "name": "Apache License 2.0", 202 "key": "apache-2.0" 203 }, 204 "name": "kubernetes", 205 "language": "Go", 206 "created_at": "2016-05-15T01:04:18Z", 207 "pushed_at": "2018-07-27T16:37:17Z", 208 "forks_count": 0, 209 "default_branch": "master" 210 }, 211 "sha": "90680e35391e777b5d1e49ad0c9dd7c4946bb459", 212 "ref": "test-image-for-a-release-1.7-based-sample-apiserver", 213 "user": { 214 "avatar_url": "https://avatars2.githubusercontent.com/u/23304?v=4", 215 "html_url": "https://github.com/dims", 216 "node_id": "MDQ6VXNlcjIzMzA0", 217 "gravatar_id": "", 218 "site_admin": false, 219 "login": "dims", 220 "type": "User", 221 "id": 23304 222 }, 223 "label": "dims:test-image-for-a-release-1.7-based-sample-apiserver" 224 }, 225 "author_association": "MEMBER", 226 "html_url": "https://github.com/kubernetes/kubernetes/pull/66686", 227 "updated_at": "2018-07-27T17:01:20Z", 228 "node_id": "MDExOlB1bGxSZXF1ZXN0MjA0MjQ4NzU2", 229 "user": { 230 "avatar_url": "https://avatars2.githubusercontent.com/u/23304?v=4", 231 "html_url": "https://github.com/dims", 232 "node_id": "MDQ6VXNlcjIzMzA0", 233 "gravatar_id": "", 234 "site_admin": false, 235 "login": "dims", 236 "type": "User", 237 "id": 23304 238 }, 239 "milestone": null, 240 "requested_teams": [], 241 "locked": false, 242 "created_at": "2018-07-26T19:51:45Z", 243 "assignees": [], 244 "base": { 245 "repo": { 246 "stargazers_count": 39280, 247 "mirror_url": null, 248 "updated_at": "2018-07-27T16:53:46Z", 249 "private": false, 250 "has_wiki": false, 251 "full_name": "kubernetes/kubernetes", 252 "owner": { 253 "avatar_url": "https://avatars2.githubusercontent.com/u/13629408?v=4", 254 "html_url": "https://github.com/kubernetes", 255 "node_id": "MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4", 256 "gravatar_id": "", 257 "site_admin": false, 258 "login": "kubernetes", 259 "type": "Organization", 260 "id": 13629408 261 }, 262 "id": 20580498, 263 "description": "Production-Grade Container Scheduling and Management", 264 "archived": false, 265 "has_pages": false, 266 "open_issues_count": 3190, 267 "has_projects": true, 268 "clone_url": "https://github.com/kubernetes/kubernetes.git", 269 "watchers_count": 39280, 270 "size": 794946, 271 "homepage": "http://kubernetes.io", 272 "fork": false, 273 "watchers": 39280, 274 "html_url": "https://github.com/kubernetes/kubernetes", 275 "forks": 13699, 276 "open_issues": 3190, 277 "node_id": "MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==", 278 "git_url": "git://github.com/kubernetes/kubernetes.git", 279 "svn_url": "https://github.com/kubernetes/kubernetes", 280 "has_issues": true, 281 "ssh_url": "git@github.com:kubernetes/kubernetes.git", 282 "has_downloads": true, 283 "license": { 284 "spdx_id": "Apache-2.0", 285 "node_id": "MDc6TGljZW5zZTI=", 286 "name": "Apache License 2.0", 287 "key": "apache-2.0" 288 }, 289 "name": "kubernetes", 290 "language": "Go", 291 "created_at": "2014-06-06T22:56:04Z", 292 "pushed_at": "2018-07-27T16:56:47Z", 293 "forks_count": 13699, 294 "default_branch": "master" 295 }, 296 "sha": "4d5d2664c3b038a3da2e16c5285460c32fc0e15c", 297 "ref": "master", 298 "user": { 299 "avatar_url": "https://avatars2.githubusercontent.com/u/13629408?v=4", 300 "html_url": "https://github.com/kubernetes", 301 "node_id": "MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4", 302 "gravatar_id": "", 303 "site_admin": false, 304 "login": "kubernetes", 305 "type": "Organization", 306 "id": 13629408 307 }, 308 "label": "kubernetes:master" 309 }, 310 "patch_url": "https://github.com/kubernetes/kubernetes/pull/66686.patch" 311 }, 312 "action": "submitted", 313 "organization": { 314 "description": "Kubernetes", 315 "avatar_url": "https://avatars2.githubusercontent.com/u/13629408?v=4", 316 "node_id": "MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4", 317 "login": "kubernetes", 318 "id": 13629408 319 } 320 }