go.chromium.org/luci@v0.0.0-20240309015107-7cdc2e660f33/lucicfg/buildifier/buildifier_test.go (about)

     1  // Copyright 2020 The LUCI Authors.
     2  //
     3  // Licensed under the Apache License, Version 2.0 (the "License");
     4  // you may not use this file except in compliance with the License.
     5  // You may obtain a copy of the License at
     6  //
     7  //      http://www.apache.org/licenses/LICENSE-2.0
     8  //
     9  // Unless required by applicable law or agreed to in writing, software
    10  // distributed under the License is distributed on an "AS IS" BASIS,
    11  // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    12  // See the License for the specific language governing permissions and
    13  // limitations under the License.
    14  
    15  package buildifier
    16  
    17  import (
    18  	"testing"
    19  
    20  	"go.chromium.org/luci/common/data/stringset"
    21  
    22  	. "github.com/smartystreets/goconvey/convey"
    23  )
    24  
    25  func TestNormalizeLintChecks(t *testing.T) {
    26  	t.Parallel()
    27  
    28  	diff := func(s1, s2 stringset.Set) []string {
    29  		var d []string
    30  		for _, s := range s1.ToSortedSlice() {
    31  			if !s2.Has(s) {
    32  				d = append(d, s)
    33  			}
    34  		}
    35  		return d
    36  	}
    37  
    38  	Convey("Default", t, func() {
    39  		s, err := normalizeLintChecks(nil)
    40  		So(err, ShouldBeNil)
    41  		So(s.ToSortedSlice(), ShouldResemble, defaultChecks().ToSortedSlice())
    42  	})
    43  
    44  	Convey("Add some", t, func() {
    45  		s, err := normalizeLintChecks([]string{
    46  			"+some1",
    47  			"+some2",
    48  			"-some1",
    49  		})
    50  		So(err, ShouldBeNil)
    51  		So(diff(s, defaultChecks()), ShouldResemble, []string{"some2"})
    52  	})
    53  
    54  	Convey("Remove some", t, func() {
    55  		s, err := normalizeLintChecks([]string{
    56  			"-module-docstring",
    57  		})
    58  		So(err, ShouldBeNil)
    59  		So(diff(defaultChecks(), s), ShouldResemble, []string{"module-docstring"})
    60  	})
    61  }