sigs.k8s.io/cluster-api-provider-aws@v1.5.5/exp/api/v1beta1/awsmachinepool_webhook_test.go

/*
Copyright 2021 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

	http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1beta1

import (
	"strings"
	"testing"

	"github.com/aws/aws-sdk-go/aws"
	. "github.com/onsi/gomega"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/utils/pointer"

	infrav1 "sigs.k8s.io/cluster-api-provider-aws/api/v1beta1"
	utildefaulting "sigs.k8s.io/cluster-api/util/defaulting"
)

func TestAWSMachinePoolDefault(t *testing.T) {
	m := &AWSMachinePool{ObjectMeta: metav1.ObjectMeta{Name: "foo", Namespace: "default"}}
	t.Run("for AWSCluster", utildefaulting.DefaultValidateTest(m))
	m.Default()
	g := NewWithT(t)
	g.Expect(m.Spec.DefaultCoolDown.Duration).To(BeNumerically(">=", 0))
}

func TestAWSMachinePool_ValidateCreate(t *testing.T) {
	g := NewWithT(t)

	tests := []struct {
		name    string
		pool    *AWSMachinePool
		wantErr bool
	}{
		{
			name: "pool with valid tags is accepted",
			pool: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
				},
			},

			wantErr: false,
		},
		{
			name: "invalid tags are rejected",
			pool: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1":                    "value-1",
						"":                         "value-2",
						strings.Repeat("CAPI", 33): "value-3",
						"key-4":                    strings.Repeat("CAPI", 65),
					},
				},
			},
			wantErr: true,
		},
		{
			name: "Should fail if additional security groups are provided with both ID and Filters",
			pool: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AWSLaunchTemplate: AWSLaunchTemplate{AdditionalSecurityGroups: []infrav1.AWSResourceReference{{
						ID: aws.String("sg-1"),
						Filters: []infrav1.Filter{
							{
								Name:   "sg-1",
								Values: []string{"test"},
							},
						},
					}}},
				},
			},
			wantErr: true,
		},
		{
			name: "Should fail if both subnet ID and filters passed in AWSMachinePool spec",
			pool: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
					Subnets: []infrav1.AWSResourceReference{
						{
							ID:      pointer.StringPtr("subnet-id"),
							Filters: []infrav1.Filter{{Name: "filter_name", Values: []string{"filter_value"}}},
						},
					},
				},
			},
			wantErr: true,
		},
		{
			name: "Should pass if either subnet ID or filters passed in AWSMachinePool spec",
			pool: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
					Subnets: []infrav1.AWSResourceReference{
						{
							ID: pointer.StringPtr("subnet-id"),
						},
					},
				},
			},
			wantErr: false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := tt.pool.ValidateCreate()
			if tt.wantErr {
				g.Expect(err).To(HaveOccurred())
			} else {
				g.Expect(err).To(Succeed())
			}
		})
	}
}

func TestAWSMachinePool_ValidateUpdate(t *testing.T) {
	g := NewWithT(t)

	tests := []struct {
		name    string
		new     *AWSMachinePool
		old     *AWSMachinePool
		wantErr bool
	}{
		{
			name: "adding tags is accepted",
			old: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
					},
				},
			},
			new: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
				},
			},
			wantErr: false,
		},
		{
			name: "adding invalid tags is rejected",
			old: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
					},
				},
			},
			new: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1":                    "value-1",
						"":                         "value-2",
						strings.Repeat("CAPI", 33): "value-3",
						"key-4":                    strings.Repeat("CAPI", 65),
					},
				},
			},
			wantErr: true,
		},
		{
			name: "Should fail update if both subnetID and filters passed in AWSMachinePool spec",
			old: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
					},
				},
			},
			new: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
					Subnets: []infrav1.AWSResourceReference{
						{
							ID:      pointer.StringPtr("subnet-id"),
							Filters: []infrav1.Filter{{Name: "filter_name", Values: []string{"filter_value"}}},
						},
					},
				},
			},
			wantErr: true,
		},
		{
			name: "Should pass update if either subnetID or filters passed in AWSMachinePool spec",
			old: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
					},
				},
			},
			new: &AWSMachinePool{
				Spec: AWSMachinePoolSpec{
					AdditionalTags: infrav1.Tags{
						"key-1": "value-1",
						"key-2": "value-2",
					},
					Subnets: []infrav1.AWSResourceReference{
						{
							ID: pointer.StringPtr("subnet-id"),
						},
					},
				},
			},
			wantErr: false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := tt.new.ValidateUpdate(tt.old.DeepCopy())
			if tt.wantErr {
				g.Expect(err).To(HaveOccurred())
			} else {
				g.Expect(err).To(Succeed())
			}
		})
	}
}