storj.io/uplink@v1.13.0/.github/pull_request_template.md (about) 1 2 What: 3 4 Why: 5 6 Please describe the tests: 7 - Test 1: 8 - Test 2: 9 10 Please describe the performance impact: 11 12 ## Code Review Checklist (to be filled out by reviewer) 13 - [ ] NEW: Are there any Satellite database migrations? Are they forwards _and_ backwards compatible? 14 - [ ] Does the PR describe what changes are being made? 15 - [ ] Does the PR describe why the changes are being made? 16 - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/main/code/Style.md)? 17 - [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/main/code/Testing.md)? 18 - [ ] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be) 19 - [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially) 20 - [ ] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) 21 - [ ] Does any documentation need updating? 22 - [ ] Do the database access patterns make sense? 23